[jira] [Comment Edited] (FLINK-16636) TableEnvironmentITCase is crashing on Travis

2020-04-20 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088308#comment-17088308 ] Caizhi Weng edited comment on FLINK-16636 at 4/21/20, 5:58 AM: --- Hi

[jira] [Closed] (FLINK-17014) Implement PipelinedRegionSchedulingStrategy

2020-04-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-17014. --- Resolution: Fixed Implemented via 67835fe8b72601dbb046683c04cc9a4cedf77db3

[GitHub] [flink] wangyang0918 commented on issue #11820: [FLINK-17264][scripts] Fix broken taskmanager.sh by using -eq to compare num_lines

2020-04-20 Thread GitBox
wangyang0918 commented on issue #11820: URL: https://github.com/apache/flink/pull/11820#issuecomment-616966774 I am not sure how many users are running e2e tests on the Mac. And how many incompatible commands do we have in e2e tests. So maybe we need to create another ticket and have the

[GitHub] [flink] dianfu commented on a change in pull request #11702: [FLINK-16667][python][client] Support new Python dependency configuration options in flink-client.

2020-04-20 Thread GitBox
dianfu commented on a change in pull request #11702: URL: https://github.com/apache/flink/pull/11702#discussion_r411877184 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java ## @@ -184,10 +175,65 @@ public SavepointRestoreSettings

[GitHub] [flink] wuchong commented on a change in pull request #11822: [FLINK-16788][Connector]ElasticSearch Connector SQL DDL add optional config (eg: username/password)

2020-04-20 Thread GitBox
wuchong commented on a change in pull request #11822: URL: https://github.com/apache/flink/pull/11822#discussion_r411878291 ## File path: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/table/descriptors/Elasticsearch.java ## @@ -93,6 +95,26

[GitHub] [flink] flinkbot edited a comment on issue #11837: [FLINK-16160][table-planner-blink] Fix proctime()/rowtime() doesn't w…

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11837: URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896 ## CI report: * afa79d577eecd36ad2843f50380c07a33bedaa6c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161174787) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11835: [hotfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11835: URL: https://github.com/apache/flink/pull/11835#issuecomment-616914851 ## CI report: * 3f4e611749de42b1c7b18a7a421879e2a55379d1 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161161009) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11820: [FLINK-17264][scripts] Fix broken taskmanager.sh by using -eq to compare num_lines

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11820: URL: https://github.com/apache/flink/pull/11820#issuecomment-616475056 ## CI report: * 56a03626e5f03a65e74708c424fd8503ba563a32 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161065593) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11578: [RELEASE-1.10][FLINK-16874] Respect the dynamic options when calculating memory opt…

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11578: URL: https://github.com/apache/flink/pull/11578#issuecomment-606518441 ## CI report: * e4a8b6583841ddaa4abb405d7988b6e5883c085d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160523697) *

[jira] [Commented] (FLINK-16636) TableEnvironmentITCase is crashing on Travis

2020-04-20 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088308#comment-17088308 ] Caizhi Weng commented on FLINK-16636: - Hi [~rmetzger] thanks for reporting. Is the heap dump

[GitHub] [flink] KarmaGYZ commented on a change in pull request #11822: [FLINK-16788][Connector]ElasticSearch Connector SQL DDL add optional config (eg: username/password)

2020-04-20 Thread GitBox
KarmaGYZ commented on a change in pull request #11822: URL: https://github.com/apache/flink/pull/11822#discussion_r411364910 ## File path: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/table/descriptors/ElasticsearchValidator.java ## @@

[GitHub] [flink] leonardBang commented on issue #11835: [hotfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
leonardBang commented on issue #11835: URL: https://github.com/apache/flink/pull/11835#issuecomment-616958951 Hello @aljoscha ,could you take a look this PR? This is an automated message from the Apache Git Service. To

[GitHub] [flink] leonardBang commented on issue #11820: [FLINK-17264][scripts] Fix broken taskmanager.sh by using -eq to compare num_lines

2020-04-20 Thread GitBox
leonardBang commented on issue #11820: URL: https://github.com/apache/flink/pull/11820#issuecomment-616957287 > Sorry for introducing this bug in the code. I discover that there are also other scripts (mostly e2e test scripts, for example `test_cli.sh` and `shade.sh`) uses `wc -l` and

[GitHub] [flink] flinkbot edited a comment on issue #11835: [hotfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11835: URL: https://github.com/apache/flink/pull/11835#issuecomment-616914851 ## CI report: * 3f4e611749de42b1c7b18a7a421879e2a55379d1 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161161009) Azure:

[GitHub] [flink] flinkbot commented on issue #11837: [FLINK-16160][table-planner-blink] Fix proctime()/rowtime() doesn't w…

2020-04-20 Thread GitBox
flinkbot commented on issue #11837: URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896 ## CI report: * afa79d577eecd36ad2843f50380c07a33bedaa6c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run

[GitHub] [flink] flinkbot edited a comment on issue #11820: [FLINK-17264][scripts] Fix broken taskmanager.sh by using -eq to compare num_lines

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11820: URL: https://github.com/apache/flink/pull/11820#issuecomment-616475056 ## CI report: * 56a03626e5f03a65e74708c424fd8503ba563a32 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161065593) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11578: [RELEASE-1.10][FLINK-16874] Respect the dynamic options when calculating memory opt…

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11578: URL: https://github.com/apache/flink/pull/11578#issuecomment-606518441 ## CI report: * e4a8b6583841ddaa4abb405d7988b6e5883c085d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160523697) *

[GitHub] [flink] flinkbot edited a comment on issue #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11687: URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542 ## CI report: * 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN * d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN * cba096ae3d8eba4a0d39c64659f76ad10a62be27

[GitHub] [flink] dianfu commented on a change in pull request #11836: [FLINK-17188][python] Use pip instead of conda to install flake8 and sphinx

2020-04-20 Thread GitBox
dianfu commented on a change in pull request #11836: URL: https://github.com/apache/flink/pull/11836#discussion_r411841130 ## File path: flink-python/dev/lint-python.sh ## @@ -244,6 +244,7 @@ function install_py_env() { # Install tox. # In some situations,you need to run the

[jira] [Closed] (FLINK-17013) Support Python UDTF in old planner under batch mode

2020-04-20 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng closed FLINK-17013. --- Resolution: Resolved > Support Python UDTF in old planner under batch mode >

[jira] [Commented] (FLINK-17013) Support Python UDTF in old planner under batch mode

2020-04-20 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088298#comment-17088298 ] Hequn Cheng commented on FLINK-17013: - Resolved in 1.11.0 via

[GitHub] [flink] hequn8128 removed a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode

2020-04-20 Thread GitBox
hequn8128 removed a comment on issue #11668: URL: https://github.com/apache/flink/pull/11668#issuecomment-616952438 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] hequn8128 commented on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode

2020-04-20 Thread GitBox
hequn8128 commented on issue #11668: URL: https://github.com/apache/flink/pull/11668#issuecomment-616952779 @HuangXingBo Thanks a lot for the update. Merging... This is an automated message from the Apache Git Service. To

[GitHub] [flink] hequn8128 commented on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode

2020-04-20 Thread GitBox
hequn8128 commented on issue #11668: URL: https://github.com/apache/flink/pull/11668#issuecomment-616952438 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] wangyang0918 commented on issue #11820: [FLINK-17264][scripts] Fix broken taskmanager.sh by using -eq to compare num_lines

2020-04-20 Thread GitBox
wangyang0918 commented on issue #11820: URL: https://github.com/apache/flink/pull/11820#issuecomment-616950599 Thanks @aljoscha @leonardBang, i have updated the PR to use `-ne`. This is an automated message from the Apache

[GitHub] [flink] TsReaper commented on issue #11820: [FLINK-17264][scripts] Fix broken taskmanager.sh by using -eq to compare num_lines

2020-04-20 Thread GitBox
TsReaper commented on issue #11820: URL: https://github.com/apache/flink/pull/11820#issuecomment-616950764 Sorry for introducing this bug in the code. I discover that there are also other scripts (mostly e2e test scripts, for example `test_cli.sh` and `shade.sh`) uses `wc -l` and `==` to

[GitHub] [flink] flinkbot commented on issue #11837: [FLINK-16160][table-planner-blink] Fix proctime()/rowtime() doesn't w…

2020-04-20 Thread GitBox
flinkbot commented on issue #11837: URL: https://github.com/apache/flink/pull/11837#issuecomment-616946674 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress

[jira] [Assigned] (FLINK-17286) Integrate json to file system connector

2020-04-20 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-17286: Assignee: Leonard Xu > Integrate json to file system connector >

[GitHub] [flink] flinkbot edited a comment on issue #11829: [FLINK-17021][table-planner-blink] Blink batch planner set GlobalDataExchangeMode

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11829: URL: https://github.com/apache/flink/pull/11829#issuecomment-616561190 ## CI report: * b55c1d368238599e824f600bd4786ca2ed31f681 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161046863) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11794: [FLINK-17126] [table-planner] Correct the execution behavior of BatchTableEnvironment

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11794: URL: https://github.com/apache/flink/pull/11794#issuecomment-615243118 ## CI report: * 5bcc43b771b5c05d027268b52cf81121db562a7a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160968796) Azure:

[jira] [Created] (FLINK-17286) Integrate json to file system connector

2020-04-20 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17286: Summary: Integrate json to file system connector Key: FLINK-17286 URL: https://issues.apache.org/jira/browse/FLINK-17286 Project: Flink Issue Type: Sub-task

[GitHub] [flink] flinkbot edited a comment on issue #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11797: URL: https://github.com/apache/flink/pull/11797#issuecomment-615294694 ## CI report: * 85f40e3041783b1dbda1eb3b812f23e77936f7b3 UNKNOWN * 5b8d39bef382e260dbec301105c32dde88153245 Travis:

[GitHub] [flink] flinkbot edited a comment on issue #11774: [FLINK-17020][runtime] Introduce GlobalDataExchangeMode for JobGraph generation

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11774: URL: https://github.com/apache/flink/pull/11774#issuecomment-614576955 ## CI report: * 1fe605210a2a1331d1ecf85c952ad2d5bd5fe8ea Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160532764) Azure:

[jira] [Commented] (FLINK-16931) Large _metadata file lead to JobManager not responding when restart

2020-04-20 Thread Lu Niu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088282#comment-17088282 ] Lu Niu commented on FLINK-16931: [~trohrmann] Thanks for the advice. Certainly there are much more need

[GitHub] [flink] docete opened a new pull request #11837: [FLINK-16160][table-planner-blink] Fix proctime()/rowtime() doesn't w…

2020-04-20 Thread GitBox
docete opened a new pull request #11837: URL: https://github.com/apache/flink/pull/11837 …ork for TableEnvironment.connect().createTemporaryTable() ## What is the purpose of the change Since FLINK-14490, proctime()/rowtime() doesn't work for

[jira] [Commented] (FLINK-16160) Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path

2020-04-20 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088275#comment-17088275 ] Zhenghua Gao commented on FLINK-16160: -- The root causes are: * proctime()/rowtime() are used along

[jira] [Commented] (FLINK-17273) Fix not calling ResourceManager#closeTaskManagerConnection in KubernetesResourceManager in case of registered TaskExecutor failure

2020-04-20 Thread Canbin Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088276#comment-17088276 ] Canbin Zheng commented on FLINK-17273: -- cc [~xintongsong] > Fix not calling

[GitHub] [flink-training] tzulitai commented on issue #2: [FLINK-17276][checkstyle] add definitions from Flink and enforce them

2020-04-20 Thread GitBox
tzulitai commented on issue #2: URL: https://github.com/apache/flink-training/pull/2#issuecomment-616942594  always good to have checkstyle enforced, no objections here as well. LGTM from my side. This is an automated

[GitHub] [flink-training] tzulitai commented on issue #4: [FLINK-17278][travis] add Travis configuration

2020-04-20 Thread GitBox
tzulitai commented on issue #4: URL: https://github.com/apache/flink-training/pull/4#issuecomment-616941495 Travis is green, so LGTM  This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on issue #11829: [FLINK-17021][table-planner-blink] Blink batch planner set GlobalDataExchangeMode

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11829: URL: https://github.com/apache/flink/pull/11829#issuecomment-616561190 ## CI report: * b55c1d368238599e824f600bd4786ca2ed31f681 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161046863) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11785: [FLINK-17206][table] refactor function catalog to support delayed UDF initialization.

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11785: URL: https://github.com/apache/flink/pull/11785#issuecomment-615087743 ## CI report: * bda5c47abf20ea3682c2b1d21188d1e08edd1d87 UNKNOWN * 7fee2a180eea4d0e37ff86f04d728b5b501a3679 Travis:

[GitHub] [flink] flinkbot edited a comment on issue #11774: [FLINK-17020][runtime] Introduce GlobalDataExchangeMode for JobGraph generation

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11774: URL: https://github.com/apache/flink/pull/11774#issuecomment-614576955 ## CI report: * 1fe605210a2a1331d1ecf85c952ad2d5bd5fe8ea Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160532764) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11794: [FLINK-17126] [table-planner] Correct the execution behavior of BatchTableEnvironment

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11794: URL: https://github.com/apache/flink/pull/11794#issuecomment-615243118 ## CI report: * 5bcc43b771b5c05d027268b52cf81121db562a7a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160968796) Azure:

[GitHub] [flink-training] tzulitai commented on a change in pull request #1: [FLINK-17275] port core training exercises, descriptions, solutions and tests

2020-04-20 Thread GitBox
tzulitai commented on a change in pull request #1: URL: https://github.com/apache/flink-training/pull/1#discussion_r411849722 ## File path: README.md ## @@ -1,3 +1,257 @@ + + # Flink Training Exercises Exercises that go along with the training content in the documentation.

[GitHub] [flink] wuchong commented on a change in pull request #11766: [FLINK-16812][jdbc] support array types in PostgresRowConverter

2020-04-20 Thread GitBox
wuchong commented on a change in pull request #11766: URL: https://github.com/apache/flink/pull/11766#discussion_r411851777 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/source/row/converter/PostgresRowConverter.java ## @@ -28,4

[GitHub] [flink] wuchong commented on a change in pull request #11804: [FLINK-16473][doc][jdbc] add documentation for JDBCCatalog and PostgresCatalog

2020-04-20 Thread GitBox
wuchong commented on a change in pull request #11804: URL: https://github.com/apache/flink/pull/11804#discussion_r411846216 ## File path: docs/dev/table/catalogs.md ## @@ -37,6 +41,76 @@ Or permanent metadata, like that in a Hive Metastore. Catalogs provide a unified The

[GitHub] [flink] wuchong commented on a change in pull request #11804: [FLINK-16473][doc][jdbc] add documentation for JDBCCatalog and PostgresCatalog

2020-04-20 Thread GitBox
wuchong commented on a change in pull request #11804: URL: https://github.com/apache/flink/pull/11804#discussion_r411846216 ## File path: docs/dev/table/catalogs.md ## @@ -37,6 +41,76 @@ Or permanent metadata, like that in a Hive Metastore. Catalogs provide a unified The

[GitHub] [flink] leonardBang commented on issue #11764: [FLINK-17023][scripts] Fix format checking of extractExecutionParams in config.sh

2020-04-20 Thread GitBox
leonardBang commented on issue #11764: URL: https://github.com/apache/flink/pull/11764#issuecomment-616935579 @wangyang0918 has opened a PR https://github.com/apache/flink/pull/11820 This is an automated message from the

[GitHub] [flink] leonardBang commented on issue #11764: [FLINK-17023][scripts] Fix format checking of extractExecutionParams in config.sh

2020-04-20 Thread GitBox
leonardBang commented on issue #11764: URL: https://github.com/apache/flink/pull/11764#issuecomment-616934346 @tillrohrmann same error in my macOS ... I think using `if ! [[ ${num_lines} -eq 1 ]] ` to check number also works I'd like to fix the soon

[GitHub] [flink] flinkbot edited a comment on issue #11785: [FLINK-17206][table] refactor function catalog to support delayed UDF initialization.

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11785: URL: https://github.com/apache/flink/pull/11785#issuecomment-615087743 ## CI report: * bda5c47abf20ea3682c2b1d21188d1e08edd1d87 UNKNOWN * e55bf1e1dc93609a9303b36e2a53a9941c6a2515 Travis:

[GitHub] [flink] flinkbot edited a comment on issue #11823: [FLINK-16412][hive] Disallow embedded metastore in HiveCatalog produc…

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11823: URL: https://github.com/apache/flink/pull/11823#issuecomment-616533916 ## CI report: * b07a02f49b062c7aa965c8b084585679bfd2716e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161038172) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #10228: URL: https://github.com/apache/flink/pull/10228#issuecomment-554599522 ## CI report: * 45a8d72869eee0e3eafdc007280725e8043f2521 UNKNOWN * c0a3c6e519d1793383794c797064039fa66b90d2 UNKNOWN * 69b2f84d8f611aaa55a6d366be0c0abd11ef8d73

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

2020-04-20 Thread GitBox
wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411840734 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -47,10 +47,69 @@ * needs to retract the previous row first. OR

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

2020-04-20 Thread GitBox
wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411840734 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -47,10 +47,69 @@ * needs to retract the previous row first. OR

[jira] [Commented] (FLINK-17273) Fix not calling ResourceManager#closeTaskManagerConnection in KubernetesResourceManager in case of registered TaskExecutor failure

2020-04-20 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088255#comment-17088255 ] Zili Chen commented on FLINK-17273: --- [~trohrmann][~fly_in_gis] This seems a fast fail path when

[jira] [Commented] (FLINK-17166) Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-20 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088254#comment-17088254 ] Yang Wang commented on FLINK-17166: --- After a long consideration, i think we could use

[jira] [Assigned] (FLINK-17273) Fix not calling ResourceManager#closeTaskManagerConnection in KubernetesResourceManager in case of registered TaskExecutor failure

2020-04-20 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-17273: - Assignee: Canbin Zheng > Fix not calling ResourceManager#closeTaskManagerConnection in >

[jira] [Closed] (FLINK-17120) Support Cython Optimizing Python Operations

2020-04-20 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-17120. --- Resolution: Resolved Merged to master via 6b80935b28756122cb43053494abd765a1508934 > Support Cython

[GitHub] [flink] lamber-ken commented on a change in pull request #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
lamber-ken commented on a change in pull request #10228: URL: https://github.com/apache/flink/pull/10228#discussion_r411839773 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/JvmUtils.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on issue #11785: [FLINK-17206][table] refactor function catalog to support delayed UDF initialization.

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11785: URL: https://github.com/apache/flink/pull/11785#issuecomment-615087743 ## CI report: * bda5c47abf20ea3682c2b1d21188d1e08edd1d87 UNKNOWN * e55bf1e1dc93609a9303b36e2a53a9941c6a2515 Travis:

[GitHub] [flink] flinkbot edited a comment on issue #11823: [FLINK-16412][hive] Disallow embedded metastore in HiveCatalog produc…

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11823: URL: https://github.com/apache/flink/pull/11823#issuecomment-616533916 ## CI report: * b07a02f49b062c7aa965c8b084585679bfd2716e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161038172) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11836: [FLINK-17188][python] Use pip instead of conda to install flake8 and sphinx

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11836: URL: https://github.com/apache/flink/pull/11836#issuecomment-616922166 ## CI report: * 6df508f9c18e15b1a4c15a691c5e71500d32262d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161162947) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11687: URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542 ## CI report: * 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN * d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN * cba096ae3d8eba4a0d39c64659f76ad10a62be27

[GitHub] [flink] lamber-ken commented on a change in pull request #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
lamber-ken commented on a change in pull request #10228: URL: https://github.com/apache/flink/pull/10228#discussion_r411837822 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/JvmUtils.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on issue #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #10228: URL: https://github.com/apache/flink/pull/10228#issuecomment-554599522 ## CI report: * 45a8d72869eee0e3eafdc007280725e8043f2521 UNKNOWN * c0a3c6e519d1793383794c797064039fa66b90d2 UNKNOWN * 69b2f84d8f611aaa55a6d366be0c0abd11ef8d73

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

2020-04-20 Thread GitBox
dianfu commented on a change in pull request #11768: URL: https://github.com/apache/flink/pull/11768#discussion_r411828146 ## File path: docs/dev/table/python/dependency_management.md ## @@ -22,7 +22,24 @@ specific language governing permissions and limitations under the

[GitHub] [flink] lamber-ken commented on a change in pull request #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
lamber-ken commented on a change in pull request #10228: URL: https://github.com/apache/flink/pull/10228#discussion_r411835757 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerThreadDumpFileHeaders.java ## @@ -0,0 +1,60

[GitHub] [flink] lamber-ken commented on a change in pull request #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
lamber-ken commented on a change in pull request #10228: URL: https://github.com/apache/flink/pull/10228#discussion_r411835682 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java ## @@ -22,6 +22,18 @@ * Different file types to

[GitHub] [flink] lamber-ken commented on issue #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
lamber-ken commented on issue #10228: URL: https://github.com/apache/flink/pull/10228#issuecomment-616924812 Hi @tillrohrmann @vthinkxie , please review again, thanks ![image](https://user-images.githubusercontent.com/20113411/79821055-53bbd680-83c0-11ea-9c4d-467f5451ef6a.png)

[GitHub] [flink] flinkbot commented on issue #11836: [FLINK-17188][python] Use pip instead of conda to install flake8 and sphinx

2020-04-20 Thread GitBox
flinkbot commented on issue #11836: URL: https://github.com/apache/flink/pull/11836#issuecomment-616922166 ## CI report: * 6df508f9c18e15b1a4c15a691c5e71500d32262d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run

[GitHub] [flink] flinkbot edited a comment on issue #11835: [hotfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11835: URL: https://github.com/apache/flink/pull/11835#issuecomment-616914851 ## CI report: * 3f4e611749de42b1c7b18a7a421879e2a55379d1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161161009) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11797: URL: https://github.com/apache/flink/pull/11797#issuecomment-615294694 ## CI report: * 85f40e3041783b1dbda1eb3b812f23e77936f7b3 UNKNOWN * c0080483a48619667cbc5c64edd232ae88db0046 Travis:

[GitHub] [flink] flinkbot edited a comment on issue #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11687: URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542 ## CI report: * 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN * d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN * cba096ae3d8eba4a0d39c64659f76ad10a62be27

[GitHub] [flink] WeiZhong94 commented on issue #11785: [FLINK-17206][table] refactor function catalog to support delayed UDF initialization.

2020-04-20 Thread GitBox
WeiZhong94 commented on issue #11785: URL: https://github.com/apache/flink/pull/11785#issuecomment-616920901 @dawidwys Thanks for your review again! I have updated this PR according to your comment. This is an automated

[GitHub] [flink] lirui-apache commented on issue #11823: [FLINK-16412][hive] Disallow embedded metastore in HiveCatalog produc…

2020-04-20 Thread GitBox
lirui-apache commented on issue #11823: URL: https://github.com/apache/flink/pull/11823#issuecomment-616918761 I updated `DependencyTest` so that it doesn't call `HiveCatalogFactory::createCatalog` which has already been covered by `HiveCatalogFactoryTest`.

[GitHub] [flink] danny0405 commented on a change in pull request #11568: [FLINK-16779][table] Add RAW type support in DDL and functions

2020-04-20 Thread GitBox
danny0405 commented on a change in pull request #11568: URL: https://github.com/apache/flink/pull/11568#discussion_r411824095 ## File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd ## @@ -445,9 +445,10 @@ # Return type of method implementation should be

[jira] [Closed] (FLINK-17135) PythonCalcSplitRuleTest.testPandasFunctionMixedWithGeneralPythonFunction failed

2020-04-20 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng closed FLINK-17135. --- Resolution: Fixed > PythonCalcSplitRuleTest.testPandasFunctionMixedWithGeneralPythonFunction >

[jira] [Commented] (FLINK-17135) PythonCalcSplitRuleTest.testPandasFunctionMixedWithGeneralPythonFunction failed

2020-04-20 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088230#comment-17088230 ] Hequn Cheng commented on FLINK-17135: - Hi, the fix has been merged into master via

[GitHub] [flink] flinkbot commented on issue #11835: [hotfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
flinkbot commented on issue #11835: URL: https://github.com/apache/flink/pull/11835#issuecomment-616914851 ## CI report: * 3f4e611749de42b1c7b18a7a421879e2a55379d1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run

[GitHub] [flink] hequn8128 commented on issue #11771: [FLINK-17135][python][tests] Fix the test testPandasFunctionMixedWithGeneralPythonFunction to make it more stable

2020-04-20 Thread GitBox
hequn8128 commented on issue #11771: URL: https://github.com/apache/flink/pull/11771#issuecomment-616914863 @dawidwys @danny0405 Thanks a lot for your double-check on this. Merging... This is an automated message

[GitHub] [flink] flinkbot edited a comment on issue #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11797: URL: https://github.com/apache/flink/pull/11797#issuecomment-615294694 ## CI report: * 85f40e3041783b1dbda1eb3b812f23e77936f7b3 UNKNOWN * c0080483a48619667cbc5c64edd232ae88db0046 Travis:

[GitHub] [flink] danny0405 commented on issue #11771: [FLINK-17135][python][tests] Fix the test testPandasFunctionMixedWithGeneralPythonFunction to make it more stable

2020-04-20 Thread GitBox
danny0405 commented on issue #11771: URL: https://github.com/apache/flink/pull/11771#issuecomment-616914403 Thanks, i think it is ready for merge. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot commented on issue #11836: [FLINK-17188][python] Use pip instead of conda to install flake8 and sphinx

2020-04-20 Thread GitBox
flinkbot commented on issue #11836: URL: https://github.com/apache/flink/pull/11836#issuecomment-616913599 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress

[jira] [Updated] (FLINK-17188) Failed to download conda when running python tests

2020-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17188: --- Labels: pull-request-available test-stability (was: test-stability) > Failed to download

[GitHub] [flink] HuangXingBo opened a new pull request #11836: [FLINK-17188][python] Use pip instead of conda to install flake8 and sphinx

2020-04-20 Thread GitBox
HuangXingBo opened a new pull request #11836: URL: https://github.com/apache/flink/pull/11836 ## What is the purpose of the change *This pull request will use pip instead of conda to install flake8 and sphinx. We found our Azure machine always can't connect to anaconda channel, but

[GitHub] [flink] dianfu commented on issue #11771: [FLINK-17135][python][tests] Fix the test testPandasFunctionMixedWithGeneralPythonFunction to make it more stable

2020-04-20 Thread GitBox
dianfu commented on issue #11771: URL: https://github.com/apache/flink/pull/11771#issuecomment-616912878 @danny0405 Thanks a lot for your comments. Personally I think there is no need to revert this change even after the issue is fixed in calcite. The changed test case is to test the

[GitHub] [flink] leonardBang commented on a change in pull request #11334: [FLINK-16464][sql-client]result-mode tableau may shift when content contains Chinese String in SQL CLI

2020-04-20 Thread GitBox
leonardBang commented on a change in pull request #11334: URL: https://github.com/apache/flink/pull/11334#discussion_r411265633 ## File path: flink-table/flink-sql-client/src/main/resources/META-INF/NOTICE ## @@ -9,3 +9,4 @@ See bundled license files for details. -

[GitHub] [flink] flinkbot commented on issue #11835: [hostfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
flinkbot commented on issue #11835: URL: https://github.com/apache/flink/pull/11835#issuecomment-616908047 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress

[jira] [Closed] (FLINK-17263) Remove RepeatFamilyOperandTypeChecker in blink planner and replace it with calcite's CompositeOperandTypeChecker

2020-04-20 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-17263. -- Fix Version/s: 1.11.0 Assignee: Terry Wang Resolution: Fixed master: 

[GitHub] [flink] leonardBang opened a new pull request #11835: [hostfix][table sql planner/table sql legacy planner]fix icu license in NOTICE file.

2020-04-20 Thread GitBox
leonardBang opened a new pull request #11835: URL: https://github.com/apache/flink/pull/11835 ## What is the purpose of the change *This pull request fix the icu license, move the icu being under the ICU license block in notice file.* ## Brief change log

[GitHub] [flink] KurtYoung commented on a change in pull request #11334: [FLINK-16464][sql-client]result-mode tableau may shift when content contains Chinese String in SQL CLI

2020-04-20 Thread GitBox
KurtYoung commented on a change in pull request #11334: URL: https://github.com/apache/flink/pull/11334#discussion_r411811681 ## File path: flink-table/flink-sql-client/src/main/resources/META-INF/NOTICE ## @@ -9,3 +9,4 @@ See bundled license files for details. -

[jira] [Assigned] (FLINK-16103) Translate "Configuration" page of "Table API & SQL" into Chinese

2020-04-20 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-16103: --- Assignee: Delin Zhao > Translate "Configuration" page of "Table API & SQL" into Chinese >

[jira] [Commented] (FLINK-16103) Translate "Configuration" page of "Table API & SQL" into Chinese

2020-04-20 Thread Delin Zhao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088203#comment-17088203 ] Delin Zhao commented on FLINK-16103: You are right. I want to get it and complete it with free time

[GitHub] [flink] flinkbot edited a comment on issue #11834: [FLINK-17237][docs] Add Intro to DataStream API tutorial

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11834: URL: https://github.com/apache/flink/pull/11834#issuecomment-616733646 ## CI report: * 5f931d2730361d3d59801041010509e9945627c0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161101219) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #11826: [FLINK-17236][docs] Add Tutorials section overview

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11826: URL: https://github.com/apache/flink/pull/11826#issuecomment-616548100 ## CI report: * 99f48626c81334d4f942d19e5c9efd2098a8302e Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161120771) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #10228: URL: https://github.com/apache/flink/pull/10228#issuecomment-554599522 ## CI report: * 45a8d72869eee0e3eafdc007280725e8043f2521 UNKNOWN * c0a3c6e519d1793383794c797064039fa66b90d2 UNKNOWN * 69b2f84d8f611aaa55a6d366be0c0abd11ef8d73

[jira] [Issue Comment Deleted] (FLINK-16099) Translate "HiveCatalog" page of "Hive Integration" into Chinese

2020-04-20 Thread zhangzhanhua (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhanhua updated FLINK-16099: - Comment: was deleted (was: I can help with the translation) > Translate "HiveCatalog" page of

[GitHub] [flink] flinkbot edited a comment on issue #11834: [FLINK-17237][docs] Add Intro to DataStream API tutorial

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11834: URL: https://github.com/apache/flink/pull/11834#issuecomment-616733646 ## CI report: * 5f931d2730361d3d59801041010509e9945627c0 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161101219) Azure:

[GitHub] [flink] flinkbot edited a comment on issue #10228: [FLINK-14816] Add thread dump feature for taskmanager

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #10228: URL: https://github.com/apache/flink/pull/10228#issuecomment-554599522 ## CI report: * 45a8d72869eee0e3eafdc007280725e8043f2521 UNKNOWN * c0a3c6e519d1793383794c797064039fa66b90d2 UNKNOWN * 69b2f84d8f611aaa55a6d366be0c0abd11ef8d73

[GitHub] [flink] flinkbot edited a comment on issue #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

2020-04-20 Thread GitBox
flinkbot edited a comment on issue #11797: URL: https://github.com/apache/flink/pull/11797#issuecomment-615294694 ## CI report: * 85f40e3041783b1dbda1eb3b812f23e77936f7b3 UNKNOWN * c0080483a48619667cbc5c64edd232ae88db0046 Travis:

  1   2   3   4   5   6   7   8   >