[GitHub] [flink] flinkbot edited a comment on pull request #17665: [docs][typos] Fix typos in fault_tolerance.md

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17665: URL: https://github.com/apache/flink/pull/17665#issuecomment-960462017 ## CI report: * 4d46a90b64d13546a93cc5a9f540575d6a38e0d9 Azure:

[GitHub] [flink] flinkbot commented on pull request #17665: [docs][typos] Fix typos in fault_tolerance.md

2021-11-03 Thread GitBox
flinkbot commented on pull request #17665: URL: https://github.com/apache/flink/pull/17665#issuecomment-960462017 ## CI report: * 4d46a90b64d13546a93cc5a9f540575d6a38e0d9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17665: [docs][typos] Fix typos in fault_tolerance.md

2021-11-03 Thread GitBox
flinkbot commented on pull request #17665: URL: https://github.com/apache/flink/pull/17665#issuecomment-960461887 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] mincwang opened a new pull request #17665: [docs][typos]

2021-11-03 Thread GitBox
mincwang opened a new pull request #17665: URL: https://github.com/apache/flink/pull/17665 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] flinkbot edited a comment on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-948251540 ## CI report: * Unknown: [CANCELED](TBD) * 633084a4927bccc3958373c12ccd3441d303be68 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * 2821a77a60feefd959cdf1f54e336ab4fcaa1a71 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17605: URL: https://github.com/apache/flink/pull/17605#issuecomment-954693023 ## CI report: * 0056d2cc65fb1d0ff971c0394a32fd65972ff148 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-948251540 ## CI report: * Unknown: [CANCELED](TBD) * 633084a4927bccc3958373c12ccd3441d303be68 UNKNOWN Bot commands The @flinkbot bot supports the

[GitHub] [flink] TanYuxin-tyx removed a comment on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-03 Thread GitBox
TanYuxin-tyx removed a comment on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-958978355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] TanYuxin-tyx commented on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-03 Thread GitBox
TanYuxin-tyx commented on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-960456231 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * 2821a77a60feefd959cdf1f54e336ab4fcaa1a71 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17605: URL: https://github.com/apache/flink/pull/17605#issuecomment-954693023 ## CI report: * 0056d2cc65fb1d0ff971c0394a32fd65972ff148 Azure:

[GitHub] [flink] xuyangzhong commented on a change in pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-03 Thread GitBox
xuyangzhong commented on a change in pull request #17652: URL: https://github.com/apache/flink/pull/17652#discussion_r742532909 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala ## @@ -246,77

[GitHub] [flink] xuyangzhong commented on a change in pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-03 Thread GitBox
xuyangzhong commented on a change in pull request #17652: URL: https://github.com/apache/flink/pull/17652#discussion_r742535921 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/PartitionableSourceTest.scala ## @@

[jira] [Updated] (FLINK-24759) Metrics on web UI is not correct in a filesystem source to filesystem sink streaming job

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24759: Description: I'm running a yarn-per-job streaming job (submitted via SQL client) which reads a

[jira] [Updated] (FLINK-24759) Metrics on web UI is not correct in a filesystem source to filesystem sink streaming job

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24759: Description: I'm running a yarn-per-job streaming job (submitted via SQL client) which reads a

[jira] [Created] (FLINK-24759) Metrics on web UI is not correct in a filesystem source to filesystem sink streaming job

2021-11-03 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-24759: --- Summary: Metrics on web UI is not correct in a filesystem source to filesystem sink streaming job Key: FLINK-24759 URL: https://issues.apache.org/jira/browse/FLINK-24759

[jira] [Updated] (FLINK-24759) Metrics on web UI is not correct in a filesystem source to filesystem sink streaming job

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24759: Description: I'm running a yarn-per-job streaming job which reads a large csv file (flights.csv

[GitHub] [flink] xuyangzhong commented on a change in pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-03 Thread GitBox
xuyangzhong commented on a change in pull request #17652: URL: https://github.com/apache/flink/pull/17652#discussion_r742532909 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala ## @@ -246,77

[GitHub] [flink] flinkbot edited a comment on pull request #17635: [FLINK-24724][buildsystem] Update Sun XML Bind dependencies to latest minor version

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17635: URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981 ## CI report: * 052d2a12ed9a10c86db344dad25b292cbb1a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17646: [FLINK-24740][testinfrastructure] Update testcontainers dependency to the latest version

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17646: URL: https://github.com/apache/flink/pull/17646#issuecomment-957837700 ## CI report: * b90ca62a59048e9ea369de6942203139e372533e Azure:

[jira] [Updated] (FLINK-24758) partition.time-extractor.kind support "yyyyMMdd"

2021-11-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-24758: - Description: Now, only supports -mm-dd hh:mm:ss, we can add a new time-extractor kind to

[jira] [Updated] (FLINK-24758) filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-24758: - Summary: filesystem sink: partition.time-extractor.kind support "MMdd" (was:

[jira] [Created] (FLINK-24758) partition.time-extractor.kind support "yyyyMMdd"

2021-11-03 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-24758: Summary: partition.time-extractor.kind support "MMdd" Key: FLINK-24758 URL: https://issues.apache.org/jira/browse/FLINK-24758 Project: Flink Issue Type:

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-03 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742527302 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java ## @@ -669,6 +704,11 @@ public SchedulingTopology

[jira] [Updated] (FLINK-24757) Yarn application is not terminated after the job finishes when submitting a yarn-per-job insert job with SQL client

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24757: Description: I've seen this problem for about three times in the user mailing thread (previously

[jira] [Updated] (FLINK-24757) Yarn application is not terminated after the job finishes when submitting a yarn-per-job insert job with SQL client

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24757: Description: I've seen this problem for about three times in the user mailing thread (previously

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-03 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742521923 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerComponents.java ## @@ -124,9 +126,19 @@ private static

[jira] [Updated] (FLINK-24757) Yarn application is not terminated after the job finishes when submitting a yarn-per-job insert job with SQL client

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24757: Description: I've seen this problem for about three times in the user mailing thread (previously

[jira] [Updated] (FLINK-24757) Yarn application is not terminated after the job finishes when submitting a yarn-per-job insert job with SQL client

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24757: Description: I've seen this problem for about three times in the user mailing thread (previously

[jira] [Created] (FLINK-24757) Yarn application is not terminated after the job finishes when submitting a yarn-per-job insert job with SQL client

2021-11-03 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-24757: --- Summary: Yarn application is not terminated after the job finishes when submitting a yarn-per-job insert job with SQL client Key: FLINK-24757 URL:

[GitHub] [flink] flinkbot edited a comment on pull request #17650: [FLINK-24475] Remove no longer used NestedMap* classes

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17650: URL: https://github.com/apache/flink/pull/17650#issuecomment-958638599 ## CI report: * 150b5f9f464913cc83756cbadd233cdb279db0c7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] meetjunsu commented on pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-11-03 Thread GitBox
meetjunsu commented on pull request #17542: URL: https://github.com/apache/flink/pull/17542#issuecomment-960418603 rebase onto latest master branch to fix python tests error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] tsreaper commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
tsreaper commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742497844 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java ## @@ -312,6

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957416596 ## CI report: * a4275b6ff459651c730cce9ddb48216dad635197 Azure:

[GitHub] [flink] meetjunsu commented on pull request #17654: [FLINK-24614][Connectors/PARQUET] Add Complex types support for parquet reader

2021-11-03 Thread GitBox
meetjunsu commented on pull request #17654: URL: https://github.com/apache/flink/pull/17654#issuecomment-960417686 > @meetjunsu Thanks for the PR! Would this also make it possible to support this for DataStream API users? As far as I know `ParquetColumnarRowInputFormat` is a

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957416596 ## CI report: * a4275b6ff459651c730cce9ddb48216dad635197 Azure:

[jira] [Commented] (FLINK-24751) flink SQL comile failed cause by: java.lang.StackOverflowError

2021-11-03 Thread tao.yang03 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438463#comment-17438463 ] tao.yang03 commented on FLINK-24751: thanks 。 I  add  env.java.opts.taskmanager= '-Xss100M' ,  this  

[jira] [Updated] (FLINK-24751) flink SQL comile failed cause by: java.lang.StackOverflowError

2021-11-03 Thread tao.yang03 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tao.yang03 updated FLINK-24751: --- Attachment: image-2021-11-04-11-03-22-937.png > flink SQL comile failed cause by:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] wsz94 commented on a change in pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
wsz94 commented on a change in pull request #17643: URL: https://github.com/apache/flink/pull/17643#discussion_r742503458 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderBase.java

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[jira] [Updated] (FLINK-24728) Batch SQL file sink forgets to close the output stream

2021-11-03 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24728: Affects Version/s: (was: 1.13.4) (was: 1.14.1)

[GitHub] [flink] syhily commented on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
syhily commented on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-960414913 > > @wsz94 I have created a patch by using `consumer.receive(timeout, timeunit)`. Can you confirm this fix works? > >

[GitHub] [flink] lincoln-lil commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
lincoln-lil commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742502402 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/RankHarnessTest.scala ## @@ -220,4

[GitHub] [flink] lincoln-lil commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
lincoln-lil commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742502276 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java ## @@ -312,6

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] syhily commented on a change in pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
syhily commented on a change in pull request #17643: URL: https://github.com/apache/flink/pull/17643#discussion_r742501504 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderBase.java

[GitHub] [flink] tsreaper commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
tsreaper commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742501383 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/RankHarnessTest.scala ## @@ -220,4 +221,74

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] lincoln-lil commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
lincoln-lil commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742500845 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java ## @@ -312,6

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17650: [FLINK-24475] Remove no longer used NestedMap* classes

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17650: URL: https://github.com/apache/flink/pull/17650#issuecomment-958638599 ## CI report: * 150b5f9f464913cc83756cbadd233cdb279db0c7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17650: [FLINK-24475] Remove no longer used NestedMap* classes

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17650: URL: https://github.com/apache/flink/pull/17650#issuecomment-958638599 ## CI report: * 150b5f9f464913cc83756cbadd233cdb279db0c7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] Zakelly commented on pull request #17650: [FLINK-24475] Remove no longer used NestedMap* classes

2021-11-03 Thread GitBox
Zakelly commented on pull request #17650: URL: https://github.com/apache/flink/pull/17650#issuecomment-960404229 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] tsreaper commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
tsreaper commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742497844 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java ## @@ -312,6

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] tsreaper commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
tsreaper commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742494069 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java ## @@ -312,6

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] tsreaper commented on a change in pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-03 Thread GitBox
tsreaper commented on a change in pull request #17605: URL: https://github.com/apache/flink/pull/17605#discussion_r742492674 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java ## @@ -312,6

[jira] [Commented] (FLINK-24687) flink-table uber jar should not include flink-connector-files dependency

2021-11-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438460#comment-17438460 ] Jingsong Lee commented on FLINK-24687: -- I think it should be possible, because the previous file

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[jira] [Commented] (FLINK-24713) Postpone resourceManager serving after the recovery phase has finished

2021-11-03 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438459#comment-17438459 ] Yangze Guo commented on FLINK-24713: [~aitozi] I second Till's proposal. A configurable interval is

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * cbb562453f733959c1f7e4ca96f4c74309f1ee81 Azure:

[GitHub] [flink] wenlong88 commented on a change in pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for wi

2021-11-03 Thread GitBox
wenlong88 commented on a change in pull request #17509: URL: https://github.com/apache/flink/pull/17509#discussion_r742482235 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SlicingWindowOperator.java ## @@

[jira] [Commented] (FLINK-16833) Make JDBCDialect pluggable for JDBC SQL connector

2021-11-03 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438452#comment-17438452 ] Lijie Wang commented on FLINK-16833: Hi [~MartijnVisser] , sorry for the late reply. I see it's

[GitHub] [flink] mans2singh commented on pull request #17661: [hotfix][connectors][table][jdbc][docs] - Updated key handling section text

2021-11-03 Thread GitBox
mans2singh commented on pull request #17661: URL: https://github.com/apache/flink/pull/17661#issuecomment-959384274 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-03 Thread GitBox
slinkydeveloper commented on a change in pull request #17658: URL: https://github.com/apache/flink/pull/17658#discussion_r742034054 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/rules/AbstractCodeGeneratorCastRule.java

[jira] [Comment Edited] (FLINK-24755) sun.misc doesn't exist

2021-11-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438169#comment-17438169 ] Aitozi edited comment on FLINK-24755 at 11/4/21, 2:01 AM: -- [~chesnay]  You can

[GitHub] [flink] wsz94 edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
wsz94 edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-959583041 > @wsz94 I have created a patch by using `consumer.receive(timeout, timeunit)`. Can you confirm this fix works? > >

[GitHub] [flink] tsreaper commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-11-03 Thread GitBox
tsreaper commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-959002265 @slinkydeveloper @fapaul @JingGe I've done some benchmarking on a testing yarn cluster. * Test data: The [Kaggle flight delay

[GitHub] [flink] flinkbot commented on pull request #17651: [FLINK-24656][docs] Add documentation for window deduplication

2021-11-03 Thread GitBox
flinkbot commented on pull request #17651: URL: https://github.com/apache/flink/pull/17651#issuecomment-958639580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-03 Thread GitBox
flinkbot commented on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-959309745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] matriv commented on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-03 Thread GitBox
matriv commented on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-959587919 > @matriv regarding testing the rules in `CastFunctionsITCase`, I effectively found out that the row, array and map rules doesn't work, because some validation steps before

[GitHub] [flink] tsreaper edited a comment on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-11-03 Thread GitBox
tsreaper edited a comment on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-959002265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] JingsongLi commented on pull request #17571: [FLINK-23015][table-runtime-blink] Implement streaming window Deduplicate operator

2021-11-03 Thread GitBox
JingsongLi commented on pull request #17571: URL: https://github.com/apache/flink/pull/17571#issuecomment-958618670 Minor: @beyond1920 We don't need add "blink" in the commit message, blink planner is the only planner. -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (FLINK-24755) sun.misc doesn't exist

2021-11-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438169#comment-17438169 ] Aitozi edited comment on FLINK-24755 at 11/4/21, 2:00 AM: -- [~chesnay]  You can

[GitHub] [flink] nlu90 commented on a change in pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-03 Thread GitBox
nlu90 commented on a change in pull request #17643: URL: https://github.com/apache/flink/pull/17643#discussion_r742253290 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderBase.java

[GitHub] [flink] zentol commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization

2021-11-03 Thread GitBox
zentol commented on a change in pull request #17608: URL: https://github.com/apache/flink/pull/17608#discussion_r742040650 ## File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java ## @@ -413,7 +413,7 @@ static Object

[GitHub] [flink] CrynetLogistics commented on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-03 Thread GitBox
CrynetLogistics commented on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-959763267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-03 Thread GitBox
slinkydeveloper commented on a change in pull request #17656: URL: https://github.com/apache/flink/pull/17656#discussion_r742125995 ## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/FileRecordFormatAdapter.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17660: [FLINK-24657][runtime] Added metric of the total real size of input/o…

2021-11-03 Thread GitBox
flinkbot commented on pull request #17660: URL: https://github.com/apache/flink/pull/17660#issuecomment-958945516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17649: [FLINK-24742][table][docs] Add info about SQL client key strokes to docs

2021-11-03 Thread GitBox
flinkbot edited a comment on pull request #17649: URL: https://github.com/apache/flink/pull/17649#issuecomment-958288236 ## CI report: * 7081987de10cb9601d16a1292862fb062cf002d5 Azure:

  1   2   3   4   5   6   7   8   9   10   >