[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894982074 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink] reswqa commented on pull request #19927: [FLINK-27903][runtime] Introduce and support HYBRID resultPartitionType

2022-06-10 Thread GitBox
reswqa commented on PR #19927: URL: https://github.com/apache/flink/pull/19927#issuecomment-1152862184 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia commented on pull request #19929: T success

2022-06-10 Thread GitBox
luoyuxia commented on PR #19929: URL: https://github.com/apache/flink/pull/19929#issuecomment-1152860667 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-27667) YARNHighAvailabilityITCase fails with "Failed to delete temp directory /tmp/junit1681"

2022-06-10 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553031#comment-17553031 ] Weijie Guo commented on FLINK-27667:

[jira] [Commented] (FLINK-22644) Translate "Native Kubernetes" page into Chinese

2022-06-10 Thread linqichen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553027#comment-17553027 ] linqichen commented on FLINK-22644: --- @[~jark]  hello!!! I am willing to translate "Native Kubernetes"

[GitHub] [flink] flinkbot commented on pull request #19936: [Hotfix][connector] fix typos in Source interface

2022-06-10 Thread GitBox
flinkbot commented on PR #19936: URL: https://github.com/apache/flink/pull/19936#issuecomment-1152859112 ## CI report: * 5c23c2c64ad46c0e50c3bcd68b6bfc2d905aef59 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] littleeleventhwolf opened a new pull request, #19936: [Hotfix][connector] fix typos in Source interface

2022-06-10 Thread GitBox
littleeleventhwolf opened a new pull request, #19936: URL: https://github.com/apache/flink/pull/19936 ## What is the purpose of the change Fix typos in `Source` interface. ## Brief change log - delete useless '*' in comments - modify @link format in

[GitHub] [flink] luoyuxia commented on a diff in pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

2022-06-10 Thread GitBox
luoyuxia commented on code in PR #19931: URL: https://github.com/apache/flink/pull/19931#discussion_r894604477 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java: ## @@ -387,7 +387,9 @@

[GitHub] [flink] luoyuxia commented on a diff in pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

2022-06-10 Thread GitBox
luoyuxia commented on code in PR #19931: URL: https://github.com/apache/flink/pull/19931#discussion_r894604477 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java: ## @@ -387,7 +387,9 @@

[GitHub] [flink] luoyuxia commented on pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

2022-06-10 Thread GitBox
luoyuxia commented on PR #19931: URL: https://github.com/apache/flink/pull/19931#issuecomment-1152848363 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dusukang commented on pull request #19741: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

2022-06-10 Thread GitBox
dusukang commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1152847189 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia commented on a diff in pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

2022-06-10 Thread GitBox
luoyuxia commented on code in PR #19931: URL: https://github.com/apache/flink/pull/19931#discussion_r894604477 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java: ## @@ -387,7 +387,9 @@

[jira] [Commented] (FLINK-28008) Can not get secondary resource from context after operator restart

2022-06-10 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553018#comment-17553018 ] Aitozi commented on FLINK-28008: I don't know if there any trick with the new sdk version. cc

[GitHub] [flink] luoyuxia commented on pull request #19929: T success

2022-06-10 Thread GitBox
luoyuxia commented on PR #19929: URL: https://github.com/apache/flink/pull/19929#issuecomment-1152844191 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-28008) Can not get secondary resource from context after operator restart

2022-06-10 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553014#comment-17553014 ] Aitozi commented on FLINK-28008: I test with the last release version with    {code:java} helm install

[jira] [Comment Edited] (FLINK-28008) Can not get secondary resource from context after operator restart

2022-06-10 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553014#comment-17553014 ] Aitozi edited comment on FLINK-28008 at 6/11/22 3:01 AM: - I test with the last

[jira] [Updated] (FLINK-28008) Can not get secondary resource from context after operator restart

2022-06-10 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-28008: --- Summary: Can not get secondary resource from context after operator restart (was: Can not get secondary

[jira] [Updated] (FLINK-28008) Can not get secondary resource from after operator restart

2022-06-10 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-28008: --- Description: how to reproduce: * create session and submit session job * delete session job * restart

[jira] [Created] (FLINK-28008) Can not get secondary resource from after operator restart

2022-06-10 Thread Aitozi (Jira)
Aitozi created FLINK-28008: -- Summary: Can not get secondary resource from after operator restart Key: FLINK-28008 URL: https://issues.apache.org/jira/browse/FLINK-28008 Project: Flink Issue Type:

[jira] [Updated] (FLINK-27613) Add label for the session job to help list the session jobs in the same session cluster

2022-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27613: --- Labels: pull-request-available (was: ) > Add label for the session job to help list the

[GitHub] [flink-kubernetes-operator] Aitozi opened a new pull request, #265: [FLINK-27613] Add label for the session job to help list the session …

2022-06-10 Thread GitBox
Aitozi opened a new pull request, #265: URL: https://github.com/apache/flink-kubernetes-operator/pull/265 …jobs in the same session cluster This PR is based on https://github.com/apache/flink-kubernetes-operator/pull/215 but use the mutator webhook to do the same thing -- This is

[jira] [Commented] (FLINK-27963) FlinkRuntimeException in KafkaSink causes a Flink job to hang

2022-06-10 Thread Dmytro (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552970#comment-17552970 ] Dmytro commented on FLINK-27963: Hi [~martijnvisser], thank you for being involved!  I absolutely agree

[GitHub] [flink] coderappee commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

2022-06-10 Thread GitBox
coderappee commented on PR #19924: URL: https://github.com/apache/flink/pull/19924#issuecomment-1152655897 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] coderappee commented on pull request #19924: [FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks

2022-06-10 Thread GitBox
coderappee commented on PR #19924: URL: https://github.com/apache/flink/pull/19924#issuecomment-1152653795 > @coderappee Let me know if you're stuck, and I can take care of this when I merge the PR. > > In this particular situation, it should be enough to rollback the last commit in

[GitHub] [flink] salvalcantara commented on a diff in pull request #19366: [FLINK-24660][Connectors / Kafka] allow setting KafkaSubscriber in KafkaSourceBuilder

2022-06-10 Thread GitBox
salvalcantara commented on code in PR #19366: URL: https://github.com/apache/flink/pull/19366#discussion_r894761263 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java: ## @@ -184,6 +184,18 @@ return

[jira] [Assigned] (FLINK-27101) Periodically break the chain of incremental checkpoint

2022-06-10 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise reassigned FLINK-27101: Assignee: Jiale Tan > Periodically break the chain of incremental checkpoint >

[jira] [Updated] (FLINK-28007) Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

2022-06-10 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-28007: --- Description: h3. Background The unit & integration tests for the aws connectors in the Flink

[jira] [Updated] (FLINK-28007) Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

2022-06-10 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-28007: --- Labels: (was: pull-request-available) > Tests for AWS Connectors Using SDK v2 to use Synchronous

[jira] [Updated] (FLINK-28007) Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

2022-06-10 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-28007: --- Component/s: Connectors / Common > Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

[jira] [Updated] (FLINK-28007) Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

2022-06-10 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-28007: --- Affects Version/s: 1.15.0 1.15.1 1.15.2 > Tests for

[jira] [Created] (FLINK-28007) Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

2022-06-10 Thread Zichen Liu (Jira)
Zichen Liu created FLINK-28007: -- Summary: Tests for AWS Connectors Using SDK v2 to use Synchronous Clients Key: FLINK-28007 URL: https://issues.apache.org/jira/browse/FLINK-28007 Project: Flink

[jira] [Updated] (FLINK-28007) Tests for AWS Connectors Using SDK v2 to use Synchronous Clients

2022-06-10 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-28007: --- Priority: Minor (was: Major) > Tests for AWS Connectors Using SDK v2 to use Synchronous Clients >

[GitHub] [flink] flinkbot commented on pull request #19935: [FLINK-27884] Move OutputFormatBase to flink-core to offer flush mechanism to all output formats

2022-06-10 Thread GitBox
flinkbot commented on PR #19935: URL: https://github.com/apache/flink/pull/19935#issuecomment-1152536310 ## CI report: * 6e6751cbf94c00f35b023e2d945aaf76714ea3e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27884) Introduce a flush mechanism for OutputFormats

2022-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27884: --- Labels: pull-request-available (was: ) > Introduce a flush mechanism for OutputFormats >

[GitHub] [flink] echauchot opened a new pull request, #19935: [FLINK-27884] Move OutputFormatBase to flink-core to offer flush mechanism to all output formats

2022-06-10 Thread GitBox
echauchot opened a new pull request, #19935: URL: https://github.com/apache/flink/pull/19935 ## What is the purpose of the change Move OutputFormatBase to flink-core to offer flush mechanism to all output formats ## Brief change log Move OutputFormatBase from

[jira] [Commented] (FLINK-27934) Python API- Inefficient deserialization/serialization of state variables within a batch

2022-06-10 Thread Frans King (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552830#comment-17552830 ] Frans King commented on FLINK-27934: Pull request here with my changes -

[jira] [Updated] (FLINK-27934) Python API- Inefficient deserialization/serialization of state variables within a batch

2022-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27934: --- Labels: pull-request-available (was: ) > Python API- Inefficient

[GitHub] [flink-statefun] fransking opened a new pull request, #315: FLINK-27934 - Inefficient deserialization/serialization of state variables within a batch

2022-06-10 Thread GitBox
fransking opened a new pull request, #315: URL: https://github.com/apache/flink-statefun/pull/315 As per the JIRA in the Python SDK accessing a state variable multiple times in a single function invocation or multiple times in sequency when many function invocations are batched together is

[GitHub] [flink] wuchong commented on a diff in pull request #19742: [FLINK-27651][table] Support CREATE FUNCTION USING JAR syntax

2022-06-10 Thread GitBox
wuchong commented on code in PR #19742: URL: https://github.com/apache/flink/pull/19742#discussion_r894681266 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -1324,15 +1324,26 @@ void testCreateFunction() {

[GitHub] [flink] wuchong merged pull request #19254: [BP-1.14][hotfix][table-runtime] Fix ArrayDataSerializer null fields writing

2022-06-10 Thread GitBox
wuchong merged PR #19254: URL: https://github.com/apache/flink/pull/19254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-27954) JobVertexFlameGraphHandler does not work on standby Dispatcher

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-27954: - Description: The {{JobVertexFlameGraphHandler}} relies internally on the

[jira] [Assigned] (FLINK-27972) Race condition between task/savepoint notification failure

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-27972: Assignee: Chesnay Schepler > Race condition between task/savepoint notification

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
JingsongLi commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894603729 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink] afedulov commented on a diff in pull request #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

2022-06-10 Thread GitBox
afedulov commented on code in PR #19856: URL: https://github.com/apache/flink/pull/19856#discussion_r894608652 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersConfig.java: ## @@ -0,0 +1,599 @@ +/*

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
JingsongLi commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894605669 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/FileSystemCatalog.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache

[GitHub] [flink] luoyuxia commented on a diff in pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

2022-06-10 Thread GitBox
luoyuxia commented on code in PR #19931: URL: https://github.com/apache/flink/pull/19931#discussion_r894604477 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java: ## @@ -387,7 +387,9 @@

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
JingsongLi commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894604639 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalog.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache

[GitHub] [flink] luoyuxia commented on a diff in pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

2022-06-10 Thread GitBox
luoyuxia commented on code in PR #19931: URL: https://github.com/apache/flink/pull/19931#discussion_r894604477 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java: ## @@ -387,7 +387,9 @@

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
JingsongLi commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894603729 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds

2022-06-10 Thread GitBox
zentol commented on code in PR #19876: URL: https://github.com/apache/flink/pull/19876#discussion_r894602361 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1024,9 +1024,25 @@ under the License. -

[GitHub] [flink] luoyuxia commented on pull request #19929: T success

2022-06-10 Thread GitBox
luoyuxia commented on PR #19929: URL: https://github.com/apache/flink/pull/19929#issuecomment-1152428093 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] alpinegizmo commented on pull request #19833: [FLINK-27778][table][planner] Use correct 'newName()' method

2022-06-10 Thread GitBox
alpinegizmo commented on PR #19833: URL: https://github.com/apache/flink/pull/19833#issuecomment-1152418774 If they don't need to use the same naming scheme (but just happen to use the same one), then I don't mind the duplication and wouldn't want to add the dependency on table-common.

[jira] [Updated] (FLINK-27955) Fix the problem of windows installation failure in PyFlink

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-27955: - Fix Version/s: 1.16.0 > Fix the problem of windows installation failure in PyFlink >

[jira] [Commented] (FLINK-27933) Savepoint status cannot be queried from standby jobmanager

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552776#comment-17552776 ] Chesnay Schepler commented on FLINK-27933: -- 1.15: 0cd291ddae6581784e8d57e34fe3346607cb4f26 >

[GitHub] [flink] zentol merged pull request #19930: [FLINK-27933][rest] OperationResult implements Serializable

2022-06-10 Thread GitBox
zentol merged PR #19930: URL: https://github.com/apache/flink/pull/19930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol commented on pull request #19833: [FLINK-27778][table][planner] Use correct 'newName()' method

2022-06-10 Thread GitBox
zentol commented on PR #19833: URL: https://github.com/apache/flink/pull/19833#issuecomment-1152409972 That's a good question; they could definitely share it if we wanted to. It would result in `table-code-splitter` having a new dependency on `table-common` (presumably, if we move

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #19933: [FLINK-28000][runtime][security] Throw exception when principal is set in the configuration without keytab

2022-06-10 Thread GitBox
gaborgsomogyi commented on code in PR #19933: URL: https://github.com/apache/flink/pull/19933#discussion_r894579264 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java: ## @@ -138,25 +141,20 @@ public String getZooKeeperLoginContextName()

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #19933: [FLINK-28000][runtime][security] Throw exception when principal is set in the configuration without keytab

2022-06-10 Thread GitBox
gaborgsomogyi commented on code in PR #19933: URL: https://github.com/apache/flink/pull/19933#discussion_r894579264 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java: ## @@ -138,25 +141,20 @@ public String getZooKeeperLoginContextName()

[GitHub] [flink] gaborgsomogyi commented on pull request #19825: [FLINK-27171][runtime][security] Add periodic kerberos delegation token obtain possibility to DelegationTokenManager

2022-06-10 Thread GitBox
gaborgsomogyi commented on PR #19825: URL: https://github.com/apache/flink/pull/19825#issuecomment-1152406301 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-15736) Support Java 17 (LTS)

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552772#comment-17552772 ] Chesnay Schepler commented on FLINK-15736: -- [~jingge] No. > Support Java 17 (LTS) >

[jira] [Updated] (FLINK-27557) Submit compaction when prepareCommit is triggered

2022-06-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27557: -- Parent: (was: FLINK-27515) Issue Type: New Feature (was: Sub-task) > Submit compaction

[jira] [Closed] (FLINK-27557) Submit compaction when prepareCommit is triggered

2022-06-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-27557. - Resolution: Won't Do The impl has been refactored. > Submit compaction when prepareCommit is triggered

[jira] [Updated] (FLINK-27707) Implement ManagedTableFactory#onCompactTable

2022-06-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27707: -- Description: As discussed offline, the new implementation has been modified. * Don't perform a scan

[jira] [Commented] (FLINK-15736) Support Java 17 (LTS)

2022-06-10 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552765#comment-17552765 ] Jing Ge commented on FLINK-15736: - [~chesnay] do we have time schedule for resolving this ticket?

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894492796 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894339149 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink] link3280 closed pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

2022-06-10 Thread GitBox
link3280 closed pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests URL: https://github.com/apache/flink/pull/17320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] link3280 commented on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

2022-06-10 Thread GitBox
link3280 commented on PR #17320: URL: https://github.com/apache/flink/pull/17320#issuecomment-1152384164 OK, I'm closing this and will reopen it if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894339829 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894510200 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894510200 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot commented on pull request #19934: [FLINK-28006][tests] Run prod architecture tests in 1 JVM

2022-06-10 Thread GitBox
flinkbot commented on PR #19934: URL: https://github.com/apache/flink/pull/19934#issuecomment-1152370787 ## CI report: * abdca0f3b9b75ed8e85ad913b491c31d95f21551 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28006) Run architecture tests in single JVM

2022-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28006: --- Labels: pull-request-available (was: ) > Run architecture tests in single JVM >

[GitHub] [flink] zentol opened a new pull request, #19934: [FLINK-28006][tests] Run prod architecture tests in 1 JVM

2022-06-10 Thread GitBox
zentol opened a new pull request, #19934: URL: https://github.com/apache/flink/pull/19934 The prod architecture tests use a surprising amount of memory. Since it's difficult for us to really control that, let's run the whole thing in a single JVM. -- This is an automated message from

[jira] [Created] (FLINK-28006) Run architecture tests in single JVM

2022-06-10 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-28006: Summary: Run architecture tests in single JVM Key: FLINK-28006 URL: https://issues.apache.org/jira/browse/FLINK-28006 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-27975) Remove unnecessary RBAC rules from operator

2022-06-10 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-27975: -- Assignee: Jeesmon Jacob > Remove unnecessary RBAC rules from operator >

[jira] [Commented] (FLINK-27975) Remove unnecessary RBAC rules from operator

2022-06-10 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552751#comment-17552751 ] Márton Balassi commented on FLINK-27975: Sure, done. > Remove unnecessary RBAC rules from

[jira] [Created] (FLINK-28005) Reduce network memory in UnalignedCheckpointITCase

2022-06-10 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-28005: Summary: Reduce network memory in UnalignedCheckpointITCase Key: FLINK-28005 URL: https://issues.apache.org/jira/browse/FLINK-28005 Project: Flink

[jira] [Created] (FLINK-28004) Reduce CI heap space by 25%

2022-06-10 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-28004: Summary: Reduce CI heap space by 25% Key: FLINK-28004 URL: https://issues.apache.org/jira/browse/FLINK-28004 Project: Flink Issue Type: Technical

[jira] [Commented] (FLINK-27967) Unable to inject entropy on s3 prefix when doing a save point in Flink

2022-06-10 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552748#comment-17552748 ] David Anderson commented on FLINK-27967: [~vinay._.devadiga] You should expect to the find the

[jira] [Commented] (FLINK-27995) Upgrade Janino version

2022-06-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552742#comment-17552742 ] Martijn Visser commented on FLINK-27995: Thanks for the input Jark and Lincoln! > Upgrade

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894510200 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-27933) Savepoint status cannot be queried from standby jobmanager

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-27933: - Summary: Savepoint status cannot be queried from standby jobmanager (was: Savepoint

[jira] [Closed] (FLINK-27968) end-to-end-tests-sql CI test failed

2022-06-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-27968. Resolution: Fixed master: ca47e88a91ac28e962c9ac586bdcf983a36027d1 1.15.1:

[GitHub] [flink] zentol merged pull request #19932: [FLINK-27968][E2E] Fix failed end-to-end-tests-sql CI test

2022-06-10 Thread GitBox
zentol merged PR #19932: URL: https://github.com/apache/flink/pull/19932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol merged pull request #19922: [FLINK-27968][E2E] Fix failed end-to-end-tests-sql CI test

2022-06-10 Thread GitBox
zentol merged PR #19922: URL: https://github.com/apache/flink/pull/19922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27995) Upgrade Janino version

2022-06-10 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552738#comment-17552738 ] lincoln lee commented on FLINK-27995: - Agree with Jark that try to bump up Janino separately.

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894339149 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [flink] liujiawinds commented on pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.2

2022-06-10 Thread GitBox
liujiawinds commented on PR #19844: URL: https://github.com/apache/flink/pull/19844#issuecomment-1152332374 @JingsongLi Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19448: [FLINK-25872][state] Support restore from non-changelog checkpoint with changelog enabled in CLAIM mode

2022-06-10 Thread GitBox
rkhachatryan commented on code in PR #19448: URL: https://github.com/apache/flink/pull/19448#discussion_r894476700 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java: ## @@ -50,6 +56,9 @@ public class CheckpointsCleaner implements

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #137: [FLINK-27755] Introduce a filesystem catalog for table store

2022-06-10 Thread GitBox
LadyForest commented on code in PR #137: URL: https://github.com/apache/flink-table-store/pull/137#discussion_r894492796 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/TableStoreCatalogFactory.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-16686) [State TTL] Make user class loader available in native RocksDB compaction thread

2022-06-10 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552732#comment-17552732 ] Alexis Sarda-Espinosa commented on FLINK-16686: --- The reported problems were falling back

[GitHub] [flink] 1996fanrui commented on pull request #19499: [FLINK-26762][network] Add the overdraft buffer in ResultPartition

2022-06-10 Thread GitBox
1996fanrui commented on PR #19499: URL: https://github.com/apache/flink/pull/19499#issuecomment-1152319736 > @1996fanrui , Thanks for these changes. I have left a couple of minor comments but in general, it looks good. I want to take some time to think about how good the current tests are

[jira] [Updated] (FLINK-28003) 'pos ' field would be updated to 'POSITION' when use SqlClient

2022-06-10 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-28003: --- Description: When I run the following sql in SqlClient using 'sql-client.sh -f zj_test.sql'

[jira] (FLINK-28000) security.kerberos.login.principal can be defined wihtout keytab which is wrong configuration

2022-06-10 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28000 ] Gabor Somogyi deleted comment on FLINK-28000: --- was (Author: gaborgsomogyi): Please see the parameter description

[jira] [Created] (FLINK-28003) 'pos ' field would be updated to 'POSITION' when use SqlClient

2022-06-10 Thread Jing Zhang (Jira)
Jing Zhang created FLINK-28003: -- Summary: 'pos ' field would be updated to 'POSITION' when use SqlClient Key: FLINK-28003 URL: https://issues.apache.org/jira/browse/FLINK-28003 Project: Flink

[jira] [Updated] (FLINK-28003) 'pos ' field would be updated to 'POSITION' when use SqlClient

2022-06-10 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-28003: --- Description: When I run the following sql in SqlClient when using 'sql-client.sh -f zj_test.sql'

[jira] [Updated] (FLINK-28000) security.kerberos.login.principal can be defined wihtout keytab which is wrong configuration

2022-06-10 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-28000: -- Description: Please see the parameter description

[GitHub] [flink] alpinegizmo commented on pull request #19833: [FLINK-27778][table][planner] Use correct 'newName()' method

2022-06-10 Thread GitBox
alpinegizmo commented on PR #19833: URL: https://github.com/apache/flink/pull/19833#issuecomment-1152315518 Assuming the code generator and runtime need to agree on how the naming works, why aren't they able to somehow share an implementation of this method? -- This is an automated

[GitHub] [flink] flinkbot commented on pull request #19933: [FLINK-28000][runtime][security] Throw exception when principal is set in the configuration without keytab

2022-06-10 Thread GitBox
flinkbot commented on PR #19933: URL: https://github.com/apache/flink/pull/19933#issuecomment-1152315396 ## CI report: * 87e9d2ad0c76b8e5f356aec5d52c8d9a34f5f980 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   3   >