[jira] [Closed] (FLINK-27769) Introduce the REST endpoint framework

2022-08-01 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-27769. Fix Version/s: 1.16.0 Resolution: Done master (1.16):

[GitHub] [flink] xintongsong closed pull request #20236: [FLINK-27769][sql-gateway]Introduce the REST endpoint framework

2022-08-01 Thread GitBox
xintongsong closed pull request #20236: [FLINK-27769][sql-gateway]Introduce the REST endpoint framework URL: https://github.com/apache/flink/pull/20236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot commented on pull request #20412: sql like statement supports views

2022-08-01 Thread GitBox
flinkbot commented on PR #20412: URL: https://github.com/apache/flink/pull/20412#issuecomment-1202043798 ## CI report: * 61743eb3532257007c81ae7b55cdac75755f3970 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] godfreyhe commented on a diff in pull request #20363: [FLINK-28492][table-planner] Support "ANALYZE TABLE" execution

2022-08-01 Thread GitBox
godfreyhe commented on code in PR #20363: URL: https://github.com/apache/flink/pull/20363#discussion_r935133429 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java: ## @@ -1247,6 +1268,178 @@ private Operation

[GitHub] [flink] godfreyhe commented on a diff in pull request #20363: [FLINK-28492][table-planner] Support "ANALYZE TABLE" execution

2022-08-01 Thread GitBox
godfreyhe commented on code in PR #20363: URL: https://github.com/apache/flink/pull/20363#discussion_r935132719 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AnalyzeTableOperation.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache

[GitHub] [flink] godfreyhe commented on a diff in pull request #20363: [FLINK-28492][table-planner] Support "ANALYZE TABLE" execution

2022-08-01 Thread GitBox
godfreyhe commented on code in PR #20363: URL: https://github.com/apache/flink/pull/20363#discussion_r935132247 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AnalyzeTableOperation.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache

[GitHub] [flink] waywtdcc opened a new pull request, #20412: sql like statement supports views

2022-08-01 Thread GitBox
waywtdcc opened a new pull request, #20412: URL: https://github.com/apache/flink/pull/20412 ## What is the purpose of the change *sql like statement supports views * ## Brief change log ## Verifying this change -- This is an automated

[GitHub] [flink] fsk119 commented on pull request #20174: [FLINK-27770][sql-gateway] Introduce the script to start/stop/stop-all gateway

2022-08-01 Thread GitBox
fsk119 commented on PR #20174: URL: https://github.com/apache/flink/pull/20174#issuecomment-1202033234 @flinkbot run azure Unrelated test fails. Rerun the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] mas-chen commented on pull request #20370: [FLINK-28185][Connector/Kafka] Make TimestampOffsetsInitializer apply offset reset str…

2022-08-01 Thread GitBox
mas-chen commented on PR #20370: URL: https://github.com/apache/flink/pull/20370#issuecomment-1202030682 @PatrickRen can you help review? I can't request reviewers unfortunately :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-28589) Enhance Web UI for Speculative Execution

2022-08-01 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28589. --- Fix Version/s: 1.16.0 Resolution: Done Done via 4af75011fe32506a70076a2fe9e847cef39587bb

[GitHub] [flink] zhuzhurk closed pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution

2022-08-01 Thread GitBox
zhuzhurk closed pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution URL: https://github.com/apache/flink/pull/20380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] zhuzhurk commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution

2022-08-01 Thread GitBox
zhuzhurk commented on PR #20380: URL: https://github.com/apache/flink/pull/20380#issuecomment-1202027949 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zoltar9264 commented on pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…

2022-08-01 Thread GitBox
zoltar9264 commented on PR #20103: URL: https://github.com/apache/flink/pull/20103#issuecomment-1202025354 Kindly ping @Myasuka @rkhachatryan . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] Myracle commented on a diff in pull request #20361: [FLINK-27790][Table SQL / API] Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

2022-08-01 Thread GitBox
Myracle commented on code in PR #20361: URL: https://github.com/apache/flink/pull/20361#discussion_r935108846 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java: ## @@ -248,6 +248,7 @@ public static SessionContext

[jira] [Assigned] (FLINK-26937) Introduce Leveled compression for LSM

2022-08-01 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-26937: Assignee: xingyuan cheng > Introduce Leveled compression for LSM >

[jira] [Commented] (FLINK-26937) Introduce Leveled compression for LSM

2022-08-01 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574031#comment-17574031 ] Jingsong Lee commented on FLINK-26937: -- [~complone] Assigned to u > Introduce Leveled compression

[GitHub] [flink] godfreyhe commented on a diff in pull request #20363: [FLINK-28492][table-planner] Support "ANALYZE TABLE" execution

2022-08-01 Thread GitBox
godfreyhe commented on code in PR #20363: URL: https://github.com/apache/flink/pull/20363#discussion_r935101215 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java: ## @@ -1247,6 +1268,178 @@ private Operation

[GitHub] [flink] flinkbot commented on pull request #20411: [FLINK-28771][runtime] Assign speculative execution attempt with correct CREATED timestamp

2022-08-01 Thread GitBox
flinkbot commented on PR #20411: URL: https://github.com/apache/flink/pull/20411#issuecomment-1201997031 ## CI report: * cd64811a16a05f2ee71f1664a38a1877813d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-26542) Fix "schema of both sides of union should match" exception when one side of union select multiple same coulmns

2022-08-01 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-26542. --- Resolution: Fixed Fixed in master: 6670feaef40b022e4caf32f1db10e03b8e374d7a > Fix "schema of both sides of

[GitHub] [flink] wuchong merged pull request #19017: [FLINK-26542][hive] Hive dialect supports queries with multiple same columns in select

2022-08-01 Thread GitBox
wuchong merged PR #19017: URL: https://github.com/apache/flink/pull/19017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] godfreyhe commented on a diff in pull request #20363: [FLINK-28492][table-planner] Support "ANALYZE TABLE" execution

2022-08-01 Thread GitBox
godfreyhe commented on code in PR #20363: URL: https://github.com/apache/flink/pull/20363#discussion_r935097024 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1894,4 +1926,319 @@ public TableImpl

[GitHub] [flink] masteryhx commented on a diff in pull request #20404: [FLINK-28529][changelog] refactor ChangelogPeriodicMaterializationSwitchStateBackendITCase#testSwitchFromDisablingToEnablingInCla

2022-08-01 Thread GitBox
masteryhx commented on code in PR #20404: URL: https://github.com/apache/flink/pull/20404#discussion_r935086496 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogPeriodicMaterializationSwitchStateBackendITCase.java: ## @@ -91,39 +94,50 @@ public void

[jira] [Updated] (FLINK-28771) Assign speculative execution attempt with correct CREATED timestamp

2022-08-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28771: --- Labels: pull-request-available (was: ) > Assign speculative execution attempt with correct

[GitHub] [flink] zhuzhurk opened a new pull request, #20411: [FLINK-28771][runtime] Assign speculative execution attempt with correct CREATED timestamp

2022-08-01 Thread GitBox
zhuzhurk opened a new pull request, #20411: URL: https://github.com/apache/flink/pull/20411 ## What is the purpose of the change Currently, newly created speculative execution attempt is assigned with a wrong CREATED timestamp in SpeculativeScheduler. We need to fix it. ##

[jira] [Created] (FLINK-28771) Assign speculative execution attempt with correct CREATED timestamp

2022-08-01 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-28771: --- Summary: Assign speculative execution attempt with correct CREATED timestamp Key: FLINK-28771 URL: https://issues.apache.org/jira/browse/FLINK-28771 Project: Flink

[jira] [Commented] (FLINK-28741) Unexpected result if insert 'false' to boolean column

2022-08-01 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574026#comment-17574026 ] luoyuxia commented on FLINK-28741: -- [~jingzhang] Just another quick question. Should the empty string

[jira] [Updated] (FLINK-28701) Minimize the explosion range during failover for hybrid shuffle

2022-08-01 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-28701: - Fix Version/s: 1.16.0 > Minimize the explosion range during failover for hybrid shuffle >

[jira] [Updated] (FLINK-28769) Flink History Server show wrong name of batch jobs

2022-08-01 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-28769: - Component/s: API / DataSet (was: Runtime / Web Frontend) > Flink History

[GitHub] [flink] zhuzhurk commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution

2022-08-01 Thread GitBox
zhuzhurk commented on PR #20380: URL: https://github.com/apache/flink/pull/20380#issuecomment-1201973124 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] JasonLeeCoding commented on pull request #20327: [FLINK-28595][Connectors/kafka] KafkaSource should not read metadata of unmatched regex topics

2022-08-01 Thread GitBox
JasonLeeCoding commented on PR #20327: URL: https://github.com/apache/flink/pull/20327#issuecomment-1201968764 That makes sense. It would be friendlier. I've changed it that way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] godfreyhe commented on a diff in pull request #20365: [FLINK-26929][table-runtime] Introduce adaptive hash join for batch hash join

2022-08-01 Thread GitBox
godfreyhe commented on code in PR #20365: URL: https://github.com/apache/flink/pull/20365#discussion_r935060142 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java: ## @@ -220,6 +221,15 @@ public class

[jira] [Commented] (FLINK-22840) Assign-evenly kafkaTopicPartitions of multiple topics to flinkKafkaConsumer subtask

2022-08-01 Thread Shi Xiaolin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574018#comment-17574018 ] Shi Xiaolin commented on FLINK-22840: - Hello,What is the progress of this problem? I also

[GitHub] [flink] fredia commented on pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-08-01 Thread GitBox
fredia commented on PR #20313: URL: https://github.com/apache/flink/pull/20313#issuecomment-1201962209 Thanks a lot for updating the PR @rkhachatryan, the changes LGTM, could you please squash the commits? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-28770) CREATE TABLE AS SELECT supports explain

2022-08-01 Thread tartarus (Jira)
tartarus created FLINK-28770: Summary: CREATE TABLE AS SELECT supports explain Key: FLINK-28770 URL: https://issues.apache.org/jira/browse/FLINK-28770 Project: Flink Issue Type: Sub-task

[GitHub] [flink] yunfengzhou-hub commented on pull request #20275: [FLINK-28606][Runtime/Checkpointing] Preserve consistency of OperatorEvent from OperatorCoordinator to subtasks

2022-08-01 Thread GitBox
yunfengzhou-hub commented on PR #20275: URL: https://github.com/apache/flink/pull/20275#issuecomment-1201951778 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] LinMingQiang commented on pull request #19995: [FLINK-28060][BP 1.15][Connector/Kafka] Updated Kafka Clients to 3.1.1

2022-08-01 Thread GitBox
LinMingQiang commented on PR #19995: URL: https://github.com/apache/flink/pull/19995#issuecomment-1201950542 I'm not sure. The problem occurred after upgrading 3.1.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] fredia commented on pull request #20405: [FLINK-28010][state] Use deleteRange to optimize the clear method of RocksDBMapState.

2022-08-01 Thread GitBox
fredia commented on PR #20405: URL: https://github.com/apache/flink/pull/20405#issuecomment-1201950018 @liming30 Thanks for your PR. Would you like to share some improvements if this PR merged via [flink-benchmarks](https://github.com/apache/flink-benchmarks). -- This is an automated

[GitHub] [flink] zhuzhurk commented on a diff in pull request #20407: [FLINK-28759][e2e] Enable speculative execution for in AdaptiveBatchScheduler TPC-DS e2e tests

2022-08-01 Thread GitBox
zhuzhurk commented on code in PR #20407: URL: https://github.com/apache/flink/pull/20407#discussion_r935059049 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -397,6 +397,7 @@ function check_logs_for_errors { | grep -v "Error sending fetch request" \ |

[jira] [Closed] (FLINK-28760) Hive table store support can't be fully enabled by ADD JAR statement

2022-08-01 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28760. Assignee: Caizhi Weng Resolution: Fixed master: adcf39744c7a2c7b3ec143d1d217eaa02efa10a6

[GitHub] [flink] WencongLiu commented on a diff in pull request #20236: [FLINK-27769][sql-gateway]Introduce the REST endpoint framework

2022-08-01 Thread GitBox
WencongLiu commented on code in PR #20236: URL: https://github.com/apache/flink/pull/20236#discussion_r935056650 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -375,7 +359,7 @@ public void

[GitHub] [flink-table-store] JingsongLi merged pull request #257: [FLINK-28760] Enable table store support in Hive by creating auxlib directory

2022-08-01 Thread GitBox
JingsongLi merged PR #257: URL: https://github.com/apache/flink-table-store/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] luoyuxia commented on a diff in pull request #20394: [FLINK-28720][hive][connectors] Add Hive partition when flink has no data to write

2022-08-01 Thread GitBox
luoyuxia commented on code in PR #20394: URL: https://github.com/apache/flink/pull/20394#discussion_r935043184 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemCommitter.java: ## @@ -57,25 +57,31 @@ class

[jira] [Assigned] (FLINK-28701) Minimize the explosion range during failover for hybrid shuffle

2022-08-01 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-28701: Assignee: Weijie Guo > Minimize the explosion range during failover for hybrid shuffle >

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #135: [FLINK-28611] Add Transformer for ElementwiseProduct

2022-08-01 Thread GitBox
yunfengzhou-hub commented on code in PR #135: URL: https://github.com/apache/flink-ml/pull/135#discussion_r935044159 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/ElementwiseProductTest.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] wuchong commented on pull request #19283: [FLINK-27016][hive] Improve supporting for complex data type for Hive dialect

2022-08-01 Thread GitBox
wuchong commented on PR #19283: URL: https://github.com/apache/flink/pull/19283#issuecomment-1201932527 @luoyuxia the compile is failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Closed] (FLINK-27908) Introduce HsResultPartition and HsSubpartitionView

2022-08-01 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-27908. Fix Version/s: 1.16.0 Resolution: Done master (1.16):

[GitHub] [flink] Myracle commented on a diff in pull request #20361: [FLINK-27790][Table SQL / API] Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

2022-08-01 Thread GitBox
Myracle commented on code in PR #20361: URL: https://github.com/apache/flink/pull/20361#discussion_r935046346 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -155,6 +164,23 @@ class TableEnvironmentTest {

[GitHub] [flink] xintongsong closed pull request #20371: [FLINK-27908][network] Introduce HsResultPartition and HsSubpartitionView

2022-08-01 Thread GitBox
xintongsong closed pull request #20371: [FLINK-27908][network] Introduce HsResultPartition and HsSubpartitionView URL: https://github.com/apache/flink/pull/20371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] luoyuxia commented on pull request #19556: [FLINK-26413][hive] Hive dialect supports "LOAD DATA INPATH"

2022-08-01 Thread GitBox
luoyuxia commented on PR #19556: URL: https://github.com/apache/flink/pull/19556#issuecomment-1201923571 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] Myracle commented on a diff in pull request #20361: [FLINK-27790][Table SQL / API] Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

2022-08-01 Thread GitBox
Myracle commented on code in PR #20361: URL: https://github.com/apache/flink/pull/20361#discussion_r935041158 ## flink-end-to-end-tests/flink-end-to-end-tests-sql/src/test/java/org/apache/flink/table/sql/codegen/AddRemoteJarITCase.java: ## @@ -0,0 +1,280 @@ +/* + * Licensed to

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935037988 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicFilteringRuleTest.java: ## @@ -0,0 +1,276 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935037160 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicFilteringRule.java: ## @@ -0,0 +1,824 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935036425 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicFilteringRule.java: ## @@ -0,0 +1,824 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935036074 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicFilteringRule.java: ## @@ -0,0 +1,824 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935032679 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicFilteringRule.java: ## @@ -0,0 +1,824 @@ +/* + *

[GitHub] [flink] lincoln-lil commented on pull request #20393: [FLINK-28570][table-planner] Introduces a StreamNonDeterministicPlanResolver to validate and try to solve (lookup join only) the non-det

2022-08-01 Thread GitBox
lincoln-lil commented on PR #20393: URL: https://github.com/apache/flink/pull/20393#issuecomment-1201908318 @godfreyhe thanks for reviewing this! I'm rewriting the new scala class to java version(the progress is not as fast as expected), and will split the physical operator implementation

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935030439 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessor.java: ## @@ -222,7

[GitHub] [flink] swuferhong commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-01 Thread GitBox
swuferhong commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r935030110 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecDynamicFilteringDataCollector.java: ## @@ -0,0 +1,63

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-28606][Runtime/Checkpointing] Preserve consistency of OperatorEvent from OperatorCoordinator to subtasks

2022-08-01 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r935029768 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/CoordinatorEventsToStreamOperatorRecipientExactlyOnceITCase.java: ## @@ -0,0

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-28606][Runtime/Checkpointing] Preserve consistency of OperatorEvent from OperatorCoordinator to subtasks

2022-08-01 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r935026305 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/CoordinatorEventsToStreamOperatorRecipientExactlyOnceITCase.java: ## @@ -0,0

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20152: [FLINK-27155][changelog] Reduce multiple reads to the same Changelog …

2022-08-01 Thread GitBox
rkhachatryan commented on code in PR #20152: URL: https://github.com/apache/flink/pull/20152#discussion_r934989507 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogHandleReaderWithCache.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-28747) "target_id can not be missing" in HTTP statefun request

2022-08-01 Thread Stephan Weinwurm (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573961#comment-17573961 ] Stephan Weinwurm commented on FLINK-28747: -- I've tested this issue in the following versions

[jira] [Updated] (FLINK-28747) "target_id can not be missing" in HTTP statefun request

2022-08-01 Thread Stephan Weinwurm (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Weinwurm updated FLINK-28747: - Affects Version/s: statefun-3.0.0 > "target_id can not be missing" in HTTP statefun

[jira] [Updated] (FLINK-28747) "target_id can not be missing" in HTTP statefun request

2022-08-01 Thread Stephan Weinwurm (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Weinwurm updated FLINK-28747: - Affects Version/s: statefun-3.1.1 > "target_id can not be missing" in HTTP statefun

[jira] [Updated] (FLINK-27764) SetOperatorsITCase tests failed

2022-08-01 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-27764: --- Labels: auto-deprioritized-major test-stability (was: stale-major test-stability)

[jira] [Updated] (FLINK-27725) Create tests for TypeInformation and TypeSerializer classes in table

2022-08-01 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-27725: --- Labels: auto-deprioritized-major pull-request-available (was: pull-request-available

[jira] [Updated] (FLINK-27883) KafkaSubscriberTest failed with NPC

2022-08-01 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-27883: --- Labels: stale-major test-stability (was: test-stability) I am the [Flink Jira

[jira] [Updated] (FLINK-27941) [JUnit5 Migration] Module: flink-connector-kinesis

2022-08-01 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-27941: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-08-01 Thread GitBox
rkhachatryan commented on code in PR #20313: URL: https://github.com/apache/flink/pull/20313#discussion_r934753700 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -192,6 +211,13 @@ public void registerAll( @Override

[GitHub] [flink] rkhachatryan commented on pull request #20091: [FLINK-27570][runtime] Fix checkFailureCounter in CheckpointFailureManager for finalize failure

2022-08-01 Thread GitBox
rkhachatryan commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-120147 How about using an approach similar to

[GitHub] [flink] fredia commented on a diff in pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-08-01 Thread GitBox
fredia commented on code in PR #20313: URL: https://github.com/apache/flink/pull/20313#discussion_r934714748 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -342,6 +342,10 @@ private void advanceLastUsingCheckpointID(long

[jira] [Created] (FLINK-28769) Flink History Server show wrong name of batch jobs

2022-08-01 Thread Biao Geng (Jira)
Biao Geng created FLINK-28769: - Summary: Flink History Server show wrong name of batch jobs Key: FLINK-28769 URL: https://issues.apache.org/jira/browse/FLINK-28769 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot commented on pull request #20410: [FLINK-28768][tests][testinfrastructure] Update junit to 5.9.0

2022-08-01 Thread GitBox
flinkbot commented on PR #20410: URL: https://github.com/apache/flink/pull/20410#issuecomment-1201458400 ## CI report: * 767af9c2d62cc852ca426ecdb79c9349e89dce8f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-28643) Job archive file contains too much Job json file on Flink HistoryServer

2022-08-01 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573852#comment-17573852 ] Biao Geng commented on FLINK-28643: --- I run into this issue as well when running jobs with large

[jira] [Updated] (FLINK-28768) Update JUnit5 to v5.9.0

2022-08-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28768: --- Labels: pull-request-available (was: ) > Update JUnit5 to v5.9.0 > ---

[GitHub] [flink] snuyanzin opened a new pull request, #20410: [FLINK-28768][tests][testinfrastructure] Update junit to 5.9.0

2022-08-01 Thread GitBox
snuyanzin opened a new pull request, #20410: URL: https://github.com/apache/flink/pull/20410 ## What is the purpose of the change * Update JUnit5 dependency to the latest available version (5.9.0) * Remove `private` modifiers from methods annotated with `BeforeAll`,

[jira] [Updated] (FLINK-28758) Failed to stop with savepoint

2022-08-01 Thread hjw (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hjw updated FLINK-28758: Component/s: Runtime / Checkpointing Runtime / Task > Failed to stop with savepoint >

[jira] [Created] (FLINK-28768) Update JUnit5 to v5.9.0

2022-08-01 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-28768: --- Summary: Update JUnit5 to v5.9.0 Key: FLINK-28768 URL: https://issues.apache.org/jira/browse/FLINK-28768 Project: Flink Issue Type: Technical Debt

[GitHub] [flink] reswqa commented on pull request #20371: [FLINK-27908][network] Introduce HsResultPartition and HsSubpartitionView

2022-08-01 Thread GitBox
reswqa commented on PR #20371: URL: https://github.com/apache/flink/pull/20371#issuecomment-1201417067 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-26721) PulsarSourceITCase.testSavepoint failed on azure pipeline

2022-08-01 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573838#comment-17573838 ] Weijie Guo commented on FLINK-26721:

[jira] [Commented] (FLINK-26822) Add Source implementation for Cassandra connector

2022-08-01 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573828#comment-17573828 ] Etienne Chauchot commented on FLINK-26822: -- Hi [~oogetyboogety]. Thanks for your comment and

[jira] [Commented] (FLINK-28719) Mapping a data source before window aggregation causes Flink to stop handle late events correctly.

2022-08-01 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573809#comment-17573809 ] Chesnay Schepler commented on FLINK-28719: -- So let's dive into what is happening. The source

[GitHub] [flink] lindong28 commented on a diff in pull request #20275: [FLINK-28606][Runtime/Checkpointing] Preserve consistency of OperatorEvent from OperatorCoordinator to subtasks

2022-08-01 Thread GitBox
lindong28 commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r934612070 ## flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/CoordinatorEventsExactlyOnceITCase.java: ## @@ -111,30 +108,21 @@ * 2. Exactly-once

[jira] [Commented] (FLINK-28719) Mapping a data source before window aggregation causes Flink to stop handle late events correctly.

2022-08-01 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573804#comment-17573804 ] Chesnay Schepler commented on FLINK-28719: -- Your test only works when the elements arrive at

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

2022-08-01 Thread GitBox
bzhaoopenstack commented on PR #20193: URL: https://github.com/apache/flink/pull/20193#issuecomment-1201305262 > @bzhaoopenstack I won't be able to review this at the moment, but keep in mind that the CI is still failing for this PR. It makes sense to make sure that the CI works before the

[GitHub] [flink] flinkbot commented on pull request #20409: [FLINK-25252][Connector/Kafka] Re-enabling Kafka tests for Java 11

2022-08-01 Thread GitBox
flinkbot commented on PR #20409: URL: https://github.com/apache/flink/pull/20409#issuecomment-1201272384 ## CI report: * a44a1dff608829c4f79b79a8a253ee64b1c2658c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] trushev commented on pull request #17326: [FLINK-24342] Add right bracket to filesystem partitioner escape list

2022-08-01 Thread GitBox
trushev commented on PR #17326: URL: https://github.com/apache/flink/pull/17326#issuecomment-1201264644 Thank you, @MartijnVisser It's rebased and `[table]` is appended -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-25252) Check whether Kafka E2E tests could be run on Java 11

2022-08-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25252: --- Labels: pull-request-available (was: ) > Check whether Kafka E2E tests could be run on

[GitHub] [flink] MartijnVisser opened a new pull request, #20409: [FLINK-25252][Connector/Kafka] Re-enabling Kafka tests for Java 11

2022-08-01 Thread GitBox
MartijnVisser opened a new pull request, #20409: URL: https://github.com/apache/flink/pull/20409 ## What is the purpose of the change * Re-enable Kafka tests for Java 11 ## Brief change log * Removed code that disables tests for Java 11 ## Verifying this change

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19972: [FLINK-27399][Connector/Pulsar] Change initial consuming position setting logic for better handle the checkpoint.

2022-08-01 Thread GitBox
MartijnVisser commented on code in PR #19972: URL: https://github.com/apache/flink/pull/19972#discussion_r934562396 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarSourceITCase.java: ## @@ -33,8 +33,10 @@ import

[jira] [Closed] (FLINK-28495) Fix typos or mistakes of Flink CEP Document in the official website

2022-08-01 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-28495. -- Fix Version/s: 1.16.0 Resolution: Fixed Fixed in master:

[GitHub] [flink] MartijnVisser merged pull request #20272: [FLINK-28495][docs][docs-zh] Fix typos or mistakes of Flink CEP Document

2022-08-01 Thread GitBox
MartijnVisser merged PR #20272: URL: https://github.com/apache/flink/pull/20272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] MartijnVisser commented on pull request #20273: [hotfix][annotation] Refine java doc for annotation VisibleForTesting

2022-08-01 Thread GitBox
MartijnVisser commented on PR #20273: URL: https://github.com/apache/flink/pull/20273#issuecomment-1201234208 @luoyuxia To be honest, I see very little value in this since it's a small but obvious grammar error. To just get this merged, will consume the CI for quite some time, which I

[GitHub] [flink] MartijnVisser commented on pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

2022-08-01 Thread GitBox
MartijnVisser commented on PR #17873: URL: https://github.com/apache/flink/pull/17873#issuecomment-1201232277 No feedback from my end anymore :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-08-01 Thread GitBox
rkhachatryan commented on code in PR #20313: URL: https://github.com/apache/flink/pull/20313#discussion_r934552771 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -365,4 +401,19 @@ public String toString() { return

[jira] [Commented] (FLINK-25421) Port JDBC Sink to new Unified Sink API (FLIP-143)

2022-08-01 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573770#comment-17573770 ] Martijn Visser commented on FLINK-25421: [~eskabetxe] We'll need to finish the discussion on the

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-08-01 Thread GitBox
rkhachatryan commented on code in PR #20313: URL: https://github.com/apache/flink/pull/20313#discussion_r934545515 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/SharedStateRegistryTest.java: ## @@ -182,20 +194,113 @@ public void

[jira] [Resolved] (FLINK-24783) Improve monitoring experience and usability of state backend

2022-08-01 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-24783. -- Resolution: Fixed > Improve monitoring experience and usability of state backend >

[GitHub] [flink] MartijnVisser commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

2022-08-01 Thread GitBox
MartijnVisser commented on PR #20193: URL: https://github.com/apache/flink/pull/20193#issuecomment-1201211346 @bzhaoopenstack I won't be able to review this at the moment, but keep in mind that the CI is still failing for this PR. It makes sense to make sure that the CI works before the

[jira] [Closed] (FLINK-27916) HybridSourceReaderTest.testReader failed with AssertionError

2022-08-01 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-27916. -- Resolution: Cannot Reproduce > HybridSourceReaderTest.testReader failed with AssertionError >

  1   2   3   >