[jira] [Updated] (FLINK-29098) StoreWriteOperator#prepareCommit should let logSinkFunction flush first before fetching offset

2022-09-23 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-29098: - Fix Version/s: table-store-0.2.1 > StoreWriteOperator#prepareCommit should let logSinkFunction

[jira] [Comment Edited] (FLINK-29098) StoreWriteOperator#prepareCommit should let logSinkFunction flush first before fetching offset

2022-09-23 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17596979#comment-17596979 ] Jingsong Lee edited comment on FLINK-29098 at 9/24/22 2:38 AM: --- master:

[GitHub] [flink] SteNicholas commented on a diff in pull request #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
SteNicholas commented on code in PR #20893: URL: https://github.com/apache/flink/pull/20893#discussion_r979133150 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java: ## @@ -40,4 +40,13 @@ public boolean filter(T value,

[GitHub] [flink] SteNicholas commented on a diff in pull request #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
SteNicholas commented on code in PR #20893: URL: https://github.com/apache/flink/pull/20893#discussion_r979133150 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java: ## @@ -40,4 +40,13 @@ public boolean filter(T value,

[GitHub] [flink] SteNicholas commented on a diff in pull request #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
SteNicholas commented on code in PR #20893: URL: https://github.com/apache/flink/pull/20893#discussion_r979133150 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java: ## @@ -40,4 +40,13 @@ public boolean filter(T value,

[GitHub] [flink] SteNicholas commented on a diff in pull request #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
SteNicholas commented on code in PR #20893: URL: https://github.com/apache/flink/pull/20893#discussion_r979133150 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java: ## @@ -40,4 +40,13 @@ public boolean filter(T value,

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979107588 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -878,7 +879,8 @@ public CompletableFuture triggerSavepoint( }

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979107588 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -878,7 +879,8 @@ public CompletableFuture triggerSavepoint( }

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979072658 ## flink-core/src/main/java/org/apache/flink/core/execution/CheckpointBackupType.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] pnowojski commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
pnowojski commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979065292 ## flink-core/src/main/java/org/apache/flink/core/execution/CheckpointBackupType.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979055803 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -878,7 +879,8 @@ public CompletableFuture triggerSavepoint( }

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979042504 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/CheckpointTriggerHandlers.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979038031 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherCachedOperationsHandler.java: ## @@ -39,30 +40,66 @@ public class

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979033459 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -853,6 +855,12 @@ public CompletableFuture requestJob(Time timeout) {

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979032943 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -863,11 +871,6 @@ public CompletableFuture triggerSavepoint( return

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979031935 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherCachedOperationsHandler.java: ## @@ -39,30 +40,66 @@ public class

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r979025202 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java: ## @@ -511,6 +514,45 @@ public CompletableFuture

[GitHub] [flink] flinkbot commented on pull request #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
flinkbot commented on PR #20893: URL: https://github.com/apache/flink/pull/20893#issuecomment-1256555052 ## CI report: * 2c7d41b3202605d407993c12fec8aa85e8aa22ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zentol commented on a diff in pull request #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
zentol commented on code in PR #20893: URL: https://github.com/apache/flink/pull/20893#discussion_r978975202 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java: ## @@ -40,4 +40,13 @@ public boolean filter(T value,

[jira] [Updated] (FLINK-29403) Streamline SimpleCondition usage

2022-09-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29403: --- Labels: pull-request-available (was: ) > Streamline SimpleCondition usage >

[GitHub] [flink] zentol opened a new pull request, #20893: [FLINK-29403][cep] Streamline SimpleCondition usage

2022-09-23 Thread GitBox
zentol opened a new pull request, #20893: URL: https://github.com/apache/flink/pull/20893 Add `SimpleCondition.of(FilterFunction)` and adjust all tests and docs accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-26999) Introduce ClickHouse Connector

2022-09-23 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608885#comment-17608885 ] Robert Metzger commented on FLINK-26999: Is the idea for this ticket to use an existing

[jira] [Updated] (FLINK-29403) Streamline SimpleCondition usage

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29403: - Description: CEP SimpleCondition are essentially filter functions, but since it's an

[jira] [Created] (FLINK-29403) Streamline SimpleCondition usage

2022-09-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-29403: Summary: Streamline SimpleCondition usage Key: FLINK-29403 URL: https://issues.apache.org/jira/browse/FLINK-29403 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608729#comment-17608729 ] Chesnay Schepler edited comment on FLINK-29315 at 9/23/22 6:41 PM: ---

[GitHub] [flink] ericxiao251 commented on pull request #19983: [FLINK-27878][datastream] Add Retry Support For Async I/O In DataStream API

2022-09-23 Thread GitBox
ericxiao251 commented on PR #19983: URL: https://github.com/apache/flink/pull/19983#issuecomment-1256536753 Hi @lincoln-lil, how would one use the retry strategies in their scala flink pipelines? we noticed that the retry strategy builder classes were only exposed in the java codebase.

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r978880123 ## flink-core/src/main/java/org/apache/flink/core/execution/CheckpointBackupType.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] stevenzwu commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-23 Thread GitBox
stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r978880123 ## flink-core/src/main/java/org/apache/flink/core/execution/CheckpointBackupType.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-connector-opensearch] reta opened a new pull request, #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-09-23 Thread GitBox
reta opened a new pull request, #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1 Signed-off-by: Andriy Redko ## What is the purpose of the change The goal of this change is to provide dedicated Opensearch connectors. ## Brief change log

[jira] [Comment Edited] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608729#comment-17608729 ] Chesnay Schepler edited comment on FLINK-29315 at 9/23/22 4:40 PM: ---

[jira] [Commented] (FLINK-29396) Race condition in JobMaster shutdown can leak resource requirements

2022-09-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608814#comment-17608814 ] Matthias Pohl commented on FLINK-29396: --- I guess, you have a point here. Initially, I thought that

[jira] [Closed] (FLINK-29276) Flush all memory in SortBufferMemTable.clear

2022-09-23 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29276. Fix Version/s: table-store-0.2.1 Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #300: [FLINK-29276] BinaryInMemorySortBuffer supports to clear all memory segments

2022-09-23 Thread GitBox
JingsongLi merged PR #300: URL: https://github.com/apache/flink-table-store/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi commented on pull request #300: [FLINK-29276] BinaryInMemorySortBuffer supports to clear all memory segments

2022-09-23 Thread GitBox
JingsongLi commented on PR #300: URL: https://github.com/apache/flink-table-store/pull/300#issuecomment-1256357112 > To @JingsongLi I have tried to decrease memory buffers in WritePreemptMemoryTest. createFileStoreTable. Unfortunately, it causes java.lang.RuntimeException: File deletion

[GitHub] [flink] dannycranmer merged pull request #20876: [hotfix][docs] Fix typos in Kinesis Connector docs.

2022-09-23 Thread GitBox
dannycranmer merged PR #20876: URL: https://github.com/apache/flink/pull/20876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-29309) Relax allow-client-job-configurations for Table API and parameters

2022-09-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-29309. Fix Version/s: 1.16.0 Resolution: Fixed Fixed in master:

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978763440 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/join/JoinTest.xml: ## @@ -72,17 +72,17 @@

[GitHub] [flink] flinkbot commented on pull request #20892: [BP-1.16][FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-23 Thread GitBox
flinkbot commented on PR #20892: URL: https://github.com/apache/flink/pull/20892#issuecomment-1256318703 ## CI report: * 01500feb824aee4a12ffbadc00540eee5e6e5c5b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978758053 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/table/SetOperatorsTest.xml: ## @@ -99,13 +99,13 @@

[GitHub] [flink] PatrickRen opened a new pull request, #20892: [BP-1.16][FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-23 Thread GitBox
PatrickRen opened a new pull request, #20892: URL: https://github.com/apache/flink/pull/20892 Unchanged backport of #20884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] PatrickRen merged pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-23 Thread GitBox
PatrickRen merged PR #20884: URL: https://github.com/apache/flink/pull/20884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-28890) Incorrect semantic of latestLoadTime in CachingLookupFunction and CachingAsyncLookupFunction

2022-09-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-28890. - Resolution: Fixed > Incorrect semantic of latestLoadTime in CachingLookupFunction and >

[jira] [Comment Edited] (FLINK-28890) Incorrect semantic of latestLoadTime in CachingLookupFunction and CachingAsyncLookupFunction

2022-09-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608559#comment-17608559 ] Qingsheng Ren edited comment on FLINK-28890 at 9/23/22 2:35 PM: Fixed on

[GitHub] [flink] PatrickRen merged pull request #20889: [BP-1.16][FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function

2022-09-23 Thread GitBox
PatrickRen merged PR #20889: URL: https://github.com/apache/flink/pull/20889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] PatrickRen commented on pull request #20889: [BP-1.16][FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function

2022-09-23 Thread GitBox
PatrickRen commented on PR #20889: URL: https://github.com/apache/flink/pull/20889#issuecomment-1256296543 The CI failed because of an unrelated issue FLINK-29315. Merging to release-1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-29093) LookupJoinITCase failed with InternalCompilerException

2022-09-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608780#comment-17608780 ] Qingsheng Ren commented on FLINK-29093: --- Fixed on master: 340b100f2de5e0d90ba475aa8a00e359a61442ce 

[jira] [Assigned] (FLINK-29093) LookupJoinITCase failed with InternalCompilerException

2022-09-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-29093: - Assignee: Alexander Smirnov (was: Qingsheng Ren) > LookupJoinITCase failed with

[jira] [Closed] (FLINK-29093) LookupJoinITCase failed with InternalCompilerException

2022-09-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-29093. - Resolution: Fixed > LookupJoinITCase failed with InternalCompilerException >

[GitHub] [flink] PatrickRen merged pull request #20890: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCas…

2022-09-23 Thread GitBox
PatrickRen merged PR #20890: URL: https://github.com/apache/flink/pull/20890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] PatrickRen commented on pull request #20890: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCas…

2022-09-23 Thread GitBox
PatrickRen commented on PR #20890: URL: https://github.com/apache/flink/pull/20890#issuecomment-1256289693 The CI failed because of an unrelated issue FLINK-29315. Merging to release-1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] PatrickRen merged pull request #20734: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCase + reset resource counter before each test

2022-09-23 Thread GitBox
PatrickRen merged PR #20734: URL: https://github.com/apache/flink/pull/20734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] PatrickRen commented on pull request #20734: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCase + reset resource counter before each test

2022-09-23 Thread GitBox
PatrickRen commented on PR #20734: URL: https://github.com/apache/flink/pull/20734#issuecomment-1256286903 The CI failed because of an unrelated issue FLINK-29315. Merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-29391) Add option to set labels and annotations in kubernetes deployment

2022-09-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29391. -- Resolution: Not A Problem > Add option to set labels and annotations in kubernetes deployment >

[jira] [Commented] (FLINK-29391) Add option to set labels and annotations in kubernetes deployment

2022-09-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608778#comment-17608778 ] Gyula Fora commented on FLINK-29391: you can use the following built in Flink configs:

[jira] [Updated] (FLINK-29392) SessionJobs are lost when Session FlinkDeployment is upgraded without HA

2022-09-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29392: --- Fix Version/s: kubernetes-operator-1.2.0 > SessionJobs are lost when Session FlinkDeployment is

[jira] [Closed] (FLINK-29388) Fix args in JobSpec not being passed through to Flink in Standalone mode

2022-09-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29388. -- Resolution: Fixed merged to main e2b829c7df7501760dec8f9aa47685c680b227cf > Fix args in JobSpec not

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #379: [FLINK-29388] Fix to use JobSpec arguments in Standalone Application Mode

2022-09-23 Thread GitBox
gyfora merged PR #379: URL: https://github.com/apache/flink-kubernetes-operator/pull/379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-29402) Add USE_DIRECT_READ configuration parameter for RocksDB

2022-09-23 Thread Donatien (Jira)
Donatien created FLINK-29402: Summary: Add USE_DIRECT_READ configuration parameter for RocksDB Key: FLINK-29402 URL: https://issues.apache.org/jira/browse/FLINK-29402 Project: Flink Issue Type:

[jira] [Closed] (FLINK-27893) Add additionalPrinterColumns for Job Status and Reconciliation Status in CRDs

2022-09-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-27893. -- Resolution: Duplicate duplicate of FLINK-29383 > Add additionalPrinterColumns for Job Status and

[jira] [Commented] (FLINK-27893) Add additionalPrinterColumns for Job Status and Reconciliation Status in CRDs

2022-09-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608751#comment-17608751 ] Gyula Fora commented on FLINK-27893: Ah I did not realize that this was a duplicate. Closing > Add

[jira] [Commented] (FLINK-27893) Add additionalPrinterColumns for Job Status and Reconciliation Status in CRDs

2022-09-23 Thread Jeesmon Jacob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608750#comment-17608750 ] Jeesmon Jacob commented on FLINK-27893: --- [~gyfora] Can we mark this as closed based on

[jira] [Closed] (FLINK-29230) Publish blogpost about the Akka license change

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29230. Resolution: Fixed > Publish blogpost about the Akka license change >

[jira] [Updated] (FLINK-29254) RpcGateway should have some form of Close() method

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29254: - Parent: FLINK-29281 Issue Type: Sub-task (was: Technical Debt) > RpcGateway

[jira] [Reopened] (FLINK-29254) RpcGateway should have some form of Close() method

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-29254: -- Turns out this isn't actually that difficult. > RpcGateway should have some form of

[jira] [Commented] (FLINK-6573) Flink MongoDB Connector

2022-09-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608738#comment-17608738 ] Jiabao Sun commented on FLINK-6573: --- Hi there, The discussion thread was opened on

[GitHub] [flink] twalthr closed pull request #20840: [FLINK-29309][streaming-java] Relax allow-client-job-configurations for Table API and parameters

2022-09-23 Thread GitBox
twalthr closed pull request #20840: [FLINK-29309][streaming-java] Relax allow-client-job-configurations for Table API and parameters URL: https://github.com/apache/flink/pull/20840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Comment Edited] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608729#comment-17608729 ] Chesnay Schepler edited comment on FLINK-29315 at 9/23/22 1:13 PM: ---

[jira] [Comment Edited] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608729#comment-17608729 ] Chesnay Schepler edited comment on FLINK-29315 at 9/23/22 1:09 PM: ---

[GitHub] [flink] afedulov commented on a diff in pull request #20876: [hotfix][docs] Fix typos in Kinesis Connector docs.

2022-09-23 Thread GitBox
afedulov commented on code in PR #20876: URL: https://github.com/apache/flink/pull/20876#discussion_r978609413 ## docs/content.zh/docs/connectors/table/kinesis.md: ## @@ -776,7 +776,7 @@ You can enable and configure EFO with the following properties: This is the preferred

[GitHub] [flink] zentol commented on a diff in pull request #20867: [FLINK-29372] Add suffix to all options that conflict with YAML

2022-09-23 Thread GitBox
zentol commented on code in PR #20867: URL: https://github.com/apache/flink/pull/20867#discussion_r978603305 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java: ## @@ -269,9 +269,10 @@ public class KubernetesConfigOptions {

[GitHub] [flink] zentol commented on pull request #20867: [FLINK-29372] Add suffix to all options that conflict with YAML

2022-09-23 Thread GitBox
zentol commented on PR #20867: URL: https://github.com/apache/flink/pull/20867#issuecomment-1256170114 Added a test, which found a few more violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608729#comment-17608729 ] Chesnay Schepler commented on FLINK-29315: -- Experiment results: - test fails when using a

[jira] [Created] (FLINK-29401) Improve observer structure

2022-09-23 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-29401: -- Summary: Improve observer structure Key: FLINK-29401 URL: https://issues.apache.org/jira/browse/FLINK-29401 Project: Flink Issue Type: Improvement

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978592824 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/table/JoinTest.xml: ## @@ -84,15 +84,15 @@ Calc(select=[a, b, d, e])

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978592501 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/table/JoinTest.xml: ## @@ -84,15 +84,15 @@ Calc(select=[a, b, d, e])

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978587582 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/CalcTest.xml: ## @@ -344,13 +344,13 @@ Calc(select=[a, (b + 1) AS

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978587112 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/CalcTest.xml: ## @@ -262,7 +262,7 @@ LogicalProject(a=[$0],

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978583509 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/CalcTest.xml: ## @@ -361,13 +361,13 @@ Calc(select=[a, (b + 1) AS

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978583021 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/CalcTest.xml: ## @@ -279,7 +279,7 @@ LogicalProject(a=[$0],

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #300: [FLINK-29276] BinaryInMemorySortBuffer supports to clear all memory segments

2022-09-23 Thread GitBox
SteNicholas commented on code in PR #300: URL: https://github.com/apache/flink-table-store/pull/300#discussion_r978544844 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/memory/sort/BinaryInMemorySortBuffer.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #300: [FLINK-29276] BinaryInMemorySortBuffer supports to clear all memory segments

2022-09-23 Thread GitBox
SteNicholas commented on code in PR #300: URL: https://github.com/apache/flink-table-store/pull/300#discussion_r978544844 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/memory/sort/BinaryInMemorySortBuffer.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed

[GitHub] [flink-kubernetes-operator] avocadomaster commented on pull request #379: [FLINK-29388] Fix to use JobSpec arguments in Standalone Application Mode

2022-09-23 Thread GitBox
avocadomaster commented on PR #379: URL: https://github.com/apache/flink-kubernetes-operator/pull/379#issuecomment-1256084073 > Please rebase before we can merge this Rebased ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (FLINK-29398) Utilize Rack Awareness in Flink Consumer

2022-09-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608699#comment-17608699 ] Qingsheng Ren commented on FLINK-29398: --- Thanks for starting the discussion [~jeremy.degroot] !

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #379: [FLINK-29388] Fix to use JobSpec arguments in Standalone Application Mode

2022-09-23 Thread GitBox
gyfora commented on PR #379: URL: https://github.com/apache/flink-kubernetes-operator/pull/379#issuecomment-1256070218 Please rebase before we can merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978511255 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -1950,6 +1950,38 @@ void

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978511413 ## flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java: ## @@ -560,4 +560,36 @@ void testExplainUpsert()

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978511413 ## flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java: ## @@ -560,4 +560,36 @@ void testExplainUpsert()

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-09-23 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r978511255 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -1950,6 +1950,38 @@ void

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-09-23 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r978481060 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -74,38 +74,65 @@ public Table[] transform(Table... inputs) {

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-09-23 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r978475159 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java: ## @@ -21,11 +21,31 @@ import

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-09-23 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r978475159 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java: ## @@ -21,11 +21,31 @@ import

[GitHub] [flink] Tartarus0zm commented on pull request #20653: [FLINK-29020][docs] add document for CTAS feature

2022-09-23 Thread GitBox
Tartarus0zm commented on PR #20653: URL: https://github.com/apache/flink/pull/20653#issuecomment-1256004961 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-29375) Move getSelfGateway into RpcService

2022-09-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29375. Resolution: Fixed master: 0154de9edb44b565e9b9cba614f42e7adae3a953 > Move getSelfGateway

[GitHub] [flink] zentol merged pull request #20870: [FLINK-29375][rpc] Move getSelfGateway() into RpcService

2022-09-23 Thread GitBox
zentol merged PR #20870: URL: https://github.com/apache/flink/pull/20870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] lsyldliu commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-23 Thread GitBox
lsyldliu commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978427558 ## docs/content.zh/docs/connectors/table/jdbc.md: ## @@ -263,6 +279,47 @@ ON myTopic.key = MyUserTable.id; +### 已弃用的配置

[jira] [Updated] (FLINK-24296) [Umbrella] Refactor Google PubSub to new Source/Sink interfaces

2022-09-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-24296: --- Summary: [Umbrella] Refactor Google PubSub to new Source/Sink interfaces (was: Refactor

[jira] [Updated] (FLINK-24296) [Umbrella] Refactor Google PubSub to new Source/Sink interfaces

2022-09-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-24296: --- Component/s: Connectors / Google Cloud PubSub > [Umbrella] Refactor Google PubSub to new

[jira] [Comment Edited] (FLINK-29281) Replace Akka

2022-09-23 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607600#comment-17607600 ] Claude Warren edited comment on FLINK-29281 at 9/23/22 9:07 AM: I am

[GitHub] [flink] dannycranmer commented on a diff in pull request #20876: [hotfix][docs] Fix typos in Kinesis Connector docs.

2022-09-23 Thread GitBox
dannycranmer commented on code in PR #20876: URL: https://github.com/apache/flink/pull/20876#discussion_r978417586 ## docs/content.zh/docs/connectors/table/kinesis.md: ## @@ -776,7 +776,7 @@ You can enable and configure EFO with the following properties: This is the

[GitHub] [flink] afedulov commented on pull request #20865: [FLINK-14896][connectors/kinesis] Shade and relocate Jackson dependen…

2022-09-23 Thread GitBox
afedulov commented on PR #20865: URL: https://github.com/apache/flink/pull/20865#issuecomment-1255953839 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   >