[jira] [Assigned] (FLINK-29492) Kafka exactly-once sink causes OutOfMemoryError

2022-10-11 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-29492: - Assignee: Hang Ruan > Kafka exactly-once sink causes OutOfMemoryError >

[jira] [Commented] (FLINK-3033) Redis Source Connector

2022-10-11 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616199#comment-17616199 ] waywtdcc commented on FLINK-3033: - [~pramod] Hello, where is the Redis connector you wrote? Recently, we

[jira] [Commented] (FLINK-28229) Introduce Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2022-10-11 Thread Tigran Manasyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616198#comment-17616198 ] Tigran Manasyan commented on FLINK-28229: - Hello, [~martijnvisser] ! I have implemented FLIP-27

[jira] [Comment Edited] (FLINK-28049) Introduce FLIP-208 functionality to stop Source based on consumed records

2022-10-11 Thread Sergey Troshkov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616187#comment-17616187 ] Sergey Troshkov edited comment on FLINK-28049 at 10/12/22 5:13 AM: ---

[jira] [Commented] (FLINK-28049) Introduce FLIP-208 functionality to stop Source based on consumed records

2022-10-11 Thread Sergey Troshkov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616187#comment-17616187 ] Sergey Troshkov commented on FLINK-28049: - Thank you! > Introduce FLIP-208 functionality to

[GitHub] [flink] hehuiyuan commented on pull request #21011: [FLINK-29333][TABLE]Support the tableconfig object get configuration infos from flink-conf.yaml file

2022-10-11 Thread GitBox
hehuiyuan commented on PR #21011: URL: https://github.com/apache/flink/pull/21011#issuecomment-1275590651 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-25409) Add cache metric to LookupFunction

2022-10-11 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-25409. - Resolution: Fixed > Add cache metric to LookupFunction > -- > >

[GitHub] [flink-table-store] JingsongLi commented on pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader

2022-10-11 Thread GitBox
JingsongLi commented on PR #313: URL: https://github.com/apache/flink-table-store/pull/313#issuecomment-1275570471 Hi @zjureel can you do some benchmark to verify the improvement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-table-store] JingsongLi commented on pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader

2022-10-11 Thread GitBox
JingsongLi commented on PR #313: URL: https://github.com/apache/flink-table-store/pull/313#issuecomment-1275570123 CC: @tsreaper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-table-store] JingsongLi commented on pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-11 Thread GitBox
JingsongLi commented on PR #305: URL: https://github.com/apache/flink-table-store/pull/305#issuecomment-1275569659 Thanks for the update, just left one minor comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (FLINK-28618) Cannot use hive.dialect on master

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-28618. -- Resolution: Fixed Close it since I haven't reproduced this problem using  master branch. Feel free

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-11 Thread GitBox
JingsongLi commented on code in PR #305: URL: https://github.com/apache/flink-table-store/pull/305#discussion_r992981418 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/WriteFunction.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] [flink] flinkbot commented on pull request #21026: [FLINK-29590][hive] fix literal issue in Hive dialect

2022-10-11 Thread GitBox
flinkbot commented on PR #21026: URL: https://github.com/apache/flink/pull/21026#issuecomment-1275560087 ## CI report: * b35021c3135509cbcb1a33f30180ffc2626f19b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29590: --- Labels: pull-request-available (was: ) > Fix literal issue in HiveDialect >

[GitHub] [flink] luoyuxia opened a new pull request, #21026: [FLINK-29590][hive] fix literal issue in Hive dialect

2022-10-11 Thread GitBox
luoyuxia opened a new pull request, #21026: URL: https://github.com/apache/flink/pull/21026 ## What is the purpose of the change To fix the thrown excpetion with literal in Hive dialect. 1: some folded constant like `Double.NAN` and no-primitive type  can't be convert into

[jira] [Commented] (FLINK-29492) Kafka exactly-once sink causes OutOfMemoryError

2022-10-11 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616169#comment-17616169 ] Hang Ruan commented on FLINK-29492: --- I am interested in this bug. Maybe I could help to take a look at

[GitHub] [flink] zoltar9264 commented on pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-11 Thread GitBox
zoltar9264 commented on PR #20965: URL: https://github.com/apache/flink/pull/20965#issuecomment-1275551163 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

2022-10-11 Thread GitBox
zoltar9264 commented on PR #20975: URL: https://github.com/apache/flink/pull/20975#issuecomment-1275550883 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-28786) Cannot run PyFlink 1.16 on MacOS with M1 chip

2022-10-11 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616165#comment-17616165 ] Ran Tao commented on FLINK-28786: - [~grimsby] Yes, you are right. when i change to conda, it works well.

[GitHub] [flink] luoyuxia commented on pull request #20855: [FLINK-29337][hive] Fix fail to query non-hive table in Hive dialect

2022-10-11 Thread GitBox
luoyuxia commented on PR #20855: URL: https://github.com/apache/flink/pull/20855#issuecomment-1275532530 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2022-10-11 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616152#comment-17616152 ] Xingbo Huang commented on FLINK-25343: --

[GitHub] [flink] HuangXingBo commented on pull request #20920: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-10-11 Thread GitBox
HuangXingBo commented on PR #20920: URL: https://github.com/apache/flink/pull/20920#issuecomment-1275520470 cc @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2022-10-11 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616151#comment-17616151 ] Xingbo Huang commented on FLINK-29405: --

[GitHub] [flink] HuangXingBo commented on pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-10-11 Thread GitBox
HuangXingBo commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1275520363 cc @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992921852 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -47,10 +47,15 @@ /** * A Transformer which combines a given

[GitHub] [flink-table-store] JingsongLi commented on pull request #314: [FLINK-28128] Add e2e test for spark reader

2022-10-11 Thread GitBox
JingsongLi commented on PR #314: URL: https://github.com/apache/flink-table-store/pull/314#issuecomment-1275519030 Thanks @zjureel , I just left one minor comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #314: [FLINK-28128] Add e2e test for spark reader

2022-10-11 Thread GitBox
JingsongLi commented on code in PR #314: URL: https://github.com/apache/flink-table-store/pull/314#discussion_r992939690 ## flink-table-store-e2e-tests/src/test/java/org/apache/flink/table/store/tests/SparkE2eTest.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Description: in FLINK-26474, we try to fold constant, but it brings a issue that the folded constant

[jira] [Commented] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-10-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616142#comment-17616142 ] Xintong Song commented on FLINK-29572: -- After looking into this a bit more, I think this might not

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992921852 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -47,10 +47,15 @@ /** * A Transformer which combines a given

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Description: in FLINK-26474, we try to fold constant, but it may bring a issue that the folded

[GitHub] [flink] libenchao commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-11 Thread GitBox
libenchao commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1275500147 @qingwei91 Thanks for the updating, I'll review this PR in a few days. > I didn't implement additional operators like IN and BETWEEN because I am quite busy of late. Given they

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992921852 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -47,10 +47,15 @@ /** * A Transformer which combines a given

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616135#comment-17616135 ] Aitozi commented on FLINK-29557: Anyone can help confirm this issue ? > The SinkOperator's

[jira] [Updated] (FLINK-29590) Fix literal issue for HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Summary: Fix literal issue for HiveDialect (was: Fix constant fold issue for HiveDialect) > Fix

[jira] [Updated] (FLINK-29590) Fix constant fold issue for HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Description: in FLINK-26474, we try to fold constant, but it may bring a issue that the folded constant

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Summary: Fix literal issue in HiveDialect (was: Fix literal issue for HiveDialect) > Fix literal

[jira] [Created] (FLINK-29590) Fix constant fold issue for HiveDialect

2022-10-11 Thread luoyuxia (Jira)
luoyuxia created FLINK-29590: Summary: Fix constant fold issue for HiveDialect Key: FLINK-29590 URL: https://issues.apache.org/jira/browse/FLINK-29590 Project: Flink Issue Type: Bug

[GitHub] [flink] czy006 commented on pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

2022-10-11 Thread GitBox
czy006 commented on PR #21012: URL: https://github.com/apache/flink/pull/21012#issuecomment-1275495467 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zoucao commented on pull request #19250: [FLINK-26726][connector][hive]Hive enumerators do not assign splits to unregistered (failed) readers.

2022-10-11 Thread GitBox
zoucao commented on PR #19250: URL: https://github.com/apache/flink/pull/19250#issuecomment-1275491596 > @zoucao Thanks for updating. Could you please open the same pr to release-1.16/1.15/1.14? @wuchong Could you please help merge? Yes, I will do the bp soon. -- This is an

[GitHub] [flink] RocMarshal commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.

2022-10-11 Thread GitBox
RocMarshal commented on code in PR #20989: URL: https://github.com/apache/flink/pull/20989#discussion_r992912891 ## flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala: ## @@ -496,16 +496,16 @@ trait

[GitHub] [flink] RocMarshal commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.

2022-10-11 Thread GitBox
RocMarshal commented on code in PR #20989: URL: https://github.com/apache/flink/pull/20989#discussion_r992911391 ## flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala: ## @@ -496,16 +496,16 @@ trait

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
yunfengzhou-hub commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992901815 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java: ## @@ -21,11 +21,29 @@ import

[jira] [Updated] (FLINK-26726) Remove the unregistered task from readersAwaitingSplit

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-26726: - Issue Type: Bug (was: Improvement) > Remove the unregistered task from readersAwaitingSplit >

[GitHub] [flink] luoyuxia commented on pull request #20855: [FLINK-29337][hive] Fix fail to query non-hive table in Hive dialect

2022-10-11 Thread GitBox
luoyuxia commented on PR #20855: URL: https://github.com/apache/flink/pull/20855#issuecomment-1275467486 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia closed pull request #20883: [WIP] validate for https://github.com/apache/flink/pull/20882

2022-10-11 Thread GitBox
luoyuxia closed pull request #20883: [WIP] validate for https://github.com/apache/flink/pull/20882 URL: https://github.com/apache/flink/pull/20883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-29585) Migrate TableSchema to Schema for Hive connector

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616111#comment-17616111 ] luoyuxia commented on FLINK-29585: -- Sure.  [~jark] Could you please assign this ticket to [~aitozi] ?

[jira] [Closed] (FLINK-29495) PulsarSinkE2ECase hang

2022-10-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-29495. - Fix Version/s: 1.16.0 1.17.0 1.15.3 Assignee: Martijn

[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2022-10-11 Thread GitBox
Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1275379856 > The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the

[GitHub] [flink] hlteoh37 commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2022-10-11 Thread GitBox
hlteoh37 commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1275342620 The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the

[GitHub] [flink] snuyanzin commented on pull request #20410: [FLINK-28768][tests][testinfrastructure] Update junit to 5.9.1

2022-10-11 Thread GitBox
snuyanzin commented on PR #20410: URL: https://github.com/apache/flink/pull/20410#issuecomment-1275339899 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992793159 ## flink-table/flink-sql-parser/pom.xml: ## @@ -193,6 +204,10 @@ under the License. org.apiguardian Review Comment: I've

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992793159 ## flink-table/flink-sql-parser/pom.xml: ## @@ -193,6 +204,10 @@ under the License. org.apiguardian Review Comment: I've

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992790858 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -56,6 +56,12 @@ under the License. guava ${guava.version}

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be

[jira] [Commented] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616076#comment-17616076 ] Martijn Visser commented on FLINK-29589: If there's indeed a reproducible case with data loss I

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29589: --- Priority: Blocker (was: Major) > Data Loss in Sink GlobalCommitter during Task Manager

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be

[jira] [Created] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
Krzysztof Chmielewski created FLINK-29589: - Summary: Data Loss in Sink GlobalCommitter during Task Manager recovery Key: FLINK-29589 URL: https://issues.apache.org/jira/browse/FLINK-29589

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink's architecture with global committer seems to be

[GitHub] [flink] hlteoh37 commented on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2022-10-11 Thread GitBox
hlteoh37 commented on PR #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-1275238559 @MartijnVisser @dannycranmer Have picked it up here: https://issues.apache.org/jira/browse/FLINK-29574 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] kristoffSC commented on pull request #21025: [DRAFT] Flink 1.14 data loss sink global committer

2022-10-11 Thread GitBox
kristoffSC commented on PR #21025: URL: https://github.com/apache/flink/pull/21025#issuecomment-1275215995 wrong target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] kristoffSC closed pull request #21025: [DRAFT] Flink 1.14 data loss sink global committer

2022-10-11 Thread GitBox
kristoffSC closed pull request #21025: [DRAFT] Flink 1.14 data loss sink global committer URL: https://github.com/apache/flink/pull/21025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] kristoffSC opened a new pull request, #21025: [DRAFT] Flink 1.14 data loss sink global committer

2022-10-11 Thread GitBox
kristoffSC opened a new pull request, #21025: URL: https://github.com/apache/flink/pull/21025 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-11 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1275195142 Hi @libenchao I finally got around and implemented your suggestion. Do you mind to take a look again? I didn't implement additional operators like IN and BETWEEN because I am

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616044#comment-17616044 ] Gyula Fora commented on FLINK-29588: We don't really have a concept of application version for

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616041#comment-17616041 ] Clara Xiong commented on FLINK-29588: - appVersion is the application version of the FlinkDeployment.

[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-11 Thread GitBox
XComp commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r992679151 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -841,6 +842,12 @@ private StreamConfig

[jira] [Updated] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29588: --- Affects Version/s: (was: kubernetes-operator-1.2.0) > Add Flink Version and Application Version

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616020#comment-17616020 ] Gyula Fora commented on FLINK-29588: Since savepoints are compatible across version upgrades I think

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616018#comment-17616018 ] Gyula Fora commented on FLINK-29588: What do you mean by appVersion here? > Add Flink Version and

[GitHub] [flink] flinkbot commented on pull request #21024: Unpin cloudpickle

2022-10-11 Thread GitBox
flinkbot commented on PR #21024: URL: https://github.com/apache/flink/pull/21024#issuecomment-1275081315 ## CI report: * 2196926d20b5bd63f416355928bc4c76d0bfa205 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29495) PulsarSinkE2ECase hang

2022-10-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616011#comment-17616011 ] Martijn Visser commented on FLINK-29495: Tests alsof disabled for/via: release-1.16:

[GitHub] [flink] MartijnVisser merged pull request #21017: [FLINK-29495][BP 1.15][Connector/Pulsar] Refactor Pulsar tests for disabling tests on Java 11

2022-10-11 Thread GitBox
MartijnVisser merged PR #21017: URL: https://github.com/apache/flink/pull/21017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] MartijnVisser merged pull request #21018: [FLINK-29495][BP 1.16][Connector/Pulsar] Refactor Pulsar tests for disabling tests on Java 11

2022-10-11 Thread GitBox
MartijnVisser merged PR #21018: URL: https://github.com/apache/flink/pull/21018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] kosigz opened a new pull request, #21024: Unpin cloudpickle

2022-10-11 Thread GitBox
kosigz opened a new pull request, #21024: URL: https://github.com/apache/flink/pull/21024 The current version of cloudpickle has a bug in that locally / interactively defined classes with `@property` cannot be serialized. This makes it more difficult for MLP team to demo E2E flows.

[GitHub] [flink] leletan commented on pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-11 Thread GitBox
leletan commented on PR #20852: URL: https://github.com/apache/flink/pull/20852#issuecomment-1275067537 @zentol I see I have a lot of style issues and thanks for pointing them out. I am wondering if you have a doc / pointer for those style rules so I won't make those mistakes in the

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-11 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r992626495 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/checkpoints/CheckpointTriggerHandlersTest.java: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-11 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r992624496 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointTriggerStatusHeaders.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

[jira] [Created] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Clara Xiong (Jira)
Clara Xiong created FLINK-29588: --- Summary: Add Flink Version and Application Version to Savepoint properties Key: FLINK-29588 URL: https://issues.apache.org/jira/browse/FLINK-29588 Project: Flink

[jira] [Comment Edited] (FLINK-22243) Reactive Mode parallelism changes are not shown in the job graph visualization in the UI

2022-10-11 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613317#comment-17613317 ] Dawid Wysakowicz edited comment on FLINK-22243 at 10/11/22 5:19 PM:

[GitHub] [flink] dawidwys merged pull request #21021: [FLINK-22243] Remove adaptive scheduler Web UI limitation from docs

2022-10-11 Thread GitBox
dawidwys merged PR #21021: URL: https://github.com/apache/flink/pull/21021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992562130 ## flink-table/flink-table-planner/pom.xml: ## @@ -127,22 +127,22 @@ under the License. ${calcite.version}

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992562130 ## flink-table/flink-table-planner/pom.xml: ## @@ -127,22 +127,22 @@ under the License. ${calcite.version}

[GitHub] [flink] Samrat002 commented on pull request #20937: [FLINK-29478][flink-connector/hive] Flink connector hive upgrade to 3.1.3

2022-10-11 Thread GitBox
Samrat002 commented on PR #20937: URL: https://github.com/apache/flink/pull/20937#issuecomment-1274984521 - made changes in commit message as per contributing guide - squashed all commits to one commit - removed boiler plate example in description of pr - updated "Does this pull

[GitHub] [flink] Samrat002 commented on pull request #20937: [FLINK-29478][flink-connector/hive] Flink connector hive upgrade to 3.1.3

2022-10-11 Thread GitBox
Samrat002 commented on PR #20937: URL: https://github.com/apache/flink/pull/20937#issuecomment-1274946338 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-26890) DynamoDB consumer error consuming partitions close to retention

2022-10-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-26890: -- Fix Version/s: 1.17.0 1.15.3 1.16.1 > DynamoDB consumer

[jira] [Updated] (FLINK-26890) DynamoDB consumer error consuming partitions close to retention

2022-10-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-26890: -- Affects Version/s: 1.15.2 1.16.0 (was:

[jira] [Commented] (FLINK-26890) DynamoDB consumer error consuming partitions close to retention

2022-10-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615888#comment-17615888 ] Danny Cranmer commented on FLINK-26890: --- Thanks [~elphastori] , I have assigned to you > DynamoDB

[jira] [Assigned] (FLINK-26890) DynamoDB consumer error consuming partitions close to retention

2022-10-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-26890: - Assignee: Elphas Toringepi > DynamoDB consumer error consuming partitions close to

[jira] [Commented] (FLINK-26890) DynamoDB consumer error consuming partitions close to retention

2022-10-11 Thread Elphas Toringepi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615886#comment-17615886 ] Elphas Toringepi commented on FLINK-26890: -- I would like to take this. > DynamoDB consumer

[GitHub] [flink] dannycranmer commented on pull request #20937: [FLINK-29478][flink-connector/hive] Flink connector hive upgrade to 3.1.3

2022-10-11 Thread GitBox
dannycranmer commented on PR #20937: URL: https://github.com/apache/flink/pull/20937#issuecomment-1274827001 @Samrat002 can you please rebase and squash your commits. Please also change the commit message as per the [contribution

[jira] [Commented] (FLINK-29563) SourceTestSuiteBase#testSourceMetrics enters an infinite waiting loop in case the number of records counter is wrong

2022-10-11 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615878#comment-17615878 ] Etienne Chauchot commented on FLINK-29563: -- Ok let's forget about automatically disabling the

[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-11 Thread GitBox
XComp commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r992414646 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -841,6 +842,12 @@ private StreamConfig

[jira] [Updated] (FLINK-29577) Disable rocksdb wal when restore from full snapshot

2022-10-11 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-29577: Description: For now, RocksDBFullRestoreOperation and RocksDBHeapTimersFullRestoreOperation

[GitHub] [flink] zentol commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-11 Thread GitBox
zentol commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r992402913 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -841,6 +842,12 @@ private StreamConfig

  1   2   3   4   >