[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2023-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681211#comment-17681211 ] Matthias Pohl commented on FLINK-29405: ---

[jira] [Commented] (FLINK-30727) JoinReorderITCase.testBushyTreeJoinReorder failed due to IOException

2023-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681210#comment-17681210 ] Matthias Pohl commented on FLINK-30727: ---

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681209#comment-17681209 ] Matthias Pohl commented on FLINK-29427: ---

[jira] [Commented] (FLINK-30623) Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023

2023-01-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681196#comment-17681196 ] Rui Fan commented on FLINK-30623: - FLINK-26806 was merged at 23.01.2023, I'm not sure whether it will

[GitHub] [flink] fredia commented on pull request #21747: [FLINK-24932][state] Bump frocksdbjni to 6.20.3-ververica-2.0

2023-01-26 Thread via GitHub
fredia commented on PR #21747: URL: https://github.com/apache/flink/pull/21747#issuecomment-1406049554 @MartijnVisser Thanks for the review and verification. I compared the benchmark results based on the latest master(f6c7c30118ef26f98a7d422831fa8047f1fd9f98), below are the results.

[GitHub] [flink-kubernetes-operator] kmozaid commented on pull request #504: [FLINK-30669] update recent job status in flinkdeployment object

2023-01-26 Thread via GitHub
kmozaid commented on PR #504: URL: https://github.com/apache/flink-kubernetes-operator/pull/504#issuecomment-1406021738 > I agree @kmozaid if this doesn't affect existing jobs and improves some others then the change makes sense :) > > Could you please add a unit test to guard this

[jira] [Created] (FLINK-30799) Make SinkFunction support speculative execution for batch jobs

2023-01-26 Thread Biao Liu (Jira)
Biao Liu created FLINK-30799: Summary: Make SinkFunction support speculative execution for batch jobs Key: FLINK-30799 URL: https://issues.apache.org/jira/browse/FLINK-30799 Project: Flink

[jira] [Created] (FLINK-30798) Make OutputFormat support speculative execution for batch jobs

2023-01-26 Thread Biao Liu (Jira)
Biao Liu created FLINK-30798: Summary: Make OutputFormat support speculative execution for batch jobs Key: FLINK-30798 URL: https://issues.apache.org/jira/browse/FLINK-30798 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21765: [Flink-30755][runtime] Make SinkV2 support speculative execution for batch jobs

2023-01-26 Thread via GitHub
flinkbot commented on PR #21765: URL: https://github.com/apache/flink/pull/21765#issuecomment-1405950702 ## CI report: * 74cdbff981b35993ef2546d508f0ad6c2e4c2ba0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] ifndef-SleePy opened a new pull request, #21765: [Flink-30755][runtime] Make SinkV2 support speculative execution for batch jobs

2023-01-26 Thread via GitHub
ifndef-SleePy opened a new pull request, #21765: URL: https://github.com/apache/flink/pull/21765 ## What is the purpose of the change *This pull request introduces a way to allow SinkV2 run with speculative execution* ## Brief change log - *Introduce

[GitHub] [flink] 1996fanrui commented on pull request #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop

2023-01-26 Thread via GitHub
1996fanrui commented on PR #21697: URL: https://github.com/apache/flink/pull/21697#issuecomment-1405922443 Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-30709) NetworkInput#emitNext() should push records to DataOutput in a while loop

2023-01-26 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed FLINK-30709. Resolution: Fixed > NetworkInput#emitNext() should push records to DataOutput in a while loop >

[GitHub] [flink] lindong28 closed pull request #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop

2023-01-26 Thread via GitHub
lindong28 closed pull request #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop URL: https://github.com/apache/flink/pull/21697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] kristoffSC commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-26 Thread via GitHub
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1405755647 @tsreaper I've refactored both `BlockStatementSplitter` and `BlockStatementGrouper` so they use one `for` loop and one `visitor` instance like you suggested in your comments.

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-26 Thread via GitHub
kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1088399790 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-30444) State recovery error not handled correctly and always causes JM failure

2023-01-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681133#comment-17681133 ] Gyula Fora commented on FLINK-30444: Hi [~dmvk] ! Did you make any progress on this? Would be good

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
gyfora commented on PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#issuecomment-1405650899 > Thanks a lot @gyfora! > > Regarding: > > > We just have to ensure that we handle the Zookeeper dependency as optional > > The dependency was

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
gyfora commented on code in PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1088339662 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -160,19 +163,31 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
gyfora commented on code in PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1088338668 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -160,19 +163,31 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
gyfora commented on code in PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1088338472 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -160,19 +163,31 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
gyfora commented on code in PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1088337843 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -340,6 +341,11 @@ protected

[GitHub] [flink] MartijnVisser commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

2023-01-26 Thread via GitHub
MartijnVisser commented on PR #20049: URL: https://github.com/apache/flink/pull/20049#issuecomment-1405608732 @afedulov Do you think you can still make it before the feature freeze? (That's the 31st of January). -- This is an automated message from the Apache Git Service. To respond to

[jira] [Closed] (FLINK-30797) Bump json5 from 1.0.1 to 1.0.2

2023-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30797. -- Resolution: Fixed Fixed in master: eb8a33fb0cb7a07443df835a3142a1a139206ed6 > Bump json5

[jira] [Updated] (FLINK-30797) Bump json5 from 1.0.1 to 1.0.2

2023-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30797: --- Labels: pull-request-available (was: ) > Bump json5 from 1.0.1 to 1.0.2 >

[GitHub] [flink] MartijnVisser merged pull request #21617: [FLINK-30797] Bump json5 from 1.0.1 to 1.0.2 in /flink-runtime-web/web-dashboard

2023-01-26 Thread via GitHub
MartijnVisser merged PR #21617: URL: https://github.com/apache/flink/pull/21617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30797) Bump json5 from 1.0.1 to 1.0.2

2023-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30797: --- Summary: Bump json5 from 1.0.1 to 1.0.2 (was: Bump json5 from 1.0.1 to 1.0.2 in) > Bump

[jira] [Created] (FLINK-30797) Bump json5 from 1.0.1 to 1.0.2 in

2023-01-26 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-30797: -- Summary: Bump json5 from 1.0.1 to 1.0.2 in Key: FLINK-30797 URL: https://issues.apache.org/jira/browse/FLINK-30797 Project: Flink Issue Type: Technical

[GitHub] [flink] MartijnVisser commented on pull request #21671: [BK-1.16][FLINK-30657] Remove Shared and Key_Shared related tests in Pulsar connector

2023-01-26 Thread via GitHub
MartijnVisser commented on PR #21671: URL: https://github.com/apache/flink/pull/21671#issuecomment-1405601473 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] kristoffSC commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-26 Thread via GitHub
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1405572025 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (FLINK-30623) Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023

2023-01-26 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681102#comment-17681102 ] Piotr Nowojski edited comment on FLINK-30623 at 1/26/23 8:00 PM: - It

[jira] [Reopened] (FLINK-30623) Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023

2023-01-26 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reopened FLINK-30623: Assignee: (was: Rui Fan) > Performance regression in

[jira] [Commented] (FLINK-30623) Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023

2023-01-26 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681102#comment-17681102 ] Piotr Nowojski commented on FLINK-30623: It seems like everything has been fixed?

[GitHub] [flink] flinkbot commented on pull request #21764: [FLINK-26082][runtime] Initializing test netty server and client in the loop to avoid the probability of `Address already in use` problem.

2023-01-26 Thread via GitHub
flinkbot commented on PR #21764: URL: https://github.com/apache/flink/pull/21764#issuecomment-1405322143 ## CI report: * 09865792df8a4901f8429b063e09f5ee1b4a75e9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-26082) CancelPartitionRequestTest.testDuplicateCancel failed on azure due to bind failed

2023-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26082: --- Labels: auto-deprioritized-major pull-request-available test-stability (was:

[GitHub] [flink] akalash opened a new pull request, #21764: [FLINK-26082][runtime] Initializing test netty server and client in the loop to avoid the probability of `Address already in use` problem.

2023-01-26 Thread via GitHub
akalash opened a new pull request, #21764: URL: https://github.com/apache/flink/pull/21764 ## What is the purpose of the change This fix initializes test netty server in the loop in order to decrease probability of `Address already in use` problem. ## Brief change log

[GitHub] [flink-connector-kafka] mas-chen commented on pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-01-26 Thread via GitHub
mas-chen commented on PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#issuecomment-1405303999 Thanks for your help @zentol @MartijnVisser! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot commented on pull request #21763: [FLINK-15550][runtime] The static latches in TaskTest were replaced by latches from invokable objects.

2023-01-26 Thread via GitHub
flinkbot commented on PR #21763: URL: https://github.com/apache/flink/pull/21763#issuecomment-1405300184 ## CI report: * b29a8ee33deeca92104a8375be8b98a4bce7b524 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-28596) Support writing arrays to postgres array columns in Flink SQL JDBC connector

2023-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681036#comment-17681036 ] Martijn Visser commented on FLINK-28596: [~bobbyrlg] If you have a PR, looking forward to it :)

[GitHub] [flink] akalash opened a new pull request, #21763: [FLINK-15550][runtime] The static latches in TaskTest were replaced by latches from invokable objects.

2023-01-26 Thread via GitHub
akalash opened a new pull request, #21763: URL: https://github.com/apache/flink/pull/21763 ## What is the purpose of the change This change fixes the bug in a test which trigger the latch for the current test from the remaining thread of the previous test. ## Brief change

[jira] [Assigned] (FLINK-15550) testCancelTaskExceptionAfterTaskMarkedFailed failed on azure

2023-01-26 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-15550: - Assignee: Anton Kalashnikov > testCancelTaskExceptionAfterTaskMarkedFailed

[GitHub] [flink] kristoffSC commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-26 Thread via GitHub
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1405227888 Hi @tsreaper I'm currently working on the refactoring to include your suggestions, it does look promising. I should have new version by the end of this week. I have a

[jira] [Closed] (FLINK-30619) AdaptiveSchedulerTest.testStatusMetrics is not stable

2023-01-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30619. Fix Version/s: 1.17.0 1.16.2 Resolution: Fixed master:

[jira] [Updated] (FLINK-30619) AdaptiveSchedulerTest.testStatusMetrics is not stable

2023-01-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30619: - Issue Type: Technical Debt (was: Bug) > AdaptiveSchedulerTest.testStatusMetrics is not

[GitHub] [flink] zentol merged pull request #21751: [FLINK-30619][tests] Add retry

2023-01-26 Thread via GitHub
zentol merged PR #21751: URL: https://github.com/apache/flink/pull/21751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-01-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681024#comment-17681024 ] Chesnay Schepler commented on FLINK-30052: -- kafka-main:

[GitHub] [flink-connector-kafka] zentol merged pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-01-26 Thread via GitHub
zentol merged PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-01-26 Thread boring-cyborg
boring-cyborg[bot] commented on PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#issuecomment-1405200120 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #513: [FLINK-30781] Add completed checkpoint check to cluster health check

2023-01-26 Thread via GitHub
gaborgsomogyi commented on code in PR #513: URL: https://github.com/apache/flink-kubernetes-operator/pull/513#discussion_r1087995977 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,18 @@ + +

[GitHub] [flink-kubernetes-operator] antonipp commented on pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
antonipp commented on PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#issuecomment-1405163365 Thanks a lot @gyfora! Regarding: > We just have to ensure that we handle the Zookeeper dependency as optional The dependency was actually already there!

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087957846 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraSplitEnumerator.java: ## @@ -0,0 +1,156 @@

[jira] [Commented] (FLINK-27273) Support both configMap and zookeeper based HA data clean up

2023-01-26 Thread Anton Ippolitov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681010#comment-17681010 ] Anton Ippolitov commented on FLINK-27273: - Hi, FYI I just opened a draft PR for this issue

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087950644 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/RingRange.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

[GitHub] [flink-kubernetes-operator] antonipp commented on a diff in pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
antonipp commented on code in PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1087919678 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -160,19 +163,31 @@ public

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087944134 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + *

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1405116976 @zentol I'm almost done replacing the whole split mechanism. I could even remove the size estimates as Flink does not rely on expected split memory size as Beam. So I

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087939852 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraSplitEnumerator.java: ## @@ -0,0 +1,156 @@ +/* +

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087607875 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + *

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087928810 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/RingRange.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
gyfora commented on PR #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514#issuecomment-1405091162 I think from an initial review this looks pretty good. We just have to ensure that we handle the Zookeeper dependency as optional as this is the less frequent integration

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087926802 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/CassandraSource.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the

[jira] [Assigned] (FLINK-27273) Support both configMap and zookeeper based HA data clean up

2023-01-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-27273: -- Assignee: Anton Ippolitov > Support both configMap and zookeeper based HA data clean up >

[jira] [Updated] (FLINK-27273) Support both configMap and zookeeper based HA data clean up

2023-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27273: --- Labels: pull-request-available (was: ) > Support both configMap and zookeeper based HA

[GitHub] [flink-kubernetes-operator] antonipp opened a new pull request, #514: [WIP][FLINK-27273] Zookeeper HA support

2023-01-26 Thread via GitHub
antonipp opened a new pull request, #514: URL: https://github.com/apache/flink-kubernetes-operator/pull/514 > ⚠️ This PR is WIP, my goal is to get feedback as early as possible ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-27273 This PR makes

[GitHub] [flink] flinkbot commented on pull request #21762: [FLINK-30796][metrics][slf4j] (Partially) skip metrics report

2023-01-26 Thread via GitHub
flinkbot commented on PR #21762: URL: https://github.com/apache/flink/pull/21762#issuecomment-1405063430 ## CI report: * 476e8e6495fe8930c7bde3ad1834d79260a23580 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30796) Make Slf4jReporter less noisy when no/few metrics exist

2023-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30796: --- Labels: pull-request-available (was: ) > Make Slf4jReporter less noisy when no/few metrics

[GitHub] [flink] zentol opened a new pull request, #21762: [FLINK-30796][metrics][slf4j] (Partially) skip metrics report

2023-01-26 Thread via GitHub
zentol opened a new pull request, #21762: URL: https://github.com/apache/flink/pull/21762 The e2e logs are more noisy then they need to be because the slf4j reporter logs a lot of lines even if no metrics (of a particular type) are registered. Full skip: Before: ```

[GitHub] [flink] TJX2014 commented on pull request #21761: [FLINK-30795][tests] StreamingWithStateTestBase of win not correct

2023-01-26 Thread via GitHub
TJX2014 commented on PR #21761: URL: https://github.com/apache/flink/pull/21761#issuecomment-1405040674 Hi @AlanConfluent , could you please help me review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot commented on pull request #21761: [FLINK-30795][tests] StreamingWithStateTestBase of win not correct

2023-01-26 Thread via GitHub
flinkbot commented on PR #21761: URL: https://github.com/apache/flink/pull/21761#issuecomment-1405027565 ## CI report: * 6f02da7bce96a3bbd67c4ee868273298fb72f73a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #513: [FLINK-30781] Add completed checkpoint check to cluster health check

2023-01-26 Thread via GitHub
gyfora commented on code in PR #513: URL: https://github.com/apache/flink-kubernetes-operator/pull/513#discussion_r1087871390 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,18 @@ + +

[jira] [Updated] (FLINK-30795) StreamingWithStateTestBase of win not correct

2023-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30795: --- Labels: pull-request-available (was: ) > StreamingWithStateTestBase of win not correct >

[GitHub] [flink] TJX2014 opened a new pull request, #21761: [FLINK-30795][tests] StreamingWithStateTestBase of win not correct

2023-01-26 Thread via GitHub
TJX2014 opened a new pull request, #21761: URL: https://github.com/apache/flink/pull/21761 ## What is the purpose of the change Fix test case broken in win os. ## Brief change log Change "file://" to LocalFileSystem.getLocalFsURI.toString. ## Verifying this change

[jira] [Created] (FLINK-30796) Make Slf4jReporter less noisy when no/few metrics exist

2023-01-26 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30796: Summary: Make Slf4jReporter less noisy when no/few metrics exist Key: FLINK-30796 URL: https://issues.apache.org/jira/browse/FLINK-30796 Project: Flink

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #509: [FLINK-30653] Trigger resource Events on autoscaler actions

2023-01-26 Thread via GitHub
gyfora commented on code in PR #509: URL: https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1087868130 ## examples/autoscaling/src/main/java/autoscaling/AutoscalingExample.java: ## @@ -18,23 +18,38 @@ package autoscaling; +import

[GitHub] [flink] 1996fanrui commented on pull request #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop

2023-01-26 Thread via GitHub
1996fanrui commented on PR #21697: URL: https://github.com/apache/flink/pull/21697#issuecomment-1405010319 > Thanks for the improvement. Production code LGTM. Could you add a unit test for the `AbstractStreamTaskNetworkInput` or `StreamTaskNetworkInput` (in

[GitHub] [flink] flinkbot commented on pull request #21760: fix scala code

2023-01-26 Thread via GitHub
flinkbot commented on PR #21760: URL: https://github.com/apache/flink/pull/21760#issuecomment-1405009024 ## CI report: * 03e4e171a576de743ae8ccec2975235327fb4622 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] novakov-alexey opened a new pull request, #21760: fix scala code

2023-01-26 Thread via GitHub
novakov-alexey opened a new pull request, #21760: URL: https://github.com/apache/flink/pull/21760 ## What is the purpose of the change documentation fix. ## Brief change log Add missing val keyword ## Verifying this change Please make sure

[GitHub] [flink-web] dawidwys commented on pull request #603: Flink 1.16.1

2023-01-26 Thread via GitHub
dawidwys commented on PR #603: URL: https://github.com/apache/flink-web/pull/603#issuecomment-1405004500 @XComp > I'm not sure about the test instabilities. Do we include them? I remember some document where it stated that we should exclude them. But I couldn't find any

[jira] [Updated] (FLINK-30795) StreamingWithStateTestBase of win not correct

2023-01-26 Thread JinxinTang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JinxinTang updated FLINK-30795: --- Description: Windows path such as "

[GitHub] [flink-web] dawidwys commented on a diff in pull request #603: Flink 1.16.1

2023-01-26 Thread via GitHub
dawidwys commented on code in PR #603: URL: https://github.com/apache/flink-web/pull/603#discussion_r1087851914 ## _posts/2023-01-26-release-1.16.1.md: ## @@ -0,0 +1,258 @@ +--- +layout: post +title: "Apache Flink 1.16.1 Release Announcement" +date: 2023-01-23T22:00:00.000Z

[jira] [Created] (FLINK-30795) StreamingWithStateTestBase of win not correct

2023-01-26 Thread JinxinTang (Jira)
JinxinTang created FLINK-30795: -- Summary: StreamingWithStateTestBase of win not correct Key: FLINK-30795 URL: https://issues.apache.org/jira/browse/FLINK-30795 Project: Flink Issue Type: Bug

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087835183 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraSplitEnumerator.java: ## @@ -115,29 +109,22 @@

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087821967 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplit.java: ## @@ -48,6 +52,30 @@ public

[GitHub] [flink] XComp commented on pull request #21756: [FLINK-30787][debug] Adds dmesg call to test_controller to check whether it would succeed on Alibaba instances.

2023-01-26 Thread via GitHub
XComp commented on PR #21756: URL: https://github.com/apache/flink/pull/21756#issuecomment-1404966145 I wanted to verify it because of [Robert's

[GitHub] [flink] zentol commented on pull request #21756: [FLINK-30787][debug] Adds dmesg call to test_controller to check whether it would succeed on Alibaba instances.

2023-01-26 Thread via GitHub
zentol commented on PR #21756: URL: https://github.com/apache/flink/pull/21756#issuecomment-1404950896 I mean, it also fails in your personal azure, and the whole dmesg business was added _after_ FLINK-13978. Chances are this just fails because the tests are run in docker :shrug:

[GitHub] [flink] XComp commented on a diff in pull request #21751: [FLINK-30619][tests] Add retry

2023-01-26 Thread via GitHub
XComp commented on code in PR #21751: URL: https://github.com/apache/flink/pull/21751#discussion_r1087810726 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -585,7 +586,7 @@ public void testStatusMetrics() throws

[GitHub] [flink] zentol commented on pull request #21751: [FLINK-30619][tests] Add retry

2023-01-26 Thread via GitHub
zentol commented on PR #21751: URL: https://github.com/apache/flink/pull/21751#issuecomment-1404938724 I doubt that a thread dump is gonna help us much since we know that the job state was changed from the existing logs. But in the end waiting for it is a de-facto retry so why not. --

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #509: [FLINK-30653] Trigger resource Events on autoscaler actions

2023-01-26 Thread via GitHub
mxm commented on code in PR #509: URL: https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1087710879 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -99,14 +103,27 @@ public boolean

[jira] [Comment Edited] (FLINK-30717) Migrate Travis CI to Github Actions

2023-01-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678635#comment-17678635 ] Chesnay Schepler edited comment on FLINK-30717 at 1/26/23 10:59 AM:

[jira] [Closed] (FLINK-30717) Migrate Travis CI to Github Actions

2023-01-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30717. Resolution: Fixed > Migrate Travis CI to Github Actions >

[GitHub] [flink-training] zentol merged pull request #51: [FLINK-30717][ci] Migrate to GitHub Actions

2023-01-26 Thread via GitHub
zentol merged PR #51: URL: https://github.com/apache/flink-training/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1404820642 > > I don't think it is an ASF rule but fair enough, > > FYI; By and large it should be viewed as a legal requirement. By copying code from cassandra you have to

[jira] [Closed] (FLINK-30754) Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

2023-01-26 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30754. -- Fix Version/s: 1.17 Resolution: Fixed 3a64648 in master > Fix

[GitHub] [flink] mbalassi merged pull request #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

2023-01-26 Thread via GitHub
mbalassi merged PR #21732: URL: https://github.com/apache/flink/pull/21732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087607875 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + *

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087607875 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + *

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087607875 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + *

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-26 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1087605427 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraSplitEnumerator.java: ## @@ -0,0 +1,156 @@

[jira] [Created] (FLINK-30794) Disable dependency convergence check for night connector builds

2023-01-26 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-30794: -- Summary: Disable dependency convergence check for night connector builds Key: FLINK-30794 URL: https://issues.apache.org/jira/browse/FLINK-30794 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21759: [FLINK-29237][table] Remove RexSimplify from Flink code, SearchOperator code generation for RexUnknown.nullAs

2023-01-26 Thread via GitHub
flinkbot commented on PR #21759: URL: https://github.com/apache/flink/pull/21759#issuecomment-1404704386 ## CI report: * 8d766c9246e2178ebc237d93171e918c74e38050 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29237) RexSimplify can not be removed after update to calcite 1.27

2023-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29237: --- Labels: pull-request-available (was: ) > RexSimplify can not be removed after update to

  1   2   >