[GitHub] [flink-table-store] FangYongs closed pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader

2023-02-10 Thread via GitHub
FangYongs closed pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader URL: https://github.com/apache/flink-table-store/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-30979) The buckets of the secondary partition should fall on different tasks

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30979: --- Labels: pull-request-available (was: ) > The buckets of the secondary partition should

[GitHub] [flink-table-store] FangYongs opened a new pull request, #522: [FLINK-30979] Support shuffling data by partition

2023-02-10 Thread via GitHub
FangYongs opened a new pull request, #522: URL: https://github.com/apache/flink-table-store/pull/522 Currently sink operator in flink will shuffle data by bucket id, which cause data skew when there is only 1 bucket with multiple partitions in the table. This PR aims to support shuffling

[jira] [Commented] (FLINK-31021) JavaCodeSplitter doesn't split static method properly

2023-02-10 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687368#comment-17687368 ] Krzysztof Chmielewski commented on FLINK-31021: --- Hi, i have few questions. 1. Could you

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103520528 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarPartitionSplitReader.java: ## @@ -231,7 +232,11 @@ public void

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103523033 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumerator.java: ## @@ -220,11 +223,14 @@ private

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103523033 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumerator.java: ## @@ -220,11 +223,14 @@ private

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103522744 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumerator.java: ## @@ -220,11 +223,14 @@ private

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103522426 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -619,7 +619,7 @@ private void

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103520528 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarPartitionSplitReader.java: ## @@ -231,7 +232,11 @@ public void

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103520528 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarPartitionSplitReader.java: ## @@ -231,7 +232,11 @@ public void

[jira] [Closed] (FLINK-30993) Introduce FloatSerializer for Table Store

2023-02-10 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30993. Assignee: Feng Wang Resolution: Fixed master: c62992cef568274ec777c2d6e264a12f077b0925 >

[jira] [Closed] (FLINK-30992) Introduce ShortSerializer for Table Store

2023-02-10 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30992. Assignee: Feng Wang Resolution: Fixed master: f285db56b8a440ef4ef08d15b5a48d58b7c10e01 >

[GitHub] [flink-table-store] JingsongLi merged pull request #511: [Flink-30993] Introduce FloatSerializer for Table Store

2023-02-10 Thread via GitHub
JingsongLi merged PR #511: URL: https://github.com/apache/flink-table-store/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30991) Introduce LongSerializer for Table Store

2023-02-10 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30991. Resolution: Fixed master: 430df6c595c229a7128a43c5a1dc831d3f91f905 > Introduce LongSerializer

[GitHub] [flink-table-store] JingsongLi merged pull request #510: [Flink-30992] Introduce ShortSerializer for Table Store

2023-02-10 Thread via GitHub
JingsongLi merged PR #510: URL: https://github.com/apache/flink-table-store/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi merged pull request #509: [Flink-30991] Introduce LongSerializer for Table Store

2023-02-10 Thread via GitHub
JingsongLi merged PR #509: URL: https://github.com/apache/flink-table-store/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31021) JavaCodeSplitter doesn't split static method properly

2023-02-10 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui updated FLINK-31021: Affects Version/s: 1.15.3 > JavaCodeSplitter doesn't split static method properly >

[jira] [Created] (FLINK-31021) JavaCodeSplitter doesn't split static method properly

2023-02-10 Thread Xingcan Cui (Jira)
Xingcan Cui created FLINK-31021: --- Summary: JavaCodeSplitter doesn't split static method properly Key: FLINK-31021 URL: https://issues.apache.org/jira/browse/FLINK-31021 Project: Flink Issue

[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…

2023-02-10 Thread via GitHub
shuiqiangchen commented on PR #21897: URL: https://github.com/apache/flink/pull/21897#issuecomment-1426584980 @MartijnVisser Thank you for reminding. It worked after rebasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Comment Edited] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-10 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687347#comment-17687347 ] Shuiqiang Chen edited comment on FLINK-31003 at 2/11/23 2:51 AM: - Hi

[jira] [Commented] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-10 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687347#comment-17687347 ] Shuiqiang Chen commented on FLINK-31003: Hi [~martijnvisser][~weiqinpan], I think it is the same

[jira] [Commented] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-02-10 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687346#comment-17687346 ] Andriy Redko commented on FLINK-30998: -- [~lilyevsky] thanks, you could send the pull request to

[jira] [Commented] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-02-10 Thread Leonid Ilyevsky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687343#comment-17687343 ] Leonid Ilyevsky commented on FLINK-30998: - [~reta] Thanks, please let me know how to submit my

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103481149 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarTransactionUtils.java: ## @@ -46,17 +45,18 @@ private

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103481149 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarTransactionUtils.java: ## @@ -46,17 +45,18 @@ private

[jira] [Updated] (FLINK-31020) Read-only mode for Rest API

2023-02-10 Thread Omkar Deshpande (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omkar Deshpande updated FLINK-31020: Summary: Read-only mode for Rest API (was: Provide read-only mode for flink web UI) >

[jira] [Created] (FLINK-31020) Provide read-only mode for flink web UI

2023-02-10 Thread Omkar Deshpande (Jira)
Omkar Deshpande created FLINK-31020: --- Summary: Provide read-only mode for flink web UI Key: FLINK-31020 URL: https://issues.apache.org/jira/browse/FLINK-31020 Project: Flink Issue Type:

[GitHub] [flink] leeoo commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages

2023-02-10 Thread via GitHub
leeoo commented on PR #13081: URL: https://github.com/apache/flink/pull/13081#issuecomment-1426566305 @libenchao Okay, but I don't have experience in improving Flink framework, it's better to review it by Flink framework contributors. I will keep an eye on it and test it with my kafka JSON

[jira] [Closed] (FLINK-28283) Improving the log of flink when job start and deploy

2023-02-10 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-28283. Resolution: Won't Do [~zlzhang0122], thanks for your reply. Closing this as won't do. >

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103451369 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/source/cases/MultipleTopicsConsumingContext.java: ## @@ -56,7 +57,11 @@

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #24: [FLINK-30109][Connector/Pulsar] Drop the use of sneaky exception.

2023-02-10 Thread via GitHub
syhily commented on code in PR #24: URL: https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103449916 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/PulsarRuntimeOperator.java: ## @@ -80,7 +72,7 @@ import static

[GitHub] [flink] libenchao commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages

2023-02-10 Thread via GitHub
libenchao commented on PR #13081: URL: https://github.com/apache/flink/pull/13081#issuecomment-1426536898 @leeoo Thanks for your interest, I'll rebase the PR the latest master branch lately, would you please help to review it? -- This is an automated message from the Apache Git Service.

[jira] [Comment Edited] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-10 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687321#comment-17687321 ] Shipeng Xie edited comment on FLINK-30757 at 2/11/23 12:16 AM: --- The e2e

[jira] [Commented] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-10 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687321#comment-17687321 ] Shipeng Xie commented on FLINK-30757: - The e2e

[GitHub] [flink-kubernetes-operator] xshipeng commented on pull request #530: [FLINK-30757] Upgrade busybox version to a pinned version for operator

2023-02-10 Thread via GitHub
xshipeng commented on PR #530: URL: https://github.com/apache/flink-kubernetes-operator/pull/530#issuecomment-1426506352 It looks like busybox latest (1.36.0) is unstable -> https://github.com/docker-library/busybox/issues/162 -- This is an automated message from the Apache Git

[jira] [Commented] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-02-10 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687289#comment-17687289 ] Andriy Redko commented on FLINK-30998: -- [~martijnvisser] [~lilyevsky] sure, happy to help here >

[jira] [Commented] (FLINK-30627) Refactor FileSystemTableSink to use FileSink instead of StreamingFileSink

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687287#comment-17687287 ] Martijn Visser commented on FLINK-30627: [~tanyuxin] Could you elaborate on how you would like

[jira] [Commented] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-10 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687284#comment-17687284 ] Shipeng Xie commented on FLINK-30757: - Hi [~gyfora] [~gaborgsomogyi], I added the code to print init

[jira] [Updated] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30757: --- Labels: pull-request-available starter (was: starter) > Ugrade busybox version to a pinned

[GitHub] [flink-kubernetes-operator] xshipeng opened a new pull request, #530: [FLINK-30757] Upgrade busybox version to a pinned version for operator

2023-02-10 Thread via GitHub
xshipeng opened a new pull request, #530: URL: https://github.com/apache/flink-kubernetes-operator/pull/530 ## What is the purpose of the change Since [e2e test](https://github.com/apache/flink-kubernetes-operator/actions/runs/389690/jobs/6662337363) is flaky with latest

[GitHub] [flink] MartijnVisser commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…

2023-02-10 Thread via GitHub
MartijnVisser commented on PR #21897: URL: https://github.com/apache/flink/pull/21897#issuecomment-1426325867 @shuiqiangchen You need to rebase your PR on the latest changes in `master` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687276#comment-17687276 ] Martijn Visser commented on FLINK-30998: [~reta] WDYT? > Add optional exception handler to

[jira] [Assigned] (FLINK-30971) Modify the default value of parameter 'table.exec.local-hash-agg.adaptive.sampling-threshold'

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30971: -- Assignee: Yunhong Zheng > Modify the default value of parameter >

[jira] [Updated] (FLINK-30971) Modify the default value of parameter 'table.exec.local-hash-agg.adaptive.sampling-threshold'

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30971: --- Fix Version/s: 1.17.0 > Modify the default value of parameter >

[jira] [Updated] (FLINK-30971) Modify the default value of parameter 'table.exec.local-hash-agg.adaptive.sampling-threshold'

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30971: --- Fix Version/s: (was: 1.17.0) > Modify the default value of parameter >

[jira] [Commented] (FLINK-31006) job is not finished when using pipeline mode to run bounded source like kafka/pulsar

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687275#comment-17687275 ] Martijn Visser commented on FLINK-31006: [~renqs] WDYT? > job is not finished when using

[jira] [Commented] (FLINK-31007) The code generated by the IF function throws NullPointerException

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687274#comment-17687274 ] Martijn Visser commented on FLINK-31007: [~lincoln.86xy] WDYT? > The code generated by the IF

[GitHub] [flink] MartijnVisser commented on pull request #21630: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink

2023-02-10 Thread via GitHub
MartijnVisser commented on PR #21630: URL: https://github.com/apache/flink/pull/21630#issuecomment-1426319887 @gaoyunhaii Can you take one more look? You've already reviewed the original PR, which missed one thing that is now addressed in this PR. -- This is an automated message from the

[jira] [Updated] (FLINK-30627) Refactor FileSystemTableSink to use FileSink instead of StreamingFileSink

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30627: --- Description: {{FileSystemTableSink}} currently depends on most of the capabilities from

[jira] [Closed] (FLINK-31019) Migrate FileSystemTableSink to FileSink

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31019. -- Resolution: Duplicate > Migrate FileSystemTableSink to FileSink >

[jira] [Created] (FLINK-31019) Migrate FileSystemTableSink to FileSink

2023-02-10 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-31019: -- Summary: Migrate FileSystemTableSink to FileSink Key: FLINK-31019 URL: https://issues.apache.org/jira/browse/FLINK-31019 Project: Flink Issue Type:

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
reta commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1103191251 ## .github/workflows/push_pr.yml: ## @@ -25,6 +25,6 @@ jobs: compile_and_test: uses:

[GitHub] [flink-connector-opensearch] reta commented on pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
reta commented on PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1426283511 Thanks @dannycranmer , I think I went through all your comments, thanks a lot, really appreciate it. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-connector-opensearch] dannycranmer commented on pull request #7: [hotfix] Update Apache Flink to 1.16.1

2023-02-10 Thread via GitHub
dannycranmer commented on PR #7: URL: https://github.com/apache/flink-connector-opensearch/pull/7#issuecomment-1426268450 Thanks @reta -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-opensearch] dannycranmer merged pull request #7: [hotfix] Update Apache Flink to 1.16.1

2023-02-10 Thread via GitHub
dannycranmer merged PR #7: URL: https://github.com/apache/flink-connector-opensearch/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21911: [FLINK-19065] [runtime] Generate unique and consistent UID for internal Map operators used in CoGroupedStreams

2023-02-10 Thread via GitHub
flinkbot commented on PR #21911: URL: https://github.com/apache/flink/pull/21911#issuecomment-1426267913 ## CI report: * cee862b208cfd3674f6cbcd64d07e7f7c871253b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-19065) java.lang.IllegalStateException: Auto generated UIDs have been disabled on join

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19065: --- Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available (was:

[GitHub] [flink] hmit opened a new pull request, #21911: [FLINK-19065] [runtime] Generate unique and consistent UID for internal Map operators used in CoGroupedStreams

2023-02-10 Thread via GitHub
hmit opened a new pull request, #21911: URL: https://github.com/apache/flink/pull/21911 ## What is the purpose of the change This fixes issue when flink job using join/cogroup is run with autoGenerateUid disabled. With uid generation disabled, the input -> map-for-union

[GitHub] [flink] mxm commented on a diff in pull request #21908: [FLINK-30895][coordination] Dynamically adjust slot distribution

2023-02-10 Thread via GitHub
mxm commented on code in PR #21908: URL: https://github.com/apache/flink/pull/21908#discussion_r1103096757 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java: ## @@ -133,7 +138,56 @@ public Optional

[GitHub] [flink] mxm commented on a diff in pull request #21908: [FLINK-30895][coordination] Dynamically adjust slot distribution

2023-02-10 Thread via GitHub
mxm commented on code in PR #21908: URL: https://github.com/apache/flink/pull/21908#discussion_r1103092025 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java: ## @@ -133,7 +138,56 @@ public Optional

[GitHub] [flink] mxm commented on a diff in pull request #21908: [FLINK-30895][coordination] Dynamically adjust slot distribution

2023-02-10 Thread via GitHub
mxm commented on code in PR #21908: URL: https://github.com/apache/flink/pull/21908#discussion_r1103091640 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java: ## @@ -133,7 +138,56 @@ public Optional

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
reta commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1103088811 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchAsyncWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
reta commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1103068913 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/DocSerdeRequest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #529: [FLINK-30776] Move autoscaler code into a separate Maven module

2023-02-10 Thread via GitHub
mxm commented on code in PR #529: URL: https://github.com/apache/flink-kubernetes-operator/pull/529#discussion_r1103083946 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoscalerFactoryImpl.java: ## @@ -0,0 +1,41 @@

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #529: [FLINK-30776] Move autoscaler code into a separate Maven module

2023-02-10 Thread via GitHub
mxm commented on code in PR #529: URL: https://github.com/apache/flink-kubernetes-operator/pull/529#discussion_r1103083946 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoscalerFactoryImpl.java: ## @@ -0,0 +1,41 @@

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
reta commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1103068913 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/DocSerdeRequest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
reta commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1103066160 ## .github/workflows/push_pr.yml: ## @@ -25,4 +25,4 @@ jobs: compile_and_test: uses:

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-02-10 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1101701294 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplitState.java: ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-02-10 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1101601871 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-02-10 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1100252874 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,309 @@ +/* + *

[GitHub] [flink-connector-opensearch] reta opened a new pull request, #7: [hotfix] Update Apache Flink to 1.16.1

2023-02-10 Thread via GitHub
reta opened a new pull request, #7: URL: https://github.com/apache/flink-connector-opensearch/pull/7 Update Apache Flink to 1.16.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-31018) SQL Client -j option does not load user jars to classpath.

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687220#comment-17687220 ] Martijn Visser commented on FLINK-31018: Great to hear that fixes it, thanks for updating it! >

[jira] [Comment Edited] (FLINK-31018) SQL Client -j option does not load user jars to classpath.

2023-02-10 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687218#comment-17687218 ] Krzysztof Chmielewski edited comment on FLINK-31018 at 2/10/23 5:39 PM:

[jira] [Closed] (FLINK-31018) SQL Client -j option does not load user jars to classpath.

2023-02-10 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski closed FLINK-31018. - Resolution: Not A Bug > SQL Client -j option does not load user jars to

[jira] [Commented] (FLINK-31018) SQL Client -j option does not load user jars to classpath.

2023-02-10 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687218#comment-17687218 ] Krzysztof Chmielewski commented on FLINK-31018: --- [~martijnvisser] yes it seemt that this

[GitHub] [flink-connector-opensearch] dannycranmer commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-02-10 Thread via GitHub
dannycranmer commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1102989699 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/DocSerdeRequest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed

[GitHub] [flink] wanglijie95 commented on pull request #21813: [hotfix] Fix typo in elastic_scaling.md

2023-02-10 Thread via GitHub
wanglijie95 commented on PR #21813: URL: https://github.com/apache/flink/pull/21813#issuecomment-1426056540 Thanks @noahshpak @reswqa, merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-10 Thread weiqinpan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687149#comment-17687149 ] weiqinpan edited comment on FLINK-31003 at 2/10/23 4:20 PM: The value of

[GitHub] [flink] wanglijie95 merged pull request #21813: [hotfix] Fix typo in elastic_scaling.md

2023-02-10 Thread via GitHub
wanglijie95 merged PR #21813: URL: https://github.com/apache/flink/pull/21813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-10 Thread weiqinpan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687149#comment-17687149 ] weiqinpan commented on FLINK-31003: --- The field of marketing_flow_id is not null, but the result  of

[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…

2023-02-10 Thread via GitHub
zekai-li commented on PR #21675: URL: https://github.com/apache/flink/pull/21675#issuecomment-1426034122 ![image](https://user-images.githubusercontent.com/58294989/218140853-182a708b-408a-497f-8765-9e1b8fa09d2b.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…

2023-02-10 Thread via GitHub
zekai-li commented on PR #21675: URL: https://github.com/apache/flink/pull/21675#issuecomment-1426032058 > The compile build failed. Could you fix it first? The compilation error has been fixed -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-02-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687143#comment-17687143 ] Piotr Nowojski commented on FLINK-29825: Yes, that's a good idea :) > Improve benchmark

[jira] [Commented] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687120#comment-17687120 ] Martijn Visser commented on FLINK-31003: [~lincoln.86xy] WDYT? > Flink SQL IF / CASE WHEN

[jira] [Commented] (FLINK-31017) Early-started partial match timeout not yield completed matches

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687118#comment-17687118 ] Martijn Visser commented on FLINK-31017: [~Juntao Hu] Are you committing to fixing this in 1.18?

[jira] [Commented] (FLINK-31018) SQL Client -j option does not load user jars to classpath.

2023-02-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687117#comment-17687117 ] Martijn Visser commented on FLINK-31018: [~KristoffSC] Could this be related to FLINK-15635 ? >

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-02-10 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687116#comment-17687116 ] Dong Lin commented on FLINK-29825: -- Thanks [~Yanfei Lei] for the detailed evaluation results! Maybe we

[jira] [Created] (FLINK-31018) SQL Client -j option does not load user jars to classpath.

2023-02-10 Thread Krzysztof Chmielewski (Jira)
Krzysztof Chmielewski created FLINK-31018: - Summary: SQL Client -j option does not load user jars to classpath. Key: FLINK-31018 URL: https://issues.apache.org/jira/browse/FLINK-31018 Project:

[jira] [Commented] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-02-10 Thread Leonid Ilyevsky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687111#comment-17687111 ] Leonid Ilyevsky commented on FLINK-30998: - This morning I successfully tested my solution. The

[jira] [Closed] (FLINK-28911) Elasticsearch connector fails build

2023-02-10 Thread Niels Basjes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes closed FLINK-28911. Resolution: Won't Fix > Elasticsearch connector fails build > ---

[jira] [Assigned] (FLINK-18235) Improve the checkpoint strategy for Python UDF execution

2023-02-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-18235: -- Assignee: (was: Dian Fu) > Improve the checkpoint strategy for Python UDF

[jira] [Updated] (FLINK-18235) Improve the checkpoint strategy for Python UDF execution

2023-02-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-18235: --- Priority: Not a Priority (was: Major) > Improve the checkpoint strategy for Python UDF

[jira] [Commented] (FLINK-18235) Improve the checkpoint strategy for Python UDF execution

2023-02-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687102#comment-17687102 ] Piotr Nowojski commented on FLINK-18235: [~dianfu], may I ask if you have considered

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-02-10 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687098#comment-17687098 ] Piotr Nowojski commented on FLINK-29825: Thanks a lot for the very detailed comparison [~Yanfei

[GitHub] [flink] XComp commented on a diff in pull request #19970: [FLINK-27970][tests][JUnit5 migration] flink-hadoop-bulk

2023-02-10 Thread via GitHub
XComp commented on code in PR #19970: URL: https://github.com/apache/flink/pull/19970#discussion_r1102841851 ## flink-formats/flink-hadoop-bulk/archunit-violations/db4de53e-d09e-4fb0-bdbc-429c1b64686f: ## @@ -0,0 +1,12 @@

[jira] [Created] (FLINK-31017) Early-started partial match timeout not yield completed matches

2023-02-10 Thread Juntao Hu (Jira)
Juntao Hu created FLINK-31017: - Summary: Early-started partial match timeout not yield completed matches Key: FLINK-31017 URL: https://issues.apache.org/jira/browse/FLINK-31017 Project: Flink

[jira] [Commented] (FLINK-23016) Job client must be a Coordination Request Gateway when submit a job on web ui

2023-02-10 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687090#comment-17687090 ] Krzysztof Chmielewski commented on FLINK-23016: --- FYI, got the same error on Flink 1.16.1

[GitHub] [flink] wanglijie95 commented on pull request #21813: [hotfix] Fix typo in elastic_scaling.md

2023-02-10 Thread via GitHub
wanglijie95 commented on PR #21813: URL: https://github.com/apache/flink/pull/21813#issuecomment-1425854545 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-02-10 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687082#comment-17687082 ] Yanfei Lei commented on FLINK-29825: [~pnowojski]  I tried to use hunter to detect regression, and

  1   2   3   >