[jira] [Closed] (FLINK-31022) Using new Serializer for table store

2023-02-12 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31022. Resolution: Fixed master: 5b6ff938922aa067b59a0132c62e6cd675680b63 > Using new Serializer for

[GitHub] [flink-table-store] JingsongLi merged pull request #523: [FLINK-31022] Using new Serializer for table store

2023-02-12 Thread via GitHub
JingsongLi merged PR #523: URL: https://github.com/apache/flink-table-store/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-30489) flink-sql-connector-pulsar doesn't shade all dependencies

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687779#comment-17687779 ] Yufan Sheng commented on FLINK-30489: - [~tison] Can you assign this issue to me? >

[jira] [Updated] (FLINK-30489) flink-sql-connector-pulsar doesn't shade all dependencies

2023-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30489: --- Labels: pull-request-available (was: ) > flink-sql-connector-pulsar doesn't shade all

[GitHub] [flink-connector-pulsar] syhily opened a new pull request, #26: [FLINK-30489][Connector/Pulsar] Shade all the dependencies in flink-sql-connector-pulsar.

2023-02-12 Thread via GitHub
syhily opened a new pull request, #26: URL: https://github.com/apache/flink-connector-pulsar/pull/26 This is a PR after https://github.com/apache/flink-connector-pulsar/pull/25, but we split them for speeding up the reviews. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink-table-store] FangYongs commented on pull request #526: [FLINK-31027] Introduce annotations for table store

2023-02-12 Thread via GitHub
FangYongs commented on PR #526: URL: https://github.com/apache/flink-table-store/pull/526#issuecomment-1427476456 > Sounds good to me, then we should add `VisibleForTesting` to `flink-table-store-common` only, I'll updated this PR later -- This is an automated message from the

[jira] [Assigned] (FLINK-30559) May get wrong result for `if` expression if it's string data type

2023-02-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-30559: --- Assignee: miamiaoxyz > May get wrong result for `if` expression if it's string data type >

[jira] [Commented] (FLINK-30966) Flink SQL IF FUNCTION logic error

2023-02-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687768#comment-17687768 ] lincoln lee commented on FLINK-30966: - [~csq] assigned to you > Flink SQL IF FUNCTION logic error >

[GitHub] [flink] flinkbot commented on pull request #21913: [hotfix] Fix typo in explain.md

2023-02-12 Thread via GitHub
flinkbot commented on PR #21913: URL: https://github.com/apache/flink/pull/21913#issuecomment-1427459585 ## CI report: * 6a8d8ce72f8f9cad0907a1a057ff53b9d7cbe86e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-30966) Flink SQL IF FUNCTION logic error

2023-02-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-30966: --- Assignee: Shuiqiang Chen > Flink SQL IF FUNCTION logic error >

[jira] [Updated] (FLINK-31027) Introduce annotation for table store

2023-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31027: --- Labels: pull-request-available (was: ) > Introduce annotation for table store >

[GitHub] [flink-table-store] JingsongLi commented on pull request #526: [FLINK-31027] Introduce annotations for table store

2023-02-12 Thread via GitHub
JingsongLi commented on PR #526: URL: https://github.com/apache/flink-table-store/pull/526#issuecomment-1427449782 Thanks @FangYongs for the contribution. - `VisibleForTesting` looks good to me. - `Documentation` is introduced in https://github.com/apache/flink-table-store/pull/524

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #530: [FLINK-30757] Upgrade busybox version to a pinned version for operator

2023-02-12 Thread via GitHub
gaborgsomogyi commented on PR #530: URL: https://github.com/apache/flink-kubernetes-operator/pull/530#issuecomment-1427448370 cc @gyfora @mbalassi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687766#comment-17687766 ] Weijie Guo edited comment on FLINK-31025 at 2/13/23 7:04 AM: - BTW. I also

[jira] [Commented] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687766#comment-17687766 ] Weijie Guo commented on FLINK-31025: BTW. I also found a type in `explain.md`, I have created

[GitHub] [flink] reswqa opened a new pull request, #21913: [hotfix] Fix typo in explain.md

2023-02-12 Thread via GitHub
reswqa opened a new pull request, #21913: URL: https://github.com/apache/flink/pull/21913 ## What is the purpose of the change *Fix typo in explain.md.* ## Brief change log - *Fix typo(`OHE_PHASE` -> `ONE_PHASE`) in explain.md.* ## Verifying this change

[GitHub] [flink] liming30 commented on a diff in pull request #21503: [FLINK-30251] Move the IO with DFS during abort checkpoint to an asynchronous thread pool.

2023-02-12 Thread via GitHub
liming30 commented on code in PR #21503: URL: https://github.com/apache/flink/pull/21503#discussion_r1104060745 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -177,6 +182,14 @@ class

[jira] [Updated] (FLINK-31031) Disable the output buffer of Python process to make it more convenient for interactive users

2023-02-12 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-31031: Description: See

[jira] [Commented] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687761#comment-17687761 ] Weijie Guo commented on FLINK-31025: I verified this feature according to the description, and

[GitHub] [flink] ruanhang1993 commented on pull request #21889: [FLINK-29801][runtime] FLIP-274: Introduce metric group for OperatorCoordinator

2023-02-12 Thread via GitHub
ruanhang1993 commented on PR #21889: URL: https://github.com/apache/flink/pull/21889#issuecomment-1427435469 Hi, @zentol , I decide not to split it into two PRs and I have pushed the changes. Please review it again if you have time. Thanks~ -- This is an automated message from the

[jira] [Updated] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31025: --- Attachment: image-2023-02-13-14-52-41-855.png > Release Testing: Verify FLINK-30650 Introduce

[jira] [Created] (FLINK-31031) Disable the output buffer of Python process to make it more convenient for interactive users

2023-02-12 Thread Dian Fu (Jira)
Dian Fu created FLINK-31031: --- Summary: Disable the output buffer of Python process to make it more convenient for interactive users Key: FLINK-31031 URL: https://issues.apache.org/jira/browse/FLINK-31031

[GitHub] [flink] fsk119 commented on a diff in pull request #21912: [FLINK-28658][docs] Add docs for job statements

2023-02-12 Thread via GitHub
fsk119 commented on code in PR #21912: URL: https://github.com/apache/flink/pull/21912#discussion_r1104041538 ## docs/content/docs/dev/table/sql/show.md: ## @@ -747,4 +748,14 @@ Show all added jars in the session classloader which are added by [`ADD JAR`]({{ Attention

[jira] [Updated] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31025: --- Attachment: image-2023-02-13-14-48-53-758.png > Release Testing: Verify FLINK-30650 Introduce

[jira] [Updated] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31025: --- Attachment: test1.png > Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to

[jira] [Assigned] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31025: -- Assignee: Weijie Guo > Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to

[jira] [Commented] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687755#comment-17687755 ] Weijie Guo commented on FLINK-31025: Thanks [~qingyue] for creating this, I'd like to do this

[jira] [Created] (FLINK-31030) Support more binary classification evaluation metrics.

2023-02-12 Thread Fan Hong (Jira)
Fan Hong created FLINK-31030: Summary: Support more binary classification evaluation metrics. Key: FLINK-31030 URL: https://issues.apache.org/jira/browse/FLINK-31030 Project: Flink Issue Type:

[jira] [Updated] (FLINK-31030) Support more binary classification evaluation metrics.

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31030: - Description: Current `BinaryClassificationEvaluator` only supports 'areaUnderROC', 'areaUnderPR', 'ks'

[jira] [Updated] (FLINK-31029) KBinsDiscretizer gives wrong bin edges in 'quantile' strategy when input data contains only 2 distinct values

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31029: - Description: When one input column contains only 2 distinct values and their counts are same,

[jira] [Updated] (FLINK-31029) KBinsDiscretizer gives wrong bin edges in 'quantile' strategy when input data contains only 2 distinct values

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31029: - Description: When a input column contains only 2 distinct values, and their counts are same,  >

[jira] [Commented] (FLINK-31007) The code generated by the IF function throws NullPointerException

2023-02-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687750#comment-17687750 ] lincoln lee commented on FLINK-31007: - This is a bug for IfCallGen, all operands initialization and

[jira] [Updated] (FLINK-31029) KBinsDiscretizer gives wrong bin edges in 'quantile' strategy when input data contains only 2 distinct values

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31029: - Summary: KBinsDiscretizer gives wrong bin edges in 'quantile' strategy when input data contains only 2

[jira] [Assigned] (FLINK-31007) The code generated by the IF function throws NullPointerException

2023-02-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-31007: --- Assignee: xzw0223 > The code generated by the IF function throws NullPointerException >

[jira] [Created] (FLINK-31029) KBinsDiscretizer gives wrong bin edges when input data contains only 2 distinct values

2023-02-12 Thread Fan Hong (Jira)
Fan Hong created FLINK-31029: Summary: KBinsDiscretizer gives wrong bin edges when input data contains only 2 distinct values Key: FLINK-31029 URL: https://issues.apache.org/jira/browse/FLINK-31029

[GitHub] [flink-ml] Fanoid opened a new pull request, #211: [FLINK-31026] Fix KBinsDiscretizer when the input values of one column are same

2023-02-12 Thread via GitHub
Fanoid opened a new pull request, #211: URL: https://github.com/apache/flink-ml/pull/211 ## What is the purpose of the change KBinsDiscretizer produces `{Double.MIN_VALUE, Double.MAX_VALUE}` for columns whose input values are same which is not correct, as it doesn't cover negative

[jira] [Updated] (FLINK-31026) KBinsDiscretizer gives wrong bin edges when all values are same.

2023-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31026: --- Labels: pull-request-available (was: ) > KBinsDiscretizer gives wrong bin edges when all

[jira] [Updated] (FLINK-31026) KBinsDiscretizer gives wrong bin edges when all values are same.

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31026: - Summary: KBinsDiscretizer gives wrong bin edges when all values are same. (was: KBinsDiscretizer

[jira] [Updated] (FLINK-31022) Using new Serializer for table store

2023-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31022: --- Labels: pull-request-available (was: ) > Using new Serializer for table store >

[GitHub] [flink-table-store] FangYongs commented on pull request #523: [FLINK-31022] Using new Serializer for table store

2023-02-12 Thread via GitHub
FangYongs commented on PR #523: URL: https://github.com/apache/flink-table-store/pull/523#issuecomment-1427399487 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-30519) Add e2e tests for operator dynamic config

2023-02-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30519: -- Assignee: haiqingchen > Add e2e tests for operator dynamic config >

[GitHub] [flink] reswqa commented on pull request #21573: [FLINK-30524] Support full screen viewing on the Logs/Stdout/Thread D…

2023-02-12 Thread via GitHub
reswqa commented on PR #21573: URL: https://github.com/apache/flink/pull/21573#issuecomment-1427386691 @yangjunhan Would you mind reviwing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-31021) JavaCodeSplitter doesn't split static method properly

2023-02-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687738#comment-17687738 ] Benchao Li commented on FLINK-31021: [~xccui] Thanks for involving me. I totally agree that the

[jira] [Created] (FLINK-31028) Provide different compression methods for per level

2023-02-12 Thread Jun Zhang (Jira)
Jun Zhang created FLINK-31028: - Summary: Provide different compression methods for per level Key: FLINK-31028 URL: https://issues.apache.org/jira/browse/FLINK-31028 Project: Flink Issue Type:

[jira] [Created] (FLINK-31027) Introduce annotation for table store

2023-02-12 Thread Shammon (Jira)
Shammon created FLINK-31027: --- Summary: Introduce annotation for table store Key: FLINK-31027 URL: https://issues.apache.org/jira/browse/FLINK-31027 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-31021) JavaCodeSplitter doesn't split static method properly

2023-02-12 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687728#comment-17687728 ] Xingcan Cui commented on FLINK-31021: - I'm playing with

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21889: [FLINK-29801][runtime] FLIP-274: Introduce JobManagerOperatorMetricGroup for the components running on a JobManager of the ope

2023-02-12 Thread via GitHub
ruanhang1993 commented on code in PR #21889: URL: https://github.com/apache/flink/pull/21889#discussion_r1103993973 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalOperatorCoordinatorMetricGroup.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the

[GitHub] [flink-web] reswqa commented on pull request #607: Add Weijie Guo to the committer list

2023-02-12 Thread via GitHub
reswqa commented on PR #607: URL: https://github.com/apache/flink-web/pull/607#issuecomment-1427334809 Thanks @xintongsong for reminding me, I have removed the rebuild commit and fixed yangze's incorrect order. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (FLINK-31026) KBinsDiscretizer should gives wrong bin edges when all values are same.

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31026: - Description: Current implements gives bin edges of \{Double.MIN_VALUE, Double.MAX_VALUE} when all

[jira] [Updated] (FLINK-31026) KBinsDiscretizer should gives wrong bin edges when all values are same.

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31026: - Description: Current implements gives bin edges of \{Double.MIN_VALUE, Double.MAX_VALUE} when all

[jira] [Updated] (FLINK-31026) KBinsDiscretizer should gives wrong bin edges when all values are same.

2023-02-12 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31026: - Summary: KBinsDiscretizer should gives wrong bin edges when all values are same. (was:

[jira] [Created] (FLINK-31026) KBinsDiscretizer should gives binEdges wrong bin edges when all values are same.

2023-02-12 Thread Fan Hong (Jira)
Fan Hong created FLINK-31026: Summary: KBinsDiscretizer should gives binEdges wrong bin edges when all values are same. Key: FLINK-31026 URL: https://issues.apache.org/jira/browse/FLINK-31026 Project:

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #192: [FLINK-30451] Add AlgoOperator for Swing

2023-02-12 Thread via GitHub
zhipeng93 commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1103973578 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/SwingParams.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #192: [FLINK-30451] Add AlgoOperator for Swing

2023-02-12 Thread via GitHub
zhipeng93 commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1103974792 ## flink-ml-lib/src/test/java/org/apache/flink/ml/recommendation/SwingTest.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #192: [FLINK-30451] Add AlgoOperator for Swing

2023-02-12 Thread via GitHub
zhipeng93 commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1103961097 ## flink-ml-examples/src/main/java/org/apache/flink/ml/examples/recommendation/SwingExample.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software

[jira] [Closed] (FLINK-30969) Pyflink table example throws "module 'pandas' has no attribute 'Int8Dtype'"

2023-02-12 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-30969. --- Fix Version/s: (was: 1.18.0) Assignee: Juntao Hu Resolution: Fixed Fixed in: - master

[GitHub] [flink] dianfu closed pull request #21899: [FLINK-30969][Python] Fix pandas error when running table example

2023-02-12 Thread via GitHub
dianfu closed pull request #21899: [FLINK-30969][Python] Fix pandas error when running table example URL: https://github.com/apache/flink/pull/21899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] fsk119 commented on pull request #21500: [FLINK-27995][table] Upgrade Janino version

2023-02-12 Thread via GitHub
fsk119 commented on PR #21500: URL: https://github.com/apache/flink/pull/21500#issuecomment-1427291971 @snuyanzin I am not familiar with janino... I think you may need to find others to review this. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-31025: -- Description: This ticket aims for verifying FLINK-30650: Introduce EXPLAIN PLAN_ADVICE to provide

[jira] [Closed] (FLINK-30981) explain_sql throws java method not exist

2023-02-12 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-30981. --- Fix Version/s: (was: 1.18.0) Assignee: Juntao Hu Resolution: Fixed Fixed in: - master

[GitHub] [flink] dianfu closed pull request #21903: [FLINK-30981][Python] Fix explain_sql throws method not exist

2023-02-12 Thread via GitHub
dianfu closed pull request #21903: [FLINK-30981][Python] Fix explain_sql throws method not exist URL: https://github.com/apache/flink/pull/21903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-table-store] liming30 commented on pull request #519: [FLINK-31008] Fix the bug that ContinuousFileSplitEnumerator may be out of order when allocating splits.

2023-02-12 Thread via GitHub
liming30 commented on PR #519: URL: https://github.com/apache/flink-table-store/pull/519#issuecomment-1427286817 @JingsongLi Thanks for your comments, it has been resolved, please help to review again. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-29566) Reschedule the cleanup logic if cancel job failed

2023-02-12 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687686#comment-17687686 ] Shipeng Xie commented on FLINK-29566: - Hi [~haoxin], did you start working on this issue? If not, I

[GitHub] [flink] fredia commented on pull request #21858: [FLINK-30729][state/changelog] Refactor checkState() to WARN of StateChangelogWriter to avoid confusing IllegalException

2023-02-12 Thread via GitHub
fredia commented on PR #21858: URL: https://github.com/apache/flink/pull/21858#issuecomment-1427268488 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-31025: -- Description: This ticket aims for verifying FLINK-30650: Adaptive Batch Scheduler should also work

[jira] [Created] (FLINK-31025) Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-12 Thread Jane Chan (Jira)
Jane Chan created FLINK-31025: - Summary: Release Testing: Verify FLINK-30650 Introduce EXPLAIN PLAN_ADVICE to provide SQL advice Key: FLINK-31025 URL: https://issues.apache.org/jira/browse/FLINK-31025

[jira] [Commented] (FLINK-30274) Upgrade commons-collections 3.x to commons-collections4

2023-02-12 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687685#comment-17687685 ] Ran Tao commented on FLINK-30274: - [~martijnvisser] I have updated the pr, PTAL if your are free.

[jira] [Commented] (FLINK-30857) Create table does not create topic with multiple partitions

2023-02-12 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687684#comment-17687684 ] Yao Zhang commented on FLINK-30857: --- Hi [~lzljs3620320] , As the latest hotfix removed managed table

[jira] [Comment Edited] (FLINK-30966) Flink SQL IF FUNCTION logic error

2023-02-12 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687683#comment-17687683 ] Shuiqiang Chen edited comment on FLINK-30966 at 2/13/23 2:51 AM: -

[jira] [Commented] (FLINK-30966) Flink SQL IF FUNCTION logic error

2023-02-12 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687683#comment-17687683 ] Shuiqiang Chen commented on FLINK-30966: [~luoyuxia]The matter of

[jira] [Commented] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-12 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687682#comment-17687682 ] Shuiqiang Chen commented on FLINK-31003: [~luoyuxia] +1 > Flink SQL IF / CASE WHEN Funcation

[jira] [Commented] (FLINK-30486) Make the config documentation generator available to connector repos

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687681#comment-17687681 ] Yufan Sheng commented on FLINK-30486: - I just copied the code from flink-docs and execute in

[jira] [Commented] (FLINK-30627) Refactor FileSystemTableSink to use FileSink instead of StreamingFileSink

2023-02-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687680#comment-17687680 ] Yuxin Tan commented on FLINK-30627: --- [~martijnvisser] Sorry that I underestimated the complexity of

[jira] [Updated] (FLINK-30969) Pyflink table example throws "module 'pandas' has no attribute 'Int8Dtype'"

2023-02-12 Thread Juntao Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juntao Hu updated FLINK-30969: -- Fix Version/s: (was: 1.15.4) (was: 1.16.2) Affects Version/s:

[jira] [Commented] (FLINK-30966) Flink SQL IF FUNCTION logic error

2023-02-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687676#comment-17687676 ] luoyuxia commented on FLINK-30966: -- Seems same to FLINK-31003?  > Flink SQL IF FUNCTION logic error >

[jira] [Comment Edited] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687674#comment-17687674 ] luoyuxia edited comment on FLINK-31003 at 2/13/23 2:36 AM: --- Hi, everyone. For

[jira] [Commented] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687674#comment-17687674 ] luoyuxia commented on FLINK-31003: -- Hi, everyone. For me,  it seems the same issue of FLINK-30559. Is

[jira] [Updated] (FLINK-30292) Better support for conversion between DataType and TypeInformation

2023-02-12 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-30292: Fix Version/s: 1.18.0 > Better support for conversion between DataType and TypeInformation >

[jira] [Commented] (FLINK-30703) PulsarOrderedPartitionSplitReaderTest>PulsarPartitionSplitReaderTestBase.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition fails

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687673#comment-17687673 ] Yufan Sheng commented on FLINK-30703: - After debugging with Pulsar developers, we still can't

[jira] [Commented] (FLINK-31006) job is not finished when using pipeline mode to run bounded source like kafka/pulsar

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687671#comment-17687671 ] Yufan Sheng commented on FLINK-31006: - No more splits is only used in Pulsar connector for

[jira] [Comment Edited] (FLINK-28505) Pulsar sink doesn't support topic auto creation

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687669#comment-17687669 ] Yufan Sheng edited comment on FLINK-28505 at 2/13/23 2:25 AM: -- [~tison] Can

[jira] [Commented] (FLINK-28351) Pulsar Sink should support dynamic generated topic from record

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687670#comment-17687670 ] Yufan Sheng commented on FLINK-28351: - [~tison] Where is the release note? I can't see the link. >

[jira] [Commented] (FLINK-28505) Pulsar sink doesn't support topic auto creation

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687669#comment-17687669 ] Yufan Sheng commented on FLINK-28505: - [~Tison] Can you help me close this issue? It's fixed in

[jira] [Updated] (FLINK-30969) Pyflink table example throws "module 'pandas' has no attribute 'Int8Dtype'"

2023-02-12 Thread Juntao Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juntao Hu updated FLINK-30969: -- Fix Version/s: 1.15.4 1.16.2 Affects Version/s: 1.16.1

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-02-12 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687668#comment-17687668 ] Yanfei Lei commented on FLINK-29825: Thanks for taking the time to review the evaluation results.

[jira] [Commented] (FLINK-31006) job is not finished when using pipeline mode to run bounded source like kafka/pulsar

2023-02-12 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687666#comment-17687666 ] Yufan Sheng commented on FLINK-31006: - Hi [~jackylau], can you give me a clear reproduce steps on

[jira] [Commented] (FLINK-31003) Flink SQL IF / CASE WHEN Funcation incorrect

2023-02-12 Thread weiqinpan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687663#comment-17687663 ] weiqinpan commented on FLINK-31003: --- BTW, CASE WHEN + IFNULL also have logic problem. > Flink SQL IF

[GitHub] [flink-table-store] FangYongs commented on a diff in pull request #522: [FLINK-30979] Support shuffling data by partition

2023-02-12 Thread via GitHub
FangYongs commented on code in PR #522: URL: https://github.com/apache/flink-table-store/pull/522#discussion_r1103924487 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -69,6 +69,13 @@ public class

[GitHub] [flink] swuferhong commented on pull request #21900: [FLINK-30971][table-runtime] Modify the default value of parameter 'table.exec.local-hash-agg.adaptive.sampling-threshold'

2023-02-12 Thread via GitHub
swuferhong commented on PR #21900: URL: https://github.com/apache/flink/pull/21900#issuecomment-1427203536 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-30967) Add MongoDB connector documentation

2023-02-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30967: --- Labels: pull-request-available (was: ) > Add MongoDB connector documentation >

[GitHub] [flink-connector-mongodb] Jiabao-Sun opened a new pull request, #2: [FLINK-30967][doc] Add MongoDB connector documentation

2023-02-12 Thread via GitHub
Jiabao-Sun opened a new pull request, #2: URL: https://github.com/apache/flink-connector-mongodb/pull/2 ## What is the purpose of the change Add MongoDB connector documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] SwimSweet commented on pull request #20779: [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema.

2023-02-12 Thread via GitHub
SwimSweet commented on PR #20779: URL: https://github.com/apache/flink/pull/20779#issuecomment-1427078636 @wangyang0918 Please take a look..thx.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #530: [FLINK-30757] Upgrade busybox version to a pinned version for operator

2023-02-12 Thread via GitHub
gaborgsomogyi commented on code in PR #530: URL: https://github.com/apache/flink-kubernetes-operator/pull/530#discussion_r1103821473 ## e2e-tests/utils.sh: ## @@ -175,20 +175,33 @@ function debug_and_show_logs { echo "Flink logs:" kubectl get pods -o

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #530: [FLINK-30757] Upgrade busybox version to a pinned version for operator

2023-02-12 Thread via GitHub
gaborgsomogyi commented on PR #530: URL: https://github.com/apache/flink-kubernetes-operator/pull/530#issuecomment-1427056226 > Hi @gyfora @gaborgsomogyi , the pipeline checks with 1.35.0 busybox version passed. Should we wait for https://github.com/docker-library/busybox/issues/162 to be

[GitHub] [flink] jadireddi commented on pull request #21594: [FLINK-30483] [Formats] [Avro] Add avro format support for TIMESTAMP_LTZ

2023-02-12 Thread via GitHub
jadireddi commented on PR #21594: URL: https://github.com/apache/flink/pull/21594#issuecomment-1427037558 Thank you @dawidwys @liuml07 for the review. Will make changes as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-30519) Add e2e tests for operator dynamic config

2023-02-12 Thread haiqingchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687572#comment-17687572 ] haiqingchen commented on FLINK-30519: -  Hi [~gyfora]  could you assign this ticket to me? I'd like

[GitHub] [flink-connector-pulsar] syhily commented on pull request #25: [FLINK-30606][Connector/Pulsar] Bump the pulsar-client-all to latest 2.11.0.

2023-02-12 Thread via GitHub
syhily commented on PR #25: URL: https://github.com/apache/flink-connector-pulsar/pull/25#issuecomment-1427018099 ``` 2023-02-12T12:00:08.6685939Z [10.449s][error][gc] Failed to commit memory (Not enough space) 2023-02-12T12:00:08.6686284Z [19.855s][error][gc] Forced to lower max

[GitHub] [flink-connector-pulsar] syhily commented on pull request #25: [FLINK-30606][Connector/Pulsar] Bump the pulsar-client-all to latest 2.11.0.

2023-02-12 Thread via GitHub
syhily commented on PR #25: URL: https://github.com/apache/flink-connector-pulsar/pull/25#issuecomment-1426990810 This PR is completed on top of #24, we will rebase it until the #24 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] lindong28 commented on a diff in pull request #21589: [FLINK-25509][connector-base/connector-kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-02-12 Thread via GitHub
lindong28 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1103753156 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java: ## @@ -479,6 +486,134 @@ public