[jira] [Commented] (FLINK-23352) Collect Sink Operator Factory does not support to configure max bytes per batch

2023-05-16 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723349#comment-17723349 ] Xin Chen commented on FLINK-23352: -- Thank you for above comments,but I still hava a question. Is there

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195949292 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java: ## @@ -66,6 +76,13 @@ public static Throwable handleMissingThrowable(@Nullable

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22560: [FLINK-32023][API / DataStream] Support negative Duration for special usage, such as -1ms for execution.buffer-timeout

2023-05-16 Thread via GitHub
1996fanrui commented on code in PR #22560: URL: https://github.com/apache/flink/pull/22560#discussion_r1195929472 ## flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java: ## @@ -92,6 +92,17 @@ public class ExecutionOptions {

[GitHub] [flink] WencongLiu commented on pull request #22596: [FLINK-32112][docus] Fixed State Backend sample config in zh-doc

2023-05-16 Thread via GitHub
WencongLiu commented on PR #22596: URL: https://github.com/apache/flink/pull/22596#issuecomment-1550719602 Thanks for the changes @xmzhou00 . LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195913384 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java: ## @@ -39,6 +44,10 @@ public class ErrorInfo implements Serializable {

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195913556 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandlerTest.java: ## @@ -59,17 +64,25 @@ class

[jira] [Updated] (FLINK-32075) Delete merged files on checkpoint abort or subsumption

2023-05-16 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-32075: Summary: Delete merged files on checkpoint abort or subsumption (was: Delete merged files on

[jira] [Updated] (FLINK-32071) Implement the snapshot manager for merged checkpoint files in TM

2023-05-16 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-32071: Labels: pull-request-available (was: ) > Implement the snapshot manager for merged checkpoint

[jira] [Commented] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread Xianming Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723335#comment-17723335 ] Xianming Zhou commented on FLINK-32112: --- Hi [~Wencong Liu]  ,Thank you for your reply. I have made

[jira] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread Xianming Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32112 ] Xianming Zhou deleted comment on FLINK-32112: --- was (Author: JIRAUSER300268): Hi [~Wencong Liu] ,Thank you for your recovery. I have made changes to the document and created a Pull

[jira] [Updated] (FLINK-32115) json_value support cache

2023-05-16 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-32115: -- Description:

[jira] [Updated] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread Xianming Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xianming Zhou updated FLINK-32112: -- External issue URL: (was: https://github.com/apache/flink/pull/22596) > Fixed State Backend

[jira] [Updated] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread Xianming Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xianming Zhou updated FLINK-32112: -- External issue URL: https://github.com/apache/flink/pull/22596 > Fixed State Backend sample

[jira] [Updated] (FLINK-32114) Extend FailureEnricherContext with task specific fields

2023-05-16 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-32114: --- Description: On task failures, context would be nice to include extra

[jira] [Updated] (FLINK-32114) Make FailureEnricherContext more flexible and include task specific fields

2023-05-16 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-32114: --- Summary: Make FailureEnricherContext more flexible and include task

[jira] [Commented] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread Xianming Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1772#comment-1772 ] Xianming Zhou commented on FLINK-32112: --- Hi [~Wencong Liu] ,Thank you for your recovery. I have

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195894111 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandler.java: ## @@ -51,22 +57,35 @@ public class

[jira] [Created] (FLINK-32115) json_value support cache

2023-05-16 Thread xiaogang zhou (Jira)
xiaogang zhou created FLINK-32115: - Summary: json_value support cache Key: FLINK-32115 URL: https://issues.apache.org/jira/browse/FLINK-32115 Project: Flink Issue Type: Improvement

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195892521 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/exceptionhistory/ExceptionHistoryEntry.java: ## @@ -63,21 +66,27 @@ public static

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195887716 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -167,9 +171,31 @@ protected DefaultScheduler(

[jira] [Created] (FLINK-32114) Extend FailureEnricherContext with task specific fields

2023-05-16 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-32114: -- Summary: Extend FailureEnricherContext with task specific fields Key: FLINK-32114 URL: https://issues.apache.org/jira/browse/FLINK-32114 Project:

[jira] [Commented] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723330#comment-17723330 ] Wencong Liu commented on FLINK-32112: - Helllo [~xmzhou] , Thanks for your proposal. Currently, the

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195886436 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -295,7 +300,7 @@ void initializeVerticesIfPossible()

[jira] [Updated] (FLINK-31893) Introduce AdaptiveBatchScheduler failure enrichment/labeling

2023-05-16 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31893: --- Description: See discussion:

[GitHub] [flink] WencongLiu commented on a diff in pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-05-16 Thread via GitHub
WencongLiu commented on code in PR #22579: URL: https://github.com/apache/flink/pull/22579#discussion_r1195876258 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/LookupJoinITCase.scala: ## @@ -301,28 +374,46 @@ class

[GitHub] [flink] WencongLiu commented on a diff in pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-05-16 Thread via GitHub
WencongLiu commented on code in PR #22579: URL: https://github.com/apache/flink/pull/22579#discussion_r1195873787 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala: ## @@ -130,12 +136,14 @@ class

[GitHub] [flink] luoyuxia commented on pull request #22525: [FLINK-32001][table] Row-level update should support returning partial columns

2023-05-16 Thread via GitHub
luoyuxia commented on PR #22525: URL: https://github.com/apache/flink/pull/22525#issuecomment-1550611212 @fsk119 Thanks for reviewing again. Address your comments in [19c680d|https://github.com/apache/flink/pull/22525/commits/19c680d1896c1424efd423645b33d2f179ae0304\ -- This is an

[GitHub] [flink] luoyuxia commented on a diff in pull request #22525: [FLINK-32001][table] Row-level update should support returning partial columns

2023-05-16 Thread via GitHub
luoyuxia commented on code in PR #22525: URL: https://github.com/apache/flink/pull/22525#discussion_r1195872817 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java: ## @@ -647,15 +649,51 @@ private

[GitHub] [flink] reswqa commented on pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa commented on PR #22598: URL: https://github.com/apache/flink/pull/22598#issuecomment-1550609875 Not sure if there's a simpler/more elegant way, @XComp do you have any other thoughts 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] flinkbot commented on pull request #22599: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-16 Thread via GitHub
flinkbot commented on PR #22599: URL: https://github.com/apache/flink/pull/22599#issuecomment-1550607621 ## CI report: * 8712371536af4f520b48c465bd075227f768620d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa commented on pull request #22246: [FLINK-31498][runtime] Only request redundant task manager when all pending slots registered.

2023-05-16 Thread via GitHub
reswqa commented on PR #22246: URL: https://github.com/apache/flink/pull/22246#issuecomment-1550604870 @flinkbot run azur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] whjshj opened a new pull request, #22599: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-16 Thread via GitHub
whjshj opened a new pull request, #22599: URL: https://github.com/apache/flink/pull/22599 …ggregation ## What is the purpose of the change Solve the problem of initializing default values for LagAggFunction ## Brief change log - *Judge whether the

[jira] [Updated] (FLINK-32053) Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

2023-05-16 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32053: -- Labels: pull-request-available (was: ) > Introduce StateMetadata to ExecNode to support configure

[GitHub] [flink] whjshj closed pull request #22580: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-16 Thread via GitHub
whjshj closed pull request #22580: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA… URL: https://github.com/apache/flink/pull/22580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] whjshj commented on pull request #22580: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-16 Thread via GitHub
whjshj commented on PR #22580: URL: https://github.com/apache/flink/pull/22580#issuecomment-1550596872 > Solving the Initial Value Problem of LagAggregation > > ## What is the purpose of the change > Set the defaultValue of lagFunction to nullable > > ## Brief change log

[GitHub] [flink] luoyuxia commented on a diff in pull request #22525: [FLINK-32001][table] Row-level update should support returning partial columns

2023-05-16 Thread via GitHub
luoyuxia commented on code in PR #22525: URL: https://github.com/apache/flink/pull/22525#discussion_r1195861072 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/sink/RowLevelDeleteSpec.java: ## @@ -78,6 +87,11 @@ public

[GitHub] [flink] fsk119 commented on a diff in pull request #22525: [FLINK-32001][table] Row-level update should support returning partial columns

2023-05-16 Thread via GitHub
fsk119 commented on code in PR #22525: URL: https://github.com/apache/flink/pull/22525#discussion_r1195847470 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/sink/RowLevelDeleteSpec.java: ## @@ -78,6 +87,11 @@ public

[jira] [Resolved] (FLINK-31882) SqlGateway will throw exception when executing DeleteFromFilterOperation

2023-05-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-31882. -- Fix Version/s: 1.18.0 1.17.1 Resolution: Fixed master:

[GitHub] [flink] luoyuxia commented on pull request #22581: [FLINK-31413][hive] Change scope of flink-table-planner dependency from provided to test in Hive connector

2023-05-16 Thread via GitHub
luoyuxia commented on PR #22581: URL: https://github.com/apache/flink/pull/22581#issuecomment-1550558585 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-31946) DynamoDB Sink Allow Multiple Item Writes

2023-05-16 Thread Curtis Jensen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723272#comment-17723272 ] Curtis Jensen commented on FLINK-31946: --- I re-evaluated the GSI option. I think the cost may be

[jira] [Commented] (FLINK-31661) Add parity between `ROW` value function and it's type declaration

2023-05-16 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723266#comment-17723266 ] Sergey Nuyanzin commented on FLINK-31661: - it seems in spark it is called {{named_struct}}

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #603: [FLINK-32111] - Add Null check for checkpoints history obj

2023-05-16 Thread via GitHub
morhidi commented on code in PR #603: URL: https://github.com/apache/flink-kubernetes-operator/pull/603#discussion_r1195618058 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/NativeFlinkServiceTest.java: ## @@ -307,6 +308,30 @@ public

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-16 Thread via GitHub
jbusche commented on PR #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600#issuecomment-1550186662 Looks good on OpenShift with OLM and also with the regular helm install: ``` oc get pods NAME READY

[GitHub] [flink] zhuzhurk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
zhuzhurk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195539179 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandler.java: ## @@ -51,22 +57,35 @@ public class

[GitHub] [flink] zhuzhurk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
zhuzhurk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195539179 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandler.java: ## @@ -51,22 +57,35 @@ public class

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #603: [FLINK-32111] - Add NPE check for checkpoints history obj

2023-05-16 Thread via GitHub
morhidi commented on PR #603: URL: https://github.com/apache/flink-kubernetes-operator/pull/603#issuecomment-1550142228 Thanks for taking a stab at this @tamirsagi. Could you please address the formatting issues? Hint: run `mvn spotless:apply` The CI/CD pipeline fails with this: ```

[GitHub] [flink] reswqa commented on a diff in pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa commented on code in PR #22598: URL: https://github.com/apache/flink/pull/22598#discussion_r1195480981 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityRecoverFromSavepointITCase.java: ## @@ -63,12 +64,16 @@ import

[jira] [Comment Edited] (FLINK-31946) DynamoDB Sink Allow Multiple Item Writes

2023-05-16 Thread Curtis Jensen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723237#comment-17723237 ] Curtis Jensen edited comment on FLINK-31946 at 5/16/23 5:52 PM: Hello

[jira] [Commented] (FLINK-31946) DynamoDB Sink Allow Multiple Item Writes

2023-05-16 Thread Curtis Jensen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723237#comment-17723237 ] Curtis Jensen commented on FLINK-31946: --- Hello [~liangtl]  Thank you for the reply. To better

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-16 Thread via GitHub
jbusche commented on PR #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600#issuecomment-1550101538 Testing now, both with helm installs (OpenShift and regular Kubernetes) and OLM installs. Will post results. -- This is an automated message from the Apache Git

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-16 Thread via GitHub
jbusche commented on PR #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600#issuecomment-1550096776 Sure @mbalassi, I'll re-test it again to make sure... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] reswqa commented on a diff in pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa commented on code in PR #22598: URL: https://github.com/apache/flink/pull/22598#discussion_r1195491972 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityRecoverFromSavepointITCase.java: ## @@ -63,12 +64,16 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa commented on code in PR #22598: URL: https://github.com/apache/flink/pull/22598#discussion_r1195480981 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityRecoverFromSavepointITCase.java: ## @@ -63,12 +64,16 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa commented on code in PR #22598: URL: https://github.com/apache/flink/pull/22598#discussion_r1195480981 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityRecoverFromSavepointITCase.java: ## @@ -63,12 +64,16 @@ import

[jira] [Resolved] (FLINK-32102) Aggregate multiple pendingRecords metric per source if present

2023-05-16 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-32102. Resolution: Fixed > Aggregate multiple pendingRecords metric per source if

[jira] [Resolved] (FLINK-32100) Max parallelism is incorrectly calculated with multiple topics

2023-05-16 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-32100. Resolution: Fixed > Max parallelism is incorrectly calculated with multiple

[GitHub] [flink] flinkbot commented on pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
flinkbot commented on PR #22598: URL: https://github.com/apache/flink/pull/22598#issuecomment-1550074506 ## CI report: * 26d154d7ed299895a86b43667072b48630bd9c28 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa commented on a diff in pull request #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa commented on code in PR #22598: URL: https://github.com/apache/flink/pull/22598#discussion_r1195476076 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesExtension.java: ## @@ -22,40 +22,54 @@ import

[GitHub] [flink-kubernetes-operator] mxm merged pull request #597: [FLINK-32100] Use the total number of Kafka partitions as the max source parallelism

2023-05-16 Thread via GitHub
mxm merged PR #597: URL: https://github.com/apache/flink-kubernetes-operator/pull/597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-32113) TtlMapStateAllEntriesTestContext failure in generic types

2023-05-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723209#comment-17723209 ] Matthias Pohl commented on FLINK-32113: --- Similar error was reported in FLINK-23982. >

[jira] [Created] (FLINK-32113) TtlMapStateAllEntriesTestContext failure in generic types

2023-05-16 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32113: - Summary: TtlMapStateAllEntriesTestContext failure in generic types Key: FLINK-32113 URL: https://issues.apache.org/jira/browse/FLINK-32113 Project: Flink

[jira] [Commented] (FLINK-32109) Operator doesn't recognize JobManager stuck on volumeMount startup errors

2023-05-16 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723208#comment-17723208 ] Thomas Weise commented on FLINK-32109: -- [~gyfora] if the issue can be corrected externally and

[GitHub] [flink] reswqa opened a new pull request, #22598: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-05-16 Thread via GitHub
reswqa opened a new pull request, #22598: URL: https://github.com/apache/flink/pull/22598 ## What is the purpose of the change *KubernetesExtension implements BeforeAllCallback which calls the assumeThat in the @BeforeAll context. assumeThat doesn't work properly in the @BeforeAll

[GitHub] [flink] dmvk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
dmvk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195453154 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -295,7 +300,7 @@ void initializeVerticesIfPossible() {

[jira] [Updated] (FLINK-32030) SQL Client gateway mode should accept URLs

2023-05-16 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise updated FLINK-32030: - Fix Version/s: 1.18.0 > SQL Client gateway mode should accept URLs >

[jira] [Resolved] (FLINK-32030) SQL Client gateway mode should accept URLs

2023-05-16 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise resolved FLINK-32030. -- Resolution: Fixed > SQL Client gateway mode should accept URLs >

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #597: [FLINK-32100] Use the total number of Kafka partitions as the max source parallelism

2023-05-16 Thread via GitHub
mxm commented on PR #597: URL: https://github.com/apache/flink-kubernetes-operator/pull/597#issuecomment-1550041077 I agree, probably makes sense to disable key group alignment for sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #598: [FLINK-32102] Aggregate multiple pendingRecords metric per source if present

2023-05-16 Thread via GitHub
mxm commented on PR #598: URL: https://github.com/apache/flink-kubernetes-operator/pull/598#issuecomment-1550030784 This is a fix for https://cwiki.apache.org/confluence/display/FLINK/FLIP-246%3A+Multi+Cluster+Kafka+Source which we already use internally. It exposes multiple pending

[GitHub] [flink] tweise merged pull request #22556: [FLINK-32030][sql-client] Add URLs support for SQL Client gateway mode

2023-05-16 Thread via GitHub
tweise merged PR #22556: URL: https://github.com/apache/flink/pull/22556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #597: [FLINK-32100] Use the total number of Kafka partitions as the max source parallelism

2023-05-16 Thread via GitHub
mxm commented on PR #597: URL: https://github.com/apache/flink-kubernetes-operator/pull/597#issuecomment-1550025309 For reference:

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #597: [FLINK-32100] Use the total number of Kafka partitions as the max source parallelism

2023-05-16 Thread via GitHub
mxm commented on PR #597: URL: https://github.com/apache/flink-kubernetes-operator/pull/597#issuecomment-1550024389 We don't know how many divisors the number of partitions of a topic has. Similarly, we don't know how how many divisors the sum of the number of partitions of all topics

[GitHub] [flink] dmvk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
dmvk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195440132 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java: ## @@ -39,6 +44,10 @@ public class ErrorInfo implements Serializable {

[jira] [Commented] (FLINK-31970) "Key group 0 is not in KeyGroupRange" when using CheckpointedFunction

2023-05-16 Thread Yordan Pavlov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723194#comment-17723194 ] Yordan Pavlov commented on FLINK-31970: --- First and foremost thank you for your input [~pnowojski] 

[GitHub] [flink-kubernetes-operator] tamirsagi opened a new pull request, #603: FLINK-32111 - Add NPE check for checkpoints history obj

2023-05-16 Thread via GitHub
tamirsagi opened a new pull request, #603: URL: https://github.com/apache/flink-kubernetes-operator/pull/603 ## What is the purpose of the change Fix NPE while observing Savepoint info. ## Brief change log - Add NPE check ## Verifying this change

[GitHub] [flink] dmvk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
dmvk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195425478 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java: ## @@ -39,6 +44,10 @@ public class ErrorInfo implements Serializable {

[jira] (FLINK-32053) Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

2023-05-16 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32053 ] Jane Chan deleted comment on FLINK-32053: --- was (Author: qingyue): Wait for FLINK-32064 to be merged > Introduce StateMetadata to ExecNode to support configure operator-level state > TTL via

[jira] [Closed] (FLINK-31917) Loss of Idempotence in JsonSerDe Round Trip for AggregateCall and RexNode

2023-05-16 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-31917. - Resolution: Fixed Merged into master: 333e023196d90d265c286632f8c01c41b8911ef8 > Loss of Idempotence

[GitHub] [flink] dmvk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-16 Thread via GitHub
dmvk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1195405513 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailureHandlingResult.java: ## @@ -204,13 +226,15 @@ public static

[jira] [Closed] (FLINK-31884) Upgrade ExecNode to new version causes the old serialized plan failed to pass Json SerDe round trip

2023-05-16 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-31884. - Resolution: Fixed Fixed in master: 3664609c7622ccae80e36e85099a1b79b5935fe9 > Upgrade ExecNode to new

[GitHub] [flink] flinkbot commented on pull request #22597: [FLINK-32110][python]Fix the native memory leak when using time window in Pyflink thread mode.

2023-05-16 Thread via GitHub
flinkbot commented on PR #22597: URL: https://github.com/apache/flink/pull/22597#issuecomment-1549986058 ## CI report: * 2958200b05e7c22e6198cf050313254d87229565 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LuoYunjun opened a new pull request, #22597: [FLINK-32110][python]Fix the native memory leak when using time window in Pyflink thread mode.

2023-05-16 Thread via GitHub
LuoYunjun opened a new pull request, #22597: URL: https://github.com/apache/flink/pull/22597 ## What is the purpose of the change *This pull request will fix the native memory leak of time window in Pyflink thread mode* ## Brief change log - *Redundant on

[GitHub] [flink] flinkbot commented on pull request #22596: .[FLINK-32112][docus] Fixed State Backend sample config in zh-doc

2023-05-16 Thread via GitHub
flinkbot commented on PR #22596: URL: https://github.com/apache/flink/pull/22596#issuecomment-1549956904 ## CI report: * 4a27aac49146da3f55f58b7147a3be4a6ef2c76f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-31663) Add ARRAY_EXCEPT supported in SQL & Table API

2023-05-16 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-31663: Assignee: Bonnie Varghese > Add ARRAY_EXCEPT supported in SQL & Table API >

[GitHub] [flink] xmzhou00 opened a new pull request, #22596: .[FLINK-32112][docus] Fixed State Backend sample config in zh-doc

2023-05-16 Thread via GitHub
xmzhou00 opened a new pull request, #22596: URL: https://github.com/apache/flink/pull/22596 ## What is the purpose of the change This pull request fixed State Backend sample config error in zh-doc ## Brief change log update State Backends configuration in

[jira] [Updated] (FLINK-32110) TM native memory leak when using time window in Pyflink ThreadMode

2023-05-16 Thread Yunjun Luo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunjun Luo updated FLINK-32110: --- Summary: TM native memory leak when using time window in Pyflink ThreadMode (was: TM native memory

[jira] [Created] (FLINK-32112) Fixed State Backend sample config in zh-doc

2023-05-16 Thread ZhouXianming (Jira)
ZhouXianming created FLINK-32112: Summary: Fixed State Backend sample config in zh-doc Key: FLINK-32112 URL: https://issues.apache.org/jira/browse/FLINK-32112 Project: Flink Issue Type:

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #597: [FLINK-32100] Use the total number of Kafka partitions as the max source parallelism

2023-05-16 Thread via GitHub
gyfora commented on PR #597: URL: https://github.com/apache/flink-kubernetes-operator/pull/597#issuecomment-1549875653 My only concern here is that we might get into a situation where the sum(partitions) does not have many divisors and will trigger a big scaleup of the source. I

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723166#comment-17723166 ] Gyula Fora commented on FLINK-32012: I agree [~nfraison.datadog] it should be possible to unify

[jira] [Commented] (FLINK-32111) Replacing cluster in failed state with a new one failed

2023-05-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723165#comment-17723165 ] Gyula Fora commented on FLINK-32111: [~tamirsagi] would you be interested in providing a simple fix

[jira] [Updated] (FLINK-32111) Replacing cluster in failed state with a new one failed

2023-05-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-32111: --- Affects Version/s: kubernetes-operator-1.5.0 kubernetes-operator-1.6.0 >

[jira] [Commented] (FLINK-32111) Replacing cluster in failed state with a new one failed

2023-05-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723164#comment-17723164 ] Gyula Fora commented on FLINK-32111: I have seen this issue once in the past, could be that some

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-16 Thread Aleksandr Iushmanov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723162#comment-17723162 ] Aleksandr Iushmanov commented on FLINK-32069: - {quote}I'm missing the path, though, where we

[jira] [Updated] (FLINK-32111) Replacing cluster in failed state with a new one failed

2023-05-16 Thread Tamir Sagi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamir Sagi updated FLINK-32111: --- Description: I deployed a problematic cluster(HA enabled with 3 JMs) to check cluster updates

[jira] [Created] (FLINK-32111) Replacing cluster in failed state with a new one failed

2023-05-16 Thread Tamir Sagi (Jira)
Tamir Sagi created FLINK-32111: -- Summary: Replacing cluster in failed state with a new one failed Key: FLINK-32111 URL: https://issues.apache.org/jira/browse/FLINK-32111 Project: Flink Issue

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-16 Thread Aleksandr Iushmanov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723161#comment-17723161 ] Aleksandr Iushmanov commented on FLINK-32069: - {quote}Does that sound reasonable?{quote} Oh,

[jira] [Updated] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-16 Thread Aleksandr Iushmanov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Iushmanov updated FLINK-32069: Affects Version/s: (was: 1.16.1) > jobClient.getJobStatus() can return status

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-16 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723156#comment-17723156 ] Nicolas Fraison commented on FLINK-32012: - I'd like to have your feeling on the first approach

[jira] [Updated] (FLINK-32110) TM native memory leak when use time window in Pyflink ThreadMode

2023-05-16 Thread Yunjun Luo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunjun Luo updated FLINK-32110: --- Description: If job use time window in Pyflink thread mode, TM native memory will grow slowly

[GitHub] [flink] XComp commented on pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver and regis

2023-05-16 Thread via GitHub
XComp commented on PR #22380: URL: https://github.com/apache/flink/pull/22380#issuecomment-1549810465 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-31963) java.lang.ArrayIndexOutOfBoundsException when scaling down with unaligned checkpoints

2023-05-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-31963: --- Fix Version/s: 1.16.2 1.18.0 1.17.1 >

  1   2   3   >