[jira] [Commented] (FLINK-32721) agg max/min supports char type

2023-11-07 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783908#comment-17783908 ] Yao Zhang commented on FLINK-32721: --- Hi Community,   It seems that there is a contradiction in what

Re: [PR] [FLINK-32993][table] Datagen connector handles fixed-length data types according to the original definition by default [flink]

2023-11-07 Thread via GitHub
liyubin117 commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1801248024 @LadyForest Hi, we just need to modify few codes to implement the feature, now CI has succeed, Looking forward your review, thanks! -- This is an automated message from the Apache

[jira] [Commented] (FLINK-33437) Flink 1.17 sink commited legacy Committable state, but it was not removed from state backend

2023-11-07 Thread Yuchi Duan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783903#comment-17783903 ] Yuchi Duan commented on FLINK-33437: [~masteryhx] I have submitted the PR, can you help me review

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-07 Thread via GitHub
jm-paulin commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1801222447 @tzulitai I sent an email to the dev flink mailing list, but apparently no-one picked it. Is there a dedicated list for the connectors? -- This is an automated message

[jira] [Closed] (FLINK-31242) Correct the definition of creating functions in the SQL client documentation

2023-11-07 Thread Xianxun Ye (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xianxun Ye closed FLINK-31242. -- Resolution: Duplicate > Correct the definition of creating functions in the SQL client documentation

[jira] [Commented] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-07 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783896#comment-17783896 ] Jonas Weile commented on FLINK-33466: - See the following issues for the same problem: [FLINK-31006]

[jira] [Comment Edited] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-07 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783896#comment-17783896 ] Jonas Weile edited comment on FLINK-33466 at 11/8/23 6:49 AM: -- See the

[jira] [Comment Edited] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-07 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783896#comment-17783896 ] Jonas Weile edited comment on FLINK-33466 at 11/8/23 6:49 AM: -- See the

Re: [PR] [FLINK-29153][connector/kafka] Retry KafkaConsumer#commitAsync on WakeupException in KafkaConsumerThread [flink]

2023-11-07 Thread via GitHub
PatrickRen commented on PR #20764: URL: https://github.com/apache/flink/pull/20764#issuecomment-1801185234 @ngannt1710 Please use the Flink user mailing list (u...@flink.apache.org) to get supports. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23676: URL: https://github.com/apache/flink/pull/23676#issuecomment-1801174911 > I think this is not true after [FLINK-23654](https://issues.apache.org/jira/browse/FLINK-23654) resolved. @Myasuka Thanks for the information! However I think it is still valid

[jira] [Commented] (FLINK-20672) notifyCheckpointAborted RPC failure can fail JM

2023-11-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783892#comment-17783892 ] Zakelly Lan commented on FLINK-20672: - [~yunta] I'm afraid this is still valid since the io

[jira] [Commented] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-07 Thread xiang1 yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783891#comment-17783891 ] xiang1 yu commented on FLINK-25538: --- Hi [~mapohl],  I would be interested to work on this one. Could

Re: [PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23683: URL: https://github.com/apache/flink/pull/23683#issuecomment-1801132442 The compile ci passed https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=54430=logs=b59e5554-36c7-5512-ab1a-b80b74075fce=849d419c-1b8f-52b7-e455-d4bc36ec43ad --

Re: [PR] [FLINK-33069]Mysql and Postgres catalog support url extra parameters [flink-connector-jdbc]

2023-11-07 Thread via GitHub
waywtdcc commented on PR #74: URL: https://github.com/apache/flink-connector-jdbc/pull/74#issuecomment-1801124368 > @waywtdcc Why does this need to be an additional parameter? Because sometimes you need to use ?characterEncoding=utf8 similar url parameters to connect to jdbc --

Re: [PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23683: URL: https://github.com/apache/flink/pull/23683#issuecomment-1801096430 Validated via my local compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
masteryhx commented on PR #23683: URL: https://github.com/apache/flink/pull/23683#issuecomment-1801093765 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23683: URL: https://github.com/apache/flink/pull/23683#issuecomment-1801082279 ## CI report: * ccd18bff46c12b69224e125034ba0f3ed22e33e2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23683: URL: https://github.com/apache/flink/pull/23683#issuecomment-1801081508 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23441: URL: https://github.com/apache/flink/pull/23441#issuecomment-1801079127 The spotless check is failed. I openend https://github.com/apache/flink/pull/23683 to fix this. Sorry for the mistake. -- This is an automated message from the Apache Git Service. To

[PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
Zakelly opened a new pull request, #23683: URL: https://github.com/apache/flink/pull/23683 ## What is the purpose of the change Fixing up the https://github.com/apache/flink/pull/23441 since the spotless check is broken. ## Brief change log ## Verifying this change

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-07 Thread via GitHub
xuyangzhong commented on PR #23620: URL: https://github.com/apache/flink/pull/23620#issuecomment-1801019486 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-29153][connector/kafka] Retry KafkaConsumer#commitAsync on WakeupException in KafkaConsumerThread [flink]

2023-11-07 Thread via GitHub
ngannt1710 commented on PR #20764: URL: https://github.com/apache/flink/pull/20764#issuecomment-1800978621 I use FlinkKafkaConsumer with two consumer and two partitions. But the two consumers receive the same message regardless of which partitions it is pushed to. Can you suggest me to

Re: [PR] [hotfix][doc] `FlinkKafkaConsumer` will be removed with Flink 1.17 instead of 1.15 [flink]

2023-11-07 Thread via GitHub
ngannt1710 commented on PR #21181: URL: https://github.com/apache/flink/pull/21181#issuecomment-1800977428 I use FlinkKafkaConsumer with two consumer and two partitions. But the two consumers receive the same message regardless of which partitions it is pushed to. Can you suggest me to

[jira] [Resolved] (FLINK-32737) Add support for Snowflake sink connector

2023-11-07 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohsen Rezaei resolved FLINK-32737. --- Resolution: Fixed > Add support for Snowflake sink connector >

[jira] [Commented] (FLINK-32737) Add support for Snowflake sink connector

2023-11-07 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783876#comment-17783876 ] Mohsen Rezaei commented on FLINK-32737: --- This connector has been open-sourced and the first

[jira] [Updated] (FLINK-32737) Add support for Snowflake sink connector

2023-11-07 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohsen Rezaei updated FLINK-32737: -- Fix Version/s: 1.17.1 > Add support for Snowflake sink connector >

Re: [PR] [FLINK-33206] Verify the existence of hbase table before read/write [flink-connector-hbase]

2023-11-07 Thread via GitHub
Tan-JiaLiang commented on PR #22: URL: https://github.com/apache/flink-connector-hbase/pull/22#issuecomment-1800963553 You are right, the try/catches from both `HBaseRowDataInputFormat#connectToTable()` methods are meaningless. I've fixed and PTAL. -- This is an automated message from

[jira] [Commented] (FLINK-33479) Add Rerouting support to KafkaSink

2023-11-07 Thread Bo Shen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783869#comment-17783869 ] Bo Shen commented on FLINK-33479: - I have encountered a similar situation in JdbcSink a while ago, the

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-07 Thread via GitHub
Zakelly commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1800938033 Hi, @pnowojski @masteryhx Would you please take a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Comment Edited] (FLINK-20672) notifyCheckpointAborted RPC failure can fail JM

2023-11-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783868#comment-17783868 ] Yun Tang edited comment on FLINK-20672 at 11/8/23 3:01 AM: --- [~Zakelly] Thanks

[jira] [Commented] (FLINK-20672) notifyCheckpointAborted RPC failure can fail JM

2023-11-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783868#comment-17783868 ] Yun Tang commented on FLINK-20672: -- [~Zakelly] Thanks for picking up the stale tickets. However, I

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-07 Thread via GitHub
masteryhx commented on code in PR #23239: URL: https://github.com/apache/flink/pull/23239#discussion_r1385899714 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/input/MultiStateKeyIterator.java: ## @@ -46,47 +48,54 @@ public final class

[jira] [Commented] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783866#comment-17783866 ] hansonhe commented on FLINK-33481: -- @[~trohrmann]  or AnyBody Can you or anybody help me to answer my

[jira] [Commented] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2023-11-07 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783865#comment-17783865 ] Qingsheng Ren commented on FLINK-33465: --- [~loserwang1024] Thanks for raising the issue. It looks

Re: [PR] [FLINK-33478][hive] Enable foldExpr by default in filter condition [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23682: URL: https://github.com/apache/flink/pull/23682#issuecomment-1800926621 ## CI report: * 3b3b2097aa9048640f76a67f031e6bc4e884e5dc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-07 Thread via GitHub
masteryhx closed pull request #23441: [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value URL: https://github.com/apache/flink/pull/23441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-33060) Fix the javadoc of ListState.update/addAll about not allowing null value

2023-11-07 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-33060: - Fix Version/s: 1.19.0 > Fix the javadoc of ListState.update/addAll about not allowing null

[jira] [Resolved] (FLINK-33060) Fix the javadoc of ListState.update/addAll about not allowing null value

2023-11-07 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-33060. -- Resolution: Fixed merged e0240c78 into master. > Fix the javadoc of ListState.update/addAll

[jira] [Updated] (FLINK-33060) Fix the javadoc of ListState.update/addAll about not allowing null value

2023-11-07 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-33060: - Component/s: Runtime / State Backends > Fix the javadoc of ListState.update/addAll about not

[jira] [Updated] (FLINK-33478) Fail to call unix_timestamp when it is in filter condition

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33478: --- Labels: pull-request-available (was: ) > Fail to call unix_timestamp when it is in filter

[PR] [FLINK-33478][hive] Enable foldExpr by default in filter condition [flink]

2023-11-07 Thread via GitHub
yunfan123 opened a new pull request, #23682: URL: https://github.com/apache/flink/pull/23682 ## What is the purpose of the change Use foldExpr config as default to fix NPE problem when use unix_timestamp() in filter condition. And it is already the default value in hive project.

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
TanYuxin-tyx commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385872477 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Attachment: image-2023-11-08-10-05-54-694.png > Why were checkpoints stored on zookeeper deleted when

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Attachment: image-2023-11-08-09-57-17-739.png > Why were checkpoints stored on zookeeper deleted when

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-11-07 Thread via GitHub
victor09091 closed pull request #23494: FLINK-30893 Replace not specifying a driver in Minikube by something … URL: https://github.com/apache/flink/pull/23494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Attachment: image-2023-11-08-09-40-59-889.png > Why were checkpoints stored on zookeeper deleted when

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  (1)jobmanager appattempt_1684323088373_1744_01    Tue Oct 31 11:19:07

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  (1)jobmanager appattempt_1684323088373_1744_01    Tue Oct 31 11:19:07

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  appattempt_1684323088373_1744_02    Sat Nov 4 11:10:52 +0800 2023

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Summary: Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Summary: Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High

[jira] [Created] (FLINK-33481) Why were CheckPoints stored on ZooKeeper deleted when use Flink High Availability

2023-11-07 Thread hansonhe (Jira)
hansonhe created FLINK-33481: Summary: Why were CheckPoints stored on ZooKeeper deleted when use Flink High Availability Key: FLINK-33481 URL: https://issues.apache.org/jira/browse/FLINK-33481 Project:

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23681: URL: https://github.com/apache/flink/pull/23681#issuecomment-1800844592 ## CI report: * 7d14168f580690f52bafea6e5be95c2d31f30525 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33480) Implement restore tests for GroupAggregate node

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33480: --- Labels: pull-request-available (was: ) > Implement restore tests for GroupAggregate node >

[PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-11-07 Thread via GitHub
bvarghese1 opened a new pull request, #23681: URL: https://github.com/apache/flink/pull/23681 ## What is the purpose of the change Implement restore tests for GroupAggregate node ## Verifying this change This change added tests and can be verified as follows:

[jira] [Created] (FLINK-33480) Implement restore tests for GroupAggregate node

2023-11-07 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-33480: --- Summary: Implement restore tests for GroupAggregate node Key: FLINK-33480 URL: https://issues.apache.org/jira/browse/FLINK-33480 Project: Flink Issue

[jira] [Commented] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-11-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783827#comment-17783827 ] Danny Cranmer commented on FLINK-33260: --- [~iemre] I have merged the EFO support. Will you be

[jira] [Commented] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-11-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783826#comment-17783826 ] Danny Cranmer commented on FLINK-33260: --- Merged commit

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-11-07 Thread via GitHub
dannycranmer merged PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-11-07 Thread via GitHub
dannycranmer commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1385669429 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/RecoverableErrorsConfig.java: ## @@

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-11-07 Thread via GitHub
dannycranmer commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1385680247 ##

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23680: URL: https://github.com/apache/flink/pull/23680#issuecomment-1800285139 ## CI report: * 5da58a4bacbba7cc2547a7c3acb1b12fb662c667 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33470) Implement restore tests for Join node

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33470: --- Labels: pull-request-available (was: ) > Implement restore tests for Join node >

[PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-07 Thread via GitHub
jnh5y opened a new pull request, #23680: URL: https://github.com/apache/flink/pull/23680 ## What is the purpose of the change Implement restore tests for Join node ## Verifying this change This change added tests and can be verified as follows: * Added restore

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783816#comment-17783816 ] Yaroslav Tkachenko commented on FLINK-29288: Yep, it should work out of the box. That page

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783806#comment-17783806 ] Trystan commented on FLINK-29288: - Thank you! This is exactly what we are trying to do. I thought we had

Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-11-07 Thread via GitHub
snuyanzin commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1799805561 does it make sense to bump to 3.5.1 since there was added support for jdk20+ ? https://issues.apache.org/jira/browse/MSHADE-454 -- This is an automated message

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783773#comment-17783773 ] Yaroslav Tkachenko commented on FLINK-29288: > what is the correct procedure to put job jars

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783755#comment-17783755 ] Trystan commented on FLINK-29288: - With this change, what is the correct procedure to put job jars on

[jira] [Commented] (FLINK-33479) Add Rerouting support to KafkaSink

2023-11-07 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783741#comment-17783741 ] Kevin Tseng commented on FLINK-33479: - can someone assign this to me. we have idea on how this

[jira] [Created] (FLINK-33479) Add Rerouting support to KafkaSink

2023-11-07 Thread Kevin Tseng (Jira)
Kevin Tseng created FLINK-33479: --- Summary: Add Rerouting support to KafkaSink Key: FLINK-33479 URL: https://issues.apache.org/jira/browse/FLINK-33479 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385293460 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
bvarghese1 commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1799279843 > One more thing I just noticed (actually it's also a problem for Calc tests) that we should not put those classes/tests in `org.apache.flink.table.planner.plan.nodes.exec.testutils`.

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
bvarghese1 commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1385277745 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,121 @@ +/* + *

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385277845 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java: ## @@ -0,0 +1,83 @@ +/* + *

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
bvarghese1 commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1385277745 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,121 @@ +/* + *

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385224887 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java: ## @@ -0,0 +1,83 @@ +/* + *

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
dawidwys commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1798988635 One more thing I just noticed (actually it's also a problem for Calc tests) that we should not put those classes/tests in `org.apache.flink.table.planner.plan.nodes.exec.testutils`.

[jira] [Commented] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-07 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783674#comment-17783674 ] Jonas Weile commented on FLINK-33466: - Hi, would appreciate it if any of the committers could have a

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385059368 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/subquery.scala: ## @@ -1,78 +0,0 @@ -/* - * Licensed to the Apache

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385055760 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategy.java: ## @@ -0,0 +1,115 @@ +/* + *

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385029083 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java: ## @@ -242,6 +245,139 @@ public static boolean

[jira] [Updated] (FLINK-12302) Fixed the wrong finalStatus of yarn application when application finished

2023-11-07 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-12302: - Attachment: (was: container_e15_1693914709123_8498_01_01_8042) > Fixed the wrong finalStatus of

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-11-07 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1798607054 @afedulov Is there anything else that you think is needed here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-07 Thread via GitHub
gyfora commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1798603528 Addressed these comments @XComp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   >