[
https://issues.apache.org/jira/browse/FLINK-32721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783908#comment-17783908
]
Yao Zhang commented on FLINK-32721:
---
Hi Community,
It seems that there is a contradiction in what
liyubin117 commented on PR #23678:
URL: https://github.com/apache/flink/pull/23678#issuecomment-1801248024
@LadyForest Hi, we just need to modify few codes to implement the feature,
now CI has succeed, Looking forward your review, thanks!
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/FLINK-33437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783903#comment-17783903
]
Yuchi Duan commented on FLINK-33437:
[~masteryhx] I have submitted the PR, can you help me review
jm-paulin commented on PR #11:
URL:
https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1801222447
@tzulitai I sent an email to the dev flink mailing list, but apparently
no-one picked it. Is there a dedicated list for the connectors?
--
This is an automated message
[
https://issues.apache.org/jira/browse/FLINK-31242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xianxun Ye closed FLINK-31242.
--
Resolution: Duplicate
> Correct the definition of creating functions in the SQL client documentation
[
https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783896#comment-17783896
]
Jonas Weile commented on FLINK-33466:
-
See the following issues for the same problem:
[FLINK-31006]
[
https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783896#comment-17783896
]
Jonas Weile edited comment on FLINK-33466 at 11/8/23 6:49 AM:
--
See the
[
https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783896#comment-17783896
]
Jonas Weile edited comment on FLINK-33466 at 11/8/23 6:49 AM:
--
See the
PatrickRen commented on PR #20764:
URL: https://github.com/apache/flink/pull/20764#issuecomment-1801185234
@ngannt1710 Please use the Flink user mailing list (u...@flink.apache.org)
to get supports. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
Zakelly commented on PR #23676:
URL: https://github.com/apache/flink/pull/23676#issuecomment-1801174911
> I think this is not true after
[FLINK-23654](https://issues.apache.org/jira/browse/FLINK-23654) resolved.
@Myasuka Thanks for the information! However I think it is still valid
[
https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783892#comment-17783892
]
Zakelly Lan commented on FLINK-20672:
-
[~yunta] I'm afraid this is still valid since the io
[
https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783891#comment-17783891
]
xiang1 yu commented on FLINK-25538:
---
Hi [~mapohl], I would be interested to work on this one. Could
Zakelly commented on PR #23683:
URL: https://github.com/apache/flink/pull/23683#issuecomment-1801132442
The compile ci passed
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=54430=logs=b59e5554-36c7-5512-ab1a-b80b74075fce=849d419c-1b8f-52b7-e455-d4bc36ec43ad
--
waywtdcc commented on PR #74:
URL:
https://github.com/apache/flink-connector-jdbc/pull/74#issuecomment-1801124368
> @waywtdcc Why does this need to be an additional parameter?
Because sometimes you need to use ?characterEncoding=utf8 similar url
parameters to connect to jdbc
--
Zakelly commented on PR #23683:
URL: https://github.com/apache/flink/pull/23683#issuecomment-1801096430
Validated via my local compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
masteryhx commented on PR #23683:
URL: https://github.com/apache/flink/pull/23683#issuecomment-1801093765
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flinkbot commented on PR #23683:
URL: https://github.com/apache/flink/pull/23683#issuecomment-1801082279
## CI report:
* ccd18bff46c12b69224e125034ba0f3ed22e33e2 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly commented on PR #23683:
URL: https://github.com/apache/flink/pull/23683#issuecomment-1801081508
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Zakelly commented on PR #23441:
URL: https://github.com/apache/flink/pull/23441#issuecomment-1801079127
The spotless check is failed. I openend
https://github.com/apache/flink/pull/23683 to fix this. Sorry for the mistake.
--
This is an automated message from the Apache Git Service.
To
Zakelly opened a new pull request, #23683:
URL: https://github.com/apache/flink/pull/23683
## What is the purpose of the change
Fixing up the https://github.com/apache/flink/pull/23441 since the spotless
check is broken.
## Brief change log
## Verifying this change
xuyangzhong commented on PR #23620:
URL: https://github.com/apache/flink/pull/23620#issuecomment-1801019486
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ngannt1710 commented on PR #20764:
URL: https://github.com/apache/flink/pull/20764#issuecomment-1800978621
I use FlinkKafkaConsumer with two consumer and two partitions. But the two
consumers receive the same message regardless of which partitions it is pushed
to. Can you suggest me to
ngannt1710 commented on PR #21181:
URL: https://github.com/apache/flink/pull/21181#issuecomment-1800977428
I use FlinkKafkaConsumer with two consumer and two partitions. But the two
consumers receive the same message regardless of which partitions it is pushed
to. Can you suggest me to
[
https://issues.apache.org/jira/browse/FLINK-32737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohsen Rezaei resolved FLINK-32737.
---
Resolution: Fixed
> Add support for Snowflake sink connector
>
[
https://issues.apache.org/jira/browse/FLINK-32737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783876#comment-17783876
]
Mohsen Rezaei commented on FLINK-32737:
---
This connector has been open-sourced and the first
[
https://issues.apache.org/jira/browse/FLINK-32737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohsen Rezaei updated FLINK-32737:
--
Fix Version/s: 1.17.1
> Add support for Snowflake sink connector
>
Tan-JiaLiang commented on PR #22:
URL:
https://github.com/apache/flink-connector-hbase/pull/22#issuecomment-1800963553
You are right, the try/catches from both
`HBaseRowDataInputFormat#connectToTable()` methods are meaningless. I've fixed
and PTAL.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/FLINK-33479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783869#comment-17783869
]
Bo Shen commented on FLINK-33479:
-
I have encountered a similar situation in JdbcSink a while ago, the
Zakelly commented on PR #23679:
URL: https://github.com/apache/flink/pull/23679#issuecomment-1800938033
Hi, @pnowojski @masteryhx Would you please take a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783868#comment-17783868
]
Yun Tang edited comment on FLINK-20672 at 11/8/23 3:01 AM:
---
[~Zakelly] Thanks
[
https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783868#comment-17783868
]
Yun Tang commented on FLINK-20672:
--
[~Zakelly] Thanks for picking up the stale tickets. However, I
masteryhx commented on code in PR #23239:
URL: https://github.com/apache/flink/pull/23239#discussion_r1385899714
##
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/input/MultiStateKeyIterator.java:
##
@@ -46,47 +48,54 @@ public final class
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783866#comment-17783866
]
hansonhe commented on FLINK-33481:
--
@[~trohrmann] or AnyBody
Can you or anybody help me to answer my
[
https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783865#comment-17783865
]
Qingsheng Ren commented on FLINK-33465:
---
[~loserwang1024] Thanks for raising the issue. It looks
flinkbot commented on PR #23682:
URL: https://github.com/apache/flink/pull/23682#issuecomment-1800926621
## CI report:
* 3b3b2097aa9048640f76a67f031e6bc4e884e5dc UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
masteryhx closed pull request #23441: [FLINK-33060] Fix the javadoc of
ListState interfaces about not allowing null value
URL: https://github.com/apache/flink/pull/23441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/FLINK-33060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu updated FLINK-33060:
-
Fix Version/s: 1.19.0
> Fix the javadoc of ListState.update/addAll about not allowing null
[
https://issues.apache.org/jira/browse/FLINK-33060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu resolved FLINK-33060.
--
Resolution: Fixed
merged e0240c78 into master.
> Fix the javadoc of ListState.update/addAll
[
https://issues.apache.org/jira/browse/FLINK-33060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu updated FLINK-33060:
-
Component/s: Runtime / State Backends
> Fix the javadoc of ListState.update/addAll about not
[
https://issues.apache.org/jira/browse/FLINK-33478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33478:
---
Labels: pull-request-available (was: )
> Fail to call unix_timestamp when it is in filter
yunfan123 opened a new pull request, #23682:
URL: https://github.com/apache/flink/pull/23682
## What is the purpose of the change
Use foldExpr config as default to fix NPE problem when use unix_timestamp()
in filter condition.
And it is already the default value in hive project.
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
TanYuxin-tyx commented on code in PR #23664:
URL: https://github.com/apache/flink/pull/23664#discussion_r1385872477
##
pom.xml:
##
@@ -887,7 +887,7 @@ under the License.
io.netty
netty-bom
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Attachment: image-2023-11-08-10-05-54-694.png
> Why were checkpoints stored on zookeeper deleted when
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion: 1.13.5 ,
(1) flink-conf.yaml
high-availability.zookeeper.path.root
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Attachment: image-2023-11-08-09-57-17-739.png
> Why were checkpoints stored on zookeeper deleted when
victor09091 closed pull request #23494: FLINK-30893 Replace not specifying a
driver in Minikube by something …
URL: https://github.com/apache/flink/pull/23494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Attachment: image-2023-11-08-09-40-59-889.png
> Why were checkpoints stored on zookeeper deleted when
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion:
(1)jobmanager
appattempt_1684323088373_1744_01 Tue Oct 31 11:19:07
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion:
(1)jobmanager
appattempt_1684323088373_1744_01 Tue Oct 31 11:19:07
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Description:
FlinkVersion:
appattempt_1684323088373_1744_02 Sat Nov 4 11:10:52 +0800 2023
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Summary: Why were checkpoints stored on zookeeper deleted when JobManager
failures with Flink High
[
https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hansonhe updated FLINK-33481:
-
Summary: Why were checkpoints stored on zookeeper deleted when JobManager
failures with Flink High
hansonhe created FLINK-33481:
Summary: Why were CheckPoints stored on ZooKeeper deleted when use
Flink High Availability
Key: FLINK-33481
URL: https://issues.apache.org/jira/browse/FLINK-33481
Project:
flinkbot commented on PR #23681:
URL: https://github.com/apache/flink/pull/23681#issuecomment-1800844592
## CI report:
* 7d14168f580690f52bafea6e5be95c2d31f30525 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33480:
---
Labels: pull-request-available (was: )
> Implement restore tests for GroupAggregate node
>
bvarghese1 opened a new pull request, #23681:
URL: https://github.com/apache/flink/pull/23681
## What is the purpose of the change
Implement restore tests for GroupAggregate node
## Verifying this change
This change added tests and can be verified as follows:
Bonnie Varghese created FLINK-33480:
---
Summary: Implement restore tests for GroupAggregate node
Key: FLINK-33480
URL: https://issues.apache.org/jira/browse/FLINK-33480
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783827#comment-17783827
]
Danny Cranmer commented on FLINK-33260:
---
[~iemre] I have merged the EFO support. Will you be
[
https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783826#comment-17783826
]
Danny Cranmer commented on FLINK-33260:
---
Merged commit
dannycranmer merged PR #110:
URL: https://github.com/apache/flink-connector-aws/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dannycranmer commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-aws/pull/110#discussion_r1385669429
##
flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/RecoverableErrorsConfig.java:
##
@@
dannycranmer commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-aws/pull/110#discussion_r1385680247
##
flinkbot commented on PR #23680:
URL: https://github.com/apache/flink/pull/23680#issuecomment-1800285139
## CI report:
* 5da58a4bacbba7cc2547a7c3acb1b12fb662c667 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33470:
---
Labels: pull-request-available (was: )
> Implement restore tests for Join node
>
jnh5y opened a new pull request, #23680:
URL: https://github.com/apache/flink/pull/23680
## What is the purpose of the change
Implement restore tests for Join node
## Verifying this change
This change added tests and can be verified as follows:
* Added restore
[
https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783816#comment-17783816
]
Yaroslav Tkachenko commented on FLINK-29288:
Yep, it should work out of the box. That page
[
https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783806#comment-17783806
]
Trystan commented on FLINK-29288:
-
Thank you! This is exactly what we are trying to do. I thought we had
snuyanzin commented on PR #20:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1799805561
does it make sense to bump to 3.5.1 since there was added support for jdk20+
?
https://issues.apache.org/jira/browse/MSHADE-454
--
This is an automated message
[
https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783773#comment-17783773
]
Yaroslav Tkachenko commented on FLINK-29288:
> what is the correct procedure to put job jars
[
https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783755#comment-17783755
]
Trystan commented on FLINK-29288:
-
With this change, what is the correct procedure to put job jars on
[
https://issues.apache.org/jira/browse/FLINK-33479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783741#comment-17783741
]
Kevin Tseng commented on FLINK-33479:
-
can someone assign this to me. we have idea on how this
Kevin Tseng created FLINK-33479:
---
Summary: Add Rerouting support to KafkaSink
Key: FLINK-33479
URL: https://issues.apache.org/jira/browse/FLINK-33479
Project: Flink
Issue Type: Improvement
snuyanzin commented on code in PR #23664:
URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937
##
pom.xml:
##
@@ -887,7 +887,7 @@ under the License.
io.netty
netty-bom
-
snuyanzin commented on code in PR #23664:
URL: https://github.com/apache/flink/pull/23664#discussion_r1385293460
##
pom.xml:
##
@@ -887,7 +887,7 @@ under the License.
io.netty
netty-bom
-
bvarghese1 commented on PR #23660:
URL: https://github.com/apache/flink/pull/23660#issuecomment-1799279843
> One more thing I just noticed (actually it's also a problem for Calc
tests) that we should not put those classes/tests in
`org.apache.flink.table.planner.plan.nodes.exec.testutils`.
bvarghese1 commented on code in PR #23660:
URL: https://github.com/apache/flink/pull/23660#discussion_r1385277745
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java:
##
@@ -0,0 +1,121 @@
+/*
+ *
jnh5y commented on code in PR #23652:
URL: https://github.com/apache/flink/pull/23652#discussion_r1385277845
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java:
##
@@ -0,0 +1,83 @@
+/*
+ *
bvarghese1 commented on code in PR #23660:
URL: https://github.com/apache/flink/pull/23660#discussion_r1385277745
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java:
##
@@ -0,0 +1,121 @@
+/*
+ *
snuyanzin commented on code in PR #23664:
URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937
##
pom.xml:
##
@@ -887,7 +887,7 @@ under the License.
io.netty
netty-bom
-
snuyanzin commented on code in PR #23664:
URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937
##
pom.xml:
##
@@ -887,7 +887,7 @@ under the License.
io.netty
netty-bom
-
dawidwys commented on code in PR #23652:
URL: https://github.com/apache/flink/pull/23652#discussion_r1385224887
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java:
##
@@ -0,0 +1,83 @@
+/*
+ *
dawidwys commented on PR #23660:
URL: https://github.com/apache/flink/pull/23660#issuecomment-1798988635
One more thing I just noticed (actually it's also a problem for Calc tests)
that we should not put those classes/tests in
`org.apache.flink.table.planner.plan.nodes.exec.testutils`.
[
https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783674#comment-17783674
]
Jonas Weile commented on FLINK-33466:
-
Hi, would appreciate it if any of the committers could have a
dawidwys commented on code in PR #23652:
URL: https://github.com/apache/flink/pull/23652#discussion_r1385059368
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/subquery.scala:
##
@@ -1,78 +0,0 @@
-/*
- * Licensed to the Apache
dawidwys commented on code in PR #23652:
URL: https://github.com/apache/flink/pull/23652#discussion_r1385055760
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategy.java:
##
@@ -0,0 +1,115 @@
+/*
+ *
dawidwys commented on code in PR #23652:
URL: https://github.com/apache/flink/pull/23652#discussion_r1385029083
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java:
##
@@ -242,6 +245,139 @@ public static boolean
[
https://issues.apache.org/jira/browse/FLINK-12302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xin Chen updated FLINK-12302:
-
Attachment: (was: container_e15_1693914709123_8498_01_01_8042)
> Fixed the wrong finalStatus of
dalelane commented on PR #23395:
URL: https://github.com/apache/flink/pull/23395#issuecomment-1798607054
@afedulov Is there anything else that you think is needed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gyfora commented on PR #23490:
URL: https://github.com/apache/flink/pull/23490#issuecomment-1798603528
Addressed these comments @XComp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
1 - 100 of 161 matches
Mail list logo