Re: [PR] [FLINK-32993][table] Datagen connector handles fixed-length data types according to the original definition by default [flink]

2023-11-10 Thread via GitHub
LadyForest commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1806728583 Hi @liyubin117 thanks for your contributionon! As concluded in the offline discussion, since this is a question regarding modification of the default behavior for the datagen

[jira] [Updated] (FLINK-33524) IntervalJoinOperator 's judgment on late data has bug

2023-11-10 Thread ZhangTao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangTao updated FLINK-33524: - Labels: (was: pull-request-available) > IntervalJoinOperator 's judgment on late data has bug >

Re: [PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

2023-11-10 Thread via GitHub
flinkbot commented on PR #23699: URL: https://github.com/apache/flink/pull/23699#issuecomment-1806722894 ## CI report: * 0bc5397f48610d1a26681974af917ac9230d17be UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33524) IntervalJoinOperator 's judgment on late data has bug

2023-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33524: --- Labels: pull-request-available (was: ) > IntervalJoinOperator 's judgment on late data has

[PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

2023-11-10 Thread via GitHub
Tao-Zhang9876 opened a new pull request, #23699: URL: https://github.com/apache/flink/pull/23699 Due to the Watermark calculation method : ``` public void onPeriodicEmit(WatermarkOutput output) { output.emitWatermark(new Watermark(maxTs - delayTime - 1L));

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-10 Thread via GitHub
LadyForest commented on code in PR #23620: URL: https://github.com/apache/flink/pull/23620#discussion_r1390116335 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelOptUtil.scala: ## @@ -524,4 +530,219 @@ object FlinkRelOptUtil {

[jira] [Created] (FLINK-33524) IntervalJoinOperator 's judgment on late data has bug

2023-11-10 Thread ZhangTao (Jira)
ZhangTao created FLINK-33524: Summary: IntervalJoinOperator 's judgment on late data has bug Key: FLINK-33524 URL: https://issues.apache.org/jira/browse/FLINK-33524 Project: Flink Issue Type:

[jira] [Updated] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-11-10 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph updated FLINK-33523: -- Description: When upgrading Iceberg's Flink version to 1.18, we found the Flink-related unit

[jira] [Created] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-11-10 Thread Prabhu Joseph (Jira)
Prabhu Joseph created FLINK-33523: - Summary: DataType ARRAY fails to cast into Object[] Key: FLINK-33523 URL: https://issues.apache.org/jira/browse/FLINK-33523 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-10 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390096801 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-10 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390096271 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +711,60 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27 [flink-connector-gcp-pubsub]

2023-11-10 Thread via GitHub
dchristle commented on PR #2: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/2#issuecomment-1806569957 Hi @RyanSkraba, Thank you for shepherding and improving this connector implementation over the years. I'm hoping to help review & improve it so we can finally get

Re: [PR] [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27 [flink-connector-gcp-pubsub]

2023-11-10 Thread via GitHub
dchristle commented on code in PR #2: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/2#discussion_r1389778481 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/source/PubSubSource.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to

[jira] [Updated] (FLINK-33522) Savepoint upgrade mode fails despite the savepoint succeeding

2023-11-10 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-33522: --- Description: Under certain circumstances, savepoint creation can succeed but the

[jira] [Updated] (FLINK-33522) Savepoint upgrade mode fails despite the savepoint succeeding

2023-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33522: --- Labels: pull-request-available (was: ) > Savepoint upgrade mode fails despite the

[PR] [FLINK-33522] Use created savepoint even if job cancellation fails [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
mxm opened a new pull request, #706: URL: https://github.com/apache/flink-kubernetes-operator/pull/706 Under certain circumstances, savepoint creation can succeed but the job fails afterwards. One example is when there are messages being distributed by the source coordinator to

[jira] [Created] (FLINK-33522) Savepoint upgrade mode fails despite the savepoint succeeding

2023-11-10 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33522: -- Summary: Savepoint upgrade mode fails despite the savepoint succeeding Key: FLINK-33522 URL: https://issues.apache.org/jira/browse/FLINK-33522 Project:

Re: [PR] Fix a speling error in upgrade.md [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
mxm merged PR #705: URL: https://github.com/apache/flink-kubernetes-operator/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix a speling error in upgrade.md [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
mxm commented on PR #705: URL: https://github.com/apache/flink-kubernetes-operator/pull/705#issuecomment-1806431131 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-33385) Flink connector redshift Sink API implementation

2023-11-10 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33385: --- Summary: Flink connector redshift Sink API implementation (was: Flink connector redshift Sink

[jira] [Updated] (FLINK-33132) Flink Connector Redshift Implementation (Table-API)

2023-11-10 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33132: --- Summary: Flink Connector Redshift Implementation (Table-API) (was: Flink Connector Redshift Sink

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785031#comment-17785031 ] david radley edited comment on FLINK-33365 at 11/10/23 6:18 PM: I am not

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785031#comment-17785031 ] david radley commented on FLINK-33365: -- I am not sure about the design intent in this area. Should

[jira] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365 ] david radley deleted comment on FLINK-33365: -- was (Author: JIRAUSER300523): Testing against MariaDB I see: select  CAST(0 AS INT) as type  from c; +--+ |type| +--+ |    0| |   

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784915#comment-17784915 ] david radley edited comment on FLINK-33365 at 11/10/23 4:33 PM: an

Re: [PR] [FLINK-31631][FileSystems] shade guava in gs-fs filesystem [flink]

2023-11-10 Thread via GitHub
sofam commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1806052931 Any progress on this? We need it for upgrading our jobs to 1.18 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33148] Update Web UI to adopt the new "endpoint" field in REST API [flink]

2023-11-10 Thread via GitHub
flinkbot commented on PR #23698: URL: https://github.com/apache/flink/pull/23698#issuecomment-1806045977 ## CI report: * 815fdd06b59c593124bfbe8d9443949c05b4dba4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33515][python] Stream python process output to log instead of collecting it in memory [flink]

2023-11-10 Thread via GitHub
flinkbot commented on PR #23697: URL: https://github.com/apache/flink/pull/23697#issuecomment-1806033945 ## CI report: * ac8e2bd3884973b10c8e17110f4dae8e625576fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33148] Update Web UI to adopt the new "endpoint" field in REST API [flink]

2023-11-10 Thread via GitHub
local cluster setup. ![screenshot-20231110-232106](https://github.com/apache/flink/assets/22020529/3264f31e-cfd5-4902-8667-e820077dd1be) ![screenshot-20231110-232603](https://github.com/apache/flink/assets/22020529/c861259b-20b2-40ed-9e1e-70a413cd) ![screenshot-20231110-232730](https

[jira] [Updated] (FLINK-33148) Update Web UI to adopt the new "endpoint" field in REST API

2023-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33148: --- Labels: pull-request-available (was: ) > Update Web UI to adopt the new "endpoint" field

[jira] [Updated] (FLINK-33515) PythonDriver need to stream python process output to log instead of collecting it in memory

2023-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33515: --- Labels: pull-request-available (was: ) > PythonDriver need to stream python process output

[PR] [FLINK-33515][python] Stream python process output to log instead of collecting it in memory [flink]

2023-11-10 Thread via GitHub
gaborgsomogyi opened a new pull request, #23697: URL: https://github.com/apache/flink/pull/23697 ## What is the purpose of the change `PythonDriver` now collects the python process output in a `Stringbuilder` instead of streaming it. It can cause OOM when the python process is

Re: [PR] [FLINK-33515][python] Stream python process output to log instead of collecting it in memory [flink]

2023-11-10 Thread via GitHub
gaborgsomogyi commented on PR #23697: URL: https://github.com/apache/flink/pull/23697#issuecomment-1806023401 cc @gyfora @mbalassi @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33520] Avoid using FLINK_HOME to find test scripts [flink]

2023-11-10 Thread via GitHub
flinkbot commented on PR #23696: URL: https://github.com/apache/flink/pull/23696#issuecomment-1806015650 ## CI report: * 741114833862d9def23b3ea09b886c8f5afe0b7b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
gaborgsomogyi commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1806013754 Just for the reference for others: https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/security/security-ssl/#rest-endpoints-external-connectivity

[jira] [Updated] (FLINK-33520) FileNotFoundException when running GPUDriverTest

2023-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33520: --- Labels: pull-request-available (was: ) > FileNotFoundException when running GPUDriverTest

[PR] [FLINK-33520] Avoid using FLINK_HOME to find test scripts [flink]

2023-11-10 Thread via GitHub
RyanSkraba opened a new pull request, #23696: URL: https://github.com/apache/flink/pull/23696 ## What is the purpose of the change This is a *very* minor change to avoid depending on the value of the `FLINK_HOME` environment variable when discovering the value of the gpu discovery

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
gaborgsomogyi commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1806003173 Makes sense, mTLS is one reason what justifies to add the remaining 3 keystore related configs. -- This is an automated message from the Apache Git Service. To

[jira] [Closed] (FLINK-13786) Implement type inference for other functions

2023-11-10 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-13786. Resolution: Won't Fix > Implement type inference for other functions >

[jira] [Commented] (FLINK-13786) Implement type inference for other functions

2023-11-10 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784990#comment-17784990 ] Dawid Wysakowicz commented on FLINK-13786: -- I'll close this ticket in favour of more granular

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784915#comment-17784915 ] david radley edited comment on FLINK-33365 at 11/10/23 3:08 PM: an

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784915#comment-17784915 ] david radley edited comment on FLINK-33365 at 11/10/23 3:04 PM: an

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784924#comment-17784924 ] david radley edited comment on FLINK-33365 at 11/10/23 3:01 PM: Testing

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784915#comment-17784915 ] david radley edited comment on FLINK-33365 at 11/10/23 3:01 PM: an

[jira] [Assigned] (FLINK-33521) Implement restore tests for PythonCalc node

2023-11-10 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes reassigned FLINK-33521: -- Assignee: Jim Hughes > Implement restore tests for PythonCalc node >

[jira] [Created] (FLINK-33521) Implement restore tests for PythonCalc node

2023-11-10 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33521: -- Summary: Implement restore tests for PythonCalc node Key: FLINK-33521 URL: https://issues.apache.org/jira/browse/FLINK-33521 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33520) FileNotFoundException when running GPUDriverTest

2023-11-10 Thread Ryan Skraba (Jira)
Ryan Skraba created FLINK-33520: --- Summary: FileNotFoundException when running GPUDriverTest Key: FLINK-33520 URL: https://issues.apache.org/jira/browse/FLINK-33520 Project: Flink Issue Type:

[jira] [Closed] (FLINK-33419) Port PROCTIME/ROWTIME functions to the new inference stack

2023-11-10 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33419. Resolution: Implemented Implemented in 3dd98430e5cc7ee88051d0eb6bc2c71908eb997b > Port

Re: [PR] [FLINK-33419] Port PROCTIME/ROWTIME functions to the new inference stack [flink]

2023-11-10 Thread via GitHub
dawidwys merged PR #23634: URL: https://github.com/apache/flink/pull/23634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33507) JsonToRowDataConverters can't parse zero timestamp '0000-00-00 00:00:00'

2023-11-10 Thread jinzhuguang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784930#comment-17784930 ] jinzhuguang commented on FLINK-33507: - [~martijnvisser] Thank you for your reply. In my scenario, I

[jira] (FLINK-33507) JsonToRowDataConverters can't parse zero timestamp '0000-00-00 00:00:00'

2023-11-10 Thread jinzhuguang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33507 ] jinzhuguang deleted comment on FLINK-33507: - was (Author: JIRAUSER302532): Thank you for your reply. In my scenario, I just want to recognize zero date as null, but json.ignore-parse-errors

[jira] [Commented] (FLINK-33507) JsonToRowDataConverters can't parse zero timestamp '0000-00-00 00:00:00'

2023-11-10 Thread jinzhuguang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784929#comment-17784929 ] jinzhuguang commented on FLINK-33507: - Thank you for your reply. In my scenario, I just want to

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784924#comment-17784924 ] david radley edited comment on FLINK-33365 at 11/10/23 12:47 PM: -

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784924#comment-17784924 ] david radley commented on FLINK-33365: -- Testing against MariaDB I see: select  CAST(0 AS INT) as

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784924#comment-17784924 ] david radley edited comment on FLINK-33365 at 11/10/23 12:46 PM: -

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784915#comment-17784915 ] david radley edited comment on FLINK-33365 at 11/10/23 12:29 PM: - an

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-10 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784915#comment-17784915 ] david radley commented on FLINK-33365: -- an update on what I have found:   I have switched on

[jira] [Commented] (FLINK-33251) SQL Client query execution aborts after a few seconds: ConnectTimeoutException

2023-11-10 Thread Jorick Caberio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784905#comment-17784905 ] Jorick Caberio commented on FLINK-33251: No > SQL Client query execution aborts after a few

[jira] [Created] (FLINK-33519) standalone mode could not create keytab secret

2023-11-10 Thread chaoran.su (Jira)
chaoran.su created FLINK-33519: -- Summary: standalone mode could not create keytab secret Key: FLINK-33519 URL: https://issues.apache.org/jira/browse/FLINK-33519 Project: Flink Issue Type: Bug

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
tagarr commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1805607794 You're right truststore would normally only be needed, it depends on if we want to cater for mTLS. If we did we would need to include keystore info. Quick question if

[PR] Fix a speling error in upgrade.md [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
sdahlbac opened a new pull request, #705: URL: https://github.com/apache/flink-kubernetes-operator/pull/705 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-11-10 Thread via GitHub
pvary commented on PR #23555: URL: https://github.com/apache/flink/pull/23555#issuecomment-1805565611 @mbalassi: Rebased, and got a green run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-10 Thread via GitHub
leonardBang commented on PR #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20#issuecomment-1805552181 > @leonardBang If we want to bump the minimum version to 1.17.0, you'll also need to address the dependency convergence. > > However, looking at the code, we

[jira] [Commented] (FLINK-33507) JsonToRowDataConverters can't parse zero timestamp '0000-00-00 00:00:00'

2023-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784767#comment-17784767 ] Martijn Visser commented on FLINK-33507: [~lucas_jin] There is already the option

[jira] [Updated] (FLINK-33510) Update plugin for SBOM generation to 2.7.10

2023-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33510: --- Issue Type: Technical Debt (was: Improvement) > Update plugin for SBOM generation to

[jira] [Updated] (FLINK-33510) Update plugin for SBOM generation to 2.7.10

2023-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33510: --- Component/s: Build System > Update plugin for SBOM generation to 2.7.10 >

Re: [PR] [hotfix][docs] refer to sql_connector_download_table shortcode in zh docs [flink-connector-kafka]

2023-11-10 Thread via GitHub
MartijnVisser closed pull request #65: [hotfix][docs] refer to sql_connector_download_table shortcode in zh docs URL: https://github.com/apache/flink-connector-kafka/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [hotfix][docs] refer to sql_connector_download_table shortcode in zh docs [flink-connector-kafka]

2023-11-10 Thread via GitHub
MartijnVisser commented on PR #65: URL: https://github.com/apache/flink-connector-kafka/pull/65#issuecomment-1805462974 Closed, duplicate of https://github.com/apache/flink-connector-kafka/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-10 Thread via GitHub
MartijnVisser commented on PR #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20#issuecomment-1805460516 @leonardBang If we want to bump the minimum version to 1.17.0, you'll also need to address the dependency convergence. However, looking at the code, we

[jira] [Commented] (FLINK-33514) FlinkScalaKryoInstantiator class not found in KryoSerializer

2023-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784758#comment-17784758 ] Martijn Visser commented on FLINK-33514: This sounds like you're missing a dependency. What's in

[jira] [Resolved] (FLINK-30314) Unable to read all records from compressed delimited file input format

2023-11-10 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot resolved FLINK-30314. -- Fix Version/s: 1.19.0 Resolution: Fixed Fixed by

[jira] [Assigned] (FLINK-33207) Scan hbase table will throw error when table is empty

2023-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33207: -- Assignee: tanjialiang > Scan hbase table will throw error when table is empty >

[jira] [Closed] (FLINK-33207) Scan hbase table will throw error when table is empty

2023-11-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33207. -- Fix Version/s: hbase-3.0.1 Resolution: Fixed Fixed in apache/flink-connector-hbase

[jira] [Closed] (FLINK-32807) when i use emitUpdateWithRetract of udtagg,bug error

2023-11-10 Thread yong yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yong yang closed FLINK-32807. - Resolution: Duplicate > when i use emitUpdateWithRetract of udtagg,bug error >

Re: [PR] [FLINK-33207] Return empty split when the hbase table is empty [flink-connector-hbase]

2023-11-10 Thread via GitHub
MartijnVisser merged PR #23: URL: https://github.com/apache/flink-connector-hbase/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33484) Flink Kafka Connector Offset Lag Issue with Transactional Data and Read Committed Isolation Level

2023-11-10 Thread Darcy Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784752#comment-17784752 ] Darcy Lin commented on FLINK-33484: --- [~martijnvisser] The issue remains the same with

Re: [PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-10 Thread via GitHub
boring-cyborg[bot] commented on PR #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20#issuecomment-1805427501 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) --

[PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-10 Thread via GitHub
leonardBang opened a new pull request, #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20 Bump lowest supported flink version to 1.17.0 as the discussion thread[1] [1] https://lists.apache.org/thread/2qqd59nng50k4po1dlyoxkwjmvb2fmb4 -- This is an automated

[jira] [Created] (FLINK-33518) Implement restore tests for WatermarkAssigner node

2023-11-10 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-33518: - Summary: Implement restore tests for WatermarkAssigner node Key: FLINK-33518 URL: https://issues.apache.org/jira/browse/FLINK-33518 Project: Flink Issue Type:

[jira] [Created] (FLINK-33517) Implement restore tests for Value node

2023-11-10 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-33517: - Summary: Implement restore tests for Value node Key: FLINK-33517 URL: https://issues.apache.org/jira/browse/FLINK-33517 Project: Flink Issue Type: Sub-task

Re: [PR] [hotfix] fix_kafka_sasl_ssl_example in the docs [flink-connector-kafka]

2023-11-10 Thread via GitHub
boring-cyborg[bot] commented on PR #67: URL: https://github.com/apache/flink-connector-kafka/pull/67#issuecomment-1805424464 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [hotfix] fix_kafka_sasl_ssl_example in the docs [flink-connector-kafka]

2023-11-10 Thread via GitHub
531651225 opened a new pull request, #67: URL: https://github.com/apache/flink-connector-kafka/pull/67 - Removing unnecessary transition symbols'/'in the document ` 'properties.sasl.jaas.config' = 'org.apache.kafka.common.security.scram.ScramLoginModule required

[jira] [Created] (FLINK-33516) Create dedicated PyFlink channel

2023-11-10 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33516: -- Summary: Create dedicated PyFlink channel Key: FLINK-33516 URL: https://issues.apache.org/jira/browse/FLINK-33516 Project: Flink Issue Type: Improvement

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
gaborgsomogyi commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1805421386 What you're suggesting sounds better. I think we need 2 additional parameters: * `...trustore` * `...trustore-password` Not yet understand why keystore

Re: [PR] [FLINK-33207] Return empty split when the hbase table is empty [flink-connector-hbase]

2023-11-10 Thread via GitHub
ferenc-csaky commented on PR #23: URL: https://github.com/apache/flink-connector-hbase/pull/23#issuecomment-1805419097 cc @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-10 Thread via GitHub
grzegorz8 commented on PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1805376630 @eskabetxe Could you review the PR, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-33513) Metastore delegation-token can be cached?

2023-11-10 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784739#comment-17784739 ] Gabor Somogyi commented on FLINK-33513: --- If that hurts the solution is not caching but adding a

Re: [PR] [FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak [flink-connector-jdbc]

2023-11-10 Thread via GitHub
KevDi commented on PR #75: URL: https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-1805360349 @eskabetxe @MartijnVisser i looked into this error but i was unable to resolve it. I removed the mentioned import with explicit imports but then i get an error telling me that

Re: [PR] [hotfix] Fix the checkstyle after supporting jdk21 [flink-kubernetes-operator]

2023-11-10 Thread via GitHub
gyfora merged PR #704: URL: https://github.com/apache/flink-kubernetes-operator/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-10 Thread via GitHub
MartijnVisser commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1805337202 > I have a question, why we always follow hive and spark? if we thinks is a feature need to support, we can implement it firstly. i think having rich functions is better

[jira] [Resolved] (FLINK-33059) Support transparent compression for file-connector for all file input formats

2023-11-10 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot resolved FLINK-33059. -- Fix Version/s: 1.19.0 Resolution: Fixed master:

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-10 Thread via GitHub
leoyy0316 commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1805324411 > > trino support this function, we need use this function, so can we suuport this function? > > I don't think Trino is the primary engine we compare ourselves against. Does the

[jira] [Closed] (FLINK-33488) Implement restore tests for Deduplicate node

2023-11-10 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33488. Resolution: Implemented Implemented in 88953ba622f4d3b67b59f56e15e1983e7932b926 >

[jira] [Comment Edited] (FLINK-33401) Kafka connector has broken version

2023-11-10 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784724#comment-17784724 ] Yuxin Tan edited comment on FLINK-33401 at 11/10/23 8:47 AM: - After merging

[jira] [Comment Edited] (FLINK-33401) Kafka connector has broken version

2023-11-10 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784724#comment-17784724 ] Yuxin Tan edited comment on FLINK-33401 at 11/10/23 8:47 AM: - After merging

Re: [PR] [FLINK-33488] Implement restore tests for Deduplicate node [flink]

2023-11-10 Thread via GitHub
dawidwys closed pull request #23686: [FLINK-33488] Implement restore tests for Deduplicate node URL: https://github.com/apache/flink/pull/23686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-33401) Kafka connector has broken version

2023-11-10 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784724#comment-17784724 ] Yuxin Tan commented on FLINK-33401: --- After merging the Flink 1.19 hotfix

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-10 Thread via GitHub
Zakelly commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1805307753 > Can you squash the latest two fixup commits into the first two commits: > > ``` > [[FLINK-6755] Support manual checkpoints triggering from

[jira] [Created] (FLINK-33515) PythonDriver need to stream python process output to log instead of collecting it in memory

2023-11-10 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-33515: - Summary: PythonDriver need to stream python process output to log instead of collecting it in memory Key: FLINK-33515 URL: https://issues.apache.org/jira/browse/FLINK-33515

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-10 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1389074605 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does not

  1   2   >