[jira] [Commented] (FLINK-20539) Type mismatch when using ROW in computed column

2023-11-21 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788663#comment-17788663 ] Jane Chan commented on FLINK-20539: --- master: db934bfe3772cc44263d42e875a5957ea00c15c1 > Type mismatch

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-11-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788662#comment-17788662 ] Matthias Pohl commented on FLINK-33414: ---

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-11-21 Thread via GitHub
LadyForest merged PR #23519: URL: https://github.com/apache/flink/pull/23519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-33614) Docker pull failed

2023-11-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33614: - Summary: Docker pull failed Key: FLINK-33614 URL: https://issues.apache.org/jira/browse/FLINK-33614 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-11-21 Thread via GitHub
LadyForest commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1822270188 @xuyangzhong Could you help to pick the fix to release-1.18? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-11-21 Thread via GitHub
flinkbot commented on PR #23771: URL: https://github.com/apache/flink/pull/23771#issuecomment-1822252927 ## CI report: * b28265317fdb66e766d7f80e47ea4c7061591c2f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33613) Python UDF Runner process leak in Process Mode

2023-11-21 Thread Yu Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Chen updated FLINK-33613: Description: While working with PyFlink, we found that in Process Mode, the Python UDF process may leak

[jira] [Created] (FLINK-33613) Python UDF Runner process leak in Process Mode

2023-11-21 Thread Yu Chen (Jira)
Yu Chen created FLINK-33613: --- Summary: Python UDF Runner process leak in Process Mode Key: FLINK-33613 URL: https://issues.apache.org/jira/browse/FLINK-33613 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-33612) The table plan of hybrid shuffle may introduce additional blocking edges occasionally

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33612: --- Labels: pull-request-available (was: ) > The table plan of hybrid shuffle may introduce

[PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-11-21 Thread via GitHub
TanYuxin-tyx opened a new pull request, #23771: URL: https://github.com/apache/flink/pull/23771 ## What is the purpose of the change *To enhance the performance of hybrid shuffle, it is imperative to address the inconsistency between hybrid shuffle mode and blocking

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
LadyForest commented on PR #23751: URL: https://github.com/apache/flink/pull/23751#issuecomment-1822240496 I just noticed that the master branch has been updated, would you mind rebasing and resolving conflicts? @snuyanzin -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-33490][table-planner] Validate the column name conflicts in view when creating view [flink]

2023-11-21 Thread via GitHub
xuyangzhong commented on PR #23760: URL: https://github.com/apache/flink/pull/23760#issuecomment-1822203012 Hi, @JingGe . Thanks for your review. I have refactored it. Can you do the final check? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33490][table-planner] Validate the name conflicts when creating view [flink]

2023-11-21 Thread via GitHub
xuyangzhong commented on code in PR #23760: URL: https://github.com/apache/flink/pull/23760#discussion_r1401572450 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java: ## @@ -63,6 +69,32 @@ static

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-21 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788648#comment-17788648 ] xuyang commented on FLINK-33490: Hi, [~libenchao] .  I test the sql you provide and some more SQL. The

[jira] [Resolved] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-11-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-29541. Resolution: Implemented > [JUnit5 Migration] Module: flink-table-planner >

[jira] [Updated] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-11-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-29541: --- Affects Version/s: 1.18.0 > [JUnit5 Migration] Module: flink-table-planner >

[jira] [Closed] (FLINK-32997) [JUnit5 Migration] Module: flink-table-planner (StreamingTestBase)

2023-11-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu closed FLINK-32997. -- Resolution: Implemented Implemented by master(1.19): dcc47907354a0cd86a4d319d9cea3ad01d2104b5 >

Re: [PR] [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase) [flink]

2023-11-21 Thread via GitHub
leonardBang merged PR #23330: URL: https://github.com/apache/flink/pull/23330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase) [flink]

2023-11-21 Thread via GitHub
leonardBang commented on PR #23330: URL: https://github.com/apache/flink/pull/23330#issuecomment-1822167605 CI passed https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=54753=logs=b59e5554-36c7-5512-ab1a-b80b74075fce, merging... -- This is an automated message from

Re: [PR] Kubernetes Operator 1.7.0 [flink-web]

2023-11-21 Thread via GitHub
gyfora merged PR #699: URL: https://github.com/apache/flink-web/pull/699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33610][runtime] Fix unstable test CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping [flink]

2023-11-21 Thread via GitHub
flinkbot commented on PR #23770: URL: https://github.com/apache/flink/pull/23770#issuecomment-1822139600 ## CI report: * 6c686a4b3f1c7661748aae62fbf1c828820cd306 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33610) CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping failed with an AssertionError

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33610: --- Labels: pull-request-available test-stability (was: test-stability) >

[PR] [FLINK-33610][runtime] Fix unstable test CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping [flink]

2023-11-21 Thread via GitHub
Jiabao-Sun opened a new pull request, #23770: URL: https://github.com/apache/flink/pull/23770 ## What is the purpose of the change [FLINK-33610][runtime] Fix unstable test CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-21 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1401482553 ## flink-clients/src/main/java/org/apache/flink/client/cli/CheckpointOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (FLINK-33610) CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping failed with an AssertionError

2023-11-21 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788613#comment-17788613 ] Jiabao Sun commented on FLINK-33610: {code} java.lang.NullPointerException: Cannot invoke

[jira] [Assigned] (FLINK-33612) The table plan of hybrid shuffle may introduce additional blocking edges occasionally

2023-11-21 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-33612: - Assignee: Yuxin Tan > The table plan of hybrid shuffle may introduce additional blocking edges

[jira] [Created] (FLINK-33612) The table plan of hybrid shuffle may introduce additional blocking edges occasionally

2023-11-21 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33612: - Summary: The table plan of hybrid shuffle may introduce additional blocking edges occasionally Key: FLINK-33612 URL: https://issues.apache.org/jira/browse/FLINK-33612

[jira] [Commented] (FLINK-33606) Support streaming mode in Flink JDBC driver

2023-11-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788604#comment-17788604 ] Benchao Li commented on FLINK-33606: Leaving out streaming/changelog out of Flink JDBC Driver was

Re: [PR] [FLINK-33592]Modified the return type of the method, make it more convenient to use. [flink]

2023-11-21 Thread via GitHub
Tao-Zhang9876 closed pull request #23750: [FLINK-33592]Modified the return type of the method, make it more convenient to use. URL: https://github.com/apache/flink/pull/23750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Closed] (FLINK-33592) The return type of the function is void,not convenient to use

2023-11-21 Thread ZhangTao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangTao closed FLINK-33592. Resolution: Not A Problem > The return type of the function is void,not convenient to use >

[jira] [Commented] (FLINK-33592) The return type of the function is void,not convenient to use

2023-11-21 Thread ZhangTao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788588#comment-17788588 ] ZhangTao commented on FLINK-33592: -- I see. Thank you very much for your reply > The return type of

Re: [PR] [FLINK-26782] Remove PlannerExpression and related [flink]

2023-11-21 Thread via GitHub
jnh5y commented on code in PR #23761: URL: https://github.com/apache/flink/pull/23761#discussion_r1401353983 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/LegacyUserDefinedFunctionInference.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the

[jira] [Closed] (FLINK-32918) Update reference data for Migration Tests

2023-11-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-32918. --- > Update reference data for Migration Tests > - > >

[jira] [Resolved] (FLINK-32918) Update reference data for Migration Tests

2023-11-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32918. - Fix Version/s: 1.19.0 1.18.1 Resolution: Fixed > Update

[jira] [Commented] (FLINK-32918) Update reference data for Migration Tests

2023-11-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788568#comment-17788568 ] Sergey Nuyanzin commented on FLINK-32918: - Merged to master as

[jira] [Commented] (FLINK-33453) Add java21-target profile

2023-11-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788567#comment-17788567 ] Sergey Nuyanzin commented on FLINK-33453: - Merged as

[jira] [Resolved] (FLINK-33453) Add java21-target profile

2023-11-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33453. - Fix Version/s: 1.19.0 Resolution: Fixed > Add java21-target profile >

[jira] [Closed] (FLINK-33453) Add java21-target profile

2023-11-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33453. --- > Add java21-target profile > - > > Key: FLINK-33453 >

Re: [PR] Bump org.apache.derby:derby from 10.10.2.0 to 10.17.1.0 in /flink-connectors/flink-connector-hive [flink]

2023-11-21 Thread via GitHub
flinkbot commented on PR #23769: URL: https://github.com/apache/flink/pull/23769#issuecomment-1821823473 ## CI report: * 6efa3e3fae012e0d3f83fd6b3db07fe380976203 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-18][FLINK-32918][tests] Upgraded migration test data [flink]

2023-11-21 Thread via GitHub
snuyanzin merged PR #23711: URL: https://github.com/apache/flink/pull/23711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump org.apache.derby:derby from 10.10.2.0 to 10.17.1.0 in /flink-connectors/flink-connector-hive [flink]

2023-11-21 Thread via GitHub
dependabot[bot] opened a new pull request, #23769: URL: https://github.com/apache/flink/pull/23769 Bumps org.apache.derby:derby from 10.10.2.0 to 10.17.1.0. [![Dependabot compatibility

Re: [PR] [FLINK-33453][build] Add java21-target profile [flink]

2023-11-21 Thread via GitHub
snuyanzin merged PR #23657: URL: https://github.com/apache/flink/pull/23657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33453][build] Add java21-target profile [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on PR #23657: URL: https://github.com/apache/flink/pull/23657#issuecomment-1821820163 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33503][build] Upgrades Maven Wrapper version and integrates checksum verification [flink]

2023-11-21 Thread via GitHub
JingGe commented on code in PR #23766: URL: https://github.com/apache/flink/pull/23766#discussion_r1401254115 ## mvnw: ## @@ -282,35 +251,58 @@ fi # End of extension ## -export

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-11-21 Thread via GitHub
JingGe merged PR #23395: URL: https://github.com/apache/flink/pull/23395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32918][release] Generate reference data for state migration tests based on release-1.18.0 [flink]

2023-11-21 Thread via GitHub
snuyanzin merged PR #23710: URL: https://github.com/apache/flink/pull/23710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-11-21 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1821577035 @JingGe Thanks very much - I've done the squash and rebase now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-33611) Add the ability to reuse variable names across different split method scopes

2023-11-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-33611: -- Description: h3. Background Flink serializes and deserializes protobuf format data

Re: [PR] [hotfix] Add issue NavigationLink for IDEA [flink-connector-opensearch]

2023-11-21 Thread via GitHub
snuyanzin merged PR #35: URL: https://github.com/apache/flink-connector-opensearch/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Backport][FLINK-31856] Add support for Opensearch Connector REST client customization [flink-connector-opensearch]

2023-11-21 Thread via GitHub
snuyanzin commented on PR #26: URL: https://github.com/apache/flink-connector-opensearch/pull/26#issuecomment-1821490819 @cthtrifork sorry, seems I missed it there is a discussion about releaseing of connectors since 1.18.0 was released

[PR] [hotfix] Add issue NavigationLink for IDEA [flink-connector-opensearch]

2023-11-21 Thread via GitHub
snuyanzin opened a new pull request, #35: URL: https://github.com/apache/flink-connector-opensearch/pull/35 Same navigation link as was done for Flink within FLINK-24013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-11-21 Thread via GitHub
JingGe commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1821357880 @xuyangzhong Thanks for driving it! NIT: remove `(for example:)` in PR description. It belongs to PR template only. -- This is an automated message from the Apache Git Service. To

[jira] [Closed] (FLINK-33601) Implement restore tests for Expand node

2023-11-21 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33601. Fix Version/s: 1.19.0 Resolution: Implemented Implemented in

Re: [PR] [FLINK-33601] Implement restore tests for Expand node [flink]

2023-11-21 Thread via GitHub
dawidwys merged PR #23763: URL: https://github.com/apache/flink/pull/23763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33611) Add the ability to reuse variable names across different split method scopes

2023-11-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-33611: -- Description: h3. Background Flink serializes and deserializes protobuf format data

[jira] [Created] (FLINK-33611) Add the ability to reuse variable names across different split method scopes

2023-11-21 Thread Sai Sharath Dandi (Jira)
Sai Sharath Dandi created FLINK-33611: - Summary: Add the ability to reuse variable names across different split method scopes Key: FLINK-33611 URL: https://issues.apache.org/jira/browse/FLINK-33611

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-21 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1400933355 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupWindowAggregateTestPrograms.java: ## @@ -0,0 +1,256 @@

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-21 Thread via GitHub
surendralilhore commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1821341423 @gyfora Please can you help me to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-21 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1400873924 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupWindowAggregateTestPrograms.java: ## @@ -0,0 +1,256 @@

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-21 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1400870003 ##

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-21 Thread via GitHub
grzegorz8 commented on PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1821252252 > Hi @grzegorz8, thanks for your contribution. I left some comments > > but should be this PR on https://github.com/apache/flink-connector-elasticsearch ?? I

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-21 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1400851224 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-33440] Add Flink 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-11-21 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1821235845 > shoukd we wait a bit since currently 1.16.3 and 1.17.2 are in voting phase and then add all three? Yeah, that makes sense.  -- This is an automated message

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-21 Thread via GitHub
JingGe commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1400838655 ## flink-clients/src/main/java/org/apache/flink/client/cli/CheckpointOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [FLINK-33440] Add Flink 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-11-21 Thread via GitHub
snuyanzin commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1821220699 shoukd we wait a bit since currently 1.16.3 and 1.17.2 are in voting phase and then add all three? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-33440] Add Flink 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-11-21 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1821215701 I guess we should also update the `v3.0` branch, or since there were a couple features added since that would it make sense to create a `v3.1` and release that against

[jira] [Updated] (FLINK-33440) Bump flink version on flink-connectors-hbase

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33440: --- Labels: pull-request-available (was: ) > Bump flink version on flink-connectors-hbase >

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-21 Thread via GitHub
gyfora commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1400811069 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -142,9 +142,11 @@ public double

[jira] [Commented] (FLINK-33610) CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping failed with an AssertionError

2023-11-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788459#comment-17788459 ] Matthias Pohl commented on FLINK-33610: --- It's hard to grasp what the actual error is. The tests in

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-11-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788456#comment-17788456 ] Matthias Pohl commented on FLINK-18356: --- The following build failure in {{release-1.18}} happened

[jira] [Commented] (FLINK-32744) HiveDialectQueryITCase.testWithOverWindow fails with timeout

2023-11-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788450#comment-17788450 ] Matthias Pohl commented on FLINK-32744: ---

[jira] [Updated] (FLINK-32744) HiveDialectQueryITCase.testWithOverWindow fails with timeout

2023-11-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32744: -- Affects Version/s: 1.19.0 > HiveDialectQueryITCase.testWithOverWindow fails with timeout >

[jira] [Created] (FLINK-33610) CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping failed with an AssertionError

2023-11-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33610: - Summary: CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping failed with an AssertionError Key: FLINK-33610 URL: https://issues.apache.org/jira/browse/FLINK-33610

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-11-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788434#comment-17788434 ] Matthias Pohl commented on FLINK-18356: --- 1.18 backport: e4699226ec9ff077ac336fbf8a5cf2d0f61611e7

Re: [PR] [BP-1.18][FLINK-18356] Update CI image [flink]

2023-11-21 Thread via GitHub
XComp merged PR #23756: URL: https://github.com/apache/flink/pull/23756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-21 Thread via GitHub
flinkbot commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1821007113 ## CI report: * bbf51c6e8a359305f3e0d67cf0ece9bc7240070f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33609) Take into account the resource limit specified in the pod template.

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33609: --- Labels: pull-request-available (was: ) > Take into account the resource limit specified in

[PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-21 Thread via GitHub
surendralilhore opened a new pull request, #23768: URL: https://github.com/apache/flink/pull/23768 Flink is currently not considering the pod template resource limits and is only utilizing the limit obtained from the configured or default limit factor. Flink should consider both the value

[jira] [Created] (FLINK-33609) Take into account the resource limit specified in the pod template.

2023-11-21 Thread Surendra Singh Lilhore (Jira)
Surendra Singh Lilhore created FLINK-33609: -- Summary: Take into account the resource limit specified in the pod template. Key: FLINK-33609 URL: https://issues.apache.org/jira/browse/FLINK-33609

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-11-21 Thread via GitHub
JingGe commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1820932810 @dalelane would you please rebase and squash the commits? Once the CI passed, I will merge it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [hotfix][docs] Delete kafka connector docs [flink]

2023-11-21 Thread via GitHub
JingGe merged PR #23628: URL: https://github.com/apache/flink/pull/23628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400588039 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/UserDefinedFunctionTestUtils.scala: ## @@ -275,21 +296,44 @@ object

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400589355 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/table/CorrelateTest.xml: ## @@ -321,12 +321,12 @@

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400587507 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/OverAggregateITCase.scala: ## @@ -22,14 +22,16 @@ import

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400588997 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/UserDefinedTableFunctions.scala: ## @@ -429,12 +431,24 @@ abstract class

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400588441 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/SumAggFunction.scala: ## @@ -20,7 +20,13 @@ package

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400586673 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableScanTest.scala: ## @@ -63,7 +63,7 @@ class TableScanTest

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-21 Thread via GitHub
snuyanzin commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1400586235 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/DagOptimizationTest.scala: ## @@ -235,7 +235,7 @@ class

[jira] [Commented] (FLINK-33605) flink1.17 fd leak

2023-11-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788402#comment-17788402 ] Martijn Visser commented on FLINK-33605: [~oxwangfeng521] I'm sorry but there's only one

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-21 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1400542478 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -142,9 +142,11 @@ public double

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-21 Thread via GitHub
Myasuka commented on code in PR #23764: URL: https://github.com/apache/flink/pull/23764#discussion_r1400535656 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionHaServices.java: ## @@ -202,11 +199,7 @@ public void

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-11-21 Thread via GitHub
afedulov commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1820842514 From us three only Jing has the permissions to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-21 Thread via GitHub
dawidwys commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1400462743 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -151,7 +156,7 @@ public void

Re: [PR] [FLINK-33608][test-utils] UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData [flink]

2023-11-21 Thread via GitHub
flinkbot commented on PR #23767: URL: https://github.com/apache/flink/pull/23767#issuecomment-1820801731 ## CI report: * 281487aef5c1ad0207e61e7cbe22dbe222b2aba5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33608][test-utils] UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData [flink]

2023-11-21 Thread via GitHub
Jiabao-Sun commented on PR #23767: URL: https://github.com/apache/flink/pull/23767#issuecomment-1820795081 Hi @alpreu, could you help review this PR when you have time? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-33608) UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33608: --- Labels: pull-request-available (was: ) > UpsertTestDynamicTableSink's

[PR] [FLINK-33608][test-utils] UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData [flink]

2023-11-21 Thread via GitHub
Jiabao-Sun opened a new pull request, #23767: URL: https://github.com/apache/flink/pull/23767 ## What is the purpose of the change [FLINK-33608][test-utils] UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData

Re: [PR] [FLINK-33301][release] Add Java and Maven version check script [flink]

2023-11-21 Thread via GitHub
XComp commented on code in PR #23544: URL: https://github.com/apache/flink/pull/23544#discussion_r1400467360 ## tools/releasing/create_binary_release.sh: ## @@ -17,6 +17,9 @@ # limitations under the License. # +## check required Java and Maven version Review Comment:

[jira] [Created] (FLINK-33608) UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData

2023-11-21 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33608: -- Summary: UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData Key: FLINK-33608 URL:

[jira] [Updated] (FLINK-33605) flink1.17 fd leak

2023-11-21 Thread feng wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] feng wang updated FLINK-33605: -- Description: Environmental information: Flink 1.17.1;   executed the command in the Flink

  1   2   >