Re: [PR] [FLINK-33502][network] Ignore RejectedExecutionException in DiskIOScheduler when the batch read executor service shuts down [flink]

2023-11-22 Thread via GitHub
WencongLiu commented on code in PR #23781: URL: https://github.com/apache/flink/pull/23781#discussion_r1403013119 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -302,18 +299,23 @@ private void

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-22 Thread via GitHub
Myasuka commented on code in PR #23764: URL: https://github.com/apache/flink/pull/23764#discussion_r1403010154 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesConfigMapSharedInformer.java: ## @@ -38,10 +39,21 @@ public

[jira] [Commented] (FLINK-33149) Bump snappy-java to 1.1.10.4

2023-11-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789014#comment-17789014 ] Matthias Pohl commented on FLINK-33149: --- [~rskraba] wanted to work on bringing this update to the

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-22 Thread via GitHub
Myasuka commented on code in PR #23764: URL: https://github.com/apache/flink/pull/23764#discussion_r1403008922 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformerITCase.java: ## @@ -72,56 +71,41 @@ void setUp() throws

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-22 Thread via GitHub
gyfora commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1823921369 Since this will considerably change the resource handling I think we need to have at least a quick discussion on this in the dev list. Furthermore the logic should be consistent for the

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-22 Thread via GitHub
gyfora commented on code in PR #23768: URL: https://github.com/apache/flink/pull/23768#discussion_r1402993805 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java: ## @@ -367,10 +367,24 @@ public static ResourceRequirements

Re: [PR] [FLINK-33619][table-planner][JUnit5 Migration] Module: flink-table-planner (Remaining Tests) [flink]

2023-11-22 Thread via GitHub
leonardBang commented on code in PR #23775: URL: https://github.com/apache/flink/pull/23775#discussion_r1402980163 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala: ## @@ -255,7 +253,7 @@ class

Re: [PR] [FLINK-33619][table-planner][JUnit5 Migration] Module: flink-table-planner (Remaining Tests) [flink]

2023-11-22 Thread via GitHub
Jiabao-Sun commented on code in PR #23775: URL: https://github.com/apache/flink/pull/23775#discussion_r1402974265 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/table/validation/UnsupportedOpsValidationTest.scala: ## @@ -18,68

Re: [PR] [FLINK-33472][Client] Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23782: URL: https://github.com/apache/flink/pull/23782#issuecomment-1823896636 ## CI report: * cffe70a57dea9bfad80f90938c668da927b965ca UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33502][network] Ignore RejectedExecutionException in DiskIOScheduler when the batch read executor service shuts down [flink]

2023-11-22 Thread via GitHub
reswqa commented on code in PR #23781: URL: https://github.com/apache/flink/pull/23781#discussion_r1402971255 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -302,18 +299,23 @@ private void

[jira] [Commented] (FLINK-33472) Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded

2023-11-22 Thread zhengzhili (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789000#comment-17789000 ] zhengzhili commented on FLINK-33472: https://github.com/apache/flink/pull/23782 > Solve the problem

[jira] [Updated] (FLINK-33472) Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33472: --- Labels: pull-request-available (was: ) > Solve the problem that the temporary file of

[PR] [FLINK-33472][Client] Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded [flink]

2023-11-22 Thread via GitHub
zhengzhili333 opened a new pull request, #23782: URL: https://github.com/apache/flink/pull/23782 ## What is the purpose of the change *This pull request solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded.* ## Brief change log -

[jira] [Comment Edited] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-22 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788998#comment-17788998 ] Wencong Liu edited comment on FLINK-33502 at 11/23/23 6:49 AM: --- Thank

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-22 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788998#comment-17788998 ] Wencong Liu commented on FLINK-33502: - Thank [~mapohl]  for your help. The fix should be merged

Re: [PR] [FLINK-33502][network] Ignore RejectedExecutionException in DiskIOScheduler when the batch read executor service shuts down [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23781: URL: https://github.com/apache/flink/pull/23781#issuecomment-1823884883 ## CI report: * 3a14637820ab3b1fa34c6e53cf7081f99fd3d89b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33502: --- Labels: pull-request-available test-stability (was: test-stability) > HybridShuffleITCase

[PR] [FLINK-33502][network] Ignore RejectedExecutionException in DiskIOScheduler when the batch read executor service shuts down [flink]

2023-11-22 Thread via GitHub
WencongLiu opened a new pull request, #23781: URL: https://github.com/apache/flink/pull/23781 ## What is the purpose of the change *Ignore RejectedExecutionException in DiskIOScheduler when the batch read executor service shuts down.* ## Does this pull request

Re: [PR] [hotfix] Fix wrong flink-conf.yaml file path [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23780: URL: https://github.com/apache/flink/pull/23780#issuecomment-1823881216 ## CI report: * ecbec6e4eea9f1fb0d766496da8060536fe1bf02 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] Fix wrong flink-conf.yaml file path [flink]

2023-11-22 Thread via GitHub
xleoken opened a new pull request, #23780: URL: https://github.com/apache/flink/pull/23780 ## What is the purpose of the change Met exception when submit flink app to yarn which integrated with s3 ``` 2023-11-23 14:25:39,200 DEBUG

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-11-22 Thread via GitHub
AlexYinHan commented on code in PR #23514: URL: https://github.com/apache/flink/pull/23514#discussion_r1402954318 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerTest.java: ## @@ -18,19 +18,28 @@ package

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-22 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788993#comment-17788993 ] xuyang commented on FLINK-33541: Hi, [~libenchao]  when I try to fix it and add tests, I notice

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-11-22 Thread via GitHub
AlexYinHan commented on code in PR #23514: URL: https://github.com/apache/flink/pull/23514#discussion_r1402953830 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -206,6 +213,64 @@ protected PhysicalFile

Re: [PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23779: URL: https://github.com/apache/flink/pull/23779#issuecomment-1823867353 ## CI report: * 896c04a6ab9bd230e1cee0c4065480c67e680579 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-11-22 Thread via GitHub
xuyangzhong opened a new pull request, #23779: URL: https://github.com/apache/flink/pull/23779 ## What is the purpose of the change Currently RAND and RAND_INTEGER are always return type "NOT NULL" as built in functions in `FlinkSqlOperatorTable`. But when codegen, the result type is

[jira] [Updated] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33541: --- Labels: pull-request-available (was: ) > RAND_INTEGER can't be existed in a IF statement

Re: [PR] [FLINK-33619][table-planner][JUnit5 Migration] Module: flink-table-planner (Remaining Tests) [flink]

2023-11-22 Thread via GitHub
Jiabao-Sun commented on PR #23775: URL: https://github.com/apache/flink/pull/23775#issuecomment-1823858170 Hi @leonardBang, please help review it when you have time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788987#comment-17788987 ] xuyang commented on FLINK-33490: Hi, [~libenchao] [~fsk119] . I think we can pick some of the

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788984#comment-17788984 ] Shengkai Fang commented on FLINK-33490: --- +1 to clarify the behaviour. > Validate the name

Re: [PR] [FLINK-33490][table-planner] Validate the column name conflicts in view when creating view [flink]

2023-11-22 Thread via GitHub
fsk119 commented on code in PR #23760: URL: https://github.com/apache/flink/pull/23760#discussion_r1402925888 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java: ## @@ -63,6 +69,32 @@ static CatalogView

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788980#comment-17788980 ] Benchao Li commented on FLINK-33490: Great, thanks [~xuyangzhong] for the investigation! The reason

[jira] [Comment Edited] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788979#comment-17788979 ] gabrywu edited comment on FLINK-33623 at 11/23/23 4:52 AM: --- Flink Netty Client

[jira] [Commented] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788979#comment-17788979 ] gabrywu commented on FLINK-33623: - Flink Netty Client and Fink Netty Server uses different classloader,

[jira] [Commented] (FLINK-33606) Support streaming mode in Flink JDBC driver

2023-11-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788974#comment-17788974 ] Benchao Li commented on FLINK-33606: +1 to have a FLIP since this would be in public api realm. I

[jira] [Commented] (FLINK-28051) Promote ExternallyInducedSourceReader to non-experimental @Public

2023-11-22 Thread Brian Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788970#comment-17788970 ] Brian Zhou commented on FLINK-28051: Hi [~afedulov] and [~knaufk] , thanks for bringing the topic to

Re: [PR] Add release 1.17.2 [flink-web]

2023-11-22 Thread via GitHub
Myasuka commented on code in PR #696: URL: https://github.com/apache/flink-web/pull/696#discussion_r1402892048 ## docs/content/posts/2023-11-13-release-1.17.2.md: ## @@ -0,0 +1,204 @@ +--- +title: "Apache Flink 1.17.2 Release Announcement" +date: "2023-11-13T00:00:00.000Z"

[jira] [Commented] (FLINK-33149) Bump snappy-java to 1.1.10.4

2023-11-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788969#comment-17788969 ] Yun Tang commented on FLINK-33149: -- [~mapohl] When can we close this ticket? > Bump snappy-java to

[jira] [Assigned] (FLINK-33549) Exception "Factory does not implement interface YieldingOperatorFactory" thrown in batch mode

2023-11-22 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-33549: Assignee: Shuai Xu > Exception "Factory does not implement interface YieldingOperatorFactory" >

Re: [PR] Add release 1.17.2 [flink-web]

2023-11-22 Thread via GitHub
Myasuka commented on code in PR #696: URL: https://github.com/apache/flink-web/pull/696#discussion_r1402889789 ## docs/data/flink.yml: ## @@ -26,13 +26,13 @@ release_notes_url: "https://nightlies.apache.org/flink/flink-docs-release-1.18/release-notes/flink-1.18; 1.17: -

[jira] [Comment Edited] (FLINK-33549) Exception "Factory does not implement interface YieldingOperatorFactory" thrown in batch mode

2023-11-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788967#comment-17788967 ] Shuai Xu edited comment on FLINK-33549 at 11/23/23 3:39 AM: Hi [~luoyuxia] ,

[jira] [Commented] (FLINK-33549) Exception "Factory does not implement interface YieldingOperatorFactory" thrown in batch mode

2023-11-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788967#comment-17788967 ] Shuai Xu commented on FLINK-33549: -- I'd like to fix this. Could you assign it to me? [~luoyuxia]  >

Re: [PR] Add release 1.17.2 [flink-web]

2023-11-22 Thread via GitHub
Myasuka commented on code in PR #696: URL: https://github.com/apache/flink-web/pull/696#discussion_r1402889083 ## docs/content/posts/2023-11-13-release-1.17.2.md: ## @@ -0,0 +1,204 @@ +--- +title: "Apache Flink 1.17.2 Release Announcement" +date: "2023-11-13T00:00:00.000Z"

Re: [PR] [FLINK-33507][json]Support zero-timestamp.behavior option for JSON fo… [flink]

2023-11-22 Thread via GitHub
CoderUper commented on PR #23774: URL: https://github.com/apache/flink/pull/23774#issuecomment-1823784708 run azure re-run the last Azure build > 2023年11月23日 01:21,flinkbot ***@***.***> 写道: > > > CI report: > > 2cff58f

[jira] [Commented] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788963#comment-17788963 ] gabrywu commented on FLINK-33623: - I think Flink Netty Client and Fink Netty Server have nothing to do

[jira] [Updated] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gabrywu updated FLINK-33623: Attachment: (was: image-2023-11-23-10-48-43-070.png) > Metaspce leak caused by Flink Netty Client

Re: [PR] [FLINK-33624][table] Bump Guava to 32.1.3-jre [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23778: URL: https://github.com/apache/flink/pull/23778#issuecomment-1823771816 ## CI report: * 11d796a0a2e22c90d6d3f6e8dc23860f6e3c9b4c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33624) Bump Guava to 32.1.3-jre in flink-table

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33624: --- Labels: pull-request-available (was: ) > Bump Guava to 32.1.3-jre in flink-table >

[PR] [FLINK-33624][table] Bump Guava to 32.1.3-jre [flink]

2023-11-22 Thread via GitHub
JingGe opened a new pull request, #23778: URL: https://github.com/apache/flink/pull/23778 ## What is the purpose of the change Bump Guava to 32.1.3-jre ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this

[jira] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623 ] gabrywu deleted comment on FLINK-33623: - was (Author: gabry.wu): Flink Netty Server is created successfully once TASKMANAGER starts, and there is not any Flink Netty Client thread created.

Re: [PR] [FLINK-32862][format/canal-json] Support INIT operation type to be compatible with DTS on Alibaba Cloud [flink]

2023-11-22 Thread via GitHub
ruanhang1993 closed pull request #23207: [FLINK-32862][format/canal-json] Support INIT operation type to be compatible with DTS on Alibaba Cloud URL: https://github.com/apache/flink/pull/23207 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788959#comment-17788959 ] gabrywu commented on FLINK-33623: - Flink Netty Server is created successfully once TASKMANAGER starts,

[jira] [Updated] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gabrywu updated FLINK-33623: Attachment: image-2023-11-23-10-48-43-070.png > Metaspce leak caused by Flink Netty Client thread >

[jira] [Created] (FLINK-33624) Bump Guava to 32.1.3-jre in flink-table

2023-11-22 Thread Jing Ge (Jira)
Jing Ge created FLINK-33624: --- Summary: Bump Guava to 32.1.3-jre in flink-table Key: FLINK-33624 URL: https://issues.apache.org/jira/browse/FLINK-33624 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-31449) Remove DeclarativeSlotManager related logic

2023-11-22 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31449: -- Priority: Major (was: Blocker) > Remove DeclarativeSlotManager related logic >

[jira] [Commented] (FLINK-33621) Table Store with PyFlink

2023-11-22 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788950#comment-17788950 ] Jingsong Lee commented on FLINK-33621: -- Hi [~mfatihaktas] First, I think you can take a look to

Re: [PR] [FLINK-20539][table-planner] Fix type mismatch when using ROW in comp… [flink]

2023-11-22 Thread via GitHub
xuyangzhong commented on PR #23772: URL: https://github.com/apache/flink/pull/23772#issuecomment-1823737804 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
gabrywu created FLINK-33623: --- Summary: Metaspce leak caused by Flink Netty Client thread Key: FLINK-33623 URL: https://issues.apache.org/jira/browse/FLINK-33623 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-33622) table.optimizer.reuse-sub-plan-enabled doesn't work when a Table is converted to a DataStream

2023-11-22 Thread Yaroslav Tkachenko (Jira)
Yaroslav Tkachenko created FLINK-33622: -- Summary: table.optimizer.reuse-sub-plan-enabled doesn't work when a Table is converted to a DataStream Key: FLINK-33622 URL:

Re: [PR] [FLINK-33490][table-planner] Validate the column name conflicts in view when creating view [flink]

2023-11-22 Thread via GitHub
JingGe commented on code in PR #23760: URL: https://github.com/apache/flink/pull/23760#discussion_r1402846477 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -2210,6 +2211,32 @@ public void

Re: [PR] [FLINK-33301][release] Add Java and Maven version check script [flink]

2023-11-22 Thread via GitHub
JingGe commented on code in PR #23544: URL: https://github.com/apache/flink/pull/23544#discussion_r1402844665 ## tools/releasing/create_binary_release.sh: ## @@ -17,6 +17,9 @@ # limitations under the License. # +## check required Java and Maven version Review Comment:

Re: [PR] [FLINK-33301][release] Add Java and Maven version check script [flink]

2023-11-22 Thread via GitHub
JingGe closed pull request #23544: [FLINK-33301][release] Add Java and Maven version check script URL: https://github.com/apache/flink/pull/23544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33053][runtime] Refactoring of workaround to fix thread leakage on the ZooKeeper server side. [flink]

2023-11-22 Thread via GitHub
KarmaGYZ commented on PR #23773: URL: https://github.com/apache/flink/pull/23773#issuecomment-1823701763 Thanks for the fix, @XComp . Great job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-22 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1402821698 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -200,17 +213,43 @@ void

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-22 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1402827336 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -81,9 +81,22 @@ public

Re: [PR] [FLINK-33053][runtime] Refactoring of workaround to fix thread leakage on the ZooKeeper server side. [flink]

2023-11-22 Thread via GitHub
KarmaGYZ commented on code in PR #23773: URL: https://github.com/apache/flink/pull/23773#discussion_r1402826269 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriverFactory.java: ## @@ -46,11 +51,13 @@ public

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-22 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1402821994 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -95,12 +95,15 @@ public class TableTestProgram {

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-22 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1402821698 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -200,17 +213,43 @@ void

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-22 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1402821480 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupWindowAggregateTestPrograms.java: ## @@ -0,0 +1,248 @@

[jira] [Created] (FLINK-33621) Table Store with PyFlink

2023-11-22 Thread Mehmet Aktas (Jira)
Mehmet Aktas created FLINK-33621: Summary: Table Store with PyFlink Key: FLINK-33621 URL: https://issues.apache.org/jira/browse/FLINK-33621 Project: Flink Issue Type: Technical Debt

[jira] [Updated] (FLINK-28051) Promote ExternallyInducedSourceReader to non-experimental @Public

2023-11-22 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-28051: -- Summary: Promote ExternallyInducedSourceReader to non-experimental @Public (was:

Re: [PR] Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.13 in /flink-connector-elasticsearch-base [flink-connector-elasticsearch]

2023-11-22 Thread via GitHub
dependabot[bot] closed pull request #79: Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.13 in /flink-connector-elasticsearch-base URL: https://github.com/apache/flink-connector-elasticsearch/pull/79 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.13 in /flink-connector-elasticsearch-base [flink-connector-elasticsearch]

2023-11-22 Thread via GitHub
dependabot[bot] commented on PR #79: URL: https://github.com/apache/flink-connector-elasticsearch/pull/79#issuecomment-1823494310 Superseded by #82. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.14 in /flink-connector-elasticsearch-base [flink-connector-elasticsearch]

2023-11-22 Thread via GitHub
dependabot[bot] opened a new pull request, #82: URL: https://github.com/apache/flink-connector-elasticsearch/pull/82 Bumps [org.elasticsearch:elasticsearch](https://github.com/elastic/elasticsearch) from 7.10.2 to 7.17.14. Release notes Sourced from

Re: [PR] [FLINK-28048] Introduce Source API alternative to FiniteTestSource [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1823445930 ## CI report: * 7bc98dc22aff95adbd94fcc88b9411af1bdf9b28 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Draft [FLINK-28048] [flink]

2023-11-22 Thread via GitHub
afedulov closed pull request #23665: Draft [FLINK-28048] URL: https://github.com/apache/flink/pull/23665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] [FLINK-28048] Introduce Source API alternative to FiniteTestSource [flink]

2023-11-22 Thread via GitHub
afedulov opened a new pull request, #23777: URL: https://github.com/apache/flink/pull/23777 ## What is the purpose of the change FiniteTestSource used for testing various bulk writers is based on the deprecates `SourceFunction` API. This PR introduces an alternative that provides

[jira] [Created] (FLINK-33620) Add Java 21 to docker image

2023-11-22 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33620: --- Summary: Add Java 21 to docker image Key: FLINK-33620 URL: https://issues.apache.org/jira/browse/FLINK-33620 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-22 Thread via GitHub
snuyanzin commented on code in PR #23685: URL: https://github.com/apache/flink/pull/23685#discussion_r1402650157 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkSubQueryRemoveRule.scala: ## @@ -216,6 +216,18 @@ class

Re: [PR] [hotfix][docs] Remove reference to obsolete Collector and refer to yield instead [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23776: URL: https://github.com/apache/flink/pull/23776#issuecomment-1823415440 ## CI report: * ef0177d4757b369b352415da657e5a31715ab2af UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][docs] Remove reference to obsolete Collector and refer to yield instead [flink]

2023-11-22 Thread via GitHub
afedulov opened a new pull request, #23776: URL: https://github.com/apache/flink/pull/23776 This is a trivial documentation fix: there is no `Collector` in PyFlink, `yield` has to be used instead. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33610][runtime] Fix unstable test CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping [flink]

2023-11-22 Thread via GitHub
Jiabao-Sun commented on code in PR #23770: URL: https://github.com/apache/flink/pull/23770#discussion_r1402565436 ## flink-runtime/src/test/java/org/apache/flink/runtime/operators/CoGroupTaskTest.java: ## @@ -406,46 +328,28 @@ void testCancelCoGroupTaskWhileCoGrouping() {

Re: [PR] [FLINK-33619][table-planner][JUnit5 Migration] Module: flink-table-planner (Remaining Tests) [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23775: URL: https://github.com/apache/flink/pull/23775#issuecomment-1823224922 ## CI report: * 3116ca29e1ad846e72153e34fa1fb727b4891795 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33619][table-planner][JUnit5 Migration] Module: flink-table-planner (Remaining Tests) [flink]

2023-11-22 Thread via GitHub
Jiabao-Sun opened a new pull request, #23775: URL: https://github.com/apache/flink/pull/23775 ## What is the purpose of the change [FLINK-33619][table-planner][JUnit5 Migration] Module: flink-table-planner (Remaining Tests) ## Brief change log [JUnit5 Migration]

[jira] [Updated] (FLINK-33619) [JUnit5 Migration] Module: flink-table-planner (Remaining Tests)

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33619: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] Module: flink-table-planner

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-22 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1402445510 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33507][json]Support zero-timestamp.behavior option for JSON fo… [flink]

2023-11-22 Thread via GitHub
flinkbot commented on PR #23774: URL: https://github.com/apache/flink/pull/23774#issuecomment-1823186964 ## CI report: * 2cff58f1a6cd2ddea1e31dbe382f1abc1d5c8ac8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33507) JsonToRowDataConverters can't parse zero timestamp '0000-00-00 00:00:00'

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33507: --- Labels: CDC JsonFormatter Kafka MySQL pull-request-available (was: CDC JsonFormatter Kafka

[PR] [FLINK-33507][json]Support zero-timestamp.behavior option for JSON fo… [flink]

2023-11-22 Thread via GitHub
CoderUper opened a new pull request, #23774: URL: https://github.com/apache/flink/pull/23774 ## What is the purpose of the change This pull requests support a new json-format option:*zero-timestamp.behavior* when we deserialize a json string to RowData. In

[jira] [Created] (FLINK-33619) [JUnit5 Migration] Module: flink-table-planner (Remaining Tests)

2023-11-22 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33619: -- Summary: [JUnit5 Migration] Module: flink-table-planner (Remaining Tests) Key: FLINK-33619 URL: https://issues.apache.org/jira/browse/FLINK-33619 Project: Flink

[jira] [Commented] (FLINK-33606) Support streaming mode in Flink JDBC driver

2023-11-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788841#comment-17788841 ] Martijn Visser commented on FLINK-33606: I think it would be good to have a FLIP and a

[jira] [Commented] (FLINK-33606) Support streaming mode in Flink JDBC driver

2023-11-22 Thread Sangram Reddy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788838#comment-17788838 ] Sangram Reddy commented on FLINK-33606: --- Hi We will not be breaking any standard and Flink

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-22 Thread via GitHub
mxm commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1402359219 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -142,6 +142,27 @@ private static

Re: [PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-22 Thread via GitHub
alpinegizmo commented on code in PR #23743: URL: https://github.com/apache/flink/pull/23743#discussion_r1402329936 ## docs/content/docs/dev/table/jdbcDriver.md: ## @@ -228,8 +252,8 @@ public class Sample { } ``` -### Use with Others +### Other languages -In addition to

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-22 Thread via GitHub
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1823069285 @MartijnVisser are you ok you'd like to have anything else improved? (asking since you are marked as one who requested changes) -- This is an automated message from the

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-22 Thread via GitHub
eskabetxe commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1823053525 > can you also change PR's description to match changes within this PR? done -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33501][ci] Makes use of Maven wrapper [flink]

2023-11-22 Thread via GitHub
XComp commented on PR #23689: URL: https://github.com/apache/flink/pull/23689#issuecomment-1823042304 Another force push to cover the changes of FLINK-33503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2023-11-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788818#comment-17788818 ] Sergey Nuyanzin commented on FLINK-33115: -

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-22 Thread via GitHub
gaborgsomogyi commented on PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#issuecomment-1823032588 Thanks for the efforts! I've gone through the code and the direction looks good in general. There are some points where we can simplify the code without changing

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2023-11-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788817#comment-17788817 ] Sergey Nuyanzin commented on FLINK-33115: -

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-22 Thread via GitHub
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1823008918 great, thanks can you also change PR's description to match changes within this PR? -- This is an automated message from the Apache Git Service. To respond to the

  1   2   >