Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1867349736 ## CI report: * d996c020cea9582b5df989f4eb277efb395931fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33217) Flink SQL: UNNEST fails with on LEFT JOIN with NOT NULL type in array

2023-12-21 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799692#comment-17799692 ] Jane Chan commented on FLINK-33217: --- Sorry for being late. Hi, [~xuyangzhong], thanks for the

Re: [PR] [FLINK-33927][table] Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS) [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23983: URL: https://github.com/apache/flink/pull/23983#issuecomment-1867344725 ## CI report: * d8230c9858c38019428e42bc8a7ee411fdb2d345 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33792) Generate the same code for the same logic

2023-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33792: --- Labels: pull-request-available (was: ) > Generate the same code for the same logic >

[PR] [FLINK-33792] Generate the same code for the same logic [flink]

2023-12-21 Thread via GitHub
zoudan opened a new pull request, #23984: URL: https://github.com/apache/flink/pull/23984 ## What is the purpose of the change This pull request ensure that we generate the same code for the same logic, it is a precondition for sharing generated classes between different jobs.

[PR] [FLINK-33927][table] Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS) [flink]

2023-12-21 Thread via GitHub
liyubin117 opened a new pull request, #23983: URL: https://github.com/apache/flink/pull/23983 ## What is the purpose of the change Cleanup the usage of deprecated org.apache.flink.table.api.config.ExecutionConfigOptions#TABLE_EXEC_SHUFFLE_MODE,

[jira] [Updated] (FLINK-33927) Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS)

2023-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33927: --- Labels: pull-request-available (was: ) > Cleanup usage of deprecated

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799688#comment-17799688 ] Benchao Li commented on FLINK-33490: [~xuyangzhong] No, I mean  {code:SQL} CREATE VIEW MyView(col1,

[jira] [Commented] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799686#comment-17799686 ] Tom commented on FLINK-33917: - I've also raised this as a JDK bug in the mean time

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434780474 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434780474 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434780474 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[jira] [Updated] (FLINK-33927) Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS)

2023-12-21 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-33927: - Description: |org.apache.flink.table.api.config.ExecutionConfigOptions#TABLE_EXEC_SHUFFLE_MODE|

[jira] [Created] (FLINK-33927) Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS)

2023-12-21 Thread Yubin Li (Jira)
Yubin Li created FLINK-33927: Summary: Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS) Key: FLINK-33927 URL:

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434766546 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -83,12 +92,27 @@ default void

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799679#comment-17799679 ] xuyang commented on FLINK-33490: Hi, [~libenchao] .IIUC, do you mean we need to support the following

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434764455 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[jira] [Updated] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom updated FLINK-33917: Description: In certain scenarios, if the hostname contains certain characters it will throw an exception when

[jira] [Comment Edited] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799677#comment-17799677 ] Tom edited comment on FLINK-33917 at 12/22/23 6:25 AM: --- Actually uri("123-test")

[jira] [Comment Edited] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799677#comment-17799677 ] Tom edited comment on FLINK-33917 at 12/22/23 6:25 AM: --- Actually uri("123-test")

[jira] [Updated] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom updated FLINK-33917: Description: In certain scenarios, if the hostname contains certain characters it will throw an exception when

[jira] [Commented] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799677#comment-17799677 ] Tom commented on FLINK-33917: - Actually uri("123-test") does work. The issue here is the  '.' followed by a

Re: [PR] [FLINK-33583][table] support state ttl hint for join [flink]

2023-12-21 Thread via GitHub
LadyForest commented on PR #23752: URL: https://github.com/apache/flink/pull/23752#issuecomment-1867289962 Hi @xuyangzhong, sorry for being late. Could you mind rebasing the master and resolving the conflicts? I'll take a look within this week. -- This is an automated message from the

[jira] [Resolved] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-32850. Resolution: Implemented All PRs merged, close this ticket > [JUnit5 Migration] The io package of

[jira] [Updated] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-32850: --- Affects Version/s: 1.18.0 > [JUnit5 Migration] The io package of flink-runtime module >

[jira] [Updated] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-32850: --- Fix Version/s: 1.19.0 > [JUnit5 Migration] The io package of flink-runtime module >

[jira] [Commented] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799659#comment-17799659 ] Jiabao Sun commented on FLINK-32850: Thanks [~Weijie Guo], this task is finished. Could you help

[jira] [Assigned] (FLINK-33653) Introduce a benchmark for balanced tasks scheduling

2023-12-21 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33653: --- Assignee: RocMarshal > Introduce a benchmark for balanced tasks scheduling >

[jira] [Assigned] (FLINK-33874) Support resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler

2023-12-21 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33874: --- Assignee: RocMarshal > Support resource request wait mechanism at DefaultDeclarativeSlotPool side

[jira] [Assigned] (FLINK-33875) Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler

2023-12-21 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33875: --- Assignee: RocMarshal > Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default

[jira] [Commented] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799652#comment-17799652 ] Weijie Guo commented on FLINK-32850: master(1.19) via 462708228df253de09e0a002ee0f2bee94e701c5. >

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-21 Thread via GitHub
reswqa closed pull request #23974: [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module URL: https://github.com/apache/flink/pull/23974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Comment Edited] (FLINK-32513) Job in BATCH mode with a significant number of transformations freezes on method StreamGraphGenerator.existsUnboundedSource()

2023-12-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799647#comment-17799647 ] Zhu Zhu edited comment on FLINK-32513 at 12/22/23 2:46 AM: --- The problem

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-21 Thread via GitHub
Jiabao-Sun commented on PR #23974: URL: https://github.com/apache/flink/pull/23974#issuecomment-1867163701 > After this PR, whether all tests in `io.network` have been migrated? Yes. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-32513) Job in BATCH mode with a significant number of transformations freezes on method StreamGraphGenerator.existsUnboundedSource()

2023-12-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799647#comment-17799647 ] Zhu Zhu commented on FLINK-32513: - The problem happens because the {{getTransitivePredecessors()}} of

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-21 Thread via GitHub
reswqa commented on PR #23974: URL: https://github.com/apache/flink/pull/23974#issuecomment-1867145877 After this PR, whether all tests in `io.network` have been migrated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (FLINK-25476) CharType lost in the creation of MaxAggFunction & MinAggFunction

2023-12-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-25476. --- Fix Version/s: 1.19.0 Resolution: Fixed > CharType lost in the creation of MaxAggFunction &

[jira] [Commented] (FLINK-25476) CharType lost in the creation of MaxAggFunction & MinAggFunction

2023-12-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799640#comment-17799640 ] dalongliu commented on FLINK-25476: --- Merged to master: 085859ec19f59d2f8e73632e96fae59f7821c7d0 >

Re: [PR] [FLINK-25476][table-planner] support CHAR type in function MAX and MIN [flink]

2023-12-21 Thread via GitHub
lsyldliu closed pull request #18375: [FLINK-25476][table-planner] support CHAR type in function MAX and MIN URL: https://github.com/apache/flink/pull/18375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [BP-1.18][FLINK-27082][ci] Adds a github-actions profile that disables certain tests that do not run in GHA [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23982: URL: https://github.com/apache/flink/pull/23982#issuecomment-1867064898 ## CI report: * 6c905021e5b09a3537a68d208749bdc8ee1061f5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
XComp merged PR #23962: URL: https://github.com/apache/flink/pull/23962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [BP-1.18][FLINK-27082][ci] Adds a github-actions profile that disables certain tests that do not run in GHA [flink]

2023-12-21 Thread via GitHub
XComp commented on PR #23982: URL: https://github.com/apache/flink/pull/23982#issuecomment-1867063585 @snuyanzin can you do another quick pass over this one considering that there were some conflicts which I had to resolve? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-12-21 Thread via GitHub
snuyanzin commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1867027544 There was snappy update, probably need to add explicit dependency to cope with

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1434572736 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
XComp commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1434558666 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799584#comment-17799584 ] Sai Sharath Dandi commented on FLINK-33817: --- [~libenchao] , Can you please take a look at this

[jira] [Updated] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-33817: -- Description: *Background*   The current Protobuf format

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi edited comment on FLINK-33611 at 12/21/23 9:23 PM: -

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi edited comment on FLINK-33611 at 12/21/23 9:22 PM: -

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799583#comment-17799583 ] Sai Sharath Dandi commented on FLINK-33611: --- Fwiw, I've run into this issue for one of our

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi edited comment on FLINK-33611 at 12/21/23 8:18 PM: -

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi commented on FLINK-33611: --- [~libenchao] , The constant pool size

Re: [PR] [FLINK-33611] [flink-protobuf] Support Large Protobuf Schemas [flink]

2023-12-21 Thread via GitHub
sharath1709 commented on PR #23937: URL: https://github.com/apache/flink/pull/23937#issuecomment-1866817077 @libenchao Thanks for the quick response. Sure, let's try to reach an agreement on the JIRA first -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Component/s: Kubernetes Operator > Can't start a job with a jar in the system classpath in native k8s

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Created] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
Trystan created FLINK-33926: --- Summary: Can't start a job with a jar in the system classpath in native k8s mode Key: FLINK-33926 URL: https://issues.apache.org/jira/browse/FLINK-33926 Project: Flink

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s

[PR] Mircea - module 1 [flink-training]

2023-12-21 Thread via GitHub
ness-MirceaLutic opened a new pull request, #68: URL: https://github.com/apache/flink-training/pull/68 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434220037 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434216202 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -83,12 +92,27 @@ default void

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434212997 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434211420 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434209212 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[jira] [Commented] (FLINK-20772) RocksDBValueState with TTL occurs NullPointerException when calling update(null) method

2023-12-21 Thread Seongbae Chang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799448#comment-17799448 ] Seongbae Chang commented on FLINK-20772: [~masteryhx], [~Zakelly] Sorry for the late response.

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
mxm commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434199585 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434166658 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
XComp commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1434112468 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {

Re: [PR] [FLINK-33132] Flink Connector Redshift TableSink Implementation [flink-connector-aws]

2023-12-21 Thread via GitHub
Samrat002 commented on PR #114: URL: https://github.com/apache/flink-connector-aws/pull/114#issuecomment-1866305970 @hlteoh37, @vahmed-hamdy please review in free time  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1866302758 having maven wrapper does not protect from running with installed maven -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (FLINK-33902) Switch to OpenSSL legacy algorithms

2023-12-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33902. --- Fix Version/s: 1.19.0 1.18.1 Resolution: Fixed master:

Re: [PR] [BP-1.18][FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-21 Thread via GitHub
XComp merged PR #23979: URL: https://github.com/apache/flink/pull/23979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [BP-1.18][FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-21 Thread via GitHub
XComp commented on PR #23979: URL: https://github.com/apache/flink/pull/23979#issuecomment-1866296953 I'm merging w/o extra review because there were no conflicts in the backport and the parent PR was approved. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-21 Thread via GitHub
XComp merged PR #23961: URL: https://github.com/apache/flink/pull/23961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1866287852 ## CI report: * 8bac98b51ccb4a13d5a498e377f17bb86b953b1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] [docs] Update README.md to remove Maven [flink]

2023-12-21 Thread via GitHub
asafm opened a new pull request, #23981: URL: https://github.com/apache/flink/pull/23981 ## What is the purpose of the change Small fix to README ## Brief change log No need for pre-installed maven, since we have Maven Wrapper ## Verifying this change

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434090851 ## pom.xml: ## @@ -63,6 +63,9 @@ under the License. flink-connector-jdbc-parent 1 + +-XX:+UseG1GC -Xms256m

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434090595 ## flink-connector-jdbc/pom.xml: ## @@ -42,6 +42,10 @@ under the License. 21.8.0.0 418 1.12.10 +

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434090293 ## .github/workflows/push_pr.yml: ## @@ -25,7 +25,14 @@ jobs: compile_and_test: strategy: matrix: -flink: [1.16-SNAPSHOT,

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434090293 ## .github/workflows/push_pr.yml: ## @@ -25,7 +25,14 @@ jobs: compile_and_test: strategy: matrix: -flink: [1.16-SNAPSHOT,

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434090595 ## flink-connector-jdbc/pom.xml: ## @@ -42,6 +42,10 @@ under the License. 21.8.0.0 418 1.12.10 +

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434066148 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig [flink]

2023-12-21 Thread via GitHub
liyubin117 commented on PR #23980: URL: https://github.com/apache/flink/pull/23980#issuecomment-1866172964 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799400#comment-17799400 ] Benchao Li commented on FLINK-33611: I'm wondering how large will it be that can reach this limit?

Re: [PR] [FLINK-33611] [flink-protobuf] Support Large Protobuf Schemas [flink]

2023-12-21 Thread via GitHub
libenchao commented on PR #23937: URL: https://github.com/apache/flink/pull/23937#issuecomment-1866145686 @sharath1709 Thanks for your contribution. Per the community's convention, we need to reach an agreement on the issue before we go to the PR review. I'll comment on the corresponding

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
mxm commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433991220 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -83,12 +92,27 @@ default void handleScalingEvent(

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
mxm commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433989601 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799398#comment-17799398 ] Benchao Li commented on FLINK-33490: The standard states that: {quote}i) If any two columns in the

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433973975 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433973067 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23980: URL: https://github.com/apache/flink/pull/23980#issuecomment-1866115231 ## CI report: * 620ea94f2829ebc8c55ab0657261c65f6881054b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33925) Extended failure handling for bulk requests (elasticsearch back port)

2023-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33925: --- Labels: pull-request-available (was: ) > Extended failure handling for bulk requests

Re: [PR] [FLINK-33925][connectors/opensearch] Allow customising bulk failure handling [flink-connector-opensearch]

2023-12-21 Thread via GitHub
boring-cyborg[bot] commented on PR #39: URL: https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1866114172 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) --

[PR] [FLINK-33925][connectors/opensearch] Allow customising bulk failure handling [flink-connector-opensearch]

2023-12-21 Thread via GitHub
schulzp opened a new pull request, #39: URL: https://github.com/apache/flink-connector-opensearch/pull/39 This is a back port of the implementation for the elasticsearch connector, see [FLINK-32028](https://issues.apache.org/jira/browse/FLINK-32028), to achieve consistent APIs.

[jira] [Created] (FLINK-33925) Extended failure handling for bulk requests (elasticsearch back port)

2023-12-21 Thread Peter Schulz (Jira)
Peter Schulz created FLINK-33925: Summary: Extended failure handling for bulk requests (elasticsearch back port) Key: FLINK-33925 URL: https://issues.apache.org/jira/browse/FLINK-33925 Project: Flink

[PR] Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig [flink]

2023-12-21 Thread via GitHub
liyubin117 opened a new pull request, #23980: URL: https://github.com/apache/flink/pull/23980 ## What is the purpose of the change Cleanup the usage of deprecated org.apache.flink.table.api.TableConfig#getMinIdleStateRetentionTime,

Re: [PR] [BP-1.18][FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23979: URL: https://github.com/apache/flink/pull/23979#issuecomment-1866078496 ## CI report: * 7d32f61389784a833100d065c17ffd2fca753eb4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-21 Thread via GitHub
XComp commented on PR #23961: URL: https://github.com/apache/flink/pull/23961#issuecomment-1866076157 Thanks for approving the PR. I created the corresponding 1.18 backport. :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >