[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804056#comment-17804056 ] Sergey Nuyanzin commented on FLINK-33115: -

[jira] [Created] (FLINK-34011) EmbeddedThreadDependencyTests.test_add_python_file fails with This function should not be called!

2024-01-07 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34011: --- Summary: EmbeddedThreadDependencyTests.test_add_python_file fails with This function should not be called! Key: FLINK-34011 URL:

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804055#comment-17804055 ] Sergey Nuyanzin commented on FLINK-33115: - 1.18:

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804054#comment-17804054 ] Sergey Nuyanzin commented on FLINK-31472: - 1.18:

[jira] [Created] (FLINK-34010) KafkaTableITCase.testPerPartitionWatermarkWithIdleSource is unstable on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34010: --- Summary: KafkaTableITCase.testPerPartitionWatermarkWithIdleSource is unstable on AZP Key: FLINK-34010 URL: https://issues.apache.org/jira/browse/FLINK-34010

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804053#comment-17804053 ] Sergey Nuyanzin commented on FLINK-28440: - Redirected to here from FLINK-30107

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804052#comment-17804052 ] Sergey Nuyanzin commented on FLINK-31472: - 1.17:

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804051#comment-17804051 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Updated] (FLINK-30433) HiveDialectITCase#testCreateDatabase fails with "Could not execute CREATE DATABASE"

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-30433: Affects Version/s: 1.18.0 > HiveDialectITCase#testCreateDatabase fails with "Could not

[jira] [Commented] (FLINK-30433) HiveDialectITCase#testCreateDatabase fails with "Could not execute CREATE DATABASE"

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804049#comment-17804049 ] Sergey Nuyanzin commented on FLINK-30433: - 1.18:

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804048#comment-17804048 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Comment Edited] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804048#comment-17804048 ] Sergey Nuyanzin edited comment on FLINK-31472 at 1/8/24 12:15 AM: --

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804047#comment-17804047 ] Sergey Nuyanzin commented on FLINK-22765: -

[jira] [Commented] (FLINK-27916) HybridSourceReaderTest.testReader failed with AssertionError

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804045#comment-17804045 ] Sergey Nuyanzin commented on FLINK-27916: - 1.17:

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804046#comment-17804046 ] Sergey Nuyanzin commented on FLINK-27756: -

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804044#comment-17804044 ] Sergey Nuyanzin commented on FLINK-27756: -

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804043#comment-17804043 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Commented] (FLINK-32483) RescaleCheckpointManuallyITCase.testCheckpointRescalingOutKeyedState fails on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804042#comment-17804042 ] Sergey Nuyanzin commented on FLINK-32483: -

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804040#comment-17804040 ] Sergey Nuyanzin commented on FLINK-31472: - 1.17:

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804038#comment-17804038 ] Sergey Nuyanzin commented on FLINK-22765: -

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804037#comment-17804037 ] Sergey Nuyanzin commented on FLINK-28440: - Redirected to here from FLINK-30107

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804034#comment-17804034 ] Sergey Nuyanzin commented on FLINK-33115: - 1.18:

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804033#comment-17804033 ] Sergey Nuyanzin commented on FLINK-31472: - 1.18:

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804032#comment-17804032 ] Sergey Nuyanzin commented on FLINK-33115: -

[jira] [Comment Edited] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804032#comment-17804032 ] Sergey Nuyanzin edited comment on FLINK-33115 at 1/7/24 11:50 PM: --

[jira] [Comment Edited] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804030#comment-17804030 ] Sergey Nuyanzin edited comment on FLINK-26515 at 1/7/24 11:43 PM: --

[jira] [Commented] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804030#comment-17804030 ] Sergey Nuyanzin commented on FLINK-26515: -

[jira] [Updated] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33115: Affects Version/s: 1.17.3 > AbstractHadoopRecoverableWriterITCase is hanging with timeout

[jira] [Comment Edited] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804029#comment-17804029 ] Sergey Nuyanzin edited comment on FLINK-33115 at 1/7/24 11:40 PM: --

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804029#comment-17804029 ] Sergey Nuyanzin commented on FLINK-33115: -

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804028#comment-17804028 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804027#comment-17804027 ] Sergey Nuyanzin commented on FLINK-22765: -

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804026#comment-17804026 ] Sergey Nuyanzin commented on FLINK-33115: -

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804025#comment-17804025 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Commented] (FLINK-33574) testRecoverAfterMultiplePersistsStateWithMultiPart andtestRecoverAfterMultiplePersistsStateWithMultiPart run into timeouts

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804023#comment-17804023 ] Sergey Nuyanzin commented on FLINK-33574: - [~mapohl] it seems it is a duplicate of FLINK-33115

[jira] [Commented] (FLINK-33115) AbstractHadoopRecoverableWriterITCase is hanging with timeout on AZP

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804024#comment-17804024 ] Sergey Nuyanzin commented on FLINK-33115: -

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804022#comment-17804022 ] Sergey Nuyanzin commented on FLINK-22765: -

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804021#comment-17804021 ] Sergey Nuyanzin commented on FLINK-27756: -

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804020#comment-17804020 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804019#comment-17804019 ] Sergey Nuyanzin commented on FLINK-27756: -

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804018#comment-17804018 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804017#comment-17804017 ] Sergey Nuyanzin commented on FLINK-27756: - [~chalixar] thanks for looking into this any idea how

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804016#comment-17804016 ] Sergey Nuyanzin commented on FLINK-31472: - 1.18:

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804014#comment-17804014 ] Sergey Nuyanzin commented on FLINK-31472: -

[jira] [Comment Edited] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804014#comment-17804014 ] Sergey Nuyanzin edited comment on FLINK-31472 at 1/7/24 11:18 PM: --

[jira] [Reopened] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-31472: - Have to reopen since it is reproduced after the fix

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804013#comment-17804013 ] Sergey Nuyanzin commented on FLINK-31472: - [~chalixar] could you please have a look? >

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444085074 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicatePlanTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444085074 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicatePlanTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444084926 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ## @@ -52,8 +69,26 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1880199985 @davidradl thanks for your efforts Based on findings I created a PR to your branch https://github.com/davidradl/flink-connector-jdbc/pull/1 which passes all the tests

Re: [PR] [hotfix][docs] fix typo in ddl data type [flink]

2024-01-07 Thread via GitHub
flinkbot commented on PR #24038: URL: https://github.com/apache/flink/pull/24038#issuecomment-1880134737 ## CI report: * 10ed140dbacb7bed0e6aef16c44054fb918c09b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34009) Apache flink: Checkpoint restoration issue on Application Mode of deployment

2024-01-07 Thread Vijay (Jira)
Vijay created FLINK-34009: - Summary: Apache flink: Checkpoint restoration issue on Application Mode of deployment Key: FLINK-34009 URL: https://issues.apache.org/jira/browse/FLINK-34009 Project: Flink

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444024895 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ## @@ -52,8 +69,26 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444027424 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicatePlanTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444024895 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ## @@ -52,8 +69,26 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444006740 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ## @@ -52,8 +69,26 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444006740 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ## @@ -52,8 +69,26 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444005737 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicatePlanTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444005456 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicatePlanTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1443986879 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ## @@ -52,8 +69,26 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-07 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1443983356 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownPreparedStatementVisitor.java: ## @@ -46,8 +50,53 @@ public

Re: [PR] [FLINK-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot [flink]

2024-01-07 Thread via GitHub
jiangxin369 commented on code in PR #23977: URL: https://github.com/apache/flink/pull/23977#discussion_r1443960924 ## flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java: ## @@ -127,6 +129,11 @@ private void

<    1   2