Re: [PR] [FLINK-34410][ci] Disables the nightly trigger workflow for forks [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24291: URL: https://github.com/apache/flink/pull/24291#issuecomment-1933536761 ## CI report: * e46a0011b4cacac0b793307c4e58b17dbb109a41 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34267][CI] Update miniconda install script to fix build on MacOS [flink-connector-shared-utils]

2024-02-07 Thread via GitHub
gaborgsomogyi commented on PR #34: URL: https://github.com/apache/flink-connector-shared-utils/pull/34#issuecomment-1933528414 @pvary do you remember why we added the old conda version here? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (FLINK-34410) Disable nightly trigger in forks

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34410: -- Description: We can disable the automatic triggering of the nightly trigger workflow in fork

[jira] [Updated] (FLINK-34410) Disable nightly trigger in forks

2024-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34410: --- Labels: pull-request-available (was: ) > Disable nightly trigger in forks >

[PR] [FLINK-34410][ci] Disables the nightly trigger workflow for forks [flink]

2024-02-07 Thread via GitHub
XComp opened a new pull request, #24291: URL: https://github.com/apache/flink/pull/24291 ## What is the purpose of the change Disables the nightly trigger for the forks. The nightly builds can be still triggered manually through the [`workflow_dispatch` trigger of the nightly

Re: [PR] [FLINK-34267][CI] Update miniconda install script to fix build on MacOS [flink-connector-shared-utils]

2024-02-07 Thread via GitHub
gaborgsomogyi commented on PR #34: URL: https://github.com/apache/flink-connector-shared-utils/pull/34#issuecomment-1933522906 I've just taken a small look at the release date of the mentioned version and seems like it's released on `2019-10-25`. Is it possible to use a more recent

[jira] [Assigned] (FLINK-34410) Disable nightly trigger in forks

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34410: - Assignee: Matthias Pohl > Disable nightly trigger in forks >

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1933490545 ## CI report: * 096179ded432aefd53274cc26402c82a274b4865 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34410) Disable nightly trigger in forks

2024-02-07 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34410: - Summary: Disable nightly trigger in forks Key: FLINK-34410 URL: https://issues.apache.org/jira/browse/FLINK-34410 Project: Flink Issue Type: Technical

[jira] [Updated] (FLINK-33936) Outputting Identical Results in Mini-Batch Aggregation with Set TTL

2024-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33936: --- Labels: pull-request-available (was: ) > Outputting Identical Results in Mini-Batch

[PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-07 Thread via GitHub
hackergin opened a new pull request, #24290: URL: https://github.com/apache/flink/pull/24290 ## What is the purpose of the change *Outputting Identical Results in Mini-Batch Aggregation with Set TTL* ## Brief change log - Outputting Identical Results in Mini-Batch

[jira] [Updated] (FLINK-33936) Outputting Identical Results in Mini-Batch Aggregation with Set TTL

2024-02-07 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33936: - Summary: Outputting Identical Results in Mini-Batch Aggregation with Set TTL (was: The aggregation of

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-07 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1482469765 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/utils/MemoryTuningUtils.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-07 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1482469765 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/utils/MemoryTuningUtils.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815532#comment-17815532 ] Piotr Nowojski edited comment on FLINK-34289 at 2/8/24 6:33 AM:

[jira] [Commented] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815532#comment-17815532 ] Piotr Nowojski commented on FLINK-34289: !Screenshot 2024-02-08 at 07.22.19.png! This part

[jira] [Commented] (FLINK-34405) RightOuterJoinTaskTest#testCancelOuterJoinTaskWhileSort2 fails due to an interruption of the RightOuterJoinDriver#prepare method

2024-02-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815531#comment-17815531 ] Rui Fan commented on FLINK-34405: -

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-07 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1482361348 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -250,6 +251,31 @@ private static

[jira] [Updated] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34289: --- Attachment: Screenshot 2024-02-08 at 07.22.19.png > Release Testing Instructions: Verify

Re: [PR] [FLINK-34386][state] Add RocksDB bloom filter metrics [flink]

2024-02-07 Thread via GitHub
hejufang commented on PR #24274: URL: https://github.com/apache/flink/pull/24274#issuecomment-1933419178 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate … [flink]

2024-02-07 Thread via GitHub
caodizhou commented on PR #24115: URL: https://github.com/apache/flink/pull/24115#issuecomment-1933323089 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34060][table] Migrate UserDefinedTableAggFunctions to JavaUserDefinedTableAggFunctions [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24289: URL: https://github.com/apache/flink/pull/24289#issuecomment-1933319116 ## CI report: * ebc29752d43c83eef334c29498202c888142893f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-33489) LISTAGG with generating partial-final agg will cause wrong result

2024-02-07 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang resolved FLINK-33489. Resolution: Resolved > LISTAGG with generating partial-final agg will cause wrong result >

[jira] [Updated] (FLINK-34060) Migrate UserDefinedTableAggFunctions to JavaUserDefinedTableAggFunctions

2024-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34060: --- Labels: pull-request-available (was: ) > Migrate UserDefinedTableAggFunctions to

[PR] [FLINK-34060][table] Migrate UserDefinedTableAggFunctions to JavaUserDefinedTableAggFunctions [flink]

2024-02-07 Thread via GitHub
xuyangzhong opened a new pull request, #24289: URL: https://github.com/apache/flink/pull/24289 ## What is the purpose of the change The Top3 function emits a tuple of (entry.getKey, entry.getKey) see

Re: [PR] [FLINK-34192] Update to be compatible with updated SinkV2 interfaces [flink-connector-kafka]

2024-02-07 Thread via GitHub
Jiabao-Sun commented on PR #84: URL: https://github.com/apache/flink-connector-kafka/pull/84#issuecomment-1933308568 By the way, this PR was blocked by https://github.com/apache/flink/pull/24249 before is that InitContextWrapper does not implement the metadataConsumer (introduced by

Re: [PR] [FLINK-34192] Update to be compatible with updated SinkV2 interfaces [flink-connector-kafka]

2024-02-07 Thread via GitHub
Jiabao-Sun commented on PR #84: URL: https://github.com/apache/flink-connector-kafka/pull/84#issuecomment-1933305498 Thanks @mas-chen for the review. The main reason for this PR is in version 1.19, due to the introduction of WriterInitContext by FLINK-33973. In terms of code

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-02-07 Thread via GitHub
lajith2006 commented on PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#issuecomment-1933293529 > > > > @gyfora yes, I am having JIRA account using which I can login to https://issues.apache.org/jira/projects/FLINK/. > > > > > > > > > okay then can you

[jira] [Commented] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815489#comment-17815489 ] junzhong qin commented on FLINK-34390: -- Hi [~yunta] I have tested it and it meets expectations.

[jira] [Commented] (FLINK-34239) Introduce a deep copy method of SerializerConfig for merging with Table configs in org.apache.flink.table.catalog.DataTypeFactoryImpl

2024-02-07 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815486#comment-17815486 ] Fang Yong commented on FLINK-34239: --- [~mallikarjuna] DONE > Introduce a deep copy method of

[jira] [Assigned] (FLINK-34239) Introduce a deep copy method of SerializerConfig for merging with Table configs in org.apache.flink.table.catalog.DataTypeFactoryImpl

2024-02-07 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-34239: - Assignee: Kumar Mallikarjuna > Introduce a deep copy method of SerializerConfig for merging

[jira] [Updated] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34390: - Attachment: image-2024-02-08-10-45-13-951.png > Release Testing: Verify FLINK-33325 Built-in

[jira] [Updated] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34390: - Attachment: image-2024-02-08-10-45-31-564.png > Release Testing: Verify FLINK-33325 Built-in

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-07 Thread via GitHub
1996fanrui commented on PR #24248: URL: https://github.com/apache/flink/pull/24248#issuecomment-1933278564 https://github.com/apache/flink/pull/24246 is merged so far, I guess the CI of master branch may be stuck. This PR can fix it if CI is stuck on `waitForRunningTasks` of

[jira] [Updated] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34390: - Attachment: image-2024-02-08-10-44-55-401.png > Release Testing: Verify FLINK-33325 Built-in

[jira] [Updated] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34390: - Attachment: (was: image-2024-02-08-10-42-34-802.png) > Release Testing: Verify FLINK-33325

[jira] [Updated] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34390: - Attachment: image-2024-02-08-10-43-27-679.png > Release Testing: Verify FLINK-33325 Built-in

[jira] [Updated] (FLINK-34390) Release Testing: Verify FLINK-33325 Built-in cross-platform powerful java profiler

2024-02-07 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34390: - Attachment: image-2024-02-08-10-42-34-802.png > Release Testing: Verify FLINK-33325 Built-in

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

2024-02-07 Thread via GitHub
xuyangzhong commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-1933276374 Hi, @snuyanzin I think regular IT tests and UT tests cannot help. If some tests must be added, I guess it can be added to the `flink-stream-sql-test` module in the

Re: [PR] [FLINK-33960][Scheduler] Fix the bug that Adaptive Scheduler doesn't respect the lowerBound when one flink job has more than 1 tasks [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24288: URL: https://github.com/apache/flink/pull/24288#issuecomment-1933274806 ## CI report: * c34660e4be25e533cf52c1e21c97291cfa11b4b5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33960][Scheduler] Fix the bug that Adaptive Scheduler doesn't respect the lowerBound when one flink job has more than 1 tasks [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24287: URL: https://github.com/apache/flink/pull/24287#issuecomment-1933274217 ## CI report: * 437473a4ae810c1542cc3c5628fee0c201228c36 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34348) Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input

2024-02-07 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815480#comment-17815480 ] xuyang commented on FLINK-34348: Hi, [~hackergin]. Thanks for your detailed testing. Overall, it seems

[jira] [Updated] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34200: Fix Version/s: 1.19.0 1.20.0 > AutoRescalingITCase#testCheckpointRescalingInKeyedState

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24286: URL: https://github.com/apache/flink/pull/24286#issuecomment-1933267143 ## CI report: * 3106d453263661e7a08972882a2aabbdf3a7b20d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-07 Thread via GitHub
1996fanrui opened a new pull request, #24286: URL: https://github.com/apache/flink/pull/24286 Backporting FLINK-34200 to 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815477#comment-17815477 ] Rui Fan commented on FLINK-34200: - Merged to: master(1.20) via:

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-07 Thread via GitHub
1996fanrui merged PR #24246: URL: https://github.com/apache/flink/pull/24246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-07 Thread via GitHub
1996fanrui commented on PR #24246: URL: https://github.com/apache/flink/pull/24246#issuecomment-1933257619 Thanks @XComp @StefanRRichter for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-33960) Adaptive Scheduler doesn't respect the lowerBound for tasks

2024-02-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815475#comment-17815475 ] Rui Fan commented on FLINK-33960: - Merged to: master(1.20) via:

Re: [PR] [FLINK-33960][Scheduler] Fix the bug that Adaptive Scheduler doesn't respect the lowerBound when one flink job has more than 1 tasks [flink]

2024-02-07 Thread via GitHub
1996fanrui merged PR #24012: URL: https://github.com/apache/flink/pull/24012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34192] Update to be compatible with updated SinkV2 interfaces [flink-connector-kafka]

2024-02-07 Thread via GitHub
mas-chen commented on code in PR #84: URL: https://github.com/apache/flink-connector-kafka/pull/84#discussion_r1482311723 ## .github/workflows/push_pr.yml: ## @@ -30,6 +30,8 @@ jobs: include: - flink: 1.18.1 jdk: '8, 11, 17' + - flink:

Re: [PR] [FLINK-34192] Update to be compatible with updated SinkV2 interfaces [flink-connector-kafka]

2024-02-07 Thread via GitHub
mas-chen commented on code in PR #84: URL: https://github.com/apache/flink-connector-kafka/pull/84#discussion_r1482310252 ## .github/workflows/push_pr.yml: ## @@ -30,6 +30,8 @@ jobs: include: - flink: 1.18.1 jdk: '8, 11, 17' + - flink:

Re: [PR] [FLINK-34282] Update dev-master point to 1.20 [flink-docker]

2024-02-07 Thread via GitHub
lincoln-lil merged PR #178: URL: https://github.com/apache/flink-docker/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2024-02-07 Thread via GitHub
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1933166244 Hi, @MartijnVisser. I have a question regarding compatibility. This pull request is working on every Flink version but `1.19-SNAPSHOT`. I've checked [this

[jira] [Comment Edited] (FLINK-34400) Kafka sources with watermark alignment sporadically stop consuming

2024-02-07 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815253#comment-17815253 ] Alexis Sarda-Espinosa edited comment on FLINK-34400 at 2/7/24 10:50 PM:

[jira] [Commented] (FLINK-34404) GroupWindowAggregateProcTimeRestoreTest#testRestore times out

2024-02-07 Thread Bonnie Varghese (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815429#comment-17815429 ] Bonnie Varghese commented on FLINK-34404: - I ran this in repeat mode (200 times) on master

[jira] [Commented] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-07 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815422#comment-17815422 ] Sai Sharath Dandi commented on FLINK-34403: --- The test was added for an extreme case that would

[jira] [Commented] (FLINK-34404) GroupWindowAggregateProcTimeRestoreTest#testRestore times out

2024-02-07 Thread Bonnie Varghese (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815396#comment-17815396 ] Bonnie Varghese commented on FLINK-34404: - Unsure how this is related to FLINK-34095. Will see

[jira] [Commented] (FLINK-34234) Apply ShadeOptionalChecker for flink-shaded

2024-02-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815379#comment-17815379 ] Sergey Nuyanzin commented on FLINK-34234: - This is a good question >From one side just to fix

Re: [PR] [FLINK-34267][CI] Update miniconda install script to fix build on MacOS [flink-connector-shared-utils]

2024-02-07 Thread via GitHub
z3d1k commented on PR #34: URL: https://github.com/apache/flink-connector-shared-utils/pull/34#issuecomment-1932525296 Thanks for the feedback @gaborgsomogyi, I see that main repo has newer miniconda versions in the script: `Miniconda3-py310_23.5.2-0-{OS}` in main vs

Re: [PR] [FLINK-34267][CI] Update miniconda install script to fix build on MacOS [flink-connector-shared-utils]

2024-02-07 Thread via GitHub
gaborgsomogyi commented on PR #34: URL: https://github.com/apache/flink-connector-shared-utils/pull/34#issuecomment-1932446087 It would be good to change in Flink main repo too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
dawidwys commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481739305 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -323,15

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
jnh5y commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481698481 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -323,15

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
dawidwys commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481687197 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -323,15

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
dawidwys commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481689031 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalJoinTestPrograms.java: ## @@ -84,6 +130,36 @@ public

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
dawidwys commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481688174 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -237,57

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
dawidwys commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481688174 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -237,57

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
dawidwys commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481687197 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -323,15

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
jnh5y commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481681792 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -237,57

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
jnh5y commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481679233 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala: ## @@ -323,15

Re: [PR] [FLINK-31220] Replace Pod with PodTemplateSpec for the pod template properties [flink-kubernetes-operator]

2024-02-07 Thread via GitHub
gyfora commented on PR #770: URL: https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1932314211 > My understanding is that in the main Flink project people are encouraged to use the Jira Release Note field in case something special needs to be mentioned for the

Re: [PR] [FLINK-34409][ci] Enables (most) tests that were disabled for the AdaptiveScheduler due to missing features [flink]

2024-02-07 Thread via GitHub
XComp commented on PR #24285: URL: https://github.com/apache/flink/pull/24285#issuecomment-1932301482 > Should we check if any on the other tests that are currently disabled for AdaptiveScheduler would now work, e.g. ? Yikes, that was actually my intention. But looks like I forgot to

Re: [PR] [FLINK-24239] Event time temporal join should support values from array, map, row, etc. as join key [flink]

2024-02-07 Thread via GitHub
jnh5y commented on code in PR #24253: URL: https://github.com/apache/flink/pull/24253#discussion_r1481662098 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalJoinTestPrograms.java: ## @@ -84,6 +130,36 @@ public class

Re: [PR] [FLINK-31220] Replace Pod with PodTemplateSpec for the pod template properties [flink-kubernetes-operator]

2024-02-07 Thread via GitHub
afedulov commented on PR #770: URL: https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1932291404 My understanding is that in the main Flink project people are encouraged to use the Jira Release Note field in case something special needs to be mentioned for the

Re: [PR] [FLINK-34409][ci] Enables (most) tests that were disabled for the AdaptiveScheduler due to missing features [flink]

2024-02-07 Thread via GitHub
MartijnVisser commented on code in PR #24285: URL: https://github.com/apache/flink/pull/24285#discussion_r1481652226 ## tools/azure-pipelines/build-apache-repo.yml: ## @@ -69,7 +69,7 @@ stages: name: Default e2e_pool_definition: vmImage:

Re: [PR] [FLINK-34409][ci] Enables (most) tests that were disabled for the AdaptiveScheduler due to missing features [flink]

2024-02-07 Thread via GitHub
XComp commented on code in PR #24285: URL: https://github.com/apache/flink/pull/24285#discussion_r1481649353 ## tools/azure-pipelines/build-apache-repo.yml: ## @@ -69,7 +69,7 @@ stages: name: Default e2e_pool_definition: vmImage:

Re: [PR] [FLINK-34409][ci] Enables (most) tests that were disabled for the AdaptiveScheduler due to missing features [flink]

2024-02-07 Thread via GitHub
MartijnVisser commented on code in PR #24285: URL: https://github.com/apache/flink/pull/24285#discussion_r1481645434 ## tools/azure-pipelines/build-apache-repo.yml: ## @@ -69,7 +69,7 @@ stages: name: Default e2e_pool_definition: vmImage:

Re: [PR] [FLINK-34409][ci] Enables (most) tests that were disabled for the AdaptiveScheduler due to missing features [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24285: URL: https://github.com/apache/flink/pull/24285#issuecomment-1932271167 ## CI report: * 5ccb2b93fcc79079d28293d9a72394236aa412f5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34234) Apply ShadeOptionalChecker for flink-shaded

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815338#comment-17815338 ] Matthias Pohl commented on FLINK-34234: --- [~Sergey Nuyanzin] what's the state of this issue now?

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815314#comment-17815314 ] Matthias Pohl edited comment on FLINK-34403 at 2/7/24 3:16 PM: ---

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815314#comment-17815314 ] Matthias Pohl edited comment on FLINK-34403 at 2/7/24 3:16 PM: ---

[jira] [Updated] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34403: -- Component/s: Formats (JSON, Avro, Parquet, ORC, SequenceFile) (was: Build

[jira] [Updated] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34403: -- Labels: test-stability (was: ) > VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM >

Re: [PR] [FLINK-21400][ci] Enables FileSink and Stateful stream job e2e test for the AdaptiveScheduler [flink]

2024-02-07 Thread via GitHub
XComp commented on PR #24284: URL: https://github.com/apache/flink/pull/24284#issuecomment-1932261297 Closing the issue in favor of FLINK-34409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-21400][ci] Enables FileSink and Stateful stream job e2e test for the AdaptiveScheduler [flink]

2024-02-07 Thread via GitHub
XComp closed pull request #24284: [FLINK-21400][ci] Enables FileSink and Stateful stream job e2e test for the AdaptiveScheduler URL: https://github.com/apache/flink/pull/24284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-34409) Increase test coverage for AdaptiveScheduler

2024-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34409: --- Labels: pull-request-available (was: ) > Increase test coverage for AdaptiveScheduler >

[PR] [FLINK-34409][ci] Enables (most) tests that were disabled for the AdaptiveScheduler due to missing features [flink]

2024-02-07 Thread via GitHub
XComp opened a new pull request, #24285: URL: https://github.com/apache/flink/pull/24285 ## What is the purpose of the change Increasing test coverage. ## Brief change log * Removes annotations ## Verifying this change This change is a trivial rework / code

[jira] [Commented] (FLINK-34409) Increase test coverage for AdaptiveScheduler

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815337#comment-17815337 ] Matthias Pohl commented on FLINK-34409: --- We can't remove the annotation because of

[jira] [Updated] (FLINK-34409) Increase test coverage for AdaptiveScheduler

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34409: -- Affects Version/s: 1.17.2 > Increase test coverage for AdaptiveScheduler >

[jira] [Commented] (FLINK-34409) Increase test coverage for AdaptiveScheduler

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815336#comment-17815336 ] Matthias Pohl commented on FLINK-34409: --- Linking FLINK-21535, FLINK-21450 and FLINK-21400. These

[jira] [Assigned] (FLINK-34409) Increase test coverage for AdaptiveScheduler

2024-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34409: - Assignee: Matthias Pohl > Increase test coverage for AdaptiveScheduler >

[jira] [Closed] (FLINK-21949) Support ARRAY_AGG aggregate function

2024-02-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-21949. Fix Version/s: 1.20.0 (was: 1.19.0) Resolution: Implemented

[jira] [Created] (FLINK-34409) Increase test coverage for AdaptiveScheduler

2024-02-07 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34409: - Summary: Increase test coverage for AdaptiveScheduler Key: FLINK-34409 URL: https://issues.apache.org/jira/browse/FLINK-34409 Project: Flink Issue Type:

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-02-07 Thread via GitHub
dawidwys merged PR #23411: URL: https://github.com/apache/flink/pull/23411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-34314) Update CI Node Actions from NodeJS 16 to NodeJS 20

2024-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34314: --- Labels: pull-request-available (was: ) > Update CI Node Actions from NodeJS 16 to NodeJS

Re: [PR] [FLINK-34314] Update CI Node Actions from NodeJS 16 to NodeJS 20 [flink-connector-shared-utils]

2024-02-07 Thread via GitHub
MartijnVisser commented on PR #35: URL: https://github.com/apache/flink-connector-shared-utils/pull/35#issuecomment-1932224534 Looking at another GHA run (say) https://github.com/apache/flink-connector-shared-utils/actions/runs/7702796322 shows that this run has no annotations about

Re: [PR] [FLINK-21400][ci] Enables FileSink and Stateful stream job e2e test for the AdaptiveScheduler [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24284: URL: https://github.com/apache/flink/pull/24284#issuecomment-1932211497 ## CI report: * bb877762a050476aac84f2adb60347cb4cf39185 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34282) Create a release branch

2024-02-07 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815329#comment-17815329 ] lincoln lee commented on FLINK-34282: - Record the related commits that without prs: master branch

[PR] [FLINK-21400][ci] Enables FileSink and Stateful stream job e2e test for the AdaptiveScheduler [flink]

2024-02-07 Thread via GitHub
XComp opened a new pull request, #24284: URL: https://github.com/apache/flink/pull/24284 ## What is the purpose of the change Increases test coverage for `AdaptiveScheduler`. ## Brief change log * Removes if condition ## Verifying this change This change is

Re: [PR] [FLINK-34192] Update to be compatible with updated SinkV2 interfaces [flink-connector-kafka]

2024-02-07 Thread via GitHub
MartijnVisser commented on PR #84: URL: https://github.com/apache/flink-connector-kafka/pull/84#issuecomment-1932188194 @pvary @mas-chen Can either of you want to take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   >