[jira] [Updated] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33555: -- Labels: test-stability (was: github-actions test-stability) >

[jira] [Updated] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33555: -- Parent: (was: FLINK-27075) Issue Type: Bug (was: Sub-task) >

[jira] [Updated] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33555: -- Priority: Critical (was: Major) >

[jira] [Updated] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33555: -- Affects Version/s: 1.19.0 1.20.0 >

[jira] [Commented] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817860#comment-17817860 ] Matthias Pohl commented on FLINK-33555: ---

[jira] [Comment Edited] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817860#comment-17817860 ] Matthias Pohl edited comment on FLINK-33555 at 2/16/24 7:57 AM:

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817857#comment-17817857 ] Matthias Pohl commented on FLINK-22765: --- JDK21:

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817858#comment-17817858 ] Matthias Pohl commented on FLINK-29114: ---

[jira] [Updated] (FLINK-34448) ChangelogLocalRecoveryITCase failed fatally with 127 exit code

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34448: -- Priority: Critical (was: Major) > ChangelogLocalRecoveryITCase failed fatally with 127 exit

[jira] [Created] (FLINK-34448) ChangelogLocalRecoveryITCase failed fatally with 127 exit code

2024-02-15 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34448: - Summary: ChangelogLocalRecoveryITCase failed fatally with 127 exit code Key: FLINK-34448 URL: https://issues.apache.org/jira/browse/FLINK-34448 Project: Flink

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817856#comment-17817856 ] Matthias Pohl commented on FLINK-34202: --- 1.20 (master):

Re: [PR] [FLINK-32743][Connectors/Kafka] Parse data from kafka connect and convert it into regular JSON data [flink-connector-kafka]

2024-02-15 Thread via GitHub
mas-chen commented on PR #42: URL: https://github.com/apache/flink-connector-kafka/pull/42#issuecomment-1947817531 @sunxiaojian have you considered implementing this as a Flink format? You could draw inspiration from pre-existing formats:

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491954798 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491954798 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

[jira] [Commented] (FLINK-34446) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817845#comment-17817845 ] Sergey Nuyanzin commented on FLINK-34446: - [~jingge] , [~jeyhunkarimov]  I applied similar fix I

Re: [PR] [FLINK-34446][table] Apply workaround to allow parsing of cross join with lateral [flink]

2024-02-15 Thread via GitHub
flinkbot commented on PR #24317: URL: https://github.com/apache/flink/pull/24317#issuecomment-1947771463 ## CI report: * 893202ea5400dae5021f31f538a59f7f772ac044 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34446) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34446: --- Labels: pull-request-available (was: ) > SqlValidatorException with LATERAL TABLE and JOIN

[PR] [FLINK-34446][table] Apply workaround to allow parsing of cross join with lateral [flink]

2024-02-15 Thread via GitHub
snuyanzin opened a new pull request, #24317: URL: https://github.com/apache/flink/pull/24317 ## What is the purpose of the change The PR applies WA to fix [CALCITE-6266](https://issues.apache.org/jira/browse/CALCITE-6266) It applieas similar fix as for

Re: [PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2024-02-15 Thread via GitHub
mas-chen commented on code in PR #70: URL: https://github.com/apache/flink-connector-kafka/pull/70#discussion_r1491960996 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java: ## @@ -74,6 +76,10 @@ private static

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491954798 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491941807 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491941807 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491941807 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491941807 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491941807 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491299515 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -391,6 +391,16 @@ ANY,

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491937994 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -1370,4 +1371,145 @@ private Stream

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491299515 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -391,6 +391,16 @@ ANY,

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491405037 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491933930 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491330263 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] array_except_error [flink]

2024-02-15 Thread via GitHub
flinkbot commented on PR #24316: URL: https://github.com/apache/flink/pull/24316#issuecomment-1947357889 ## CI report: * 17c5b7b107584a3c084ace278d144917d9744ca3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] array_except_error [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 opened a new pull request, #24316: URL: https://github.com/apache/flink/pull/24316 hashCode ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491405037 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491405037 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-02-15 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817758#comment-17817758 ] Kevin Tseng commented on FLINK-33545: - Hi [~mason6345] , [~yang]  I have simplified the approach to

[jira] [Commented] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2024-02-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817750#comment-17817750 ] Hong Liang Teoh commented on FLINK-32964: -  merged commit

Re: [PR] [FLINK-32964][Connectors/AWS] Ensure that new instance of DefaultCredentialsProvider is created for each client [flink-connector-aws]

2024-02-15 Thread via GitHub
hlteoh37 merged PR #129: URL: https://github.com/apache/flink-connector-aws/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491405037 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491395312 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutorService.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] [hotfix] Add IssueNavigationLink in Intellij VCS config [flink-connector-aws]

2024-02-15 Thread via GitHub
z3d1k opened a new pull request, #130: URL: https://github.com/apache/flink-connector-aws/pull/130 ## Purpose of the change Add instructions for Intellij on how to interpret Jira ticket ids and FLIPs. This change allows to easily navigate from git log view in IDE to these

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491387438 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutor.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491387018 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491354424 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491337569 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491337569 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491337569 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491337569 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491337569 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-34447][test] Hardens ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime [flink]

2024-02-15 Thread via GitHub
XComp commented on PR #24314: URL: https://github.com/apache/flink/pull/24314#issuecomment-1946576926 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491330263 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491299515 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -391,6 +391,16 @@ ANY,

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491299515 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -391,6 +391,16 @@ ANY,

[jira] [Commented] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817728#comment-17817728 ] Jing Ge commented on FLINK-31362: - Thanks for the clarification. > Upgrade to Calcite version to 1.33.0

Re: [PR] [FLINK-22765][test] Fixes test instability in ExceptionUtilsITCase#testIsMetaspaceOutOfMemoryError [flink]

2024-02-15 Thread via GitHub
flinkbot commented on PR #24315: URL: https://github.com/apache/flink/pull/24315#issuecomment-1946420906 ## CI report: * 83368ca5bda5692ebc43f9024fa13d0f803369be UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-22765][test] Fixes test instability in ExceptionUtilsITCase#testIsMetaspaceOutOfMemoryError [flink]

2024-02-15 Thread via GitHub
XComp opened a new pull request, #24315: URL: https://github.com/apache/flink/pull/24315 ## What is the purpose of the change The test failed mostly with JDK21. It can happen that the OutOfMemoryError appeared during the compilation phase. In that case, it would print a different

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1491240847 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySortFunction.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1491240847 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySortFunction.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-15 Thread via GitHub
nathantalewis commented on PR #24035: URL: https://github.com/apache/flink/pull/24035#issuecomment-1946388197 I just tested this on one of my clients' datasets which uses a lot of `oneof` fields and it fixed the same problem that wckdman mentioned. -- This is an automated message from

[jira] [Comment Edited] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817717#comment-17817717 ] Sergey Nuyanzin edited comment on FLINK-31362 at 2/15/24 3:51 PM: --

[jira] [Comment Edited] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817711#comment-17817711 ] Jing Ge edited comment on FLINK-31362 at 2/15/24 3:47 PM: -- Hi folks, would you

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-15 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1491222383 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +231,28 @@ ANY,

[jira] [Comment Edited] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817717#comment-17817717 ] Sergey Nuyanzin edited comment on FLINK-31362 at 2/15/24 3:44 PM: --

[jira] [Commented] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817717#comment-17817717 ] Sergey Nuyanzin commented on FLINK-31362: - Calcite upgrade itself is pretty complex task that's

[jira] [Comment Edited] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817711#comment-17817711 ] Jing Ge edited comment on FLINK-31362 at 2/15/24 3:35 PM: -- Hi folks, would you

[jira] [Commented] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2024-02-15 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817711#comment-17817711 ] Jing Ge commented on FLINK-31362: - Hi folks, would you like share the reason why we should upgrade to

[jira] [Updated] (FLINK-34446) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeyhun Karimov updated FLINK-34446: --- Description: found one regression issue. Query working Flink 1.17.2, but failing with Flink

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-15 Thread via GitHub
mxm commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1491077036 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -109,4 +110,51 @@

[jira] [Comment Edited] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817683#comment-17817683 ] Matthias Pohl edited comment on FLINK-22765 at 2/15/24 2:06 PM: The

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-15 Thread via GitHub
dawidwys commented on code in PR #23171: URL: https://github.com/apache/flink/pull/23171#discussion_r1491059814 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-02-15 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1491037396 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -391,6 +391,16 @@ ANY,

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817683#comment-17817683 ] Matthias Pohl commented on FLINK-22765: --- The following error is reported: {code} The system is out

[jira] [Comment Edited] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817676#comment-17817676 ] Matthias Pohl edited comment on FLINK-22765 at 2/15/24 1:50 PM: The

[jira] [Comment Edited] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817676#comment-17817676 ] Matthias Pohl edited comment on FLINK-22765 at 2/15/24 1:49 PM: The

[jira] [Comment Edited] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817676#comment-17817676 ] Matthias Pohl edited comment on FLINK-22765 at 2/15/24 1:49 PM: The

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817676#comment-17817676 ] Matthias Pohl commented on FLINK-22765: --- The issue seems to be related with the JDK version. We've

[jira] [Comment Edited] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817676#comment-17817676 ] Matthias Pohl edited comment on FLINK-22765 at 2/15/24 1:34 PM: The

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491016717 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java: ## @@ -34,4 +34,16 @@ public interface RpcGateway { * @return Fully

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-15 Thread via GitHub
rkhachatryan commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1491013640 ## docs/content.zh/docs/deployment/advanced/logging.md: ## @@ -40,6 +40,21 @@ Flink 中的日志记录是使用 [SLF4J](http://www.slf4j.org/) 日志接口实 +### Structured logging +

Re: [PR] [FLINK-34437][SQL Client] Fix typo [flink]

2024-02-15 Thread via GitHub
rmoff commented on PR #24310: URL: https://github.com/apache/flink/pull/24310#issuecomment-1946084609 squashed, thanks @JingGe ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (FLINK-34446) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817665#comment-17817665 ] Sergey Nuyanzin edited comment on FLINK-34446 at 2/15/24 12:50 PM: ---

[jira] [Commented] (FLINK-34446) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817665#comment-17817665 ] Sergey Nuyanzin commented on FLINK-34446: - most probably comes with 1.31.0 as part of 

[jira] [Updated] (FLINK-34025) Show data skew score on Flink Dashboard

2024-02-15 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emre Kartoglu updated FLINK-34025: -- Affects Version/s: 1.20.0 (was: 1.19.0) > Show data skew score on

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-15 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1490935727 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY,

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-15 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1490931709 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySortFunction.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the

[jira] [Reopened] (FLINK-34025) Show data skew score on Flink Dashboard

2024-02-15 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emre Kartoglu reopened FLINK-34025: --- reopening based on the votes I've received for

Re: [PR] [FLINK-33960][Scheduler] Fix the bug that Adaptive Scheduler doesn't respect the lowerBound when one flink job has more than 1 tasks [flink]

2024-02-15 Thread via GitHub
1996fanrui commented on PR #24288: URL: https://github.com/apache/flink/pull/24288#issuecomment-1945972912 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-15 Thread via GitHub
1996fanrui commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490909393 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -109,4 +110,51

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-15 Thread via GitHub
mxm merged PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817644#comment-17817644 ] Matthias Pohl commented on FLINK-22765: ---

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-15 Thread via GitHub
XComp commented on PR #24309: URL: https://github.com/apache/flink/pull/24309#issuecomment-1945921834 I looked into the missing synchronization for the `FineGrainedSlotManager#started` field: AFAIU, we're relying on all the methods which touch `#started` to run in the same thread (which is

Re: [PR] [FLINK-34447][test] Hardens ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime [flink]

2024-02-15 Thread via GitHub
flinkbot commented on PR #24314: URL: https://github.com/apache/flink/pull/24314#issuecomment-1945913323 ## CI report: * 40f4f24be9f6a9d45bf0dd1078b1ce75b876f36d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-15 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1490866557 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/utils/MemoryTuningUtils.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (FLINK-34447) ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime still fails on slow machines

2024-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34447: - Assignee: Matthias Pohl >

[jira] [Updated] (FLINK-34447) ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime still fails on slow machines

2024-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34447: --- Labels: pull-request-available (was: ) >

[PR] [FLINK-34447][test] Hardens ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime [flink]

2024-02-15 Thread via GitHub
XComp opened a new pull request, #24314: URL: https://github.com/apache/flink/pull/24314 ## What is the purpose of the change We're still seeing test instabilities here if the machine is slow because the release could be trigger resulting in the completion of the

[jira] [Resolved] (FLINK-34038) IncrementalGroupAggregateRestoreTest.testRestore fails

2024-02-15 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-34038. -- Fix Version/s: 1.20.0 Resolution: Fixed >

[jira] [Commented] (FLINK-34248) Implement restore tests for ChangelogNormalize node

2024-02-15 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817640#comment-17817640 ] Dawid Wysakowicz commented on FLINK-34248: -- Implemented in

[jira] [Closed] (FLINK-34248) Implement restore tests for ChangelogNormalize node

2024-02-15 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-34248. Fix Version/s: 1.20.0 Resolution: Implemented > Implement restore tests for

Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-02-15 Thread via GitHub
dawidwys merged PR #24203: URL: https://github.com/apache/flink/pull/24203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >