[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-112099290 Hi @vasia , In essence the `difference` method is just a fancy way of removing vertices, right? When you remove a vertex, you also remove the edge for

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-112086337 Looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32415140 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1151,6 +1151,23 @@ public void coGroup(Iterable> ver

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32415176 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1151,6 +1151,23 @@ public void coGroup(Iterable> ver

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32414981 --- Diff: docs/libs/gelly_guide.md --- @@ -240,6 +240,7 @@ Graph networkWithWeights = network.joinWithEdgesOnSource(v

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/832#discussion_r32410253 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111811473 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/770#issuecomment-111807874 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111761198 Yup, exactly! The use case was: I modified something in the edge data set, called groupReduceOnNeighbors on the result and got NPE, exception that could have been

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-13 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/832 [FLINK-2152] Added zipWithIndex This PR adds the zipWithIndex utility method to Flink's DataSetUtils as described in the mailing list discussion: http://apache-flink-mailing-list-ar

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-110739263 Hi @shghatge, Apart from the minor cosmetic suggestions I made, everything looks well. @vasia, could you double check this? After Shivani simplifies

[GitHub] flink pull request: [FLINK-2140][gelly] Allowed access to the numb...

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/779#issuecomment-110654021 If no objections, I'd like to merge this one within the next week. There is a direction issue for GSA(FLINK-2141) that will actually touch the same files. -

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110647258 Hi @tillrohrmann , For the log2 part, you mean something like this: ceil(log2(x)) = 32 - numberOfLeadingZeros(x - 1)? 32 because it's int, in this ca

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110642404 Ooops! My bad. Fixed the log and the ceil issue in the latest update. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110520392 I think I got it! Have a look now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110502315 Hi @fhueske , To tell the truth, I was a bit reserved regarding your approach, so maybe we can discuss it a bit further! :) I updated the PR to contain what

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-110481761 uhmm, guys! IMO this should be merged before the release! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-110448745 I am super excited about this one! :) Will also have a look in the next days! Awesome job! --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/807#issuecomment-110070080 Hi @shghatge , This very nice for a first PR and I am happy to see that you followed my guidelines :) I left a set of comments in-line. Apart

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932709 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932002 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932048 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31930744 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1233,6 +1233,34 @@ public void coGroup(Iterable> e

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31930812 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1233,6 +1233,34 @@ public void coGroup(Iterable> e

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31930244 --- Diff: docs/libs/gelly_guide.md --- @@ -236,6 +236,8 @@ Graph networkWithWeights = network.joinWithEdgesOnSource(v * Union: Gelly's `

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/801 [FLINK-2150][gelly] Added library method for assigning unique labels to vertices This PR adds a library method that assigns unique labels to vertices. The following facts are used: * a

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-06 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/799 [FLINK-2178][gelly] Fixed groupReduceOnNeighbors bug This PR adds an iterator.hasNext() check in the groupReduceOnNeighbors method, fixing the NoSuchElementException bug reported in FLINK-2178

[GitHub] flink pull request: [FLINK-2140][gelly] Allowed access to the numb...

2015-06-04 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/779 [FLINK-2140][gelly] Allowed access to the number of vertices in the GSA functions Similar to the vertex-centric approach, this PR enables users to access the total number of vertices from within

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-108634942 Hi @mfahimazizi, The common practice is to prefix the commit with the Jira issue, e.g. [FLINK-20XX][gelly]. Also, you should play with your IDE's set

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/765#discussion_r31678387 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/HITSExample.java --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/765#discussion_r31678355 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/HITSExample.java --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/765#discussion_r31677964 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/HITS.java --- @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-03 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/770 [FLINK-2149][gelly] Simplified Jaccard Example This PR simplifies Gelly's Jaccard example by using the more efficient reduceOnNeighbors rather than groupReduceOnNeighbors. You can merge

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-06-03 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-108431985 For 1, I would open a fresh PR, I guess this is too messy to try to fix. Normally, you should: change to master git remote -v pull the latest

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-06-03 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-108364900 Hi @vasia , I believe the problem @joey001 had was that in one of the test modes, he got the classical "Too few memory segments provided. You need at lea

[GitHub] flink pull request: [FLINK-1526][gelly] [work in progress] Added M...

2015-06-03 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...

2015-06-02 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/763 [docs/javadoc][hotfix] Corrected Join hint and misleadling pointer to Spargel This PR adds the following patches: - in the Iteration programming guide, there was a misleading link to

[GitHub] flink pull request: [FLINK-2113][gelly] removed env.execute() afte...

2015-05-29 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/749 [FLINK-2113][gelly] removed env.execute() after print() This PR removes all the env.execute() that occur after a Dataset.print() in gelly examples to fit the new functionality. @uce can you

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-105311774 Yes, I got the idea of difference, we agree on the functionality. What I was trying to say is that it cannot be used in the remove* methods as it needs to create a

[GitHub] flink pull request: [FLINK-1941] documentation for the Gather-Sum-...

2015-05-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/722#issuecomment-105277082 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-105277029 Hi @vasia, I updated the addition methods to fit your suggestion. Feedback, for both of us in the future: discuss implementation details like just add

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-103862850 Hi @vasia , I will address your comments one by one :) - the addVertices method receives a List of Edges instead of a DataSet of Edges because you need to

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102684206 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1523] vertex-centric iteration extensio...

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/680#issuecomment-102387218 Uhhh this looks incredibly clean now :)) +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102376105 If you don't like the example string at the end, then we can go for sol (b) --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-05-15 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-102301712 Well that was embarrassing ^^. Excellent catch @rmetzger! The code was written yesterday evening during a plane ride; My tests found a bug and I basically put that

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-15 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/678 [FLINK-2012][gelly] Added methods to remove/add multiple edges/vertices This pull request provides methods for adding/deleting more than one vertex/edge at a time. The addEdges method is

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-05-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-101989242 @joey001, How did you rebase this? It should not normally contain everyone's commits... Right now it looks like 18 people participated in the implement

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-05-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-101978637 Hi @vasia, I had a look at the new branch. The changes look good, degrees are no longer exposed to the user and the current approach removes the need to

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/663#issuecomment-101972007 Guys, Maybe it makes sense to merge this :) It's been here for a while. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/663#issuecomment-100544083 Indeed I was missing that annotation. Nice catch! PR updated :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/663#issuecomment-100372745 Sure @hsaputra , I thought the JIRA issue was descriptive enough. We were missing ForwardedFields* annotations for the majority of Gelly classes in

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-08 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/663 [FLINK-1976][gelly] Added ForwardedFields Annotations You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink fwdFields

[GitHub] flink pull request: [FLINK-1987][docs] Fixed broken links

2015-05-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/662 [FLINK-1987][docs] Fixed broken links The two html links I replaced were never actually written. In any flink release. In my opinion it is better to omit this information than to point the user

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-99499311 @vasia Don't forget to also have a look at this PR. It's rebased :) --- If your project is set up for it, you can reply to this email and have your re

[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...

2015-05-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/635#issuecomment-99494248 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-05-05 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-99232613 Hey @vasia , Everyone is acting as though I do not want to make these methods user-freindly. I do :), it's just not possible. Keep in mind th

[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...

2015-05-05 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/635#issuecomment-99157184 Hi @vasia, The alternatives to having a single config class for all types of iterations are: - having two separate classes in spargel and in gsa = massive

[GitHub] flink pull request: [FLINK-1975][gelly] Graph getUndirected improv...

2015-05-05 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/653 [FLINK-1975][gelly] Graph getUndirected improvement We were using an union of two data sets to create the undirected graph. This could be done by simply calling a flatMap. Thanks for

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-05-05 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-98983169 For the test: did you have a look at the other Gelly tests(https://github.com/apache/flink/tree/master/flink-staging/flink-gelly/src/test/java/org/apache/flink/graph

[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...

2015-05-01 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/600#issuecomment-98173050 Hi @vasia ! To me it looked normal, probably because I know Spargel :P I moved it in a separate section and rebased. Should be fine now :) --- If your

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-28 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-97159494 Thanks for the review, @StephanEwen! PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...

2015-04-27 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/635 [FLINK-1942][gelly] GSA Iteration Configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink gsaConfig Alternatively you

[GitHub] flink pull request: [FLINK-1944][gelly] Added GSA-PageRank example

2015-04-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/626 [FLINK-1944][gelly] Added GSA-PageRank example This PR also adds the getSuperStepNumber() method to the Gather, Sum and Apply Functions. You can merge this pull request into a Git repository by

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-04-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/625 [gelly][Refactoring] Removed example string @vasia, Just FYI :), in example/utils we have a class EdgeWithLongIdNullValueParser that is never used. The examples that correspond

[GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...

2015-04-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/408#issuecomment-95866092 I noticed that there is no GSAPageRank example in the latest version of the code. I'd like to take care of that once this PR gets merged, to get to under

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-94915061 Hi @vasia , I added some answers to your inline comments! I will push my latest version for this tomorrow. Regarding the suggestion that the Vertex

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28812911 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java --- @@ -228,48 +213,92 @@ public void

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28811435 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/example/IncrementalSSSPITCase.java --- @@ -0,0 +1,84

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28785218 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java --- @@ -138,69 +146,46 @@ public void

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28764335 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java --- @@ -40,7 +42,37 @@ VertexValue

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/576#issuecomment-94572014 Apart from the fact that I don't agree with those two methods having the same name, everything else was updated. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/576#issuecomment-94461019 Hi @vasia , The inline comments have been addressed, I still have the big comment to look at :) One thing(or two ^^) that could be discussed

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/596#issuecomment-94438358 @vasia , The library method matches Spargel now. I also refactored the randomised edges test a bit. Tell me what you think! --- If your project is set

[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/600#issuecomment-94432522 Hi @vasia , The general guidelines were added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/596#issuecomment-94177583 Hi @vasia , I will change the code to match Spargel, probably Monday :) I came across this class in our tests the other day, while searching for something

[GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...

2015-04-17 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/408#issuecomment-93975508 Hi @balidani :) This PR has not been updated in a while now. Are you facing any issues? In that case I would like to help. Otherwise, if you're busy may

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-93696531 Hi @vasia , The PR was updated to include your suggestions. Last test fails for some reason, but that shouldn't get in the way of reviewers :) A

[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...

2015-04-14 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/600 [FLINK-1871][gelly] Added Spargel to Gelly migration guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink migrationGuide

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/596#issuecomment-92750207 Hi @vasia , I wanted to be as close to the example in the guide, to show that Spargel code can easily be ported to Gelly, hence the name. I changed it now

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-13 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/596 [FLINK-1883][gelly] Added Min Vertex Id Propagation library and example You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/576#issuecomment-92270780 Hello @vasia , I updated the PR to use reduce where possible(for the functions which return one value per vertex). Let me know if there is anything I

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-07 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-90728415 Hi @vasia , I simply assumed that if the previous examples work, the iteration also works as before. Would you like a specific test suite for that

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/576 [FLINK-1758][gelly] Neighborhood Methods Extensions You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink extendNeighborhood

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-04-07 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-90715751 @vasia, I updated the PR with your latest suggestions. Travis seems to fail because of flink-steaming :-s; my quick refactoring couldn't have triggered

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-04-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-90062739 Fair enough :). Let me know if the example seems clearer now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-90061271 @vasia , PR updated :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-03-31 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-88088234 Sure, I thought it was obvious from the ugly if :) In EmitOneEdgePerNode we have: public void flatMap(Edge edge, Collector>>

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-03-30 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-87830769 Hi @vasia , The problem(at least mine) was that Jaccard works on both an undirected and on a directed graph... and I just needed to make a final decision

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-03-30 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/544 [FLINK-1741][gelly] Adds Jaccard Similarity Metric Example You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink flinkJaccard

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-03-29 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-87425953 Hi @vasia , 1). I will add the documentation once we reach a consensus. No use documenting something that might change :) 2). For the public setter: I

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-28 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/452#issuecomment-87269837 @vasia , No need to ignore the hadoop1 failure, I rebased and everything is nice and green now. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-03-28 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r27344502 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -38,11 +41,41 @@ * @param The type

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-03-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/537 [FLINK-1523][gelly] Vertex centric iteration extensions Thank you @StephanEwen for the hint!(keeping the degrees within the vertex value) @vasia, I am sure I left some trailing irrelevant

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/505#issuecomment-86366858 Travis passed :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/505#issuecomment-85725549 @vasia , I integrated your suggestions, the example works on the cluster for Orkut, max iter = 20. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-23 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/505#issuecomment-85194124 Leave it to @rmetzger to be uber meticulous :D I will add the bullet point! Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-20 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/505 [FLINK-1726][gelly] Added Community Detection Library and Example You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-16 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/452#discussion_r26487168 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/EuclideanGraphExample.java --- @@ -0,0 +1,231 @@ +/* + * Licensed

<    1   2   3   >