Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3783
@fhueske , this is the PR with the code generated distinct aggregation for
OVER. You mentioned that the value of the aggregation should be a Row, but what
is kept in the distinct state is just
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3783
@rtudoran @fhueske the first implementation I made was with the state in
the ProcessFunction without code generated aggregation function. Second, I
pushed a branch with the state in the process
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3771
@fhueske I have created #3783 with just the code generation part. At least
the GROUP BY distinct can move ahead. I will close this PR and wait for the
merging of the Calcite fix.
---
If your
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3783
@fhueske please have a look at this PR, it contains just the code
generation part with optional distinct.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3783
[FLINK-6338] Add support for DISTINCT into Code Generated Aggregations
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3771
So, what do you want me to keep for this PR? just the code generation and
its test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3771#discussion_r113472166
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRowsOver.scala
---
@@ -72,7 +73,15
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3771#discussion_r113472029
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -20,16 +20,22
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3771#discussion_r113471605
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -335,14 +371,28 @@ class CodeGenerator
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3771#discussion_r113471045
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -296,6 +297,41 @@ class CodeGenerator
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3771
@fhueske @haohui I have no problem removing the DIST() part, it is just not
possible to test it without. Shall I push just the code generation and
aggregates util changes?
---
If your project
Github user huawei-flink closed the pull request at:
https://github.com/apache/flink/pull/3732
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112210389
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112210097
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112180091
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112151646
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112151222
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3732
[FLINK-6250] Distinct procTime with Rows boundaries
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user huawei-flink closed the pull request at:
https://github.com/apache/flink/pull/3459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3574
@fhueske Thanks a lot of the clarification. I understand the issue better
now, and see your attempt to make an average case that would work for both in
memory as well as on external persistence
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3574
Hi @fhueske, @sunjincheng121 ,
let me try to explain my perspective on this specific case (row based, proc
time). This is for the purpose of discussion, to show that we are spending
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3574
I have a first implementation of the processFunction, using a Queue as a
state. However, I need to implement the retractableAggregation, as AVG for
example is not supported.
---
If your
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3574
@fhueske let's see if the third attempt works. I have included all the
comments of @sunjincheng121 (apart from the window function) and having done a
merge on a fresh checkout also the imports
Github user huawei-flink closed the pull request at:
https://github.com/apache/flink/pull/3547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3574
Eager aggregation over row bounded window
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3547
sorry about the mess. I don't understand the mess the rebase does with
eclipse... I will close this PR and open another one including all the changes
and comments
---
If your project is set
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106917566
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -17,35 +17,62
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106868683
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/ProcTimeRowBoundedAggregationTest.scala
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106616178
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,9 +113,14
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106615708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -17,34 +17,41
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106465657
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverWindowFunction.scala
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106453475
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106452550
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106369028
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106367506
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106367130
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -130,32 +142,76
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106366744
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverWindowFunction.scala
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106361152
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -19,33 +19,124 @@ package
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106360688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/rel/LogicalWindowAggregate.scala
---
@@ -18,8 +18,6
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106238200
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -19,33 +19,124 @@ package
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106222135
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/rel/LogicalWindowAggregate.scala
---
@@ -18,8 +18,6
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106221708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/rel/LogicalWindowAggregate.scala
---
@@ -37,8 +35,8 @@ class
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106220189
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -159,6 +168,42
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106219814
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -19,33 +19,124 @@ package
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106219673
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverWindowFunction.scala
---
@@ -0,0
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3547
[FLINK-5653] Add processing time OVER ROWS BETWEEN x PRECEDING aggregation
to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user huawei-flink closed the pull request at:
https://github.com/apache/flink/pull/3443
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3443
@fhueske, I am closing this PR and opening a new one in Scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
@fhueske
3. "â¢The first OVER window aggregation should serve as a blueprint for
future OVER window implementations." - is this a general thought or you
indicate that we need
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3443
Hi @fhueske about the squashing, what is the best strategy? I was thinking
to just get a clean branch and merge my contribution there and then push it in
one commit.
About the scala
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
Hi @fhueske
I will start with the minor comments: in principle those were done by
mistake within the rebase...
Regarding the FunctionCatalog - that was because initially we used
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r105162342
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamCalcRule.scala
---
@@ -46,6 +52,20
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r105162261
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala
---
@@ -165,6 +165,11 @@ object
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
@fhueske @wuchong @twalthr can you please take a look to see if you can
merge this. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104431103
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104430878
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
Related to the building failure - I see that this fails only for one
particular case. I looked into the error and it is not related to my
modifications as you cans see below. In fact I did
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104429058
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/StreamAggregator.java
---
@@ -0,0 +1,23
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104428922
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104366556
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
@shijinkui I think Radu and I complicated a bit the code pulling from each
other branch some stuff. Next time we'll squash the commit.
---
If your project is set up for it, you can reply
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104362378
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r104361048
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r104148648
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3459
[FLINK-5654] Add processing time OVER RANGE BETWEEN x PRECEDING aggregation
to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103925068
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103920777
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103919690
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103914685
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103887096
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103866134
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103866164
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java
---
@@ -0,0
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103865652
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/logical/rel/util/WindowAggregateUtil.java
---
@@ -0,0 +1,103
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3443
[FLINK-5653] Add processing time OVER ROWS BETWEEN x PRECEDING aggregation
to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
@fhueske no problem, I understand. It was bad timing, as I was on the run
for more than two weeks, with little time to follow this. We'll contribute on
other issues.
---
If your project
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3370
@haohui thanks for the contribution. I merged your code, I will push it
later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
I managed to merge the changes from PR #3370 into my branch after rebase,
and the test works. I will push the code later today. sorry if I am a little
latent, but I am travelling
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
Hi Fabian,
I will follow up in the next days, probably early next week. is it ok?
Stefano
---
If your project is set up for it, you can reply to this email and have your
reply
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
@fhueske I've addressed most of the points, however there is a thing that
is not clear to me yet. So far, the procTime() function generates a timestamp.
My understanding
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3271#discussion_r101455204
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/functions/FlinkStreamFunctionCatalog.java
---
@@ -0,0 +1,39
Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3271#discussion_r101454598
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ProcTimeCallGen.scala
---
@@ -0,0 +1,40
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3302
[FLINK-5710] Add ProcTime() function to indicate StreamSQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3271
@fhueske not sure this was noticed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3271
Flink 5710
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items
84 matches
Mail list logo
