[GitHub] flink issue #5992: [FLINK-8944] [Kinesis Connector] Use listShards instead o...

2018-06-08 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5992 Bumping this up in case it got lost in the queue. @tzulitai ---

[GitHub] flink issue #5992: [FLINK-8944] [Kinesis Connector] Use listShards instead o...

2018-05-25 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5992 Please note I rebased my changes to the master as I was having some failures when building just the flink-connector-kinesis maven project. I hope this will not cause problems with reviewing

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-25 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r191033585 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -26,20

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-25 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r191033584 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -26,20

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-18 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r189417750 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -181,6

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188481562 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188481158 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -97,8

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188481152 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -97,8

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188377393 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -382,50

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188377434 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -70,20

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188377363 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188377415 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -353,19

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-15 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r188377376 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -382,50

[GitHub] flink issue #5992: [FLINK-8944] [Kinesis Connector] Use listShards instead o...

2018-05-11 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5992 R: @tzulitai @tweise ---

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-11 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r187632455 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-11 Thread kailashhd
Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r187630051 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-11 Thread kailashhd
GitHub user kailashhd opened a pull request: https://github.com/apache/flink/pull/5992 [FLINK-8944] [Kinesis Connector] Use listShards instead of DescribeSt… …ream for shard discovery as it offer higher rate limits ## What is the purpose of the change List

[GitHub] flink issue #5698: [FLINK-8945] [kinesis] Allow customization of KinesisProx...

2018-03-14 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5698 cc @tweise ---

[GitHub] flink pull request #5698: [FLINK-8945] [kinesis] Allow customization of Kine...

2018-03-14 Thread kailashhd
GitHub user kailashhd opened a pull request: https://github.com/apache/flink/pull/5698 [FLINK-8945] [kinesis] Allow customization of KinesisProxy ## What is the purpose of the change Allow customization of KinesisProxy. In this case we want to override just the getShardList

[GitHub] flink issue #5663: [FLINK-8888] [Kinesis Connectors] Update the AWS SDK for ...

2018-03-13 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5663 Sorry for the delay in this. Confirming that I tested this using kinesalite and kinesis for both the consumer and producer functionality. I had some trouble when connecting this to kinesalite due

[GitHub] flink issue #5663: [FLINK-8888] [Kinesis Connectors] Update the AWS SDK for ...

2018-03-09 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5663 Currently in flink connector we are depending only on aws-sdk-kinesis and not on aws-java-sdk-bundle and also don't depend on kinesisvideo. So by default the dependency on kinesisvideo

[GitHub] flink pull request #5663: [FLINK-8888] [Kinesis Connectors] Update the AWS S...

2018-03-08 Thread kailashhd
GitHub user kailashhd opened a pull request: https://github.com/apache/flink/pull/5663 [FLINK-] [Kinesis Connectors] Update the AWS SDK for flink kinesis connector ## What is the purpose of the change Updating the AWS Java SDK in order to be able to use new features