Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1320#issuecomment-153766231
Of I want to address other peoples concerns: "If nobody has a better ideas".
What would be a good color scheme? Please provide some constructive
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1320#issuecomment-153805545
I don't like the idea of the second navigation bar. The menu should not
occupy too much space. And using the logo as back link to the homepage is a
very good solution
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1320
[FLINK-2752] [Documentation] Documentation is not easily differentiable
from the Flink homepage
Changed menu color schema to make page clearly distinguishable from project
page.
You can merge
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1320#discussion_r43746460
--- Diff: docs/internals/coding_guidelines.md ---
@@ -1,23 +0,0 @@
-title: "Coding Guidelines"
-
-
-The *Coding
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1320#issuecomment-153355782
Wrong screenshot? I am open to use different colors for the menu -- I am
not a designer and this was just a try to come up with something...
I think a "
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1157#issuecomment-152474074
Hi. Are you still working on this? It's a couple of weeks since the last
update.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1274#issuecomment-150515179
Merging this, if no objection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-149580271
Is there any news here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1274#issuecomment-149639349
@StephanEwen Please give short review. Should be good to get merged. Will
address https://issues.apache.org/jira/browse/FLINK-2861 after this is merged.
---
If your
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1274
[FLINK-2862] [Storm Compatibility] FlinkTopologyBuilder should use proper
generic types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1157#issuecomment-148658081
There is no need to rush. I was just curious. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1157#issuecomment-148370496
Any progress on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1256#issuecomment-148207709
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-145794134
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-145085340
Just updated this PR. It additionally contains the maven module
restructuring and internal code cleanup in a second commit. If no objects, I
will push this into master
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-145085684
Prove reading for README, Web documenation, and examples JavaDoc would be
appreciated ;) It's a lot if renaming going on and I might have missed
something.
---
If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1181#issuecomment-143995828
Both. I labeled it as milestone-1 because I opened this PR before it was
decided that the next RC will be forked from master. So I would just merge in
into master right
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1181#issuecomment-144205184
Merging this now to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1181#issuecomment-143749079
If no objections I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1181#issuecomment-143533234
Can I merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-143539717
Done. I split the PR and squashed the commit. @StephanEwen please let me
know if it is ok.
---
If your project is set up for it, you can reply to this email and have your
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1181
[0.10.0-milestone-1] [hotfix] [webclient] WebClient was not able to display
multiple jobs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-142999802
Thanks for the review! Just to clarify: I did not apply any changes "just
for fun". But I agree that this PR contains more changes as are actually
related
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-142345277
Thanks. Makes sense. I wait for the feedback of Till and Stephan and fix
this afterwards. This PR need a rebase anyway, that I can do all of this stuff
when merging
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1157#issuecomment-142210957
Yes, but I don't understand the purpose of `FlinkCounMetric`... Flink
should be able to deal with Storm metrics directly (without requiring the user
to use a special
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1157#issuecomment-141985771
This looks promising. However, how can `CountMetric` be used (without any
changes to the Spout/Bolt code within Flink? Right now it seems, that the user
has to replace
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1157#discussion_r39972364
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyContext.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-141926593
Any news here? What is the opinion on Till's concern about using a `Future`?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-141024224
Can you add a test case that checks if "returns" works now. See the JIRA
example.
---
If your project is set up for it, you can reply to this email and have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-141121393
One failing test in new to me. Do we need a JIRA for it?
```
Tests in error:
CompactingHashTableTest.testHashTableGrowthWithInsert:98->getMemory:243
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140795134
I know. See dev mailing list "Java 8 JDK issue".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1135#discussion_r39652292
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140895609
Fixed. Please let me know if I can merge this. Or should I wait for #1046 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140901671
Thanks. I agree with you. Just wanted to get a second opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140899681
I use the config that is introduced in #1046 already... See TODO in
StormWrapperSetupHelper.java and StormWrapperSetupHelperTest.java ... Not sure
if it is cleaver
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1135
[FLINK-2566] FlinkTopologyContext not populated completely
- extended FlinkTopologyContext to be populted with all supportable
attributes
- added JUnit test
- updated README.md
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-140301180
Hi, I cleand-up all old commits, and put a new commit on top introducing
`SourceFunction.stop()` and unblock stop signal using an own thread. Please
give feedback
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-140301378
Storm only supports one global configuration that is shared over all
spout/bolts. So `GlobalJobParameter` will work just fine.
---
If your project is set up for it, you
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-140375020
I thinks it should be fine. The `TaskOperationResult` should only indicate,
that the signal was delivered successful (ie, only sent to "streaming
sources").
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1122#issuecomment-140119712
Can I merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r39453004
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -418,6 +418,17 @@ public void setBytes(String key, byte[] bytes
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-140224226
It is not clear (at least to me) how to do this. The API does not offer an
(obvious) way to set a configuration... (or I just don't get it).
`StreamExecutionEnvironment
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1122
[FLINK-2658] fieldsGrouping for multiple output streams fails
added `SplitStreamTypeKeySelector` and JUnit tests
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1114
[FLINK-2632] Web Client does not respect the class loader of submitted jobs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1114#issuecomment-139211341
I just did a quick test via `bin/start-local.sh` and
`bin/start-webclient.sh`. Uploaded WordCount example via WebClient UI and
submitted it successfully.
---
If your
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38914538
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138524518
I just had a few "cosmetic" comments. Otherwise it looks good to me to get
merged.
---
If your project is set up for it, you can reply to this email and have
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38913931
--- Diff: docs/apis/storm_compatibility.md ---
@@ -201,6 +201,26 @@ DataStream s2 =
splitStream.select("s2").transform(/* use Bolt f
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38913193
--- Diff: docs/apis/storm_compatibility.md ---
@@ -201,6 +201,26 @@ DataStream s2 =
splitStream.select("s2").transform(/* use Bolt f
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38914417
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38914633
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38913061
--- Diff: docs/apis/storm_compatibility.md ---
@@ -201,6 +201,26 @@ DataStream s2 =
splitStream.select("s2").transform(/* use Bolt f
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38914053
--- Diff: docs/apis/storm_compatibility.md ---
@@ -201,6 +201,26 @@ DataStream s2 =
splitStream.select("s2").transform(/* use Bolt f
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-138587744
Yes. That is what I assumed writing the code for this PR. The question is,
if you still simply assume that `cancel` behaves this way or try to enforce it
somehow
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138274145
Why is `public void add(Double value)` overloaded with `public void
add(double value)`? The usage of primitive types and there class counterparts
seem to be mixed... Why
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138288718
We should discuss this over the dev list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138277939
Yes, I don't see any advantage in having this overload. I would also change
`add(long value)` and `add(int value)` into `add(Long value)` and `add(Integer
value
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38859306
--- Diff: docs/apis/cli.md ---
@@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs.
-s,--scheduled
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-138278500
Any input on the blocking/non-blocking question about `cancel` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38856253
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/accumulators/AverageAccumulatorTest.java
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138283474
To me, the tests seems to be unstable. Maybe we need to open a JIRA for
them. I will report them on the dev mailing list.
---
If your project is set up for it, you can
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38860604
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38863884
--- Diff: docs/apis/cli.md ---
@@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs.
-s,--scheduled
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38866736
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38865859
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38866357
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38867651
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38867892
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138302632
+1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38867760
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38867724
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/stormoperators
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38867413
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138320697
Can you update documentation, too? For README.md just delete the line that
claims configuration is not supported. WebPage documentation should contain a
short paragraph
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138280298
Fail enough. Ignore my comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38856700
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/accumulators/AverageAccumulatorTest.java
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-137742282
I have just a quick look over it, and so far it like it. Two things are
open to be discussed. I not sure it the change to `ConfigConstants` in a good
choice. Would
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1074#issuecomment-137397048
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38635830
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38515501
--- Diff: docs/apis/cli.md ---
@@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs.
-s,--scheduled
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38516042
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38458556
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38456958
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136302889
Travis run on Linux. There is only a single ":" in the path there.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136289777
This is the stack trace (occurs in 4/5 runs -- the other run failed before
due to unrelated test). It seems you broke something.
```
Tests run: 1, Failures: 1
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136305354
This might be the case. I never tried it. And as far as I know, all
developers work on Linux or Mac, so this was never an issue.
---
If your project is set up
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312505
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312609
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312152
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312112
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312165
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312340
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38311967
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormBoltWrapper.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38311822
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312308
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38312802
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -275,7 +275,14 @@
* Path to Hadoop configuration
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1074#issuecomment-136152037
Test fails in instable yarn-test. Should be ready to get merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1074
[FLINK-2475] Rename Flink Client log file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-2475-renameClientLogFile
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191418
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -534,7 +536,70 @@ public int compare(JobStatusMessage o1
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191682
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -588,15 +653,16 @@ protected int cancel(String[] args
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38195523
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
401 - 500 of 694 matches
Mail list logo
