Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3235
Merging to `master`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3246
Thanks for the feedbacks. I'll rebase this PR soon.
@static-max thanks for the tip. I'll keep that in mind when updating the
docs for this feature!
---
If your project is set up
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3278
Thanks for the detailed review @tillrohrmann, I'll follow-up and address
your comments.
Regarding removing the `setFlushOnCheckpoint`:
I think it was added at first to provide
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3278#discussion_r100036593
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3278#discussion_r100036011
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3278#discussion_r100035659
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3278#discussion_r100035474
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3235
From the Maven dependency tree, there seems to be no additional
dependencies for 1.3.0. Quick check on the compile dependencies of 1.3.0 and
original 1.2.3 in Maven central, they're identical
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3278
Instead of directly re-adding
`testAtLeastOnceProducerFailsIfFlushingDisabled `, I instead added a test
`testDoesNotWaitForPendingRecordsIfFlushingDisabled` to simply assure that the
snapshot
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3282
Merging to `master` and `release-1.2` ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2767
Hi @mikedias! Your contribution has been merged with
8699b03d79a441ca33d9f62b96490d29a0efaf44 and
b5caaef82add4a6f424094d526700c77b011724e. Could you manually close this PR? The
bot only closed
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Merging to `master` ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r99837460
--- Diff: docs/dev/connectors/elasticsearch.md ---
@@ -23,158 +23,291 @@ specific language governing permissions and
limitations
under the License
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3274
AFAIK, for simple changes we don't strictly require a separate PR for
backporting to a release branch. Committers usually just cherry-pick the
changes on the release branch.
---
If your project
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3278
@tillrohrmann thanks for the comment. I'll try again and see if I can come
with up a proper test for `testAtLeastOnceProdcuerFailsIfFlushingDisabled()`.
---
If your project is set up for it, you
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3282
The comments have been addressed. Apart from the minor fixes for grammar,
all sections were moved up the hierarchy by one to show a better ToC. The
at-least-once info for the producer is moved
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3235
I can look into this tomorrow and check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3282
Thank you for the review @uce! I'll address all of them except the last one
(please see my inline reply).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3282#discussion_r99796056
--- Diff: docs/dev/connectors/kafka.md ---
@@ -250,57 +250,116 @@ if a new watermark should be emitted and with which
timestamp.
### Kafka
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3282#discussion_r99793908
--- Diff: docs/dev/connectors/kafka.md ---
@@ -250,57 +250,116 @@ if a new watermark should be emitted and with which
timestamp.
### Kafka
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3282#discussion_r99793771
--- Diff: docs/dev/connectors/kafka.md ---
@@ -250,57 +250,116 @@ if a new watermark should be emitted and with which
timestamp.
### Kafka
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Thank you for the review! I'll address the missing semicolons and merge
this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3282
[FLINK-5702] [doc] At-least-once configuration info for FlinkKafkaProducer
Adds information about the `setLogFailureOnly` and `setFlushOnCheckpoint`
methods with regards to at-least-once
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3278
@tillrohrmann
Yes, in the condition that you described, then at-least-once doesn't hold.
I said _might_ mainly considering there is chance that for every checkpoint
barrier, the previous
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3278
[FLINK-5701] [kafka] FlinkKafkaProducer should check asyncException on
checkpoints
Prior to this change, at-least-once is violated for the FlinkKafkaProducer
because we were not failing
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3270
Thank you for the contribution @mylog00!
It isn't necessary, but I agree with @zentol that it would be nice to have
them consistent with each other :-)
---
If your project is set up
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2801
@aljoscha and me had an offline discussion to let `StreamStatus` bypass the
operators, instead of exposing them and have another `processStreamStatus(..)`
method in the operator interface
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2509
Note about 3rd commit: fixed failing `FlinkKafkaConsumerBaseMigrationTest`s
after the rebase.
The tests were failing due to the removal of
`AbstractFetcher#restoreOffsets(...)` method
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99067629
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -203,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99066877
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99067395
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99067569
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r95134466
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99065929
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r95132586
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -88,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99065974
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r95133373
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -107,27
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99067451
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r99066645
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -154,42
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3235
Thank you for looking into this @tedyu.
In the
ML(http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Help-using-HBase-with-Flink-1-1-4-td11094.html),
Giuliano has also
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99064341
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99064510
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99064919
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3236#discussion_r99061454
--- Diff: docs/setup/mesos.md ---
@@ -145,60 +174,75 @@ If set to 'docker', specify the image name:
In the `/bin` directory of the Flink distribution
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3236#discussion_r99063127
--- Diff: docs/setup/mesos.md ---
@@ -107,29 +107,58 @@ Unvierse. Please use the following workaround in the
meantime:
## Mesos without DC/OS
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3236#discussion_r99062197
--- Diff: docs/setup/mesos.md ---
@@ -107,29 +107,58 @@ Unvierse. Please use the following workaround in the
meantime:
## Mesos without DC/OS
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3236#discussion_r99063368
--- Diff: docs/setup/mesos.md ---
@@ -107,29 +107,58 @@ Unvierse. Please use the following workaround in the
meantime:
## Mesos without DC/OS
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3236#discussion_r99063747
--- Diff: docs/setup/mesos.md ---
@@ -145,60 +174,75 @@ If set to 'docker', specify the image name:
In the `/bin` directory of the Flink distribution
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3236#discussion_r99061517
--- Diff: docs/setup/mesos.md ---
@@ -145,60 +174,75 @@ If set to 'docker', specify the image name:
In the `/bin` directory of the Flink distribution
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3246
@fpompermaier @static-max tagging you so that you're aware of this PR. Will
be great to hear feedback from you!
---
If your project is set up for it, you can reply to this email and have your
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3246
[FLINK-5353] [elasticsearch] User-provided failure handler for
ElasticsearchSink
Only the last commit is relevant. This PR is based on #3112 so that the
functionality is added for all
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Hi @fpompermaier! Thanks for bringing it up. However, as Robert suggested,
lets not include that as this PR. But I'll like to discuss with you on the
matter on the corresponding JIRA concurrently
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
I think the PR is in a stable state for a final review now. I'll keep the
PR as is until another review, sorry for jumping around as I was trying options
for more future change proof.
---
If your
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
While rebasing #2861 on the restructured ES connectors in this PR, I jumped
around different options on whether or not the `BulkProcessor` build process
should be abstracted. In the end, I think
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Thank you for your comments @mikedias, I will address them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2861
Thanks! There wasn't any discussion on switching to a pure HTTP client, but
we might need to take into consideration the effort it will take and benefits
the result will offer if we were to go
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2861
Thank you for the detail information! I've actually already started some
work on top of your commits in this PR, so I think it'll be easier to proceed
to implement the nested exceptions checks
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2861
Small note (would be great if @static-max can clarify this also) on
matching the exceptions:
We can actually use `BulkItemResponse.getFailure().getCause()` to get a
`Throwable` that we can use
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2861
Hi @static-max! Will you be ok with me opening a PR for
[FLINK-5487](https://issues.apache.org/jira/browse/FLINK-5487) by basing it on
this PR? Your contribution will be included in that PR
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3031
A re-clarification about backwards compatibility for state type change:
Currently, one limitation for compatible applications across savepoint
restore is that you can't change the type of state
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1962
Thank you for picking this up again @sbcd90. I would wait until #3112 is
merged before rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97935636
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97757847
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -101,7
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97935971
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97935696
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97758477
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -345,39
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97935720
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Rebased to resolve conflicts in documentation changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3185
@aljoscha thank you for the review. I'll address the inline comment and
merge this to `master` and `release-1.2`
---
If your project is set up for it, you can reply to this email and have your
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2801
Rebased on latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2916
Merged to master. Thank you for your contribution @tony810430 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3035
Thank you for picking this up @StephanEwen! I've taken a look at your
approach in the local branch, +1 to the approach.
---
If your project is set up for it, you can reply to this email and have
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2937#discussion_r97481654
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/examples/CEPMonitoringExample.scala
---
@@ -0,0 +1,106
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2937#discussion_r97481738
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/examples/events/MonitoringEvent.scala
---
@@ -0,0 +1,33
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2916
Rebasing and merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3031
Thank you for the contribution @MayerRoman. Just want to let you know that
I've noticed this PR, and I think the issue is definitely something we want to
fix. I'll allocate some time this week
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3035
Hi @BrainLogic, we're still seeing this exception in tests sometimes, and
it'll be great to have this fixed soon.
Please let us know on how you'd like to proceed with the contribution
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1962
Hi @sbcd90, will you like to continue working on this PR?
There's going to be a restructuring of the ES connectors (#3112) perhaps
soon after the 1.2 release, and this PR will very likely
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3158
This is an identical backport / forwardport of the other 3 Mesos fixes,
correct?
If so, since #3155 and #3156 all have +1s, and #3157 is also a +1 once the
minor code style comments
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97253388
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -394,6 +395,14 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97257309
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperUtilityFactory.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97257878
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperUtilityFactory.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97256203
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperVersionedValue.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97255788
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
@@ -376,15 +376,19 @@ public static
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97255571
--- Diff:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManagerTest.java
---
@@ -73,13 +74,16
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3155
+1 to merge, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3185
[FLINK-5375] [doc] Fix Watermark Semantics
Fix watermark semantics in documenation to be correctly aligned with
implementation: a Watermark _t_ declares that event time has reached time _t_
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3078
Thank you @skidder for addressing the comments! Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3177
Thanks @EronWright for investigating this together and @rmetzger for the
review.
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3181
[FLINK-5581] [doc] Improve user accessibility for Kerberos-related
documentation
The goal of this PR is to organize Kerberos related information as so:
1. `flink-conf.yaml` configuration
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3036
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3036
+1 to merge. Thank you for the reminder @Rohithyeravothula.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3177
[FLINK-5580] [security] Fix path setting of shipped Kerberos keytabs in
YARN mode
Previously, the local path of the shipped keytab was set _after_
`SecurityConfiguration` was created, causing
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3136
Thanks @StephanEwen and @alpinegizmo for the review.
I think the re-wording for "of a queue" is definitely an improvement.
I'll change it to your suggestion and merge this
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3137
[hotfix] [doc] Fix several broken "Linking with Flink" links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink hotf
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3136
[FLINK-5512] [doc] Improve RabbitMQ documentation
Added information about non-parallel restriction for RabbitMQ source in
order to achieve exactly-once.
Also attempted to overall improve
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
@rmetzger The comments are all addressed now, including the last two
problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3078#discussion_r96145784
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
---
@@ -0,0
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3078#discussion_r96145735
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@ -253,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3078#discussion_r96145771
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
---
@@ -0,0
1401 - 1500 of 1924 matches
Mail list logo
