Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r127129047
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -0,0 +1,349
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126671328
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -0,0 +1,187
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r127153991
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeWindowInnerJoin.scala
---
@@ -0,0 +1,326
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126680044
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -0,0 +1,349
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126683783
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinITCase.scala
---
@@ -0,0 +1,117
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126684002
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinITCase.scala
---
@@ -0,0 +1,117
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126671128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -0,0 +1,349
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126680468
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -0,0 +1,349
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r127113760
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala
---
@@ -20,28 +20,60
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4308#discussion_r126907470
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -687,11 +687,11 @@ case class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126896677
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala
---
@@ -107,6 +107,18 @@ class FunctionCatalog
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126881414
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
---
@@ -277,3 +278,47 @@ case class Overlay
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4105
merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126871619
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
---
@@ -277,3 +278,47 @@ case class Overlay
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126870651
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -982,4 +982,27 @@ object randInteger
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126881444
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
---
@@ -277,3 +278,47 @@ case class Overlay
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126870614
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -982,4 +982,27 @@ object randInteger
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r126871598
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
---
@@ -277,3 +278,47 @@ case class Overlay
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4279
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r126865636
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/utils/UserDefinedAggFunctions.java
---
@@ -59,7 +59,7 @@ public boolean
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4279
Thanks @fhueske , I have addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4279#discussion_r126589762
--- Diff: docs/dev/table/tableApi.md ---
@@ -373,7 +373,7 @@ Table result = orders
Distinct
-Batch
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4279#discussion_r126589666
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/AggregationsTest.scala
---
@@ -39,4 +40,42 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4279
Thanks @sunjincheng121 , I have updated tableAPI document.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3816
Hi @caddac , you can use `AggregateFunction` and
`KeyedStream.aggregate(AggregationFunction aggregate)` instead of fold.
---
If your project is set up for it, you can reply to this email and have
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4279
[FLINK-7126] [table] Support Distinct for Stream SQL and Table API
Distinct is a syntax sugar which is translated to a GROUP BY by Calcite. As
we have supported GROUP BY on stream tables, distinct
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4266
Hi @hongyuhong , is this the same PR with #3715 ? In order to
rebase/remove merge commit, please do not create a new PR, otherwise committers
may review an out-date PR or lose the review context
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4263
Thank your for the work , I will also look into this in the next days. BTW,
can you please close #3714 @rtudoran ?
---
If your project is set up for it, you can reply to this email and have your
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4105
I have rebased the code and updated. Would you like to have a look again?
@fhueske @twalthr @sunjincheng121
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4138
I will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4183
The proposal makes sense to me.
BTW, the concepts of `earlyResultTimeOffset` and `updateRate` also works on
window group aggregates, right?
---
If your project is set up for it, you can
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4172
Yes @twalthr , you are right, the cause is different classloader. The
compiled class is under Janino's custom ClassLoader. Using the current thread's
classloader or user code classloader
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4199#discussion_r124725025
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala
---
@@ -54,34 +56,75
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4199#discussion_r124733642
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala
---
@@ -54,34 +56,75
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4138
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4105
Comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4210#discussion_r124705183
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -654,17 +654,23 @@ case class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r124704209
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -320,12 +348,20 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4183
Regarding to early firing, I think we are not on the same page and need to
discuss about what is early firing, how to configure it, how to implement it.
IMO, the early firing is to config
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4172
@kl0u I mean the compiled class (i.e. the class of the code generated
`IterativeCondition`) can't be found while deserializing. Maybe it's a problem
of Janino compiler. cc @fhueske do yo
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4200
Thanks. I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4172
@kl0u , do you mean compile code to `IterativeCondition` and set it to
`StateTransition.newCondition` field instead of the original wrapper? And it
will be serialized during snapshot and
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124506864
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -458,4 +459,52 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4183
Hi @fhueske , jincheng and me have discussed offline and have an unified
opinion.
We think the approach of window(with custom trigger) + custom operator will
increase the latency when
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4200
Thanks for updating and rebasing, the changes look good to me now.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124457542
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -422,4 +423,50 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124457316
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -422,4 +423,50 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4138#discussion_r124452756
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -0,0 +1,87
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4138#discussion_r123681972
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/scalarFunctions/ScalarFunctions.scala
---
@@ -0,0 +1,79
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4138#discussion_r124456117
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -0,0 +1,87
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4138#discussion_r124456032
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -0,0 +1,87
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4183
Hi @fhueske , I like the `firstResultTimeOffset`, a good design ! ð
Regarding to the watermark and timestamp, it makes sense to me. And a
simple approach come to my mind : assign a new
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124443977
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -230,6
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124443845
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala
---
@@ -57,6 +57,8 @@ class AggSqlFunction
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124436213
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -230,6
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4186
Looks good from my side. I think it's fine to make the CONV_RULES
non-optional for now.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4172
@kl0u I'm fine with this. I want to make sure that in order to support
FLINK-6938, we have to call `open()` on every condition after every time we
call `getNFA()`, right?
---
If your proje
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r124171844
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -358,20 +358,27 @@ abstract class
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4189
[FLINK-6958] [async] Async I/O hang when the source is bounded and collect
timeout
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4183
Oh, one thing more, would be great to add the document to the website.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4183#discussion_r123989779
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/triggers/DeferredComputationTrigger.scala
---
@@ -0,0 +1,83
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4183#discussion_r123989165
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -92,6 +100,23 @@ class StreamQueryConfig private
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4183#discussion_r123990133
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -92,6 +100,23 @@ class StreamQueryConfig private
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3943
Thanks @twalthr , I'm fine with this ,a great +1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4171
[FLINK-6887] [table] Split up CodeGenerator into several specific
CodeGenerator
Currently, the `CodeGenerator` is very huge and a bit difficult to
maintain. This PR splits it up into several
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4152
Thanks for the updating. I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4145
@dianfu I agree with you. I think we can improve that in another JIRA.
@dawidwys I have addressed all the comments.
@kl0u It'll be great if you can have a look.
Cheers,
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4145#discussion_r123204588
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -126,6 +129,7 @@ public
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4152#discussion_r123188958
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/scalarSqlFunctions/MathSqlFunctions.scala
---
@@ -0,0 +1,35
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4152#discussion_r123189112
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1116,6 +1116,13 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4145#discussion_r123186831
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -1131,6 +1152,7 @@ private void serializeStates(Set> sta
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4145#discussion_r123140396
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
@@ -36,6 +36,12 @@
private final
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4145#discussion_r123139456
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -126,6 +129,7 @@ public
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4145#discussion_r123138630
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -1131,6 +1152,7 @@ private void serializeStates(Set> sta
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r122964903
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -358,20 +358,27 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4145#discussion_r122929120
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ConditionRegistry.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4144#discussion_r122924846
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1666,14 +1666,8 @@ class CodeGenerator
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4145
[FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state
and support RichFunction interface
The core idea is that the `StateTransition` is unique in a NFA graph. So we
store the
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4111
Of course @twalthr , I haven't merged the code and thanks for your new PR.
I will have a look tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r122614563
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -192,10 +193,14 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r122613823
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -358,20 +358,27 @@ abstract class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4133
merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4133
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4133#discussion_r122389818
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -652,6 +653,21 @@ case class
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4133
[FLINK-6930] [table] Forbid selecting window start/end on row-based
Tumble/Slide windows
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4111
Travis reported a bug about composite type. Fixed it. Waiting for the new
CI pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4111#discussion_r122201344
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -871,12 +871,24 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4111#discussion_r122178152
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -871,12 +871,24 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4111#discussion_r122141845
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -871,12 +871,24 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4111#discussion_r122152659
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -871,12 +871,24 @@ class CodeGenerator
Github user wuchong closed the pull request at:
https://github.com/apache/flink/pull/4104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4104
Yes, it is cherrypicked from master. The Travis CI looks good, the failed
build seems nothing to do with this commit, so I will merge it.
---
If your project is set up for it, you can reply to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4105
Thanks @StephanEwen . This PR is aiming to fix the issues you mentioned:
it used `TypeExtractor` for Scala code.
@sunjincheng121 I addressed all your comments. Could you please have a
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4102#discussion_r121694007
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -715,15 +715,8 @@ abstract class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4102
I think the root cause is that TUMBLE_START inherits the wrong type
(`TimeIndicatorRelDataType`) from rowtime column. So maybe a better solution
is to re-create a `RelDataType` from `optimizedPlan
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121625889
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -329,6 +337,41 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4100
merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121399188
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -329,6 +337,41 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121349658
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1395,50 +1399,25 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121336133
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala
---
@@ -37,24 +36,26 @@ import
101 - 200 of 647 matches
Mail list logo
