Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5828
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5837
merging
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5836
[FLINK-9141][datastream] Fail early when using both split and side-outputs
## What is the purpose of the change
With this PR we fail early if a user attempts to use split() and
side-outputs
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4943
@shashank734 The commits are contained in 1.4 already. Have you read
[this](https://github.com/apache/flink/pull/4943#issuecomment-342156083)
comment?
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5833
[FLINK-9154][REST][docs] Document WebSubmissionExtension handlers
## What is the purpose of the change
With this PR the handlers defined in the `WebSubmissionExtension` (for
running jars
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5823
1. You should create a project _within the test_. This project must **not**
be based on `https://flink.apache.org/q/quickstart.sh`, is has to be created
with the archetype that is installed locally
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5816
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5394
I think neither solve the problem.
Variant 2 looks identical to what we have in master.
Variant 1 only allows interrupts after the task was canceled.
According to what
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5828
+1
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5786#discussion_r179716924
--- Diff: docs/ops/cli.md ---
@@ -300,70 +306,134 @@ Action "info" shows the optimized execution plan of
the pro
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5760
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5821
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5808
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5824
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5800
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5669
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5822
[FLINK-8743][docs] Allow overriding documented default
Based on #5821.
## What is the purpose of the change
This PR adds an annotation to override the documented default
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5821
[FLINK-8742][docs] Move docs generator annotations to flink-annotations
## What is the purpose of the change
This PR moves the docs generator annotations to flink-docs, for
consolidation
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5730
@tillrohrmann I've rebased and update the PR.
I've added a `getClientConfiguration()` to the `MiniClusterResource`, and
converted the MiniCluster used in the test to the `MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5817
[FLINK-9136][tests] Remove StreamingProgramTestBase
Builds on #5816.
## What is the purpose of the change
This PR removes the `StreamingProgramTestBase` class.
The class
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5816
[FLINK-9137][tests] Merge TopSpeedWindowingExampleITCase into
StreamingExamplesITCase
## What is the purpose of the change
This PR merges the `TopSpeedWindowingExampleITCase
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5815
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5815
[FLINK-9131][travis] Disable spotbugs plugin
## What is the purpose of the change
This PR disables spotbugs on travis. This will buy us 7-8 minutes in the
misc profile that currently times
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5785
ehh...whoops. Yes i closed it by accident, thanks for catching it. I'll
merge the commit in a second...
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5814
[FLINK-9045][REST] Add logging message for web UI address
## What is the purpose of the change
Adds a logging message explicitly saying on which address and port the web
UI is listening
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5695
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179123350
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -164,16 +165,13 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179087145
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179075409
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179061417
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" g
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179050736
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
---
@@ -37,18 +39,31 @@
*/
@Public
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179060408
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179056079
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179049139
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -231,6 +234,7 @@ public TaskExecutor
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179048742
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -26,6 +26,7 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179053003
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179053531
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179056758
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179054280
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179052173
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/pom.xml ---
@@ -0,0 +1,106 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179057582
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -631,14 +631,14 @@ else if (current == ExecutionState.CANCELING
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179050544
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -331,7 +332,6 @@ public JobSubmissionResult
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179054489
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179053801
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179060824
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179057166
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179052578
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179055088
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5702
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5785
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5809
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5596
merging
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179044730
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045294
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -321,8 +321,8 @@
* credit-based flow control
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045805
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045058
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" g
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179044973
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" g
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179044920
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" g
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045089
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -153,13 +153,13
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045016
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" g
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045129
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -153,13 +153,13
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045392
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -321,8 +321,8 @@
* credit-based flow control
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5797
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5766
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3117
@ShashwatRastogi-Reflektion I'm not entirely sure, but one thing you could
try is to explicitly disable chaining
(`StreamExecutionEnvironment#disableOperatorChaining`). This way the ID of each
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3117
@ShashwatRastogi-Reflektion It's a bit odd that there are different ID's
shown, I will have to look into that. It may be that one display accounts for
the uid while the other one doesn't; in any case
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3117
@ShashwatRastogi-Reflektion
1. For each task to load from the savepoint S1:
* Determine the existing hash by searching for the task ID in the logs/UI
* Set the uidHash for that task
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5766
@tillrohrmann Could you take another look? I moved the blob upload into a
separate method,
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5806
[FLINK-8960][tests] Port SavepointITCase to flip6
## What is the purpose of the change
This PR ports the `SavepointITCase` to flip6.
Significant changes were made
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5805
[FLINK-8370][REST] Port AggregatingMetricsHandler to flip6
## What is the purpose of the change
This PR ports the `AggregatingMetricsHandler` classes to flip6.
Additionally this PR
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5730#discussion_r178778708
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -21,54 +21,69 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5730#discussion_r178777980
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -21,54 +21,69 @@
import
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5795
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5797#discussion_r178773735
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -258,6 +265,37 @@ private static String createMessageHtmlEntry
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5669
I've rebased and updated the PR.
The `JobManagerCommunicationUtils` were reworked into a
`ClusterCommunicationUtils`. All contained methods were now unused. We are also
using
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5669#discussion_r178769136
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@ -1063,23
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5782
I've run the test 10k+ times on my machine without a failure, +1 from my
side.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5771
whoops, that last comment was for the wrong PR...
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5771
I've run the test 10k+ times on my machine without a failure, +1 from my
side.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5766
@tillrohrmann I've updated the PR.
* check whether there are jars to upload
* de-duplicate jar upload code
* reverted changes to the MiniClusterResource
* added a legacy version
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5664
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5694
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5772
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5697
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5596
I've rebased the PR and minimized it to only contain the jackson changes.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5697#discussion_r178754924
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/LegacyScheduleOrUpdateConsumersTest.java
---
@@ -0,0 +1,168
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5695
IMO it is not a problem to have duplicate code for legacy/new code.
Creating a base class is more effort that it is worth, as the legacy version
will be removed again in 1.6 we would then have
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5695#discussion_r178752435
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartialConsumePipelinedResultTest.java
---
@@ -32,41 +31,51
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r178751990
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -69,6 +73,10
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5743
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5769
@jparkie It didn't get lost; i added it to my next batch to merge which
didn't grow enough yet for me to commit it. I will merge it this week.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r177843186
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroExternalJarProgramITCase.java
---
@@ -44,49 +39,24
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r177841546
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -69,6 +73,10
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5782#discussion_r177804309
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
---
@@ -193,6 +197,8 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5782#discussion_r177803798
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
---
@@ -140,6 +140,9 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5697#discussion_r177801606
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/LegacyScheduleOrUpdateConsumersTest.java
---
@@ -0,0 +1,168
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5664#discussion_r177800863
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/cancelling/CancelingTestBase.java
---
@@ -18,160 +18,111 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5664#discussion_r177801072
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/cancelling/JoinCancelingITCase.java
---
@@ -30,19 +30,18 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r177800460
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -69,6 +73,10
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r177800173
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroExternalJarProgramITCase.java
---
@@ -44,49 +39,24
801 - 900 of 5225 matches
Mail list logo
