[GitHub] [flink] Airblader commented on a change in pull request #17384: [FLINK-24388][table] Modules can provide a table source/sink factory

Airblader commented on a change in pull request #17384: URL: https://github.com/apache/flink/pull/17384#discussion_r719393574 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java ## @@ -75,7

[GitHub] [flink] Airblader commented on a change in pull request #17384: [FLINK-24388][table] Modules can provide a table source/sink factory

Airblader commented on a change in pull request #17384: URL: https://github.com/apache/flink/pull/17384#discussion_r719328578 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java ## @@ -75,7

[GitHub] [flink] Airblader commented on a change in pull request #17384: [FLINK-24388][table] Modules can provide a table source/sink factory

Airblader commented on a change in pull request #17384: URL: https://github.com/apache/flink/pull/17384#discussion_r719261473 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -220,12

[GitHub] [flink] Airblader commented on a change in pull request #17384: [FLINK-24388][table] Modules can provide a table source/sink factory

Airblader commented on a change in pull request #17384: URL: https://github.com/apache/flink/pull/17384#discussion_r719256769 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/module/ModuleITCase.java ## @@ -0,0 +1,103

[GitHub] [flink] Airblader commented on a change in pull request #17384: [FLINK-24388][table] Modules can provide a table source/sink factory

Airblader commented on a change in pull request #17384: URL: https://github.com/apache/flink/pull/17384#discussion_r718453917 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java ## @@ -125,12 +125,14 @@ public

[GitHub] [flink] Airblader commented on a change in pull request #17384: [FLINK-24388][table] Modules can provide a table source/sink factory

Airblader commented on a change in pull request #17384: URL: https://github.com/apache/flink/pull/17384#discussion_r718453917 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java ## @@ -125,12 +125,14 @@ public