[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1230722665 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/ExecNodeGraphInternalPlan.java: ## @@ -75,6 +75,9 @@ public void

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1230748686 ## flink-end-to-end-tests/flink-end-to-end-tests-sql/src/test/resources/compile_plan_use_remote_file_e2e.sql: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1230718029 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/CompileAndExecutePlanOperation.java: ## @@ -19,25 +19,26 @@ package

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1222720612 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -761,7 +760,9 @@ private CompiledPlan

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1207961398 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -731,11 +732,22 @@ public TableResultInternal

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1201419123 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -731,9 +731,16 @@ public TableResultInternal

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1191301752 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/CompiledPlan.java: ## @@ -109,6 +109,8 @@ default void writeToFile(File file) {