TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-562405231
> No problem and thanks for the effort on this @TisonKun
> BTW what about the progress of `ScalaRemoteEnvironment`
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-562401533
@zjffdu could you take over this ticket and squash the changes? You're the
direct user of `JobListener` so that I
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-562389662
> Maybe to outline a bit more how things work:
>
> As a user you would write this code when submitting a
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-562057572
I address the comments. Will rebase later.
This is
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561685163
> I don't think we should enforce user to write code like this, this is not
a user-friendly api.
> Personally, I
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561667687
> > @kl0u Had a good idea: We think that the lifecycle of the client that is
given to the listener has to be
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561553419
@aljoscha I rewrite `doClose` as described above & see also [this
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561541292
@aljoscha it would make sense. One concern is about the close actions. For
some implementations of JobClient,
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561525250
> Thanks @TisonKun I am afraid I could not test it as in Zeppelin I use
`ScalaShellRemoteEnvironment` which is not
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561522851
@zjffdu I've integrated your comments. It would be quite helpful if you try
out this patch in Zeppelin use case so
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561512326
@zjffdu what for `onJobSubmitted`? Shall we also make it
`onJobSubmitted(JobClient, Throwable)`?
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561510624
> > Another question is about failure. Currently we only call back on
submission/execution succeed. If we want to
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561507505
@zjffdu I implement `JobListener#onJobExecuted` called back on both
execution(attach/detached). One more concern is
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561502618
Another question is about failure. Currently we only call back on
submission/execution succeed. If we want to react
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561489023
travis fails on `YarnDistributedCacheITCase` which I think is irrelevant to
this patch. Filed as
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561488520
@flinkbot run travis
This is an automated message
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561474666
Given those two subtasks will be resolved before 1.10 I don't tend to add
any in-place hacking code to make
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561474402
@zjffdu from my information @kl0u is working on porting
`ScalaShellRemoteEnvironment` to the new Execution
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561446570
I pushed one more commit for the later choice, you can review with or
without it for impressions of both choice.
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561443882
In my opinion such JobListener is mainly used by job management platform
such as Zeppelin which is only interested in
20 matches
Mail list logo
