[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-07 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867317503 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867148302 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866948228 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,40 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866941979 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866941717 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -173,6 +174,16

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866940778 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java: ## @@ -57,7 +55,7 @@ public boolean

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866937604 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,40 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866934861 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-05 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r865863929 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-05 Thread GitBox
gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r865820606 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,45 @@ public