[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027901067 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/source/SnapshotEnumerator.java: ## @@ -99,11 +103,48 @@ public static class

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027654165 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -130,4 +119,42 @@ public

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027645758 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -130,4 +119,42 @@ public

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027645758 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -130,4 +119,42 @@ public

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027644999 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/ContinuousFileStoreITCase.java: ## @@ -114,6 +121,55 @@ public void

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027644463 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -130,4 +119,42 @@ public

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027639409 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -130,4 +119,42 @@ public

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027638918 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -130,4 +119,42 @@ public

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027507379 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -90,6 +90,22 @@ public boolean

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026107900 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -90,6 +90,22 @@ public boolean

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026091038 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -90,6 +90,22 @@ public boolean

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026090480 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FlinkSourceBuilder.java: ## @@ -150,20 +153,20 @@ private

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

JingsongLi commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026088012 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FlinkSourceBuilder.java: ## @@ -150,20 +153,20 @@ private