Github user gallenvara closed the pull request at:
https://github.com/apache/flink/pull/1349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-159217613
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-159220295
@gallenvara Because I forgot add close message in the commit, the PR should
be closed manually. Could you close this PR? This change is merged. Sorry for
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-159214387
Looks good, please go ahead @chiwanpark :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-158914256
@gallenvara Thanks for update! Looks good to merge for me. If there is no
objection until tomorrow, I'll merge this.
---
If your project is set up for it, you can
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-158838162
Hi, @chiwanpark . I have modified the code format and submitted a new
commit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1349#discussion_r45545495
--- Diff:
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/CastingITCase.java
---
@@ -44,29 +41,13 @@ public
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1349#discussion_r45545498
--- Diff:
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/CastingITCase.java
---
@@ -89,7 +68,7 @@ public void
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1349#discussion_r45545501
--- Diff:
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/ExpressionsITCase.java
---
@@ -98,11 +77,9 @@ public void
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1349#discussion_r45545505
--- Diff:
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/FilterITCase.java
---
@@ -73,11 +54,9 @@ public void
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1349#discussion_r45545486
--- Diff:
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/AsITCase.java
---
@@ -68,16 +49,14 @@ public void testAs() throws
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-157236045
Hi, @chiwanpark . I have modified the code and committed a new commit. Can
you help me with review work?
---
If your project is set up for it, you can reply to
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-157239452
Okay I'll review soon. Thanks for update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-157236280
Hi, @chiwanpark . I have modified the code and submitted a new commit. Can
you help me with review work?
---
If your project is set up for it, you can reply to this
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-156902819
@gallenvara Yes, exactly right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-156890933
Hi, @chiwanpark . Thanks for your review. I'm not very clear about your
first suggestion. Do you mean that we should remove type description when to
create a new
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-156469184
Hi @gallenvara, I read your PR and have some comments.
First, since Flink 0.10, we dropped Java 6 support and can use omit types
if the types can be
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-156028176
I would like to shepherd this PR. Thanks for opening pull request
@gallenvara. I'll review soon.
---
If your project is set up for it, you can reply to this email
GitHub user gallenvara opened a pull request:
https://github.com/apache/flink/pull/1349
[FLINK-2956] [tests] Migrate integration tests for Table API.
Migrate integration tests of Table API from temp file to `collect()` as
described in umbrella jira.
You can merge this pull request
19 matches
Mail list logo
