Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-214806804
Failing test case is unrelated. Really good work @StefanRRichter. Will
merge it.
As a follow up, we should update the CEP documentation to also include
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r61057258
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,178 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60945888
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,122 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60931810
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,178 @@
+/*
+ *
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-214391606
Good work @StefanRRichter. I had only some minor comments left. Once these
are addressed, the PR should be ready to be merged :-)
---
If your project is set up
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60932255
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,178 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60925702
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java
---
@@ -99,9 +116,25 @@
null,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60925320
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/PatternStreamScalaJavaAPIInteroperabiliyTest.scala
---
@@ -0,0
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60925045
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60924860
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60924299
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/PatternStreamScalaJavaAPIInteroperabiliyTest.scala
---
@@ -0,0
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60924213
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/package.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60924026
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/FollowedByPattern.scala
---
@@ -0,0 +1,46 @@
+/*
+
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60923941
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,178 @@
+/*
+ *
Github user StefanRRichter commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-213443445
The current version should cover all of your feedback and could be pulled
@tillrohrmann .
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60542216
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/package.scala
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60452526
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/package.scala
---
@@ -0,0 +1,42 @@
+/*
+ *
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-212429457
Thanks for your good contribution @StefanRRichter. I had some inline
comments.
It would be good to revisit the link tags in the ScalaDocs and replace them
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60407197
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/CEPITCase.scala
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60404836
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/pattern/PatternTest.scala
---
@@ -0,0 +1,132 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60403183
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/StreamEvent.scala
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60403142
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/Event.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60403078
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/CEPScalaAPICompletenessTest.scala
---
@@ -0,0 +1,44 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60402984
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/CEPITCase.scala
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60402681
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/CEPITCase.scala
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60402439
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/package.scala
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60402382
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60401939
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60401794
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60401470
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60400970
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/package.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60400262
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60399432
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60399384
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60399207
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60399173
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/CEP.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60399038
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/CEP.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60398887
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/CEP.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60398671
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60398456
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60397159
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60397042
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60397079
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60397035
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,209 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60394471
--- Diff:
flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/StreamEvent.scala
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60394116
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java
---
@@ -61,19 +61,36 @@
public DataStream
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60393928
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java
---
@@ -99,10 +116,26 @@
null,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60383831
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60383704
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60383389
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60383097
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60382954
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,186 @@
+/*
+ *
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-211843938
It looks like it was added as part of
[FLINK-3136](https://issues.apache.org/jira/browse/FLINK-3136).
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-211840791
Does anybody know why we needed to add the asm dependency for gelly scala?
@tillrohrmann @vasia ?
---
If your project is set up for it, you can reply to this email
Github user StefanRRichter commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-211819580
Thanks Ufuk! I just saw that the build actually failed and it seems to me
that the problem is indeed related to removing the dependency to asm from the
pom.xml
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-211784417
Thank you for this great contributio! I think that CEP and a concise Scala
API go very well together. :-) I'm not a Scala expert, but I'll also have a
look later.
---
If
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60104038
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/FollowedByPattern.scala
---
@@ -0,0 +1,34 @@
+/*
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60103959
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,216 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60102619
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/FollowedByPattern.scala
---
@@ -0,0 +1,34 @@
+/*
+ *
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r60102211
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -0,0 +1,216 @@
+
+
+http://maven.apache.org/POM/4.0.0;
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/1905
[FLINK-3708] Scala API for CEP (initial).
This module flink-cep-scala adds a Scala pendant for the Java CEP API to
Flink.
I created Scala classes for Pattern and
61 matches
Mail list logo
