Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86563313
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,111 +84,144 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86561350
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,111 +84,144 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86561357
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,111 +84,144 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86557631
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,111 +84,144 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86557736
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,111 +84,144 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86557000
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,111 +84,144 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86104959
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/CheckpointCommitter.java
---
@@ -98,17 +89,19 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86108131
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,63 +86,96 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86109187
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -142,46 +184,62 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86108910
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,63 +86,96 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86109164
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -142,46 +184,62 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86107282
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraCommitter.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86109012
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,63 +86,96 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86109229
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -142,46 +184,62 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86110695
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -201,27 +259,83 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86110136
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -57,18 +59,25 @@
private
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86108509
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,63 +86,96 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86104979
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/CheckpointCommitter.java
---
@@ -98,17 +89,19 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86107589
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -27,27 +26,30 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86109608
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -142,46 +184,62 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86109500
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -142,46 +184,62 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86111394
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -77,63 +86,96 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86106408
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraCommitter.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86106025
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraCommitter.java
---
@@
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2707
[FLINK-4939] GenericWriteAheadSink: Decouple the creating from the
committing subtask for a pending checkpoint
So far the GenericWriteAheadSink expected that the subtask that wrote a
temporary buffer
26 matches
Mail list logo