[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4199 ---

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r146350727 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala --- @@ -401,16 +402,84 @@ class

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r146580553 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/validation/GroupWindowValidationTest.scala --- @@ -79,4 +79,32 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r146575845 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowPropertiesRule.scala --- @@ -0,0 +1,256 @@ +/*

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r146349993 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalWindowAggregate.scala --- @@ -29,6 +29,7 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r146575894 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowPropertiesRule.scala --- @@ -0,0 +1,256 @@ +/*

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125004836 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125003218 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlGroupFunction.java --- @@ -50,7 +50,8 @@ * GROUP BY HOP(rowtime,

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125003073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125002758 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124991860 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124990940 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124990474 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124988636 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java --- @@ -1900,7 +1900,7 @@ public void unparse(

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-29 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124725025 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-29 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124733642 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124630671 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlGroupFunction.java --- @@ -50,7 +50,8 @@ * GROUP BY HOP(rowtime,

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124638860 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124329598 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java --- @@ -1900,7 +1900,7 @@ public void

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124335785 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124341520 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124344855 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124336278 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/LogicalWindowAggregateRule.scala --- @@ -28,6 +28,7 @@

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124335359 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/MathFunctions.scala --- @@ -16,7 +16,7 @@ *

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-27 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/4199 [FLINK-6584] [table] Support multiple consecutive windows in SQL This allows for accessing rowtime and proctime attributes of windows in SQL. It introduces `TUMBLE_ROWTIME`, `TUMBLE_PROCTIME` etc.