Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5182
---
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160841610
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160841457
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160841254
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160763163
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160610346
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160610484
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160139807
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
---
@@ -107,7 +107,7 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160132296
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
---
@@ -107,7 +107,7 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160132062
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160131414
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -70,35
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r159950881
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158496021
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158194237
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158192923
--- Diff: docs/monitoring/metrics.md ---
@@ -1293,6 +1293,29 @@ Thus, in order to infer the metric identifier:
+ Kinesis
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158160866
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158159640
--- Diff: docs/monitoring/metrics.md ---
@@ -1293,6 +1293,29 @@ Thus, in order to infer the metric identifier:
+ Kinesis
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158161267
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158161564
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r157907331
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r157907259
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5182
[FLINK-8162] [kinesis-connector] Emit Kinesis' millisBehindLatest metric
## What is the purpose of the change
- Emits [Kinesis'
22 matches
Mail list logo
