Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-08 Thread via GitHub
masteryhx closed pull request #23239: [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation URL: https://github.com/apache/flink/pull/23239 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-08 Thread via GitHub
RainerMatthiasS commented on code in PR #23239: URL: https://github.com/apache/flink/pull/23239#discussion_r1386251484 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/input/MultiStateKeyIterator.java: ## @@ -46,47 +48,54 @@ public final cla

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-07 Thread via GitHub
masteryhx commented on code in PR #23239: URL: https://github.com/apache/flink/pull/23239#discussion_r1385899714 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/input/MultiStateKeyIterator.java: ## @@ -46,47 +48,54 @@ public final class Mul

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-07 Thread via GitHub
RainerMatthiasS commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1798418690 > > > > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the maste

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-06 Thread via GitHub
masteryhx commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1797370868 > > > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?' BTW

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-06 Thread via GitHub
RainerMatthiasS commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1794694360 > > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?'

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-06 Thread via GitHub
masteryhx commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1794343153 > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?' BTW: re