victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1789901594
Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
XComp commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1788901158
Thanks for your contribution, @victor9309 . I recommend you to read through
[Flink's coding
guidelines](https://flink.apache.org/how-to-contribute/code-style-and-quality-formatting/)
and
XComp merged PR #23528:
URL: https://github.com/apache/flink/pull/23528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1788632388
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1786309362
Thanks @XComp for the review. make the diff smaller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1786292325
Thanks @XComp for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1375870619
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -50,32 +53,36 @@ function setup_kubernetes_for_linux {
if ! [ -x "$(command -v minikube)" ];
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1783723332
Thanks @XComp for the review. Only `wget `is supported and implement the
artifact download in this `retry_download `function without additional
parameters `download_type `and
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1374531279
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +94,35 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1780512772
Thanks @XComp for the review. I'm sorry, but I need three parameters here,
the first is `type`, the second is `optional`, and the third is `url`
--
This is an automated message
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1371441040
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +89,42 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1371438755
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +89,42 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1371438755
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +89,42 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1778610263
Thanks @XComp for the review.
I test to execute the next attempt when it fails
> can you double-check that wget works properly (i.e. returns an non-zero
exit code) if
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1369933104
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +89,42 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1776631419
Thanks @XComp for the review. Thank you very much for your suggestions, add
a generic download and retry function (retry_times_with_download), change
crictl and/or the
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1776628420
Thanks @XComp for the review. add a generic download and retry function
(`retry_times_with_download`), change `crictl `and/or the
`cri-dockerd-version`;
--
This is an automated
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1368316329
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +101,17 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1774335390
Test crictl
--
This is an automated message from the Apache Git Service.
To
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1774332772
Thanks @XComp for the review. Current PR and PR
https://github.com/apache/flink/pull/23497 combine submission codesï¼›Use
RETRY_COUNT and RETRY_BACKOFF_TIME variables
--
This is an
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1366863438
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -39,8 +39,12 @@ function setup_kubernetes_for_linux {
if ! [ -x "$(command -v kubectl)" ]; then
victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1772153316
Thanks @XComp for the review. modify kubectl and crictl download
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
22 matches
Mail list logo
