Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-16 Thread via GitHub
1996fanrui merged PR #24042: URL: https://github.com/apache/flink/pull/24042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-16 Thread via GitHub
1996fanrui commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453078677 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-16 Thread via GitHub
RocMarshal commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453061679 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-16 Thread via GitHub
1996fanrui commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453051405 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
1996fanrui commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453038598 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
1996fanrui commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453038598 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
1996fanrui commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1893069359 > I made a fix like the env-value passing-in at https://github.com/RocMarshal/flink/commit/624c199e756ed5f04f849e8e53033bc1ef258f93 > Would we merge the additional fix into the

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
RocMarshal commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1893035604 Thanks @X-czh for the double-check and @1996fanrui review. I made a fix like the env-value passing-in at

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
X-czh commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1892997269 Hi @1996fanrui, I've verified that the current release of Flink supports modifying the logger level in both Native K8s and Standalone mode. Since YARN prepares the container launching

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-07 Thread via GitHub
flinkbot commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1880416774 ## CI report: * 09af1b68e8bf66b0c07c760f2c879c0a364469d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-07 Thread via GitHub
RocMarshal opened a new pull request, #24042: URL: https://github.com/apache/flink/pull/24042 ## What is the purpose of the change Fix the invalid configuration when using initialized root logger level on yarn deployment mode ## Brief change log - Fill the