[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093201#comment-17093201
]
Flavio Pompermaier commented on FLINK-17356:
I think that it's not bad to have them
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093179#comment-17093179
]
Dawid Wysakowicz commented on FLINK-17356:
--
The PKs are used by the planner already. The only
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093166#comment-17093166
]
Flavio Pompermaier commented on FLINK-17356:
Yes I know tat they are not used right now, but
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093159#comment-17093159
]
Dawid Wysakowicz commented on FLINK-17356:
--
I really don't have a strong opinion on it. I'll
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093140#comment-17093140
]
Flavio Pompermaier commented on FLINK-17356:
For me it's not a problem to revert those
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093084#comment-17093084
]
Dawid Wysakowicz commented on FLINK-17356:
--
A {{UNIQUE KEY}} is commonly used term for a
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092673#comment-17092673
]
Jark Wu commented on FLINK-17356:
-
I agree with you [~f.pompermaier]. SQL standard and many database
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092595#comment-17092595
]
Flavio Pompermaier commented on FLINK-17356:
I took the freedom of changing the enum because
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092461#comment-17092461
]
Jark Wu commented on FLINK-17356:
-
I created FLINK-17385 to track the precision problem.
> Properly set
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092458#comment-17092458
]
Jark Wu commented on FLINK-17356:
-
I went through the PR and it modified the UNIQUE constraint. We may
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092358#comment-17092358
]
Flavio Pompermaier commented on FLINK-17356:
Yes, you're right. My laziness told me to try
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092249#comment-17092249
]
Jark Wu commented on FLINK-17356:
-
Hi [~f.pompermaier], I went through the fixing PR. IIUC, it also
[
https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092197#comment-17092197
]
Jark Wu commented on FLINK-17356:
-
Yes. I think we should add at least the PRIMARY KEY metainfo. cc
13 matches
Mail list logo
