[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-12-18 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798080#comment-17798080 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] Cool. I totally agree with your suggestion. >

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-12-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798066#comment-17798066 ] Martijn Visser commented on FLINK-25509: [~lindong] Yes, that's what I suggest. The one thing I

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-12-18 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798047#comment-17798047 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] Just to make sure that I understand you correctly,

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-12-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798044#comment-17798044 ] Martijn Visser commented on FLINK-25509: [~ruanhang1993] [~lindong] Both the {{v3.0}} and the

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-12-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798026#comment-17798026 ] Dong Lin commented on FLINK-25509: -- [~ruanhang1993] I think we need to update flink-kafka-connector's

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-12-17 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798000#comment-17798000 ] Hang Ruan commented on FLINK-25509: --- Hi, [~martijnvisser] & [~lindong] . The Flink 1.18 has been

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-07-25 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746860#comment-17746860 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] This Jira is open because we are still waiting for

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-07-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746850#comment-17746850 ] Martijn Visser commented on FLINK-25509: [~ruanhang1993] [~lindong] Is there a reason why this

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712144#comment-17712144 ] Dong Lin commented on FLINK-25509: -- [~syhily] In the PR related to this JIRA, we added an internal

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711914#comment-17711914 ] Martijn Visser commented on FLINK-25509: [~syhily] I defer to [~lindong] for his input on that

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711902#comment-17711902 ] Yufan Sheng commented on FLINK-25509: - [~martijnvisser] I think this breaking change should be

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711777#comment-17711777 ] Martijn Visser commented on FLINK-25509: [~tison] It depends if adding support for this in

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708825#comment-17708825 ] Zili Chen commented on FLINK-25509: --- For the Pulsar side, I have a conversation with [~syhily] and

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708809#comment-17708809 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] Sure, I am happy to participate in the discussion.

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708793#comment-17708793 ] Martijn Visser commented on FLINK-25509: [~lindong] Agree on your points. I'll flag it to

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708769#comment-17708769 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] I agree with the discussion mentioned above that

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708755#comment-17708755 ] Martijn Visser commented on FLINK-25509: [~lindong] Yes, it was one of the reasons for

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708741#comment-17708741 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] Hmm... I am not sure there is consensus in the

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-05 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708707#comment-17708707 ] Martijn Visser commented on FLINK-25509: [~lindong] If it's an internal API that's being used by

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-04 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708631#comment-17708631 ] Dong Lin commented on FLINK-25509: -- [~martijnvisser] This ticket is open because we have not updated

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708518#comment-17708518 ] Martijn Visser commented on FLINK-25509: [~ruanhang1993] [~lindong] This ticket is currently

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-03-21 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703075#comment-17703075 ] Dong Lin commented on FLINK-25509: -- The change to the connector-base has been merged into apache/flink

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2022-12-20 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650103#comment-17650103 ] Hang Ruan commented on FLINK-25509: --- Hi, [~lindong] , I have read the FLIP and I am willing to help