[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976545#comment-15976545
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976533#comment-15976533
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976517#comment-15976517
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976447#comment-15976447
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976399#comment-15976399
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976396#comment-15976396
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973937#comment-15973937
]
mingleizhang commented on FLINK-6130:
-
[~Zentol] [~till.rohrmann] That makes sense to me now. So, I
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972736#comment-15972736
]
mingleizhang commented on FLINK-6130:
-
[~till.rohrmann] Void ? I see. I would think
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972731#comment-15972731
]
Chesnay Schepler commented on FLINK-6130:
-
[~mingleizhang] No, it is of type Future, meaning it
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972709#comment-15972709
]
Till Rohrmann commented on FLINK-6130:
--
[~Zentol] maybe the {{@GuardedBy("lock)}} annotation is
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972690#comment-15972690
]
mingleizhang commented on FLINK-6130:
-
[~Zentol] Doesn't it return the result of the status of YARN
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972672#comment-15972672
]
Chesnay Schepler commented on FLINK-6130:
-
[~mingleizhang] The termination future doesn't return
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972656#comment-15972656
]
mingleizhang commented on FLINK-6130:
-
[~till.rohrmann] Thanks for review, and except for [~Zentol]
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972647#comment-15972647
]
Chesnay Schepler commented on FLINK-6130:
-
[~till.rohrmann] Because the resourceManager is
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972620#comment-15972620
]
Till Rohrmann commented on FLINK-6130:
--
What is the problem with calling {{getTerminationFuture}}
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972615#comment-15972615
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970988#comment-15970988
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970983#comment-15970983
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970977#comment-15970977
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970975#comment-15970975
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970973#comment-15970973
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user tzulitai commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970972#comment-15970972
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970959#comment-15970959
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970649#comment-15970649
]
ASF GitHub Bot commented on FLINK-6130:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970608#comment-15970608
]
ASF GitHub Bot commented on FLINK-6130:
---
GitHub user zhangminglei opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970602#comment-15970602
]
mingleizhang commented on FLINK-6130:
-
[~tedyu] Thanks and appreciate it again. If there is no more
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970599#comment-15970599
]
Ted Yu commented on FLINK-6130:
---
lgtm
> Consider calling resourceManager#getTerminationFuture() with lock
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970598#comment-15970598
]
mingleizhang commented on FLINK-6130:
-
[~tedyu] Yep. And the code like below, how do you think of this
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970590#comment-15970590
]
Ted Yu commented on FLINK-6130:
---
You don't need to create another synchronized (lock) block.
You can use the
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970588#comment-15970588
]
mingleizhang commented on FLINK-6130:
-
[~tedyu] Thanks and appreciate it. I will give a PR to this
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970587#comment-15970587
]
Ted Yu commented on FLINK-6130:
---
lgtm
> Consider calling resourceManager#getTerminationFuture() with lock
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970586#comment-15970586
]
mingleizhang commented on FLINK-6130:
-
[~tedyu] Could you please help review the code ? How do you
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970408#comment-15970408
]
Ted Yu commented on FLINK-6130:
---
You can store the return value from getTerminationFuture in a variable
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970332#comment-15970332
]
mingleizhang commented on FLINK-6130:
-
[~tedyu] Thanks. I would ask how to use those return value that
34 matches
Mail list logo
