liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439142391
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala:
##
@@ -1230,8 +1232,26 @@ class
liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439142391
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala:
##
@@ -1230,8 +1232,26 @@ class
liuyongvs commented on PR #24015:
URL: https://github.com/apache/flink/pull/24015#issuecomment-1873602881
hi @xuyangzhong @lsyldliu i have add comments for important part, it will
be convenient for review. will you have time to help review?
--
This is an automated message from the
liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439141361
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLocalGroupAggregate.java:
##
@@ -147,7 +147,7 @@
flinkbot commented on PR #24015:
URL: https://github.com/apache/flink/pull/24015#issuecomment-1873601676
## CI report:
* c729879e94c5c441e661629a62a4b1653a73a045 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439140313
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecOverAggregate.java:
##
@@ -231,7 +233,7 @@ private
