[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253867#comment-15253867 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60732781 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60733883 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60735451 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213425285 Overall, I really like the work you did for the Kinesis Consumer! As you can see I've added some comments on the PR. Please let me know what's you opinion on my

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253831#comment-15253831 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60730891 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60730773 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253852#comment-15253852 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60732133 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253871#comment-15253871 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60733759 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253899#comment-15253899 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253917#comment-15253917 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253923#comment-15253923 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3708) Scala API for CEP

[ https://issues.apache.org/jira/browse/FLINK-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254004#comment-15254004 ] ASF GitHub Bot commented on FLINK-3708: --- Github user StefanRRichter commented on the pull request:

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253837#comment-15253837 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fpompermaier commented on the pull request:

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60731184 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60731207 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java ---

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1903#issuecomment-213406637 Me and Stefano agree on this :) I'll will edit the PR and commit today --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253866#comment-15253866 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253874#comment-15253874 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on the pull request:

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253872#comment-15253872 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/1916#issuecomment-213419043 The type annotation work is done from bottom to top: Firstly, we know each schema of the two input, and we know `List[] expression` in `Project` are used to

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253936#comment-15253936 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253935#comment-15253935 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60739425 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60739344 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60739883 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253944#comment-15253944 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213491263 @rmetzger Thank you very much for your detailed review on the PR :) I've replied to the comments you added, please . I can address the issues and follow up

[jira] [Comment Edited] (FLINK-1284) Uniform random sampling operator over windows

[ https://issues.apache.org/jira/browse/FLINK-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253383#comment-15253383 ] Austin Ouyang edited comment on FLINK-1284 at 4/22/16 4:40 PM: --- Hi

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60753879 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254068#comment-15254068 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254132#comment-15254132 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on the pull request:

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60770825 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java ---

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254221#comment-15254221 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-2715) Benchmark Triangle Count methods

[ https://issues.apache.org/jira/browse/FLINK-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254230#comment-15254230 ] Greg Hogan commented on FLINK-2715: --- The performance of {{TriangleEnumerator}} was considerably worse

[jira] [Created] (FLINK-3805) BloomFilter initialized with no memory available

Greg Hogan created FLINK-3805: - Summary: BloomFilter initialized with no memory available Key: FLINK-3805 URL: https://issues.apache.org/jira/browse/FLINK-3805 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60760294 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254080#comment-15254080 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60755162 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60756732 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254090#comment-15254090 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60752259 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254055#comment-15254055 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60760085 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254107#comment-15254107 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-2715) Benchmark Triangle Count methods

[ https://issues.apache.org/jira/browse/FLINK-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254051#comment-15254051 ] Greg Hogan commented on FLINK-2715: --- I happened to include some triangle benchmarks in the pull request

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254063#comment-15254063 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on the pull request:

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user tzulitai commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213465308 @rmetzger Regarding the need to upgrade Jackson to get the example working: After updating the code for Flink 1.0.x to prepare for PR, I only tested the consumer

[jira] [Commented] (FLINK-2715) Benchmark Triangle Count methods

[ https://issues.apache.org/jira/browse/FLINK-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254084#comment-15254084 ] Vasia Kalavri commented on FLINK-2715: -- Hi [~greghogan], Thanks a lot for reporting your results!

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254106#comment-15254106 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254110#comment-15254110 ] ASF GitHub Bot commented on FLINK-3229: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254332#comment-15254332 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213530765 Hi, Cool, if you have time to adress them, go ahead :) Thanks a lot for doing this by the way! I really like the work you did so far on the connector!

[jira] [Commented] (FLINK-2946) Add orderBy() to Table API

[ https://issues.apache.org/jira/browse/FLINK-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254352#comment-15254352 ] ASF GitHub Bot commented on FLINK-2946: --- GitHub user dawidwys opened a pull request:

[jira] [Created] (FLINK-3806) Revert use of DataSet.count() in Gelly

Greg Hogan created FLINK-3806: - Summary: Revert use of DataSet.count() in Gelly Key: FLINK-3806 URL: https://issues.apache.org/jira/browse/FLINK-3806 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1926 [FLINK-2946] Add orderBy() to Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1926#issuecomment-213565509 Thanks for opening this PR @dawidwys! I skimmed over the changes and it looks good. I will do a more detailed review hopefully soon. Thanks also for adding

[jira] [Commented] (FLINK-2946) Add orderBy() to Table API

[ https://issues.apache.org/jira/browse/FLINK-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254535#comment-15254535 ] ASF GitHub Bot commented on FLINK-2946: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1916#issuecomment-213567820 Thanks for the additional information @yjshen! I'm a bit behind with PR reviews, but will definitely have a look begin of next week. Thanks, Fabian --- If your project

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254544#comment-15254544 ] ASF GitHub Bot commented on FLINK-3754: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60794593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/InputFormatVertex.java --- @@ -82,9 +82,6 @@ public void

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254549#comment-15254549 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254554#comment-15254554 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60794865 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/ReplicatingInputFormat.java --- @@ -133,4 +133,18 @@ public RuntimeContext

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254572#comment-15254572 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1903#issuecomment-213573556 Thanks for the quick update @fpompermaier! The changes look mostly good. What is missing are tests that verify that `DataSourceTask` and

[jira] [Commented] (FLINK-2946) Add orderBy() to Table API

[ https://issues.apache.org/jira/browse/FLINK-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254576#comment-15254576 ] ASF GitHub Bot commented on FLINK-2946: --- Github user dawidwys commented on the pull request:

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1926#issuecomment-213575798 Always glad to help! In fact I would be happy for any suggestions what can I work on further. I changed the tests. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60797751 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254583#comment-15254583 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

<    1   2