Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82132367
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala
---
@@ -0,0 +1,777 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551224#comment-15551224
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551226#comment-15551226
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551211#comment-15551211
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82131749
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala
---
@@ -0,0 +1,777 @@
+/*
+ *
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82135948
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -118,9 +109,9 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551284#comment-15551284
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user KurtYoung commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551341#comment-15551341
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82141352
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -55,28 +56,27 @@ case class
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551169#comment-15551169
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82129916
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -325,33 +337,42 @@ trait
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82132349
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala
---
@@ -0,0 +1,777 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551333#comment-15551333
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551249#comment-15551249
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user KurtYoung commented on a diff in the pull
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82134273
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -416,15 +333,14 @@ private boolean
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82132624
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -136,53 +127,34 @@ public
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551229#comment-15551229
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user KurtYoung commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551263#comment-15551263
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user KurtYoung commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82133014
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala
---
@@ -0,0 +1,777 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551233#comment-15551233
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82134943
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -245,22 +255,26 @@ public TaskExecutorGateway
Till Rohrmann created FLINK-4752:
Summary: Improve session window documentation
Key: FLINK-4752
URL: https://issues.apache.org/jira/browse/FLINK-4752
Project: Flink
Issue Type: Improvement
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82140542
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala
---
@@ -0,0 +1,777 @@
+/*
+ *
Github user gheo21 commented on the issue:
https://github.com/apache/flink/pull/2397
Hi guys @StephanEwen @rmetzger , I've rebased once again the branch and
fixed the merge conflicts. The travis build has two failed builds but one is
connection reset by maven and the other one is
[
https://issues.apache.org/jira/browse/FLINK-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551201#comment-15551201
]
ASF GitHub Bot commented on FLINK-4439:
---
Github user gheo21 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551460#comment-15551460
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82149847
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82149863
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551529#comment-15551529
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551523#comment-15551523
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82147739
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -0,0 +1,261 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82151066
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -0,0 +1,132 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82155453
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -118,9 +109,9 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther closed FLINK-4699.
---
Resolution: Duplicate
> Convert Kafka TableSource/TableSink tests to unit tests
>
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2600#discussion_r82142194
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java
---
@@ -232,6 +242,40 @@ public R recover(Throwable failure)
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2600#discussion_r82141826
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java
---
@@ -190,7 +191,16 @@ public R recover(Throwable failure)
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551361#comment-15551361
]
ASF GitHub Bot commented on FLINK-4751:
---
Github user uce commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551360#comment-15551360
]
ASF GitHub Bot commented on FLINK-4751:
---
Github user uce commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551359#comment-15551359
]
ASF GitHub Bot commented on FLINK-4751:
---
Github user uce commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551406#comment-15551406
]
ASF GitHub Bot commented on FLINK-4751:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2600
Thanks for the review @uce. I will address your comments and then merge the
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82146791
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -497,3 +501,95 @@ case class
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551476#comment-15551476
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551449#comment-15551449
]
ASF GitHub Bot commented on FLINK-4751:
---
Github user uce commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551459#comment-15551459
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551528#comment-15551528
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551530#comment-15551530
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551527#comment-15551527
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82151050
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -0,0 +1,132 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82152829
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -0,0 +1,261 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82147669
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -0,0 +1,261 @@
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551526#comment-15551526
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551524#comment-15551524
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82147461
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -0,0 +1,261 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82151146
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -0,0 +1,132 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82147584
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -0,0 +1,261 @@
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551522#comment-15551522
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82144274
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -0,0 +1,261 @@
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551525#comment-15551525
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551557#comment-15551557
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user mxm commented on a diff in the pull request:
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82157384
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -136,53 +127,34 @@ public
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2600#discussion_r82148748
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java
---
@@ -232,6 +244,40 @@ public R recover(Throwable failure)
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82150960
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala
---
@@ -0,0 +1,242 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82150850
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala
---
@@ -0,0 +1,242 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551475#comment-15551475
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551505#comment-15551505
]
Anton Mushin commented on FLINK-4604:
-
I have some problem.
I added rule in
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551536#comment-15551536
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user mxm commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551532#comment-15551532
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user mxm commented on a diff in the pull request:
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82155691
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -205,46 +177,64 @@ public void
Tzu-Li (Gordon) Tai created FLINK-4753:
--
Summary: Kafka 0.8 connector's Periodic Offset Committer should
synchronize on checkpoint lock
Key: FLINK-4753
URL: https://issues.apache.org/jira/browse/FLINK-4753
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2600#discussion_r82142626
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java
---
@@ -232,6 +244,40 @@ public R recover(Throwable failure)
[
https://issues.apache.org/jira/browse/FLINK-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551433#comment-15551433
]
ASF GitHub Bot commented on FLINK-3932:
---
Github user mxm commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2589
Thanks for the PR @vijikarthi. The changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551547#comment-15551547
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user mxm commented on a diff in the pull request:
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82156547
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -416,15 +333,14 @@ private boolean
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551417#comment-15551417
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
Thanks for the comments @KurtYoung. I've updated the PR. No worries, four
eyes always see more than two and it is natural that ideas progress over time :)
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551563#comment-15551563
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user mxm commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552086#comment-15552086
]
Timo Walther commented on FLINK-4604:
-
Maybe the cost function of {{DataSetAggregate}} is faulty.
Ruwen Moos created FLINK-4756:
-
Summary: NullPointerException on submiting a job with
StreamExecutionEnvironment.createRemoteEnvironment to a flink cluster
Key: FLINK-4756
URL:
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2602
[hotfix] Re-register restored processing time timers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink hotfix_reregister
Alternatively
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2603
[FLINK-4745] [table] Convert KafkaTableSource test to unit tests
This PR replaces IT cases with unit tests.
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/FLINK-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551679#comment-15551679
]
ASF GitHub Bot commented on FLINK-4745:
---
GitHub user twalthr opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551706#comment-15551706
]
Timo Walther commented on FLINK-4604:
-
Your implementation looks good so far. The output of
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-4751.
Resolution: Fixed
Added via 98710ead59305fc067cb8fdfab2c47d3bdc2e3fc
> Extend Flink's futures to
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551943#comment-15551943
]
Timo Walther edited comment on FLINK-4604 at 10/6/16 1:36 PM:
--
Ok, it seems
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552063#comment-15552063
]
Anton Mushin edited comment on FLINK-4604 at 10/6/16 2:24 PM:
--
bq. Can you
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anton Mushin updated FLINK-4604:
Attachment: 1.jpg
bq. Can you check if AggregateReduceFunctionsRule.matches is called?
yes it is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551688#comment-15551688
]
ASF GitHub Bot commented on FLINK-4751:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551712#comment-15551712
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551734#comment-15551734
]
ASF GitHub Bot commented on FLINK-4691:
---
Github user twalthr commented on a diff in the pull
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2583#discussion_r82174054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointMetaData.java
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551768#comment-15551768
]
Anton Mushin edited comment on FLINK-4604 at 10/6/16 12:22 PM:
---
I used
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82177134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -0,0 +1,132 @@
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82177163
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -0,0 +1,132 @@
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551911#comment-15551911
]
ASF GitHub Bot commented on FLINK-4348:
---
Github user mxm commented on the issue:
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82186936
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -325,33 +337,42 @@ trait
[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551943#comment-15551943
]
Timo Walther commented on FLINK-4604:
-
Ok, it seems that the {{AggregateReduceFunctionsRule}} does
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2562#discussion_r82170078
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala
---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
1 - 100 of 197 matches
Mail list logo
