[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...

2016-12-09 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 Thanks @fhueske . I agree very much. It is necessary to split the tests into a validation and a plan test class. I will follow the suggestions. --- If your project is set up for it, you

[GitHub] flink issue #2564: [FLINK-2254] Add BipartiateGraph class

2016-12-09 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2564 Thanks for the reminder @vasia. The separate JIRA sub-task does allow for a discussion of how best to document the full set of proposed bipartite functionality. --- If your project is set up for

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736459#comment-15736459 ] ASF GitHub Bot commented on FLINK-2254: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-5298) TaskManager crashes when TM log not existant

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736736#comment-15736736 ] ASF GitHub Bot commented on FLINK-5298: --- Github user EronWright commented on the issue:

[GitHub] flink issue #2974: [FLINK-5298] TM checks that log file exists

2016-12-09 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/2974 @zentol I am fine with the 'error' behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #2983: [FLINK-4693][tableApi] Add session group-windows f...

2016-12-09 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/2983 [FLINK-4693][tableApi] Add session group-windows for batch tables Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737026#comment-15737026 ] ASF GitHub Bot commented on FLINK-4693: --- GitHub user sunjincheng121 opened a pull request:

[jira] [Assigned] (FLINK-5223) Add documentation of UDTF in Table API & SQL

2016-12-09 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-5223: -- Assignee: Jark Wu > Add documentation of UDTF in Table API & SQL >

[GitHub] flink issue #2564: [FLINK-2254] Add BipartiateGraph class

2016-12-09 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2564 Hi @vasia , thank you for merging my PR. Thank you for the reminder about the documentation. I've created the JIRA for it: https://issues.apache.org/jira/browse/FLINK-5311 --- If your

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736510#comment-15736510 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on the issue:

[jira] [Assigned] (FLINK-5225) Add interface to override parameter types of UDTF's eval method

2016-12-09 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-5225: -- Assignee: Jark Wu > Add interface to override parameter types of UDTF's eval method >

[jira] [Created] (FLINK-5311) Write user documentation for BipartiteGraph

2016-12-09 Thread Ivan Mushketyk (JIRA)
Ivan Mushketyk created FLINK-5311: - Summary: Write user documentation for BipartiteGraph Key: FLINK-5311 URL: https://issues.apache.org/jira/browse/FLINK-5311 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-5084) Replace Java Table API integration tests by unit tests

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737298#comment-15737298 ] ASF GitHub Bot commented on FLINK-5084: --- Github user mtunique commented on the issue:

[GitHub] flink pull request #2942: [FLINK-4693][tableApi] Add session group-windows f...

2016-12-09 Thread sunjincheng121
Github user sunjincheng121 closed the pull request at: https://github.com/apache/flink/pull/2942 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4693) Add session group-windows for batch tables

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737014#comment-15737014 ] ASF GitHub Bot commented on FLINK-4693: --- Github user sunjincheng121 closed the pull request at:

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

2016-12-09 Thread chenqin
Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 cc @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736976#comment-15736976 ] ASF GitHub Bot commented on FLINK-4460: --- GitHub user chenqin opened a pull request:

[GitHub] flink pull request #2982: [FLINK-4460] Side Outputs in Flink

2016-12-09 Thread chenqin
GitHub user chenqin opened a pull request: https://github.com/apache/flink/pull/2982 [FLINK-4460] Side Outputs in Flink [FLIP-13](https://cwiki.apache.org/confluence/display/FLINK/FLIP-13+Side+Outputs+in+Flink) Expose sideOutput with `OutputTag`, For those userFunction

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737206#comment-15737206 ] ASF GitHub Bot commented on FLINK-4460: --- Github user chenqin commented on the issue:

[jira] [Created] (FLINK-5305) Documentation of collect() should mention parameter akka.framesize

2016-12-09 Thread Arnaud Linz (JIRA)
Arnaud Linz created FLINK-5305: -- Summary: Documentation of collect() should mention parameter akka.framesize Key: FLINK-5305 URL: https://issues.apache.org/jira/browse/FLINK-5305 Project: Flink

[GitHub] flink pull request #2961: [FLINK-5266] [table] eagerly project unused fields...

2016-12-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2961#discussion_r91691224 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -881,24 +883,21 @@ class GroupWindowedTable( *

[jira] [Commented] (FLINK-5297) Relocate Flink's Hadoop dependency and its transitive dependencies

2016-12-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734938#comment-15734938 ] Robert Metzger commented on FLINK-5297: --- I'm wondering if it would be sufficient for now to just

[jira] [Commented] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734849#comment-15734849 ] Fabian Hueske commented on FLINK-5255: -- Initially, the plan consists of {{LogicalProject}} and

[jira] [Comment Edited] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734933#comment-15734933 ] Alexander Shoshin edited comment on FLINK-5255 at 12/9/16 10:32 AM: I

[jira] [Commented] (FLINK-2821) Change Akka configuration to allow accessing actors from different URLs

2016-12-09 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734969#comment-15734969 ] Maximilian Michels commented on FLINK-2821: --- I appreciate your timely feedback! {quote} I also

[jira] [Created] (FLINK-5304) Change method name from crossApply to join in Table API

2016-12-09 Thread Jark Wu (JIRA)
Jark Wu created FLINK-5304: -- Summary: Change method name from crossApply to join in Table API Key: FLINK-5304 URL: https://issues.apache.org/jira/browse/FLINK-5304 Project: Flink Issue Type:

[jira] [Commented] (FLINK-5187) Create analog of Row in core

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734864#comment-15734864 ] ASF GitHub Bot commented on FLINK-5187: --- Github user tonycox commented on a diff in the pull

[jira] [Commented] (FLINK-5187) Create analog of Row in core

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734865#comment-15734865 ] ASF GitHub Bot commented on FLINK-5187: --- Github user tonycox commented on a diff in the pull

[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API

2016-12-09 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734941#comment-15734941 ] Timo Walther commented on FLINK-5304: - I'm fine with this change but what happens with {{outerApply}}?

[jira] [Commented] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734839#comment-15734839 ] Alexander Shoshin commented on FLINK-5255: -- I found that we can have a {{LogicalProject}}

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91690748 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-5187) Create analog of Row in core

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734903#comment-15734903 ] ASF GitHub Bot commented on FLINK-5187: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-5266) Eagerly project unused fields when selecting aggregation fields

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734912#comment-15734912 ] ASF GitHub Bot commented on FLINK-5266: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91674126 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91670483 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java --- @@ -326,8 +326,8 @@ public int getNormalizeKeyLen() {

[jira] [Commented] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734933#comment-15734933 ] Alexander Shoshin commented on FLINK-5255: -- I check join inputs in a {{matches(..)}} method of

[GitHub] flink issue #2970: [FLINK-5300] Add more gentle file deletion procedure

2016-12-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2970 I like the idea. I am wondering how expensive getting the array of `FileStatus` for all files in the directory is. HDFS in Hadoop 2 has the option to get a `ContentSummary` that has the

[jira] [Commented] (FLINK-5300) FileStateHandle#discard & FsCheckpointStateOutputStream#close tries to delete non-empty directory

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735088#comment-15735088 ] ASF GitHub Bot commented on FLINK-5300: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2971: [backport] [FLINK-5300] Add more gentle file deletion pro...

2016-12-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2971 I left a review on #2970 https://github.com/apache/flink/pull/2970#issuecomment-265994539 that can be applied here as well. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #2979: [FLINK-5307] [metrics] Log reporter configuration

2016-12-09 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2979 [FLINK-5307] [metrics] Log reporter configuration With this PR the configuration for every reporter will be logged. Twice. First, we log the `Properties` object that contains the

[GitHub] flink issue #2959: [FLINK-5278] Improve task and checkpoint related logging

2016-12-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2959 Local travis build passed: https://travis-ci.org/tillrohrmann/flink/builds/182339160. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5278) Improve Task and checkpoint logging

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735345#comment-15735345 ] ASF GitHub Bot commented on FLINK-5278: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-5285) CancelCheckpointMarker flood when using at least once mode

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735338#comment-15735338 ] ASF GitHub Bot commented on FLINK-5285: --- Github user tillrohrmann commented on the issue:

[jira] [Created] (FLINK-5306) Display checkpointing configuration details in web UI "Configuration" tab

2016-12-09 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-5306: - Summary: Display checkpointing configuration details in web UI "Configuration" tab Key: FLINK-5306 URL: https://issues.apache.org/jira/browse/FLINK-5306 Project:

[GitHub] flink pull request #2969: [FLINK-5289] Meaningful exception when using value...

2016-12-09 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2969#discussion_r91703759 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java --- @@ -106,17 +109,45 @@ public

[GitHub] flink pull request #2969: [FLINK-5289] Meaningful exception when using value...

2016-12-09 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2969#discussion_r91703632 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java --- @@ -106,17 +109,45 @@ public

[jira] [Commented] (FLINK-5289) NPE when using value state on non-keyed stream

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735125#comment-15735125 ] ASF GitHub Bot commented on FLINK-5289: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5289) NPE when using value state on non-keyed stream

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735126#comment-15735126 ] ASF GitHub Bot commented on FLINK-5289: --- Github user StephanEwen commented on a diff in the pull

[jira] [Updated] (FLINK-2609) Automatic type registration is only called from the batch execution environment

2016-12-09 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-2609: Assignee: (was: Chesnay Schepler) > Automatic type registration is only called from the

[GitHub] flink issue #2890: [hotfix] properly encapsulate the original exception in J...

2016-12-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2890 Final travis build: https://travis-ci.org/rmetzger/flink/builds/182582571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #2923: [FLINK-5220] [Table API & SQL] Flink SQL projectio...

2016-12-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2923#discussion_r91709480 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/ProjectableTableSourceITCase.scala --- @@ -0,0 +1,154 @@ +/* +

[GitHub] flink pull request #2923: [FLINK-5220] [Table API & SQL] Flink SQL projectio...

2016-12-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2923#discussion_r91711313 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/plan/rules/util/RexProgramProjectExtractorTest.scala --- @@ -0,0 +1,121 @@

[GitHub] flink pull request #2923: [FLINK-5220] [Table API & SQL] Flink SQL projectio...

2016-12-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2923#discussion_r91704173 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/PushProjectIntoBatchTableSourceScanRule.scala --- @@ -0,0

[GitHub] flink pull request #2923: [FLINK-5220] [Table API & SQL] Flink SQL projectio...

2016-12-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2923#discussion_r91713315 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/PushProjectIntoBatchTableSourceScanRule.scala --- @@ -0,0

[GitHub] flink issue #2912: [FLINK-5114] [network] Handle partition producer state ch...

2016-12-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2912 Forwarding the feedback from #2975 since the main changes are similar and merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-5114) PartitionState update with finished execution fails

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735297#comment-15735297 ] ASF GitHub Bot commented on FLINK-5114: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-5285) CancelCheckpointMarker flood when using at least once mode

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735316#comment-15735316 ] ASF GitHub Bot commented on FLINK-5285: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2964: [backport] [FLINK-5285] Abort checkpoint only once in Bar...

2016-12-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2964 Test failure are unrelated. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-5297) Relocate Flink's Hadoop dependency and its transitive dependencies

2016-12-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735043#comment-15735043 ] Till Rohrmann commented on FLINK-5297: -- Then let's try to first relocate {{aws-java-sdk}} and see

[GitHub] flink pull request #2977: Flink 5084

2016-12-09 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/2977 Flink 5084 I replace the Java Table API ITCases by tests that check that the parsing step produces a valid logical plan. Before I delete the ITCases, I have check there are UTCases in scala.

[GitHub] flink issue #2972: [FLINK-5211] [metrics] [docs] Include example reporter co...

2016-12-09 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2972 @uce Thanks for the review, I've checked that every configuration does in fact work. Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2890: [hotfix] properly encapsulate the original exception in J...

2016-12-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2890 +1 to merge. I'll merge it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2975: [backport] [FLINK-5114] [network] Handle partition produc...

2016-12-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2975 Thanks for your review Stephan! Going to address your comment and merge this for 1.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-5114) PartitionState update with finished execution fails

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735266#comment-15735266 ] ASF GitHub Bot commented on FLINK-5114: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-5306) Display checkpointing configuration details in web UI "Configuration" tab

2016-12-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735078#comment-15735078 ] Robert Metzger commented on FLINK-5306: --- Perfect :) Is this a duplicate then? > Display

[jira] [Commented] (FLINK-5306) Display checkpointing configuration details in web UI "Configuration" tab

2016-12-09 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735100#comment-15735100 ] Ufuk Celebi commented on FLINK-5306: No, didn't open an issue yet, but I'll make this a sub task. >

[jira] [Closed] (FLINK-5269) Convert string-based Table API tests into unit tests

2016-12-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5269. Resolution: Duplicate Duplicate of FLINK-5084 > Convert string-based Table API tests into unit

[jira] [Created] (FLINK-5307) Log configuration for every reporter

2016-12-09 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-5307: --- Summary: Log configuration for every reporter Key: FLINK-5307 URL: https://issues.apache.org/jira/browse/FLINK-5307 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735215#comment-15735215 ] Alexander Shoshin commented on FLINK-5255: -- Thanks, Fabian, I'll check for {{LogicalCalc}} then.

[jira] [Commented] (FLINK-4906) Use constants for the name of system-defined metrics

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735280#comment-15735280 ] ASF GitHub Bot commented on FLINK-4906: --- GitHub user zentol opened a pull request:

[GitHub] flink issue #2872: [FLINK-5158] [ckPtCoord] Handle exceptions from Completed...

2016-12-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2872 `ScalaShellITCase` hung in the failing travis build. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-5158) Handle ZooKeeperCompletedCheckpointStore exceptions in CheckpointCoordinator

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735350#comment-15735350 ] ASF GitHub Bot commented on FLINK-5158: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735030#comment-15735030 ] Fabian Hueske commented on FLINK-5255: -- I see. The {{LogicalCalc}} is hidden in the {{RelSubset}}

[jira] [Commented] (FLINK-5288) Flakey ConnectedComponentsITCase#testConnectedComponentsExample unit test

2016-12-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735140#comment-15735140 ] Stephan Ewen commented on FLINK-5288: - These kind of failures only seem to occur on the recent Travis

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91704437 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-5187) Create analog of Row in core

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735143#comment-15735143 ] ASF GitHub Bot commented on FLINK-5187: --- Github user tonycox commented on a diff in the pull

[GitHub] flink pull request #2972: [FLINK-5211] [metrics] [docs] Include example repo...

2016-12-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2972#discussion_r91705355 --- Diff: docs/monitoring/metrics.md --- @@ -335,6 +345,21 @@ Parameters: - `ttl` - time-to-live for transmitted UDP packets - `addressingMode` - UDP

[jira] [Commented] (FLINK-5211) Include an example configuration for all reporters

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735161#comment-15735161 ] ASF GitHub Bot commented on FLINK-5211: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5211) Include an example configuration for all reporters

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735158#comment-15735158 ] ASF GitHub Bot commented on FLINK-5211: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5211) Include an example configuration for all reporters

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735163#comment-15735163 ] ASF GitHub Bot commented on FLINK-5211: --- Github user zentol commented on the issue:

[GitHub] flink pull request #2978: [FLINK-5304] [table] Change method name from cross...

2016-12-09 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2978 [FLINK-5304] [table] Change method name from crossApply to join in Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-5114) PartitionState update with finished execution fails

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735176#comment-15735176 ] ASF GitHub Bot commented on FLINK-5114: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2972: [FLINK-5211] [metrics] [docs] Include example repo...

2016-12-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2972#discussion_r91715769 --- Diff: docs/monitoring/metrics.md --- @@ -335,6 +345,21 @@ Parameters: - `ttl` - time-to-live for transmitted UDP packets - `addressingMode` - UDP

[jira] [Commented] (FLINK-5211) Include an example configuration for all reporters

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735323#comment-15735323 ] ASF GitHub Bot commented on FLINK-5211: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #2909: [FLINK-5193] [jm] Harden job recovery in case of recovery...

2016-12-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2909 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Comment Edited] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule

2016-12-09 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735215#comment-15735215 ] Alexander Shoshin edited comment on FLINK-5255 at 12/9/16 12:41 PM:

[GitHub] flink pull request #2980: [FLINK-4906] [metrics] Introduce constants for IO ...

2016-12-09 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2980 [FLINK-4906] [metrics] Introduce constants for IO metrics This PR introduces constants for the names of all all records/byte related IO metrics (numRecordsOut etc.). Before we go ahead and

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735287#comment-15735287 ] ASF GitHub Bot commented on FLINK-5220: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735290#comment-15735290 ] ASF GitHub Bot commented on FLINK-5220: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735286#comment-15735286 ] ASF GitHub Bot commented on FLINK-5220: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735289#comment-15735289 ] ASF GitHub Bot commented on FLINK-5220: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735288#comment-15735288 ] ASF GitHub Bot commented on FLINK-5220: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2923: [FLINK-5220] [Table API & SQL] Flink SQL projectio...

2016-12-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2923#discussion_r91706582 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/ProjectableTableSource.scala --- @@ -0,0 +1,38 @@ +/* + *

[GitHub] flink issue #2963: [FLINK-5285] Abort checkpoint only once in BarrierTracker

2016-12-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2963 Thanks for the review @StephanEwen. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5193) Recovering all jobs fails completely if a single recovery fails

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735347#comment-15735347 ] ASF GitHub Bot commented on FLINK-5193: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API

2016-12-09 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734992#comment-15734992 ] Jark Wu commented on FLINK-5304: Yes. {{outerApply}} will be renamed to {{leftOuterJoin}} > Change method

[jira] [Commented] (FLINK-5306) Display checkpointing configuration details in web UI "Configuration" tab

2016-12-09 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735071#comment-15735071 ] Ufuk Celebi commented on FLINK-5306: I planned to make this part of the stats refactoring. Stay

[jira] [Assigned] (FLINK-5306) Display checkpointing configuration details in web UI "Configuration" tab

2016-12-09 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-5306: -- Assignee: Ufuk Celebi > Display checkpointing configuration details in web UI "Configuration"

[jira] [Commented] (FLINK-5300) FileStateHandle#discard & FsCheckpointStateOutputStream#close tries to delete non-empty directory

2016-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735089#comment-15735089 ] ASF GitHub Bot commented on FLINK-5300: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2972: [FLINK-5211] [metrics] [docs] Include example repo...

2016-12-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2972#discussion_r91705438 --- Diff: docs/monitoring/metrics.md --- @@ -335,6 +345,21 @@ Parameters: - `ttl` - time-to-live for transmitted UDP packets - `addressingMode` - UDP

  1   2   3   >