[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97730820 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837384#comment-15837384 ] ASF GitHub Bot commented on FLINK-2168: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97734069 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837402#comment-15837402 ] ASF GitHub Bot commented on FLINK-2168: --- Github user ex00 commented on a diff in the pull request:

[GitHub] flink issue #3205: [FLINK-5635] Improve Docker tooling to make it easier to ...

2017-01-25 Thread ex00
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/3205 Hi @jgrier. Thaks for your PR! Could you update [README.md](https://github.com/apache/flink/blob/master/flink-contrib/docker-flink/README.md) in accordance with your changes? --- If your project

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837387#comment-15837387 ] ASF GitHub Bot commented on FLINK-5626: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837459#comment-15837459 ] ASF GitHub Bot commented on FLINK-4905: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837496#comment-15837496 ] ASF GitHub Bot commented on FLINK-5626: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaming Examples

2017-01-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2761 @ch33hau, sure! Just drop a comment when you updated the PR (a simple push does not trigger a notification but a comment does). Thanks, Fabian --- If your project is set up for it, you

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837488#comment-15837488 ] ASF GitHub Bot commented on FLINK-5626: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837379#comment-15837379 ] ASF GitHub Bot commented on FLINK-2168: --- Github user ex00 commented on a diff in the pull request:

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97736554 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,135 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837420#comment-15837420 ] ASF GitHub Bot commented on FLINK-2168: --- Github user ramkrish86 commented on a diff in the pull

[jira] [Commented] (FLINK-5620) Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837505#comment-15837505 ] ASF GitHub Bot commented on FLINK-5620: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3201: [FLINK-5620] Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3201 This looks good, I'm merging. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3198 I think we can keep from having to close the `AbstractStateBackend` by not caching the `dbOptions` and `columnOptions` and instead giving new ones to the `RocksDBKeyedStateBackend`. The keyed

[jira] [Commented] (FLINK-5612) GlobPathFilter not-serializable exception

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837427#comment-15837427 ] ASF GitHub Bot commented on FLINK-5612: --- GitHub user mushketyk opened a pull request:

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837425#comment-15837425 ] ASF GitHub Bot commented on FLINK-2168: --- Github user ramkrish86 commented on a diff in the pull

[GitHub] flink pull request #3206: [FLINK-5612] Fix GlobPathFilter not-serializable e...

2017-01-25 Thread mushketyk
GitHub user mushketyk opened a pull request: https://github.com/apache/flink/pull/3206 [FLINK-5612] Fix GlobPathFilter not-serializable exception Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[GitHub] flink pull request #3207: Agg follow ups

2017-01-25 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/3207 Agg follow ups Issues fixed in this PR: - Add a `RichAggregateFunction` - Document generic type parameters - Document methods of the `AggregateFunction` - Adds the

[jira] [Commented] (FLINK-5633) ClassCastException: X cannot be cast to X when re-submitting a job.

2017-01-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837475#comment-15837475 ] Stephan Ewen commented on FLINK-5633: - This is covered in that section of the

[jira] [Commented] (FLINK-5635) Improve Docker tooling to make it easier to build images and launch Flink via Docker tools

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837365#comment-15837365 ] ASF GitHub Bot commented on FLINK-5635: --- Github user ex00 commented on the issue:

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837495#comment-15837495 ] ASF GitHub Bot commented on FLINK-5626: --- Github user StefanRRichter commented on the issue:

[jira] [Reopened] (FLINK-5492) BootstrapTools log wrong address of started ActorSystem

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reopened FLINK-5492: --- I need to reopen this issue because one of the changes in this JIRA are not correct. I now see

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3198 Renaming is not part of this PR/Jira Issue, though, so with the changes to ownership of the RocksDB options I would like to merge this quickly. We can then open another issue for the renaming, if

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3198 Alright, then I am changing this first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837498#comment-15837498 ] ASF GitHub Bot commented on FLINK-5626: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-5620) Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837509#comment-15837509 ] ASF GitHub Bot commented on FLINK-5620: --- Github user kl0u commented on the issue:

[GitHub] flink issue #3201: [FLINK-5620] Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3201 @aljoscha Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837415#comment-15837415 ] ASF GitHub Bot commented on FLINK-3551: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3035: [ FLINK-4905] Kafka test instability IllegalStateExceptio...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3035 Quick question: I am not sure if this scenario can happen like that: > But in this approach an unlikely bug will be still occurred: zkHandler.prepareAndCommitOffsets(offsets); throws

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837456#comment-15837456 ] ASF GitHub Bot commented on FLINK-5626: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3198 If the caching is optional, then I would also prefer to keep it out of the factory. Different question: if there is no other reason against it, wouldn't that also be an opportunity to rename

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3198 The is already `StateBackendFactory`. 😉 Both are used in the "public" APIs: `StateBackendFactory` is used for setting a backend in the config while `AbstractStateBackend` appears in a public

[jira] [Created] (FLINK-5636) IO Metric for StreamTwoInputProcessor

2017-01-25 Thread david.wang (JIRA)
david.wang created FLINK-5636: - Summary: IO Metric for StreamTwoInputProcessor Key: FLINK-5636 URL: https://issues.apache.org/jira/browse/FLINK-5636 Project: Flink Issue Type: Bug

[GitHub] flink pull request #:

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/6342d6db1de5f38a921732e35abd83e6c5b9305a#commitcomment-20606338 In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java: In

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97738061 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,135 @@ +/* + * Licensed

[jira] [Commented] (FLINK-5626) Improve resource release in RocksDBKeyedStateBackend

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837448#comment-15837448 ] ASF GitHub Bot commented on FLINK-5626: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3198 Aljoscha's proposal sounds reasonable to me :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3198: [FLINK-5626] Improved resource deallocation in RocksDBKey...

2017-01-25 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3198 I would call this `AbstractStateBackendFactory`, because that is what it is...an abstract factory for state backends. --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...

2017-01-25 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Hi @StephanEwen, @zentol Thank you for your comments. I've update the PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5546) java.io.tmpdir setted as project build directory in surefire plugin

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837776#comment-15837776 ] ASF GitHub Bot commented on FLINK-5546: --- Github user shijinkui commented on the issue:

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837807#comment-15837807 ] ASF GitHub Bot commented on FLINK-5638: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2768: [FLINK-5023][FLINK-5024] Add SimpleStateDescriptor to cla...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2768 Hi @shixiaogang ! I went through this pull request and below are a few thoughts. The pull request changes many things together. Some can work, and for others I would suggest to do it

[jira] [Commented] (FLINK-5023) Add get() method in State interface

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837881#comment-15837881 ] ASF GitHub Bot commented on FLINK-5023: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-01-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r97788511 --- Diff: flink-contrib/flink-storm-examples/pom.xml --- @@ -364,6 +363,18 @@ under the License.

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837809#comment-15837809 ] ASF GitHub Bot commented on FLINK-5092: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4944) Replace Akka's death watch with own heartbeat on the TM side

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837880#comment-15837880 ] ASF GitHub Bot commented on FLINK-4944: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837884#comment-15837884 ] ASF GitHub Bot commented on FLINK-5638: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-5628) CheckpointStatsTracker implements Serializable but isn't

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837883#comment-15837883 ] ASF GitHub Bot commented on FLINK-5628: --- GitHub user uce opened a pull request:

[jira] [Commented] (FLINK-5628) CheckpointStatsTracker implements Serializable but isn't

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837892#comment-15837892 ] ASF GitHub Bot commented on FLINK-5628: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3215: [FLINK-5628] [webfrontend] Fix serialization of st...

2017-01-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3215#discussion_r97799769 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java --- @@ -105,10 +110,12 @@ public

[GitHub] flink issue #3214: [FLINK-5644] Remove metric: Task#lastCheckpointSize

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3214 Are there alternative checkpoint metrics available? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-5644) Task#lastCheckpointSize metric broken

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837910#comment-15837910 ] ASF GitHub Bot commented on FLINK-5644: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3214: [FLINK-5644] Remove metric: Task#lastCheckpointSize

2017-01-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3214 Everything that the `CheckpointStatsTracker` tracks is also exposed as a metric on the JM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-5644) Task#lastCheckpointSize metric broken

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837912#comment-15837912 ] ASF GitHub Bot commented on FLINK-5644: --- Github user zentol commented on the issue:

[GitHub] flink issue #3213: [backport] [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3213 Thanks for the review @rmetzger. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837795#comment-15837795 ] ASF GitHub Bot commented on FLINK-5643: --- Github user tillrohrmann commented on the issue:

[jira] [Closed] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-5643. Resolution: Fixed 1.3.0: cf9f4c77c8e785567f036cc2fbb97c0cd16979a7 1.2.0:

[GitHub] flink pull request #3212: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837835#comment-15837835 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837831#comment-15837831 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837836#comment-15837836 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790385 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789988 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789900 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789775 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -80,25 +82,17 @@ // return

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837828#comment-15837828 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790228 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790026 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790105 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837834#comment-15837834 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789351 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/State.java --- @@ -43,7 +43,14 @@ public State(final String name, final StateType

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837829#comment-15837829 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790271 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837833#comment-15837833 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837830#comment-15837830 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837832#comment-15837832 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink issue #3209: [FLINK-5638] [asyncIO] Fix deadlock when closing two chai...

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3209 Forwarding the review from #3210. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3209: [FLINK-5638] [asyncIO] Fix deadlock when closing t...

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837888#comment-15837888 ] ASF GitHub Bot commented on FLINK-5638: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3206: [FLINK-5612] Fix GlobPathFilter not-serializable e...

2017-01-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97746438 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java --- @@ -52,8 +53,13 @@ private static final long

[GitHub] flink pull request #3206: [FLINK-5612] Fix GlobPathFilter not-serializable e...

2017-01-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97746573 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java --- @@ -106,12 +112,27 @@ public boolean filterPath(Path filePath)

[GitHub] flink issue #3201: [FLINK-5620] Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3201 Merged. Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-5620) Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837521#comment-15837521 ] ASF GitHub Bot commented on FLINK-5620: --- Github user kl0u closed the pull request at:

[jira] [Commented] (FLINK-5620) Fix unstable ContinuousFileProcessingTest

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837520#comment-15837520 ] ASF GitHub Bot commented on FLINK-5620: --- Github user aljoscha commented on the issue:

[jira] [Created] (FLINK-5639) Clarify License implications of RabbitMQ Connector

2017-01-25 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-5639: --- Summary: Clarify License implications of RabbitMQ Connector Key: FLINK-5639 URL: https://issues.apache.org/jira/browse/FLINK-5639 Project: Flink Issue Type:

[jira] [Updated] (FLINK-4548) Refactor ContinuousFileMonitoringTest to use OneShotLatch

2017-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-4548: Assignee: Pattarawat Chormai > Refactor ContinuousFileMonitoringTest to use OneShotLatch >

[jira] [Commented] (FLINK-4548) Refactor ContinuousFileMonitoringTest to use OneShotLatch

2017-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837583#comment-15837583 ] Aljoscha Krettek commented on FLINK-4548: - I assigned it to you but I think you should also be

[jira] [Commented] (FLINK-5612) GlobPathFilter not-serializable exception

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837648#comment-15837648 ] ASF GitHub Bot commented on FLINK-5612: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837665#comment-15837665 ] ASF GitHub Bot commented on FLINK-4905: --- Github user BrainLogic commented on the issue:

[jira] [Commented] (FLINK-5229) Cleanup StreamTaskStates if a checkpoint operation of a subsequent operator fails

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837740#comment-15837740 ] Till Rohrmann commented on FLINK-5229: -- Should be fixed. Apparently, there are state handle futures

[jira] [Updated] (FLINK-5641) Directories of expired checkpoints are not cleaned up

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5641: -- Attachment: application-1485249546281-0021-misbehaved-1.2.0-rc1 > Directories of expired

[GitHub] flink pull request #3213: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3213 [FLINK-5643] Fix NPE in StateUtil Introduces a null check to deal with state futures which have a null value. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837752#comment-15837752 ] ASF GitHub Bot commented on FLINK-5643: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-5229) Cleanup StreamTaskStates if a checkpoint operation of a subsequent operator fails

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837750#comment-15837750 ] Robert Metzger commented on FLINK-5229: --- Thank you! > Cleanup StreamTaskStates if a checkpoint

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837800#comment-15837800 ] ASF GitHub Bot commented on FLINK-5643: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3212: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3212 Forwarding review from #3213. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2742: [FLINK-4944] Replace Akka's death watch with own heartbea...

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2742 Rebased onto the latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3215: [FLINK-5628] [webfrontend] Fix serialization of st...

2017-01-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3215#discussion_r97799282 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java --- @@ -85,6 +79,9 @@ /** History of

  1   2   3   4   >