[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112456197 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala --- @@ -810,6 +810,47 @@ class Table( new

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112456740 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala --- @@ -928,6 +969,27 @@ class WindowedTable( }

[jira] [Commented] (FLINK-5756) When there are many values under the same key in ListState, RocksDBStateBackend performances poor

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977604#comment-15977604 ] ASF GitHub Bot commented on FLINK-5756: --- Github user hsaputra commented on the issue:

[GitHub] flink issue #3704: [FLINK-5756] Replace RocksDB dependency with FRocksDB

2017-04-20 Thread hsaputra
Github user hsaputra commented on the issue: https://github.com/apache/flink/pull/3704 Yeah totally understand the reason. Just want to make sure we have plan to move back as soon as RocksDB usable for Flink. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-6141) Add buffering service for stream operators

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977489#comment-15977489 ] Stephan Ewen commented on FLINK-6141: - I had a chat with [~aljoscha] about this: I think that we need

[jira] [Commented] (FLINK-5756) When there are many values under the same key in ListState, RocksDBStateBackend performances poor

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977480#comment-15977480 ] ASF GitHub Bot commented on FLINK-5756: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3704: [FLINK-5756] Replace RocksDB dependency with FRocksDB

2017-04-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3704 @hsaputra There is a plan to do that and we are in touch with the RocksDB folks. The latest RocksDB master does not work for Flink though, currently, so we needed a custom backport to an earlier

[jira] [Commented] (FLINK-4831) Implement a log4j metric reporter

2017-04-20 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977469#comment-15977469 ] Chesnay Schepler commented on FLINK-4831: - I worked based on slf4j i believe using this

[jira] [Commented] (FLINK-3952) Bump Netty to 4.1

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977390#comment-15977390 ] Stephan Ewen commented on FLINK-3952: - Just to avoid confusion: You can use a newer Netty in the user

[jira] [Commented] (FLINK-4831) Implement a log4j metric reporter

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977385#comment-15977385 ] Stephan Ewen commented on FLINK-4831: - [~Zentol] Is the implementation tied to {{log4j}} or based on

[GitHub] flink issue #3747: [FLINK-5623] [runtime] Fix TempBarrier dam has been close...

2017-04-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3747 +1 to this fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-5623) TempBarrier dam has been closed

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977381#comment-15977381 ] ASF GitHub Bot commented on FLINK-5623: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5623) TempBarrier dam has been closed

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977353#comment-15977353 ] ASF GitHub Bot commented on FLINK-5623: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #3747: [FLINK-5623] [runtime] Fix TempBarrier dam has bee...

2017-04-20 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3747 [FLINK-5623] [runtime] Fix TempBarrier dam has been closed Properly reset the "pipeline breaker" upon closing. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977227#comment-15977227 ] Stephan Ewen commented on FLINK-3328: - That's all right. We would not shade/bundle if we did not need

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977188#comment-15977188 ] ASF GitHub Bot commented on FLINK-6013: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Aha! Updated! Apparently Chrome search is case insensitive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3736 In the current PR title "Flink" isn't upper-case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977179#comment-15977179 ] ASF GitHub Bot commented on FLINK-6013: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Where is the title that you're referring to? This PR's title at the very top is already "[FLINK-6013][metrics] Add Datadog HTTP metrics reporter" (without double quote) --- If your project is

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112522071 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,78 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977162#comment-15977162 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on the issue:

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3736 Could you change the PR title to "[FLINK-6013][metrics] Add Datadog HTTP metrics reporter"? The comments aren't being mirrored to JIRA. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112521836 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,200 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112520676 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,29 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-20 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977155#comment-15977155 ] Luke Hutchison commented on FLINK-3328: --- Right, but shading requires a complete copy of the deps to

[jira] [Updated] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-20 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6013: Affects Version/s: (was: 1.2.0) 1.3.0 > Add Datadog HTTP metrics

[jira] [Updated] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-20 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6013: Fix Version/s: (was: 1.2.1) > Add Datadog HTTP metrics reporter >

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112518642 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112393795 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112394384 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,200 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112393039 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,29 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112393184 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,78 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977106#comment-15977106 ] Stephan Ewen commented on FLINK-3328: - What you suggest (let Maven or Gradle to pull in deps) is

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977103#comment-15977103 ] Stephan Ewen commented on FLINK-6315: - Please ping us anytime you have questions on this one... >

[jira] [Commented] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977101#comment-15977101 ] Stephan Ewen commented on FLINK-6319: - On clean shutdown, these errors should not occur. Do the YARN

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112499012 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112498342 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112496915 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112496785 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] flink issue #3746: [FLINK-4022] [kafka] Partition and topic discovery for Fl...

2017-04-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3746 @haohui FYI - tagging you as we discussed about this feature offline --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976969#comment-15976969 ] ASF GitHub Bot commented on FLINK-4022: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6336) Placement Constraints for Mesos

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976933#comment-15976933 ] ASF GitHub Bot commented on FLINK-6336: --- Github user EronWright commented on a diff in the pull

[jira] [Commented] (FLINK-6336) Placement Constraints for Mesos

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976932#comment-15976932 ] ASF GitHub Bot commented on FLINK-6336: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #3744: [FLINK-6336] Initial commit of mesos placement con...

2017-04-20 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/3744#discussion_r112487388 --- Diff: docs/setup/mesos.md --- @@ -222,6 +222,8 @@ When running Flink with Marathon, the whole Flink cluster including the job mana

[GitHub] flink pull request #3744: [FLINK-6336] Initial commit of mesos placement con...

2017-04-20 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/3744#discussion_r112486557 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -487,6 +487,11 @@ public static final String

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976900#comment-15976900 ] ASF GitHub Bot commented on FLINK-4022: --- GitHub user tzulitai opened a pull request:

[jira] [Commented] (FLINK-5781) Generation HTML from ConfigOption

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976899#comment-15976899 ] ASF GitHub Bot commented on FLINK-5781: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3495: [FLINK-5781][config] Generation HTML from ConfigOp...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3495#discussion_r112480838 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java --- @@ -134,6 +134,6 @@ private

[GitHub] flink pull request #3746: [FLINK-4022] [kafka] Partition and topic discovery...

2017-04-20 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/3746 [FLINK-4022] [kafka] Partition and topic discovery for FlinkKafkaConsumer This PR adds the required internals to allow partition and topic regex pattern discovery in the `FlinkKafkaConsumer`.

[jira] [Commented] (FLINK-6335) Support DISTINCT over grouped window in stream SQL

2017-04-20 Thread Stefano Bortoli (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976889#comment-15976889 ] Stefano Bortoli commented on FLINK-6335: Right. So I guess you will be working on group windows

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976879#comment-15976879 ] ASF GitHub Bot commented on FLINK-4022: --- Github user tzulitai closed the pull request at:

[GitHub] flink pull request #3476: [FLINK-4022] [kafka] Partition and topic pattern d...

2017-04-20 Thread tzulitai
Github user tzulitai closed the pull request at: https://github.com/apache/flink/pull/3476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976875#comment-15976875 ] ASF GitHub Bot commented on FLINK-4022: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3476: [FLINK-4022] [kafka] Partition and topic pattern discover...

2017-04-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3476 Closing this PR in a favor of an updated version .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #:

2017-04-20 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/5f0d6769051be8db8ee12659e13d22e5c5fd2f2d#commitcomment-21839446 In flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java: In

[GitHub] flink pull request #:

2017-04-20 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/5f0d6769051be8db8ee12659e13d22e5c5fd2f2d#commitcomment-21839439 In flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java: In

[jira] [Commented] (FLINK-6335) Support DISTINCT over grouped window in stream SQL

2017-04-20 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976845#comment-15976845 ] Haohui Mai commented on FLINK-6335: --- The scope of this jira is about supporting the DISTINCT keyword

[jira] [Closed] (FLINK-6342) Start ZooKeeperLeaderElectionService under lock to avoid race condition

2017-04-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-6342. Resolution: Invalid This only applies to changes I've made in a local branch. Will fix it in the

[jira] [Created] (FLINK-6342) Start ZooKeeperLeaderElectionService under lock to avoid race condition

2017-04-20 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6342: Summary: Start ZooKeeperLeaderElectionService under lock to avoid race condition Key: FLINK-6342 URL: https://issues.apache.org/jira/browse/FLINK-6342 Project: Flink

[jira] [Commented] (FLINK-6335) Support DISTINCT over grouped window in stream SQL

2017-04-20 Thread Stefano Bortoli (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976817#comment-15976817 ] Stefano Bortoli commented on FLINK-6335: Indeed, we have a list of open issues. Please have a look

[jira] [Updated] (FLINK-6280) Allow logging with Java flags

2017-04-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6280: -- Fix Version/s: 1.3.0 > Allow logging with Java flags > - > >

[jira] [Updated] (FLINK-5623) TempBarrier dam has been closed

2017-04-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-5623: -- Fix Version/s: 1.2.2 1.3.0 > TempBarrier dam has been closed >

[jira] [Commented] (FLINK-6341) JobManager can go to definite message sending loop when TaskManager registered

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976714#comment-15976714 ] ASF GitHub Bot commented on FLINK-6341: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3745: [FLINK-6341]Don't let JM fall into infinite loop

2017-04-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3745#discussion_r112456827 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -356,7 +356,12 @@ class JobManager(

[GitHub] flink issue #3745: [FLINK-6341]Don't let JM fall into infinite loop

2017-04-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3745 Thanks for spotting the problem @WangTaoTheTonic. This is important to fix. I think we cannot solve the problem as you've done it, because you access actor state from outside of the

[jira] [Commented] (FLINK-6341) JobManager can go to definite message sending loop when TaskManager registered

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976712#comment-15976712 ] ASF GitHub Bot commented on FLINK-6341: --- Github user tillrohrmann commented on the issue:

[jira] [Closed] (FLINK-6315) Notify on checkpoint timeout

2017-04-20 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman closed FLINK-6315. --- Resolution: Won't Do > Notify on checkpoint timeout > - > >

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976699#comment-15976699 ] ASF GitHub Bot commented on FLINK-6315: --- Github user sjwiesman closed the pull request at:

[GitHub] flink pull request #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-20 Thread sjwiesman
Github user sjwiesman closed the pull request at: https://github.com/apache/flink/pull/3729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-20 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976688#comment-15976688 ] Seth Wiesman commented on FLINK-6315: - Thank you for talking this through with me, I'm going to close

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3741 Looks quite good now. If I can ask you for one more followup: To have faster tests, it would be good to add the streaming distributed cache test and the batch distributed cache test to

[jira] [Commented] (FLINK-6177) Add support for "Distributed Cache" in streaming applications

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976668#comment-15976668 ] ASF GitHub Bot commented on FLINK-6177: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976664#comment-15976664 ] Till Rohrmann commented on FLINK-6319: -- Yes I think it is a bit of both. The error is logged in the

[jira] [Commented] (FLINK-6287) Flakey JobManagerRegistrationTest

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976662#comment-15976662 ] Stephan Ewen commented on FLINK-6287: - Another occurring instance:

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-20 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976649#comment-15976649 ] Luke Hutchison commented on FLINK-3328: --- What's the advantage to Flink of including all these shaded

[jira] [Commented] (FLINK-6280) Allow logging with Java flags

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976638#comment-15976638 ] ASF GitHub Bot commented on FLINK-6280: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6196) Support dynamic schema in Table Function

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976643#comment-15976643 ] ASF GitHub Bot commented on FLINK-6196: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3623: [FLINK-6196] [table] Support dynamic schema in Tab...

2017-04-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3623#discussion_r112444962 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -382,7 +381,10 @@ object

[GitHub] flink pull request #3701: [FLINK-6280] [scripts] Allow logging with Java fla...

2017-04-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3701#discussion_r112444789 --- Diff: docs/monitoring/application_profiling.md --- @@ -0,0 +1,54 @@ +--- +title: "Application Profiling" +nav-parent_id: monitoring

[GitHub] flink issue #3701: [FLINK-6280] [scripts] Allow logging with Java flags

2017-04-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3701 Okay, got it. The docs and examples did help a lot. This looks good to me, +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-6280) Allow logging with Java flags

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976631#comment-15976631 ] ASF GitHub Bot commented on FLINK-6280: --- Github user StephanEwen commented on the issue:

[jira] [Assigned] (FLINK-5623) TempBarrier dam has been closed

2017-04-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan reassigned FLINK-5623: - Assignee: Greg Hogan > TempBarrier dam has been closed > --- > >

[jira] [Commented] (FLINK-6335) Support DISTINCT over grouped window in stream SQL

2017-04-20 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976630#comment-15976630 ] Fabian Hueske commented on FLINK-6335: -- Hi [~wheat9], for which types of aggregations is this issue

[jira] [Commented] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976628#comment-15976628 ] Stephan Ewen commented on FLINK-6319: - Under successful shutdown, this happens anyways, because we

[jira] [Commented] (FLINK-6280) Allow logging with Java flags

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976625#comment-15976625 ] ASF GitHub Bot commented on FLINK-6280: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3701: [FLINK-6280] [scripts] Allow logging with Java flags

2017-04-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3701 @StephanEwen added some documentation covering use and examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976623#comment-15976623 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976621#comment-15976621 ] Stephan Ewen commented on FLINK-3328: - Yeah, I see your point. It would work more smooth if there is a

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-20 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 All right. I'll change as you suggest and verify the result. Thanks for comments and advise :) --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976619#comment-15976619 ] ASF GitHub Bot commented on FLINK-6295: --- Github user zentol commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3709 Why would the states by out of sync for non-suspended ExecutionGraphs? As i said before, the JobManager and web-backend are working on the same object. --- If your project is set up for it, you can

[jira] [Commented] (FLINK-6341) JobManager can go to definite message sending loop when TaskManager registered

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976609#comment-15976609 ] ASF GitHub Bot commented on FLINK-6341: --- GitHub user WangTaoTheTonic opened a pull request:

[GitHub] flink pull request #3745: [FLINK-6341]Don't let JM fall into infinite loop

2017-04-20 Thread WangTaoTheTonic
GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/flink/pull/3745 [FLINK-6341]Don't let JM fall into infinite loop When TaskManager register to JobManager, JM will send a "NotifyResourceStarted" message to kick off Resource Manager, then trigger a

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976608#comment-15976608 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-20 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 My main concern is that the status showing in web doesn't match the actual state backend. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976603#comment-15976603 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3735: [FLINK-6242] [table] Add code generation for DataSet Aggr...

2017-04-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3735 Hi @shaoxuan-wang, thanks for the PR. The changes look good. I opened a PR against your PR branch and refactored the `CodeGenerator.generateAggregations() method a bit. Among other things, I

[jira] [Created] (FLINK-6341) JobManager can go to definite message sending loop when TaskManager registered

2017-04-20 Thread Tao Wang (JIRA)
Tao Wang created FLINK-6341: --- Summary: JobManager can go to definite message sending loop when TaskManager registered Key: FLINK-6341 URL: https://issues.apache.org/jira/browse/FLINK-6341 Project: Flink

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976597#comment-15976597 ] ASF GitHub Bot commented on FLINK-6295: --- Github user zentol commented on the issue:

<    1   2   3   >