[jira] [Assigned] (FLINK-7307) Add proper command line parsing tool to ClusterEntrypoint

2017-08-04 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-7307: Assignee: Fang Yong > Add proper command line parsing tool to ClusterEntrypoint >

[jira] [Commented] (FLINK-7169) Support AFTER MATCH SKIP function in CEP library API

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114077#comment-16114077 ] ASF GitHub Bot commented on FLINK-7169: --- Github user yestinchen commented on the issue:

[GitHub] flink pull request #4368: [FLINK-7210] Introduce TwoPhaseCommitSinkFunction

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4368#discussion_r131330545 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -51,39 +48,52 @@

[jira] [Commented] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114066#comment-16114066 ] ASF GitHub Bot commented on FLINK-7210: --- Github user pnowojski commented on a diff in the pull

[jira] [Created] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread Benedict Jin (JIRA)
Benedict Jin created FLINK-7369: --- Summary: Add more information for `Key group index out of range of key group range` exception Key: FLINK-7369 URL: https://issues.apache.org/jira/browse/FLINK-7369

[GitHub] flink pull request #4368: [FLINK-7210] Introduce TwoPhaseCommitSinkFunction

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4368#discussion_r131332988 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -0,0 +1,311 @@ +/*

[jira] [Commented] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114086#comment-16114086 ] ASF GitHub Bot commented on FLINK-7210: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink issue #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP function in CE...

2017-08-04 Thread yestinchen
Github user yestinchen commented on the issue: https://github.com/apache/flink/pull/4331 @dawidwys @dianfu I've updated the approach according to the document. Feel free to comment. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #4474: FLINK-7369: Add more information for `Key group in...

2017-08-04 Thread asdf2014
GitHub user asdf2014 opened a pull request: https://github.com/apache/flink/pull/4474 FLINK-7369: Add more information for `Key group index out of range of key group range` exception When i got the following exception log, it make me confused that the index is more than `32` or

[jira] [Commented] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114093#comment-16114093 ] ASF GitHub Bot commented on FLINK-7369: --- GitHub user asdf2014 opened a pull request:

[GitHub] flink pull request #4368: [FLINK-7210] Introduce TwoPhaseCommitSinkFunction

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4368#discussion_r131334260 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -0,0 +1,311 @@ +/*

[jira] [Commented] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114096#comment-16114096 ] ASF GitHub Bot commented on FLINK-7210: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink issue #4454: [hotfix][docs] Add section in docs about writing unit/int...

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4454 +1 for adding this section to the docs. And another +1 for adding something about testing watermarks / timestamps -- this is a very frequently asked question. Could, perhaps, include a

[jira] [Updated] (FLINK-7307) Add proper command line parsing tool to ClusterEntrypoint

2017-08-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-7307: - Labels: flip-6 (was: ) > Add proper command line parsing tool to ClusterEntrypoint >

[jira] [Commented] (FLINK-7307) Add proper command line parsing tool to ClusterEntrypoint

2017-08-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114072#comment-16114072 ] Till Rohrmann commented on FLINK-7307: -- Hi [~fangyong], before you get cracking can you quickly tell

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114193#comment-16114193 ] ASF GitHub Bot commented on FLINK-7368: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-04 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114196#comment-16114196 ] Xingcan Cui commented on FLINK-7337: Hi [~fhueske], sorry for the silly questions. In my mind, to

[jira] [Commented] (FLINK-6995) Add a warning to outdated documentation

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114239#comment-16114239 ] ASF GitHub Bot commented on FLINK-6995: --- GitHub user zhangminglei opened a pull request:

[GitHub] flink issue #4480: [FLINK-6995] [docs] Enable is_latest attribute to false

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4480 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6995) Add a warning to outdated documentation

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114246#comment-16114246 ] ASF GitHub Bot commented on FLINK-6995: --- Github user alpinegizmo commented on the issue:

[GitHub] flink issue #4472: FLINK-7368: MetricStore makes cpu spin at 100%

2017-08-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4472 The problem is that the `MetricFetcher` isn't synchronizing on the `MetricStore´ object in `MetricFetcher#addMetrics()` as it should. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6995) Add a warning to outdated documentation

2017-08-04 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114205#comment-16114205 ] David Anderson commented on FLINK-6995: --- [~mingleizhang] What we need is a PR against the

[jira] [Commented] (FLINK-6995) Add a warning to outdated documentation

2017-08-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114213#comment-16114213 ] mingleizhang commented on FLINK-6995: - Ahhha. I see. Thanks ~ > Add a warning to outdated

[GitHub] flink issue #4454: [hotfix][docs] Add section in docs about writing unit/int...

2017-08-04 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4454 @pnowojski adding a link to `TwoPhaseCommitSinkFunctionTest` might make sense for testing exactly-once delivery. There are also often cases where the user, in particular, wants to check

[GitHub] flink pull request #4480: [FLINK-6995] [docs] Enable is_latest attribute to ...

2017-08-04 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4480 [FLINK-6995] [docs] Enable is_latest attribute to false ## What is the purpose of the change Add a warning to flink1.2 document. This PR is based on

[GitHub] flink pull request #4475: [FLINK-7251] Add proper command line parsing tool ...

2017-08-04 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4475 [FLINK-7251] Add proper command line parsing tool to ClusterEntrypoint ## What is the purpose of the change Add a proper command line parsing tool `CommandLineParser` to the entry point of

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114108#comment-16114108 ] ASF GitHub Bot commented on FLINK-7251: --- GitHub user zjureel opened a pull request:

[jira] [Commented] (FLINK-7307) Add proper command line parsing tool to ClusterEntrypoint

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114138#comment-16114138 ] ASF GitHub Bot commented on FLINK-7307: --- GitHub user zjureel opened a pull request:

[GitHub] flink pull request #4476: [FLINK-7307] Add proper command line parsing tool ...

2017-08-04 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4476 [FLINK-7307] Add proper command line parsing tool to ClusterEntrypoint ## What is the purpose of the change Add a proper command line parsing tool `CommandLineParser` to the entry point of

[jira] [Updated] (FLINK-7272) Support SQL IN with more than 20 elements in streaming

2017-08-04 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-7272: Description: During the implementation of FLINK-4565 I noticed that an "IN" operation with more

[GitHub] flink pull request #4478: [hotfix][docs] add documentation for `taskmanager....

2017-08-04 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4478 [hotfix][docs] add documentation for `taskmanager.exit-on-fatal-akka-error` ## What is the purpose of the change When the quarantine monitor was added as of FLINK-3347, documentation for

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114166#comment-16114166 ] ASF GitHub Bot commented on FLINK-7309: --- GitHub user yestinchen opened a pull request:

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-04 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114167#comment-16114167 ] Xingcan Cui commented on FLINK-7245: Hi all, I'd like to throw out some basic ideas about the design.

[GitHub] flink issue #4454: [hotfix][docs] Add section in docs about writing unit/int...

2017-08-04 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4454 @tzulitai maybe I will add a link to `TwoPhaseCommitSinkFunctionTest` for how to test `exactly-once`? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #4475: [FLINK-7251] Add proper command line parsing tool to Clus...

2017-08-04 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4475 @tillrohrmann I create `CommandLineParser` instead of `ParameterTool` in `ClusterEntrypoint#parseArguments`, please have a look when you're free, thanks --- If your project is set up for it, you

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114119#comment-16114119 ] ASF GitHub Bot commented on FLINK-7251: --- Github user zjureel commented on the issue:

[jira] [Commented] (FLINK-7307) Add proper command line parsing tool to ClusterEntrypoint

2017-08-04 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114122#comment-16114122 ] Fang Yong commented on FLINK-7307: -- Sorry to see this late, I will use {{CommandLine}} to parse configDir

[jira] [Commented] (FLINK-7307) Add proper command line parsing tool to ClusterEntrypoint

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114125#comment-16114125 ] ASF GitHub Bot commented on FLINK-7307: --- Github user zjureel closed the pull request at:

[GitHub] flink pull request #4475: [FLINK-7307] Add proper command line parsing tool ...

2017-08-04 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6995) Add a warning to outdated documentation

2017-08-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114134#comment-16114134 ] mingleizhang commented on FLINK-6995: - I am planning checkout a new branch based on {{release-1.2

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114141#comment-16114141 ] ASF GitHub Bot commented on FLINK-4565: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7370) rework operator documentation

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114140#comment-16114140 ] ASF GitHub Bot commented on FLINK-7370: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4477: [FLINK-7370][docs] rework the operator documentati...

2017-08-04 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4477 [FLINK-7370][docs] rework the operator documentation structure ## What is the purpose of the change Improve the docs by re-structuring the operators documentation. ## Brief change

[GitHub] flink pull request #4404: [FLINK-4565] [table] Support for SQL IN operator

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-4565) Support for SQL IN operator

2017-08-04 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4565. - Resolution: Fixed Fix Version/s: 1.4.0 Fixed in 1.4.0:

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114142#comment-16114142 ] ASF GitHub Bot commented on FLINK-4565: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3502: [FLINK-4565] Support for SQL IN operator

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4474: FLINK-7369: Add more information for `Key group index out...

2017-08-04 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4474 Hi, sorry that I saw this PR too late because Jira was hanging and I only saw the email of the opened issue. I already merged a fix for this to master and 1.3. I would have also

[jira] [Commented] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114146#comment-16114146 ] ASF GitHub Bot commented on FLINK-7369: --- Github user StefanRRichter commented on the issue:

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131352677 --- Diff: docs/dev/testing.md --- @@ -90,13 +121,69 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114123#comment-16114123 ] ASF GitHub Bot commented on FLINK-4565: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4404: [FLINK-4565] [table] Support for SQL IN operator

2017-08-04 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4404 Thanks for reviewing @fhueske. I addressed your feedback and added documentation. I will merge this now... --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Created] (FLINK-7370) rework operator documentation

2017-08-04 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7370: -- Summary: rework operator documentation Key: FLINK-7370 URL: https://issues.apache.org/jira/browse/FLINK-7370 Project: Flink Issue Type: Improvement

[GitHub] flink issue #4418: [FLINK-7293] [cep] Support custom order by in PatternStre...

2017-08-04 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4418 Hi @dianfu and @dawidwys. This PR is actually broken. The reason is that the `comparator` in the `AbstractKeyedCEPPatternOperator` is not `serializable` so when Flink tries to ship the job to

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114135#comment-16114135 ] ASF GitHub Bot commented on FLINK-7293: --- Github user kl0u commented on the issue:

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114154#comment-16114154 ] ASF GitHub Bot commented on FLINK-6429: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-08-04 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r131346038 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/rel/rules/PushProjector.java --- @@ -0,0 +1,864 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114159#comment-16114159 ] ASF GitHub Bot commented on FLINK-3347: --- GitHub user NicoK opened a pull request:

[jira] [Comment Edited] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-04 Thread Liangliang Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112834#comment-16112834 ] Liangliang Chen edited comment on FLINK-7309 at 8/4/17 9:32 AM: hi,

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-04 Thread yestinchen
GitHub user yestinchen opened a pull request: https://github.com/apache/flink/pull/4479 [FLINK-7309][hotfix] fix NullPointerException when selecting null fields ## What is the purpose of the change This pull request addresses FLINK-7309, adds null check before applying

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131342944 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131337294 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131343119 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131344197 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This

[jira] [Commented] (FLINK-6995) Add a warning to outdated documentation

2017-08-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114184#comment-16114184 ] mingleizhang commented on FLINK-6995: - Hi, [~alpinegizmo] What you said : We have to be enabled by

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-04 Thread Liangliang Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114191#comment-16114191 ] Liangliang Chen commented on FLINK-7309: @yestinchen ??? > NullPointerException in

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131354369 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,189 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-id: testing +nav-pos: 99 +---

[jira] [Commented] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114920#comment-16114920 ] Fabian Hueske commented on FLINK-7358: -- Thanks [~sunjincheng121]. Sounds good to me. We should make

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114891#comment-16114891 ] Fabian Hueske commented on FLINK-7337: -- Hi [~xccui], no worries about your questions. They are all

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114952#comment-16114952 ] Fabian Hueske commented on FLINK-7245: -- Thanks a lot for looking into this [~xccui]! A few comments:

[jira] [Comment Edited] (FLINK-6402) Consider removing annotation for REAPER_THREAD_LOCK in SafetyNetCloseableRegistry#doRegister()

2017-08-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986965#comment-15986965 ] Ted Yu edited comment on FLINK-6402 at 8/5/17 1:25 AM: --- Pardon the typo. The

[jira] [Comment Edited] (FLINK-6333) Utilize Bloomfilters in RocksDb

2017-08-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095490#comment-16095490 ] Ted Yu edited comment on FLINK-6333 at 8/5/17 1:32 AM: --- Looks like rocksdb issue

[jira] [Updated] (FLINK-4499) Introduce findbugs maven plugin

2017-08-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4499: -- Description: As suggested by Stephan in FLINK-4482, this issue is to add findbugs-maven-plugin into the build

[jira] [Updated] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2017-08-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4534: -- Description: Iteration over state.bucketStates is protected by synchronization in other methods, except for

[GitHub] flink pull request #4404: [FLINK-4565] [table] Support for SQL IN operator

2017-08-04 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4404#discussion_r131511583 --- Diff: docs/dev/table/sql.md --- @@ -497,6 +497,23 @@ FROM ( {% endhighlight %} + + + +In +

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115200#comment-16115200 ] ASF GitHub Bot commented on FLINK-4565: --- Github user tedyu commented on a diff in the pull request:

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115222#comment-16115222 ] ASF GitHub Bot commented on FLINK-6429: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-08-04 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r131512787 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/rel/rules/PushProjector.java --- @@ -0,0 +1,864 @@ +/* + * Licensed to the

[jira] [Comment Edited] (FLINK-6359) Utilize Hierarchical Timing Wheels for performant timer

2017-08-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991975#comment-15991975 ] Ted Yu edited comment on FLINK-6359 at 8/5/17 1:31 AM: --- Interesting observations,

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-04 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115247#comment-16115247 ] Xingcan Cui commented on FLINK-7337: Thanks for the explanation, [~fhueske]. Everything's clear to me

[jira] [Assigned] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2017-08-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-4534: --- Assignee: mingleizhang > Lack of synchronization in BucketingSink#restoreState() >

[jira] [Created] (FLINK-7372) Remove ActorGateway from JobGraph

2017-08-04 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7372: Summary: Remove ActorGateway from JobGraph Key: FLINK-7372 URL: https://issues.apache.org/jira/browse/FLINK-7372 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2017-08-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115259#comment-16115259 ] mingleizhang commented on FLINK-4534: - [~tedyu] Thanks for reporting this! One thing I need confirm,

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114294#comment-16114294 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on the issue:

[GitHub] flink issue #4418: [FLINK-7293] [cep] Support custom order by in PatternStre...

2017-08-04 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4418 @kl0u Good catch. Have updated the PR according to the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4445: [FLINK-7310][core] always use the HybridMemorySegment

2017-08-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4445 in a non-exhaustive mini benchmark, I ran `HashVsSortMiniBenchmark` and got the following results: # Best out of 5 (in ms) Test | `master` | `Flink-7310` | -- |

[jira] [Commented] (FLINK-7310) always use HybridMemorySegment

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114322#comment-16114322 ] ASF GitHub Bot commented on FLINK-7310: --- Github user NicoK commented on the issue:

[GitHub] flink pull request #4474: FLINK-7369: Add more information for `Key group in...

2017-08-04 Thread asdf2014
Github user asdf2014 closed the pull request at: https://github.com/apache/flink/pull/4474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114331#comment-16114331 ] ASF GitHub Bot commented on FLINK-7369: --- Github user asdf2014 commented on the issue:

[jira] [Commented] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114332#comment-16114332 ] ASF GitHub Bot commented on FLINK-7369: --- Github user asdf2014 closed the pull request at:

[GitHub] flink issue #4474: FLINK-7369: Add more information for `Key group index out...

2017-08-04 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/flink/pull/4474 Hi, @StefanRRichter . Thank you take the suggestion. I have already seen the improvement [merged](https://github.com/apache/flink/commit/04777538c0a54c113d0f9b49b5922ba47f6e1eb8) into master. :+1:

[jira] [Created] (FLINK-7371) user defined aggregator assumes nr of arguments smaller or equal than number of row fields

2017-08-04 Thread Stefano Bortoli (JIRA)
Stefano Bortoli created FLINK-7371: -- Summary: user defined aggregator assumes nr of arguments smaller or equal than number of row fields Key: FLINK-7371 URL: https://issues.apache.org/jira/browse/FLINK-7371

[jira] [Commented] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114337#comment-16114337 ] ASF GitHub Bot commented on FLINK-7369: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4474: FLINK-7369: Add more information for `Key group index out...

2017-08-04 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4474 @asdf2014 Yes, and sorry again that I didn't see the PR fast enough. It was absolutely not my intention to ignore your work. Thanks again for your efforts! --- If your project is set up for

[GitHub] flink issue #4474: FLINK-7369: Add more information for `Key group index out...

2017-08-04 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/flink/pull/4474 You are so polite that you do not have to be sorry :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114347#comment-16114347 ] ASF GitHub Bot commented on FLINK-7369: --- Github user asdf2014 commented on the issue:

[jira] [Closed] (FLINK-7369) Add more information for `Key group index out of range of key group range` exception

2017-08-04 Thread Benedict Jin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Jin closed FLINK-7369. --- Resolution: Fixed Fix Version/s: 2.0.0 > Add more information for `Key group index out of

[jira] [Commented] (FLINK-7364) Log exceptions from user code in streaming jobs

2017-08-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114473#comment-16114473 ] Stephan Ewen commented on FLINK-7364: - Can you share some sample code where this happen? So far, we

[GitHub] flink pull request #4481: [FLINK-7316][network] always use off-heap network ...

2017-08-04 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4481 [FLINK-7316][network] always use off-heap network buffers ## What is the purpose of the change For now, network buffers may be on-heap or off-heap along with Flink memory settings. As a step

[GitHub] flink issue #3085: [FLINK-5178] allow BlobCache to use a distributed file sy...

2017-08-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3085 no, this is not part of FLIP-19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   >