[jira] [Closed] (FLINK-7852) An input of GenericTypeInfo cannot be converted to Table

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7852. Resolution: Invalid Not a bug report or feature request. > An input of GenericTypeInfo cannot be

[jira] [Commented] (FLINK-7852) An input of GenericTypeInfo cannot be converted to Table

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207110#comment-16207110 ] Fabian Hueske commented on FLINK-7852: -- Hi Han, as the error message says, you need to specify a

[jira] [Updated] (FLINK-7426) Table API does not support null values in keys

2017-10-17 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-7426: Fix Version/s: (was: 1.3.3) > Table API does not support null values in keys >

[jira] [Resolved] (FLINK-7426) Table API does not support null values in keys

2017-10-17 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-7426. - Resolution: Fixed Fixed in 1.4.0: 14bc62740e90ecefd34f9202f4a37c883c3122e5 > Table API does not

[jira] [Commented] (FLINK-6173) flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207213#comment-16207213 ] ASF GitHub Bot commented on FLINK-6173: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4837: [FLINK-6173] [table] Clean-up flink-table jar and ...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4837#discussion_r145073241 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -252,6 +261,29 @@ under the License.

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207147#comment-16207147 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145061149 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[jira] [Commented] (FLINK-6019) Some log4j messages do not have a loglevel field set, so they can't be suppressed

2017-10-17 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207174#comment-16207174 ] Luke Hutchison commented on FLINK-6019: --- [~StephanEwen] yes, please see the last few lines of my

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207172#comment-16207172 ] ASF GitHub Bot commented on FLINK-7426: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207223#comment-16207223 ] Chesnay Schepler commented on FLINK-7368: - The view is not consistent in any case. The report

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145054599 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145054746 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnWorkerNode.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207148#comment-16207148 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145067245 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145067180 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207190#comment-16207190 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207192#comment-16207192 ] ASF GitHub Bot commented on FLINK-7076: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7839) Creating Quickstart project for SNAPSHOT version fails

2017-10-17 Thread Michael Fong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207188#comment-16207188 ] Michael Fong commented on FLINK-7839: - I looked at the doc code, and there is an if-statement that

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207189#comment-16207189 ] ASF GitHub Bot commented on FLINK-7076: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7373) Using URLClassLoader to load UDF triggers HepPlanner unexpected ClassNotFoundException

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207153#comment-16207153 ] Fabian Hueske commented on FLINK-7373: -- OK, thanks for the reply [~walterddr] :-) > Using

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207166#comment-16207166 ] ASF GitHub Bot commented on FLINK-7076: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink issue #4732: [FLINK-7426] [table] Support null values in keys

2017-10-17 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4732 Thanks for the review @fhueske. I will merge this now... ---

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207168#comment-16207168 ] ASF GitHub Bot commented on FLINK-7426: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145053774 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[jira] [Commented] (FLINK-7844) Fine Grained Recovery triggers checkpoint timeout failure

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207203#comment-16207203 ] ASF GitHub Bot commented on FLINK-7844: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #4844: [FLINK-7844] [ckPt] Fail unacknowledged pending ch...

2017-10-17 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4844 [FLINK-7844] [ckPt] Fail unacknowledged pending checkpoints for fine grained recovery ## What is the purpose of the change This commit will fail all pending checkpoints which have not

[jira] [Commented] (FLINK-7153) Eager Scheduling can't allocate source for ExecutionGraph correctly

2017-10-17 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207212#comment-16207212 ] Sihua Zhou commented on FLINK-7153: --- I prefer [2], it also fix FLINK-7218 and do a better job than the

[jira] [Updated] (FLINK-7852) An input of GenericTypeInfo cannot be converted to Table

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7852: - Description: Dear All: I'm starting to learn about Flink,and I have a question about Table API

[jira] [Commented] (FLINK-7844) Fine Grained Recovery triggers checkpoint timeout failure

2017-10-17 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207117#comment-16207117 ] Till Rohrmann commented on FLINK-7844: -- Yes it would. I actually have a small fix almost ready for

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-17 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207130#comment-16207130 ] Till Rohrmann commented on FLINK-7368: -- I'm not entirely sure whether it is that important to have a

[jira] [Comment Edited] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-17 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207130#comment-16207130 ] Till Rohrmann edited comment on FLINK-7368 at 10/17/17 7:43 AM: I'm not

[jira] [Created] (FLINK-7859) Allow field annotations to define TypeInformation

2017-10-17 Thread Timo Walther (JIRA)
Timo Walther created FLINK-7859: --- Summary: Allow field annotations to define TypeInformation Key: FLINK-7859 URL: https://issues.apache.org/jira/browse/FLINK-7859 Project: Flink Issue Type:

[jira] [Updated] (FLINK-7859) Allow field annotations to define TypeInformation

2017-10-17 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-7859: Affects Version/s: 1.3.2 > Allow field annotations to define TypeInformation >

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207149#comment-16207149 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink pull request #4732: [FLINK-7426] [table] Support null values in keys

2017-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4732 ---

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145067095 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnWorkerNode.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (FLINK-7860) Support YARN proxy user in Flink (impersonation)

2017-10-17 Thread Shuyi Chen (JIRA)
Shuyi Chen created FLINK-7860: - Summary: Support YARN proxy user in Flink (impersonation) Key: FLINK-7860 URL: https://issues.apache.org/jira/browse/FLINK-7860 Project: Flink Issue Type: New

[jira] [Commented] (FLINK-7861) Suppress ActorKilledExceptions

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207525#comment-16207525 ] ASF GitHub Bot commented on FLINK-7861: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207227#comment-16207227 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4199: [FLINK-6584] [table] Support multiple consecutive windows...

2017-10-17 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4199 I opened a PR for Calcite https://github.com/apache/calcite/pull/549. I will rebase this branch. ---

[GitHub] flink pull request #4845: [FLINK-7861] [flip6] Suppress ActorKilledException...

2017-10-17 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4845 [FLINK-7861] [flip6] Suppress ActorKilledException logging ## What is the purpose of the change Introduce a StoppingSupervisorWithoutLoggingStrategy which only logs the

[jira] [Assigned] (FLINK-7785) DispatcherTest failure

2017-10-17 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7785: Assignee: Till Rohrmann > DispatcherTest failure > -- > >

[jira] [Created] (FLINK-7861) Suppress ActorKilledExceptions

2017-10-17 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7861: Summary: Suppress ActorKilledExceptions Key: FLINK-7861 URL: https://issues.apache.org/jira/browse/FLINK-7861 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207549#comment-16207549 ] ASF GitHub Bot commented on FLINK-7854: --- GitHub user xccui opened a pull request:

[GitHub] flink pull request #4846: [FLINK-7854] [table] Reject lateral table outer jo...

2017-10-17 Thread xccui
GitHub user xccui opened a pull request: https://github.com/apache/flink/pull/4846 [FLINK-7854] [table] Reject lateral table outer joins with predicates in SQL ## What is the purpose of the change Due to CALCITE-2004, this PR aims to temporarily restrict the predicates for

[jira] [Commented] (FLINK-7703) Port JobExceptionsHandler to new REST endpoint

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207561#comment-16207561 ] ASF GitHub Bot commented on FLINK-7703: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4843: [FLINK-7703] Port JobExceptionsHandler to new REST...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4843#discussion_r145112112 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobExceptionsInfo.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7703) Port JobExceptionsHandler to new REST endpoint

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207560#comment-16207560 ] ASF GitHub Bot commented on FLINK-7703: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207579#comment-16207579 ] Fabian Hueske commented on FLINK-5498: -- Hi [~lincoln.86xy], I'll fix this issue as this has the same

[jira] [Resolved] (FLINK-7785) DispatcherTest failure

2017-10-17 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7785. -- Resolution: Fixed Fixed via 9772e03d725e607495f5602f716609e3e7f9b248 > DispatcherTest failure

[jira] [Assigned] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-5498: Assignee: Fabian Hueske (was: lincoln.lee) > Add support for left/right outer joins with

[jira] [Created] (FLINK-7862) Add TaskManagerDetailsHandler

2017-10-17 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7862: Summary: Add TaskManagerDetailsHandler Key: FLINK-7862 URL: https://issues.apache.org/jira/browse/FLINK-7862 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207628#comment-16207628 ] Fabian Hueske commented on FLINK-7548: -- Hi [~jark], [~wheat9], [~twalthr], [~xccui], [~ykt836],I'd

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145132472 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145126703 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145125984 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] flink pull request #4847: [hotfix][doc]CEP docs review to remove weasel word...

2017-10-17 Thread ChrisChinchilla
GitHub user ChrisChinchilla opened a pull request: https://github.com/apache/flink/pull/4847 [hotfix][doc]CEP docs review to remove weasel words, fix passive voice, typos… As requested, backport from 1.4. Ref - https://github.com/apache/flink/pull/4816 You can merge

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207717#comment-16207717 ] Timo Walther commented on FLINK-7548: - Thanks for the proposal [~fhueske]. I like the idea with a

[GitHub] flink pull request #4803: [FLINK-7813] [metrics] Replace MetricRegistryThrea...

2017-10-17 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4803#discussion_r145122089 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java --- @@ -402,25 +401,4 @@ public void run() {

[GitHub] flink pull request #4823: [FLINK-7832] [flip6] Extend SlotManager to report ...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4823#discussion_r145129240 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/TaskManagerSlot.java --- @@ -74,22 +83,51 @@ public AllocationID

[GitHub] flink pull request #4823: [FLINK-7832] [flip6] Extend SlotManager to report ...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4823#discussion_r144810955 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/TaskManagerSlot.java --- @@ -74,22 +83,51 @@ public AllocationID

[GitHub] flink pull request #4823: [FLINK-7832] [flip6] Extend SlotManager to report ...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4823#discussion_r145119294 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -556,14 +537,30 @@ private void

[GitHub] flink pull request #4823: [FLINK-7832] [flip6] Extend SlotManager to report ...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4823#discussion_r145117281 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -556,14 +537,30 @@ private void

[GitHub] flink pull request #4823: [FLINK-7832] [flip6] Extend SlotManager to report ...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4823#discussion_r145117077 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -418,26 +415,17 @@ public void

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207584#comment-16207584 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207586#comment-16207586 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207585#comment-16207585 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207587#comment-16207587 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207582#comment-16207582 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207583#comment-16207583 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7813) Replace MetricRegistryThreadFactory

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207606#comment-16207606 ] ASF GitHub Bot commented on FLINK-7813: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink issue #4837: [FLINK-6173] [table] Clean-up flink-table jar and depende...

2017-10-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4837 the table examples no longer build on travis. ---

[jira] [Commented] (FLINK-6173) flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207674#comment-16207674 ] ASF GitHub Bot commented on FLINK-6173: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145114263 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyStats.java --- @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145114978 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71 @@ +/* + *

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145115654 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71 @@ +/* + *

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145113405 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145113966 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145114119 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71 @@ +/* + *

[jira] [Assigned] (FLINK-7848) Allow time attributes for atomic types

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-7848: Assignee: Fabian Hueske > Allow time attributes for atomic types >

[jira] [Commented] (FLINK-7813) Replace MetricRegistryThreadFactory

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207603#comment-16207603 ] ASF GitHub Bot commented on FLINK-7813: --- Github user GJL commented on the issue:

[GitHub] flink issue #4803: [FLINK-7813] [metrics] Replace MetricRegistryThreadFactor...

2017-10-17 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4803 👍 I reviewed the code and can confirm that the implementations are virtually identical. ---

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207635#comment-16207635 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207633#comment-16207633 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207634#comment-16207634 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207636#comment-16207636 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7832) SlotManager should return number of registered slots

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207632#comment-16207632 ] ASF GitHub Bot commented on FLINK-7832: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207658#comment-16207658 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207659#comment-16207659 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207655#comment-16207655 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207657#comment-16207657 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145125538 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207656#comment-16207656 ] ASF GitHub Bot commented on FLINK-6444: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7648) Port TaskManagersHandler to new REST endpoint

2017-10-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207654#comment-16207654 ] ASF GitHub Bot commented on FLINK-7648: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145133848 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -439,7 +439,7 @@ public

[GitHub] flink issue #4824: [FLINK-7648] [flip6] Add TaskManagersHandler

2017-10-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4824 The handler related commits look good to me. ---

[jira] [Commented] (FLINK-7783) Don't always remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()

2017-10-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207783#comment-16207783 ] Aljoscha Krettek commented on FLINK-7783: - We should never delete checkpoints that we fail to

[jira] [Updated] (FLINK-7846) Remove guava shading from ES2 connector

2017-10-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7846: Priority: Minor (was: Blocker) > Remove guava shading from ES2 connector >

[jira] [Updated] (FLINK-7849) Remove guava shading from hcatalog connector

2017-10-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7849: Priority: Minor (was: Blocker) > Remove guava shading from hcatalog connector >

  1   2   >