Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6038
Oh this is great! @StefanRRichter Is this means that flink plan to make
checkpoint support rescaling officially in the near future?
---
[
https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480049#comment-16480049
]
ASF GitHub Bot commented on FLINK-9182:
---
Github user makeyang closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480051#comment-16480051
]
ASF GitHub Bot commented on FLINK-9394:
---
Github user sihuazhou commented on the issue:
Github user makeyang closed the pull request at:
https://github.com/apache/flink/pull/5908
---
[
https://issues.apache.org/jira/browse/FLINK-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vinoyang reassigned FLINK-9398:
---
Assignee: vinoyang
> Flink CLI list running job returns all jobs except in CREATE state
>
Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r189167881
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
---
@@ -18,74 +18,244 @@
[
https://issues.apache.org/jira/browse/FLINK-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480195#comment-16480195
]
ASF GitHub Bot commented on FLINK-8838:
---
Github user suez1224 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480054#comment-16480054
]
ASF GitHub Bot commented on FLINK-9182:
---
Github user makeyang commented on the issue:
Github user makeyang commented on the issue:
https://github.com/apache/flink/pull/5908
@StefanRRichter should jira be close too?
---
[
https://issues.apache.org/jira/browse/FLINK-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480081#comment-16480081
]
vinoyang commented on FLINK-9375:
-
[~sihuazhou] agree with you, it's duplicate of FLINK-8871, I suggest we
[
https://issues.apache.org/jira/browse/FLINK-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480081#comment-16480081
]
vinoyang edited comment on FLINK-9375 at 5/18/18 3:18 AM:
--
[~sihuazhou] agree
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r189159027
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
---
@@ -18,74 +18,244 @@
[
https://issues.apache.org/jira/browse/FLINK-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480114#comment-16480114
]
ASF GitHub Bot commented on FLINK-8838:
---
Github user lincoln-lil commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480079#comment-16480079
]
vinoyang commented on FLINK-9393:
-
the reason and opinion provided by [~yuzhih...@gmail.com] looks good.
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6040#discussion_r189168596
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/Flink9349Test.java
---
@@ -0,0
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5941
I think it is safe to merge this change.
Will merge this now ..
---
[
https://issues.apache.org/jira/browse/FLINK-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480179#comment-16480179
]
ASF GitHub Bot commented on FLINK-8971:
---
Github user tzulitai commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480177#comment-16480177
]
ASF GitHub Bot commented on FLINK-8659:
---
Github user tzulitai commented on the issue:
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5955
@kl0u yes, lets do that as a separate commit then.
+1, this looks good to me.
One final comment for the merge:
When merging to `master`, we should have test savepoints for both
[
https://issues.apache.org/jira/browse/FLINK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480198#comment-16480198
]
ASF GitHub Bot commented on FLINK-9349:
---
Github user snuyanzin commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480100#comment-16480100
]
ASF GitHub Bot commented on FLINK-8838:
---
Github user lincoln-lil commented on a diff in the pull
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r189156884
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
---
@@ -18,74 +18,244 @@
[
https://issues.apache.org/jira/browse/FLINK-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480101#comment-16480101
]
ASF GitHub Bot commented on FLINK-8554:
---
Github user yanghua commented on the issue:
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5978
version: 1.11.319:
```
[INFO] org.apache.flink:flink-connector-kinesis_2.11:jar:1.6-SNAPSHOT
[INFO] +- com.amazonaws:aws-java-sdk-kinesis:jar:1.11.319:compile
[INFO] | +-
[
https://issues.apache.org/jira/browse/FLINK-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480174#comment-16480174
]
ASF GitHub Bot commented on FLINK-9374:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189163394
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -218,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189164871
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
[
https://issues.apache.org/jira/browse/FLINK-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480173#comment-16480173
]
ASF GitHub Bot commented on FLINK-9374:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478705#comment-16478705
]
ASF GitHub Bot commented on FLINK-8910:
---
Github user StefanRRichter commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478781#comment-16478781
]
ASF GitHub Bot commented on FLINK-8428:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6030
---
[
https://issues.apache.org/jira/browse/FLINK-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478682#comment-16478682
]
ASF GitHub Bot commented on FLINK-8518:
---
Github user snuyanzin closed the pull request at:
Github user snuyanzin closed the pull request at:
https://github.com/apache/flink/pull/6007
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5327
Thanks for the update @hequn8128. The changes look good. I tested your
implementation on a cluster with TPC-H data. The results were equal to the
batch results and the state clean-up worked. I will
[
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478720#comment-16478720
]
ASF GitHub Bot commented on FLINK-8428:
---
Github user twalthr commented on the issue:
Stefan Richter created FLINK-9388:
-
Summary: Inconsistency in job shutdown produces confusing log
message
Key: FLINK-9388
URL: https://issues.apache.org/jira/browse/FLINK-9388
Project: Flink
Ufuk Celebi created FLINK-9389:
--
Summary: Improve error message when cancelling job in state
canceled via REST API
Key: FLINK-9389
URL: https://issues.apache.org/jira/browse/FLINK-9389
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-8428.
-
Resolution: Fixed
Fix Version/s: 1.6.0
Fixed in 1.6.0:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5327
---
[
https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-9381.
--
Resolution: Fixed
Fixed via
master: 2735c852b4648ae6f3e8f1e6169ef9ed6ec481d2
1.5.0:
[
https://issues.apache.org/jira/browse/FLINK-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478809#comment-16478809
]
Till Rohrmann commented on FLINK-9360:
--
Reverted the 30s change
master:
[
https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478808#comment-16478808
]
ASF GitHub Bot commented on FLINK-9381:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478813#comment-16478813
]
Chesnay Schepler commented on FLINK-9360:
-
In that case the only alternative is to disable the
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478848#comment-16478848
]
Sihua Zhou commented on FLINK-9373:
---
I think that makes sense.
> Fix potential data losing for
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5676
---
[
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478707#comment-16478707
]
ASF GitHub Bot commented on FLINK-8910:
---
Github user asfgit closed the pull request at:
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6028
cc @tillrohrmann ,
[here](https://travis-ci.org/apache/flink/jobs/380067997) is a local recovery
rocksdb full test error .
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478861#comment-16478861
]
Stefan Richter commented on FLINK-9373:
---
[~sihuazhou] Will you be able to do this quickly or can I
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5676
Thanks for the feedback, I have addressed the last comments and will merge
this.
---
[
https://issues.apache.org/jira/browse/FLINK-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478757#comment-16478757
]
ASF GitHub Bot commented on FLINK-9356:
---
Github user yanghua commented on the issue:
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
sorry, closed by mistake, restored
---
[
https://issues.apache.org/jira/browse/FLINK-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478686#comment-16478686
]
ASF GitHub Bot commented on FLINK-8518:
---
Github user snuyanzin commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478699#comment-16478699
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478842#comment-16478842
]
Stefan Richter commented on FLINK-9373:
---
Maybe we can also take the PR basically "as is" for now so
[
https://issues.apache.org/jira/browse/FLINK-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478647#comment-16478647
]
ASF GitHub Bot commented on FLINK-9356:
---
GitHub user yanghua opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478694#comment-16478694
]
ASF GitHub Bot commented on FLINK-9168:
---
Github user sijie commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478697#comment-16478697
]
ASF GitHub Bot commented on FLINK-9168:
---
Github user sijie commented on a diff in the pull request:
Stefan Richter created FLINK-9390:
-
Summary: Shutdown of KafkaProducer causes confusing log message
Key: FLINK-9390
URL: https://issues.apache.org/jira/browse/FLINK-9390
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478860#comment-16478860
]
ASF GitHub Bot commented on FLINK-9386:
---
GitHub user pnowojski opened a pull request:
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6030
[FLINK-9381] Release blobs after job termination
## What is the purpose of the change
Properly remove job blobs from BlobServer after the job terminates. If the
job reaches a globally
[
https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478670#comment-16478670
]
ASF GitHub Bot commented on FLINK-9381:
---
GitHub user tillrohrmann opened a pull request:
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
Let's wait a bit more for their response. It seems like this example is
older than their corrected docs.
---
[
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter updated FLINK-8910:
--
Fix Version/s: 1.5.0
> Introduce automated end-to-end test for local recovery (including sticky
[
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter closed FLINK-8910.
-
Resolution: Fixed
Release Note: We changed the default SLOT_IDLE_TIMEOUT to the
[
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter reopened FLINK-8910:
---
Change fix version
> Introduce automated end-to-end test for local recovery (including sticky
>
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-9373:
-
Fix Version/s: (was: 1.5.0)
1.6.0
> Fix potential data losing for
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-9373:
-
Fix Version/s: 1.5.1
> Fix potential data losing for RocksDBBackend
>
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6028
[FLINK-9356] Improve error message for when queryable state not ready /
reachable
## What is the purpose of the change
*This pull request improve error message for when queryable state not
[
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter closed FLINK-8910.
-
Resolution: Fixed
> Introduce automated end-to-end test for local recovery (including sticky
>
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188891077
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -809,6 +809,23 @@ trait
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188891227
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -809,6 +809,23 @@ trait
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895939
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
---
@@ -406,5 +406,26 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188894442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/logic.scala
---
@@ -105,3 +105,75 @@ case class If(
}
[
https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478818#comment-16478818
]
ASF GitHub Bot commented on FLINK-7814:
---
Github user xccui commented on a diff in the pull request:
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895005
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
---
@@ -406,5 +406,26 @@ class
[
https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478817#comment-16478817
]
ASF GitHub Bot commented on FLINK-7814:
---
Github user xccui commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478820#comment-16478820
]
ASF GitHub Bot commented on FLINK-7814:
---
Github user xccui commented on a diff in the pull request:
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6031
[FLINK-9386] Embed netty router
This replaces netty-router dependency with our own version of it, which is
simplified and adds guarantees about order of matching router patterns.
This is
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478857#comment-16478857
]
Stefan Richter commented on FLINK-9373:
---
Well, but we are also at risk to have only a partial fix.
vinoyang created FLINK-9387:
---
Summary: Several log message errors in queryable-state module
Key: FLINK-9387
URL: https://issues.apache.org/jira/browse/FLINK-9387
Project: Flink
Issue Type:
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6029
[FLINK-9387] Several log message errors in queryable-state module
## What is the purpose of the change
*This pull request fixed several log message errors in queryable-state
module*
[
https://issues.apache.org/jira/browse/FLINK-9387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478666#comment-16478666
]
ASF GitHub Bot commented on FLINK-9387:
---
GitHub user yanghua opened a pull request:
Github user snuyanzin closed the pull request at:
https://github.com/apache/flink/pull/5961
---
[
https://issues.apache.org/jira/browse/FLINK-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478679#comment-16478679
]
ASF GitHub Bot commented on FLINK-8255:
---
Github user snuyanzin closed the pull request at:
Github user sijie commented on a diff in the pull request:
https://github.com/apache/flink/pull/5845#discussion_r188867435
--- Diff:
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducerTest.java
---
@@ -0,0 +1,100
Github user sijie commented on the issue:
https://github.com/apache/flink/pull/5845
@pluppens thank you for your comments. I was busy with pulsar 2.0 release.
I will try to pick this up again soon :)
---
Github user sijie commented on a diff in the pull request:
https://github.com/apache/flink/pull/5845#discussion_r188867505
--- Diff:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarProduceMode.java
---
@@ -0,0 +1,36 @@
[
https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478695#comment-16478695
]
ASF GitHub Bot commented on FLINK-9168:
---
Github user sijie commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478791#comment-16478791
]
Till Rohrmann commented on FLINK-9360:
--
The hotfix {{a709b74fd8}} in master breaks the HA test for my
[
https://issues.apache.org/jira/browse/FLINK-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478792#comment-16478792
]
Till Rohrmann commented on FLINK-9360:
--
Will revert the commit for the moment
> HA end-to-end
[
https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478819#comment-16478819
]
ASF GitHub Bot commented on FLINK-7814:
---
Github user xccui commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478816#comment-16478816
]
ASF GitHub Bot commented on FLINK-7814:
---
Github user xccui commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478866#comment-16478866
]
Stefan Richter commented on FLINK-9373:
---
Great, thanks a lot!
> Fix potential data losing for
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478865#comment-16478865
]
Sihua Zhou commented on FLINK-9373:
---
I will updated the PR quickly.
> Fix potential data losing for
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-9373:
-
Fix Version/s: (was: 1.5.1)
(was: 1.6.0)
1.5.0
>
[
https://issues.apache.org/jira/browse/FLINK-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478974#comment-16478974
]
ASF GitHub Bot commented on FLINK-6895:
---
Github user twalthr commented on the issue:
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5823
Hi, @tzulitai I have updated the code according to your suggestions. It is
the time for another review, could you take a look ? Thank you very much.
And the below is the test result on
[
https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479047#comment-16479047
]
ASF GitHub Bot commented on FLINK-9008:
---
Github user zhangminglei commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479051#comment-16479051
]
ASF GitHub Bot commented on FLINK-8434:
---
Github user GJL commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5097
Thanks for the review @aljoscha. Yes, I agree that this PR is a bit messy.
I will close it for now and open PR with a finer granularity after rebasing.
---
1 - 100 of 353 matches
Mail list logo
